smart-terminal-mcp 1.2.8 → 1.2.9

package/README.md

@@ -161,7 +161,7 @@ Execute a command with deterministic completion detection. Large outputs are tru
 
 ### `terminal_run`
 
-Run a one-shot non-interactive command using `cmd + args` with `shell=false`. Safer than `terminal_exec` for predictable automation. Output is capped by `maxOutputBytes` rather than head + tail truncation. Shell built-ins such as `dir` or `cd` are not supported. On Windows, `terminal_run` resolves `PATH`/`PATHEXT` and launches `.cmd` / `.bat` wrappers via `cmd.exe` when needed.
+Run a one-shot non-interactive command using `cmd + args` with `shell=false`. Safer than `terminal_exec` for predictable automation. Output is capped by `maxOutputBytes` rather than head + tail truncation. Shell built-ins such as `dir` or `cd` are not supported. On Windows, `terminal_run` resolves `PATH`/`PATHEXT` and launches `.cmd` / `.bat` wrappers via `cmd.exe` when needed. Prefer passing the target executable directly as `cmd` instead of wrapping it in `powershell -Command` or `cmd /c`, especially when Windows paths contain spaces.
 
 | Param | Type | Default | Description |
 |-------|------|---------|-------------|
@@ -346,6 +346,12 @@ terminal_run({ cmd: "git", args: ["status", "--porcelain=v1", "--branch"] })
 -> { ok: true, stdout: { raw: "...", parsed: { branch: {...}, staged: [], modified: [], untracked: [] } } }
 ```
 
+For Windows tools installed under `Program Files`, prefer this shape over `powershell -Command`:
+
+```
+terminal_run({ cmd: "C:\\Program Files\\Vendor\\Tool.exe", args: ["/flag:value", "/other"] })
+```
+
 ### Page through large read-only output
 
 ```

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "smart-terminal-mcp",
-  "version": "1.2.8",
+  "version": "1.2.9",
   "description": "MCP PTY server providing AI agents with real interactive terminal access",
   "type": "module",
   "main": "src/index.js",

package/src/tools.js

@@ -107,10 +107,10 @@ export function registerTools(server, manager) {
   // --- terminal_run ---
   server.tool(
     'terminal_run',
-    'Run a one-shot non-interactive command.',
+    'Run a binary directly; avoid shell quoting.',
     {
-      cmd: z.string().describe('Executable'),
-      args: z.array(z.string()).default([]).describe('Arguments'),
+      cmd: z.string().describe('Executable path or name'),
+      args: z.array(z.string()).default([]).describe('Args passed verbatim'),
       cwd: z.string().optional().describe('Working directory'),
       timeout: z.number().int().min(1000).max(600000).default(DEFAULT_TIMEOUT_MS).describe('Timeout in ms'),
       maxOutputBytes: z.number().int().min(1024).max(1048576).default(DEFAULT_MAX_OUTPUT_BYTES).describe('Max output bytes'),

package/test/command-runner.test.js

@@ -1,6 +1,6 @@
 import test from 'node:test';
 import assert from 'node:assert/strict';
-import { mkdtemp, rm, writeFile } from 'node:fs/promises';
+import { chmod, mkdtemp, rm, writeFile } from 'node:fs/promises';
 import { tmpdir } from 'node:os';
 import { join } from 'node:path';
 import { getStructuredParserHint, runCommand } from '../src/command-runner.js';
@@ -168,6 +168,33 @@ test('runCommand executes explicit .cmd files on Windows', async (t) => {
   }
 });
 
+test('runCommand handles explicit command paths with spaces', async () => {
+  const tempDir = await mkdtemp(join(tmpdir(), 'smart terminal mcp-'));
+
+  try {
+    const isWindows = process.platform === 'win32';
+    const scriptPath = join(tempDir, isWindows ? 'space wrapper.cmd' : 'space-wrapper.sh');
+    const scriptBody = isWindows
+      ? '@echo off\r\necho [%~1]\r\n'
+      : '#!/bin/sh\necho "[$1]"\n';
+
+    await writeFile(scriptPath, scriptBody);
+    if (!isWindows) await chmod(scriptPath, 0o755);
+
+    const result = await runCommand({
+      cmd: scriptPath,
+      args: ['hello world'],
+      parse: false,
+    });
+
+    assert.equal(result.ok, true);
+    assert.equal(result.exitCode, 0);
+    assert.match(result.stdout.raw, /\[hello world\]/);
+  } finally {
+    await rm(tempDir, { recursive: true, force: true });
+  }
+});
+
 test('runCommand adds a helpful ENOENT hint on Windows for PATH commands', async (t) => {
   if (process.platform !== 'win32') {
     t.skip('Windows-only behavior');