smart-review 1.0.2 → 1.0.3

package/lib/default-config.js

@@ -28,13 +28,6 @@ export const defaultConfig = {
     contextMergeLines: 10 // 上下文合并行长度（大概值），用于在diff审查时提供足够的上下文
   },
 
-  // Git 行为配置
-  git: {
-    // 在 merge/rebase 过程中，默认仅审查“冲突并由开发者手动处理过”的文件；
-    // 对于无冲突的自动合并文件，默认跳过审查。
-    skipNonConflictOnMergeRebase: true
-  },
-
   // 风险等级配置
   riskLevels: {
     critical: { block: true },
@@ -137,7 +130,8 @@ export const defaultRules = {
       risk: 'high',
       message: t(undefined, 'rule_SEC001_message'),
       suggestion: t(undefined, 'rule_SEC001_suggestion'),
-      flags: 'gi'
+      flags: 'gi',
+      extensions: ['.js', '.ts', '.py', '.java', '.rb', '.php', '.cs', '.go']
     },
     {
       id: 'SEC002',
@@ -146,7 +140,8 @@ export const defaultRules = {
       risk: 'critical',
       message: t(undefined, 'rule_SEC002_message'),
       suggestion: t(undefined, 'rule_SEC002_suggestion'),
-      flags: 'gi'
+      flags: 'gi',
+      extensions: ['.js', '.ts', '.java', '.cs', '.php', '.py', '.rb', '.go']
     },
     {
       id: 'SEC003',
@@ -155,7 +150,8 @@ export const defaultRules = {
       risk: 'high',
       message: t(undefined, 'rule_SEC003_message'),
       suggestion: t(undefined, 'rule_SEC003_suggestion'),
-      flags: 'gi'
+      flags: 'gi',
+      extensions: ['.js', '.jsx', '.ts', '.tsx', '.vue', '.svelte']
     }
   ],
   
@@ -167,7 +163,8 @@ export const defaultRules = {
       risk: 'medium',
       message: t(undefined, 'rule_PERF001_message'),
       suggestion: t(undefined, 'rule_PERF001_suggestion'),
-      flags: 'gi'
+      flags: 'gi',
+      extensions: ['.js', '.ts', '.java', '.py', '.rb', '.php', '.cs', '.go']
     },
     {
       id: 'PERF002',
@@ -176,7 +173,8 @@ export const defaultRules = {
       risk: 'medium',
       message: t(undefined, 'rule_PERF002_message'),
       suggestion: t(undefined, 'rule_PERF002_suggestion'),
-      flags: 'gi'
+      flags: 'gi',
+      extensions: ['.js', '.jsx', '.ts', '.tsx', '.vue', '.svelte']
     }
   ],
   
@@ -188,7 +186,8 @@ export const defaultRules = {
       risk: 'low',
       message: t(undefined, 'rule_BP001_message'),
       suggestion: t(undefined, 'rule_BP001_suggestion'),
-      flags: 'gi'
+      flags: 'gi',
+      extensions: ['.js', '.jsx', '.ts', '.tsx', '.vue', '.svelte', '.py', '.php', '.rb']
     },
     {
       id: 'BP002',
@@ -197,7 +196,8 @@ export const defaultRules = {
       risk: 'low',
       message: t(undefined, 'rule_BP002_message'),
       suggestion: t(undefined, 'rule_BP002_suggestion'),
-      flags: 'g'
+      flags: 'g',
+      extensions: ['.js', '.ts', '.java', '.cs', '.php', '.py', '.rb', '.go']
     },
     {
       id: 'BP013',
@@ -206,7 +206,8 @@ export const defaultRules = {
       risk: 'medium',
       message: t(undefined, 'rule_BP013_message'),
       suggestion: t(undefined, 'rule_BP013_suggestion'),
-      flags: 'gi'
+      flags: 'gi',
+      extensions: ['.js', '.jsx', '.ts', '.tsx']
     }
   ]
 };

package/lib/reviewer.js

@@ -326,6 +326,17 @@ export class CodeReviewer {
        const commentRanges = this.getCachedCommentRanges(addedLinesContent, ext);
        
        for (const rule of this.rules) {
+         // 扩展名过滤：若规则声明了 extensions，则仅在匹配的扩展上生效
+         const ruleExts = Array.isArray(rule.extensions) ? rule.extensions : null;
+         if (ruleExts && ruleExts.length > 0) {
+           const normalized = ruleExts.map((e) => {
+             const s = String(e).trim().toLowerCase();
+             return s.startsWith('.') ? s : `.${s}`;
+           });
+           if (!normalized.includes(ext)) {
+             continue;
+           }
+         }
          try {
            // 函数类型规则处理
            if (typeof rule.pattern === 'function') {
@@ -823,6 +834,17 @@ export class CodeReviewer {
     let skippedByComments = 0;
     let skippedByDirectives = 0;
     for (const rule of this.rules) {
+      // 扩展名过滤：若规则声明了 extensions，则仅在匹配的扩展上生效
+      const ruleExts = Array.isArray(rule.extensions) ? rule.extensions : null;
+      if (ruleExts && ruleExts.length > 0) {
+        const normalized = ruleExts.map((e) => {
+          const s = String(e).trim().toLowerCase();
+          return s.startsWith('.') ? s : `.${s}`;
+        });
+        if (!normalized.includes(ext)) {
+          continue;
+        }
+      }
       try {
         // 保留通用 requiresAbsent 跳过，但当 requiresAbsent 明显是“函数调用样式”时，改为逐匹配的配对校验
         const requiresAbsent = Array.isArray(rule.requiresAbsent) ? rule.requiresAbsent : null;

package/lib/utils/i18n.js

@@ -69,6 +69,7 @@ const MESSAGES = {
     hook_cd_repo_fail: '❌ 无法进入仓库根目录',
     hook_cmd_not_found1: '❌ 未找到 smart-review。请在对应子项目安装：npm i -D smart-review',
     hook_cmd_not_found2: '   或在仓库根安装供统一使用：npm i -D smart-review',
+    hook_cmd_missing_continue: '⚠️ 未安装 smart-review，自动审查失败。如需自动审查，请执行：npm i -D smart-review。本次继续为你完成 commit 操作。',
     hook_use_command_prefix: '⚙️  使用命令:',
     hook_review_fail: '❌ 代码审查未通过，请修复问题后重新提交',
     hook_review_pass: '✅ 代码审查通过，继续提交',
@@ -142,10 +143,6 @@ const MESSAGES = {
     start_git_diff_mode: '🔍 启动Git Diff增量审查模式...',
     no_changes_skip: '📝 暂存区无变更内容，跳过审查',
     found_changed_files_n: '📊 发现 {count} 个变更文件，开始增量审查...',
-    // Merge/Rebase filters
-    merge_rebase_detected_info: '🔀 检测到 Git 合并/变基过程，按策略过滤审查文件',
-    merge_conflict_paths_found_n: '⚔️  冲突文件 {count} 个，仅审查这些文件',
-    merge_rebase_no_conflict_skip: '✅ 合并/变基期间未检测到冲突文件，跳过审查',
     apply_static_rules_dbg: '应用静态规则检查...',
     static_rules_found_n_dbg: '静态规则发现 {count} 个问题',
     file_skipped_by_type: '文件已跳过审查: {path} (文件类型被忽略)',
@@ -496,6 +493,7 @@ const MESSAGES = {
     hook_cd_repo_fail: '❌ Failed to cd to repo root',
     hook_cmd_not_found1: '❌ smart-review not found. Please install in the subproject: npm i -D smart-review',
     hook_cmd_not_found2: '   Or install at repo root for unified use: npm i -D smart-review',
+    hook_cmd_missing_continue: '⚠️ smart-review not installed; auto review skipped. To enable auto review, run: npm i -D smart-review. Proceeding with commit.',
     hook_use_command_prefix: '⚙️  Using command:',
     hook_review_fail: '❌ Code review failed; please fix issues and retry commit',
     hook_review_pass: '✅ Code review passed; continuing commit',
@@ -569,10 +567,6 @@ const MESSAGES = {
     start_git_diff_mode: '🔍 Starting Git Diff incremental review...',
     no_changes_skip: '📝 No changes in staged area, skipping review',
     found_changed_files_n: '📊 Found {count} changed files, starting incremental review...',
-    // Merge/Rebase filters
-    merge_rebase_detected_info: '🔀 Git merge/rebase detected; filtering to conflict files',
-    merge_conflict_paths_found_n: '⚔️  Found {count} conflict file(s); reviewing only these',
-    merge_rebase_no_conflict_skip: '✅ No conflict files during merge/rebase; skipping review',
     apply_static_rules_dbg: 'Applying static rule checks...',
     static_rules_found_n_dbg: 'Static rules found {count} issues',
     file_skipped_by_type: 'File skipped: {path} (ignored file type)',

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "smart-review",
-  "version": "1.0.2",
+  "version": "1.0.3",
   "description": "AI智能代码审查工具，支持静态规则和AI分析",
   "type": "module",
   "main": "index.js",

package/templates/rules/en-US/best-practices.js

@@ -7,7 +7,8 @@ export default [
     risk: 'low',
     message: 'Debug code found; remove before committing',
     suggestion: 'Use a logging system instead of console.log',
-    flags: 'gi'
+    flags: 'gi',
+    extensions: ['.js', '.ts', '.py', '.php', '.rb']
   },
   {
     id: 'BP002',
@@ -16,7 +17,8 @@ export default [
     risk: 'low',
     message: 'Magic numbers detected; define them as constants',
     suggestion: 'Define numbers as meaningful constants',
-    flags: 'g'
+    flags: 'g',
+    extensions: ['.js', '.ts', '.java', '.cs', '.php', '.py', '.rb', '.go']
   },
   {
     id: 'BP003',
@@ -25,7 +27,8 @@ export default [
     risk: 'medium',
     message: 'Empty catch may hide errors and cause unpredictable behavior',
     suggestion: 'Log or take remedial actions instead of swallowing exceptions',
-    flags: 'gi'
+    flags: 'gi',
+    extensions: ['.js', '.ts', '.java', '.cs', '.php']
   },
   {
     id: 'BP004',
@@ -34,7 +37,8 @@ export default [
     risk: 'medium',
     message: 'Detected @ts-ignore; may conceal type errors',
     suggestion: 'Fix type issues or use precise type definitions',
-    flags: 'gi'
+    flags: 'gi',
+    extensions: ['.ts']
   },
   {
     id: 'BP005',
@@ -43,7 +47,8 @@ export default [
     risk: 'medium',
     message: 'Using any weakens type safety guarantees',
     suggestion: 'Use concrete types or generics to improve safety',
-    flags: 'gi'
+    flags: 'gi',
+    extensions: ['.ts']
   },
   {
     id: 'BP006',
@@ -52,7 +57,8 @@ export default [
     risk: 'medium',
     message: 'Disabling ESLint may hide code quality issues',
     suggestion: 'Disable locally only when necessary, and explain the reason',
-    flags: 'gi'
+    flags: 'gi',
+    extensions: ['.js', '.ts']
   },
   {
     id: 'BP007',
@@ -61,7 +67,8 @@ export default [
     risk: 'medium',
     message: 'Debugger statement found; may affect production behavior',
     suggestion: 'Remove debugger before commit; use logs or assertions',
-    flags: 'gi'
+    flags: 'gi',
+    extensions: ['.js', '.ts']
   },
   {
     id: 'BP008',
@@ -70,7 +77,8 @@ export default [
     risk: 'medium',
     message: 'Catching broad exception types without proper handling',
     suggestion: 'Catch specific types and ensure logging or rethrowing as needed',
-    flags: 'gi'
+    flags: 'gi',
+    extensions: ['.js', '.ts', '.java', '.cs', '.php']
   },
   {
     id: 'BP009',
@@ -79,7 +87,8 @@ export default [
     risk: 'medium',
     message: 'Direct stack printing may lose context and produce uncontrolled output',
     suggestion: 'Use structured logging with context information',
-    flags: 'gi'
+    flags: 'gi',
+    extensions: ['.java']
   },
   {
     id: 'BP010',
@@ -88,7 +97,8 @@ export default [
     risk: 'high',
     message: 'System.exit detected; may cause unexpected service termination',
     suggestion: 'Use graceful shutdown, signal handling, and resource cleanup',
-    flags: 'gi'
+    flags: 'gi',
+    extensions: ['.java']
   },
   {
     id: 'BP011',
@@ -97,7 +107,8 @@ export default [
     risk: 'medium',
     message: 'Using root as DB user introduces security and audit risks',
     suggestion: 'Use a least-privileged application account and separate duties',
-    flags: 'gi'
+    flags: 'gi',
+    extensions: ['.js', '.ts', '.java', '.cs', '.php', '.py', '.rb', '.go']
   },
   {
     id: 'BP012',
@@ -106,6 +117,7 @@ export default [
     risk: 'high',
     message: 'Globally disabling CSRF may cause CSRF vulnerabilities',
     suggestion: 'Use token/same-origin policies where needed; avoid global disable',
-    flags: 'gi'
+    flags: 'gi',
+    extensions: ['.java']
   }
 ];

package/templates/rules/en-US/performance.js

@@ -7,7 +7,8 @@ export default [
     risk: 'medium',
     message: 'Executing DB queries in loops may cause N+1 problems',
     suggestion: 'Use batch queries or preload data',
-    flags: 'gi'
+    flags: 'gi',
+    extensions: ['.js', '.ts', '.java', '.py', '.php', '.rb', '.cs', '.go']
   },
   {
     id: 'PERF002',
@@ -17,6 +18,7 @@ export default [
     message: 'Timers without cleanup may cause leaks or lingering tasks',
     suggestion: 'Call clearInterval/clearTimeout at the proper lifecycle point',
     flags: 'gi',
+    extensions: ['.js', '.ts'],
     // To override built-in PERF002, external rule adds cleanup detection; skip if any cleanup exists in file
     requiresAbsent: ['clearInterval\\s*\\(', 'clearTimeout\\s*\\(']
   },
@@ -27,7 +29,8 @@ export default [
     risk: 'high',
     message: 'Sync file I/O may block the event loop and hurt throughput',
     suggestion: 'Prefer async I/O or queued processing; avoid blocking the main thread',
-    flags: 'gi'
+    flags: 'gi',
+    extensions: ['.js', '.ts']
   },
   {
     id: 'PERF004',
@@ -36,7 +39,8 @@ export default [
     risk: 'high',
     message: 'Requests inside loops can cause cascading latency and congestion',
     suggestion: 'Merge requests, control concurrency, or batch to reduce round-trips',
-    flags: 'gi'
+    flags: 'gi',
+    extensions: ['.js', '.ts', '.py']
   },
   {
     id: 'PERF005',
@@ -45,7 +49,8 @@ export default [
     risk: 'medium',
     message: 'Frequent serialization in loops causes excessive CPU overhead',
     suggestion: 'Move serialization out of the loop or cache/batch it',
-    flags: 'gi'
+    flags: 'gi',
+    extensions: ['.js', '.ts']
   },
   {
     id: 'PERF006',
@@ -54,7 +59,8 @@ export default [
     risk: 'medium',
     message: 'Repeated regex compilation adds unnecessary overhead',
     suggestion: 'Precompile or constantize regexes; avoid creating them in loops',
-    flags: 'gi'
+    flags: 'gi',
+    extensions: ['.js', '.ts']
   },
   {
     id: 'PERF007',
@@ -63,7 +69,8 @@ export default [
     risk: 'high',
     message: 'Possible busy-wait detected; can spike CPU and waste resources',
     suggestion: 'Use event-driven or blocking waits; avoid empty loops',
-    flags: 'gi'
+    flags: 'gi',
+    extensions: ['.js', '.ts', '.java', '.cs', '.php', '.rb']
   },
   {
     id: 'PERF008',
@@ -72,7 +79,8 @@ export default [
     risk: 'high',
     message: 'Reading layout in loops triggers frequent reflow/repaint',
     suggestion: 'Batch DOM reads/writes; reduce synchronous layout queries',
-    flags: 'gi'
+    flags: 'gi',
+    extensions: ['.js', '.ts']
   },
   {
     id: 'PERF009',
@@ -81,7 +89,8 @@ export default [
     risk: 'medium',
     message: 'Blocking waits reduce throughput and responsiveness',
     suggestion: 'Use async waits or rate-limiting/queues; avoid blocking',
-    flags: 'gi'
+    flags: 'gi',
+    extensions: ['.java', '.py']
   },
   {
     id: 'PERF010',
@@ -90,7 +99,8 @@ export default [
     risk: 'high',
     message: 'Unbounded pools can explode thread count and exhaust resources',
     suggestion: 'Use bounded pools with sane maximums and queue lengths',
-    flags: 'gi'
+    flags: 'gi',
+    extensions: ['.java']
   },
   {
     id: 'PERF011',
@@ -99,7 +109,8 @@ export default [
     risk: 'medium',
     message: 'Frequent concatenation in loops consumes CPU and memory',
     suggestion: 'Use StringBuilder/collect in lists then join, or batch strategies',
-    flags: 'gi'
+    flags: 'gi',
+    extensions: ['.js', '.ts', '.java', '.cs', '.py', '.rb']
   },
   {
     id: 'PERF012',
@@ -108,7 +119,8 @@ export default [
     risk: 'high',
     message: 'Repeatedly creating DB connections causes severe performance issues',
     suggestion: 'Use connection pools and reuse; acquire connections outside loops',
-    flags: 'gi'
+    flags: 'gi',
+    extensions: ['.js', '.ts', '.java', '.cs', '.php']
   },
   {
     id: 'PERF013',
@@ -118,6 +130,7 @@ export default [
     message: 'Requests without timeout can hang resources and reduce throughput',
     suggestion: 'Set reasonable timeout; control retries and circuit breaking',
     flags: 'gi',
+    extensions: ['.py'],
     requiresAbsent: ['timeout\\s*=']
   }
 ];