smart-review 1.0.1 → 1.0.2

package/lib/config-loader.js

@@ -3,6 +3,7 @@ import path from 'path';
 import { createRequire } from 'module';
 import { defaultConfig, defaultRules } from './default-config.js';
 import { logger } from './utils/logger.js';
+import { t } from './utils/i18n.js';
 
 export class ConfigLoader {
   constructor(projectRoot) {
@@ -51,7 +52,7 @@ export class ConfigLoader {
         externalConfig = JSON.parse(configContent);
 
       } catch (error) {
-        logger.warn('外部配置文件解析失败，使用默认配置:', error.message);
+        logger.warn(t(undefined, 'external_config_parse_failed_warn', { error: error?.message || String(error) }));
       }
     }
 
@@ -72,7 +73,7 @@ export class ConfigLoader {
     // 根据配置决定规则加载策略
     if (config.useExternalRulesOnly) {
       // 仅使用外部规则模式：只返回外部规则，不加载内置规则
-      logger.info('使用外部规则模式：仅加载 local-rules 目录中的规则');
+      logger.info(t(undefined, 'use_external_rules_only_info'));
       return externalRules;
     }
 
@@ -94,8 +95,9 @@ export class ConfigLoader {
     }
 
     const allRules = Array.from(ruleMap.values());
-
-    return allRules;
+    // 根据语言本地化规则的展示字段
+    const localizedRules = this.localizeRules(allRules, config);
+    return localizedRules;
   }
 
   async loadExternalRules() {
@@ -118,7 +120,7 @@ export class ConfigLoader {
         }
       }
     } catch (error) {
-      logger.warn('加载外部规则失败:', error.message);
+      logger.warn(t(undefined, 'load_external_rules_failed_warn', { error: error?.message || String(error) }));
     }
     
     return externalRules;
@@ -169,7 +171,7 @@ export class ConfigLoader {
                 }
               } catch (tempError) {
                 // 如果临时文件方法失败，回退到原来的 base64 方法
-                logger.warn(`临时文件方法失败，回退到 base64 方法: ${tempError.message}`);
+                logger.warn(t(undefined, 'temp_file_method_failed_fallback_info', { error: tempError?.message || String(tempError) }));
                 
                 // 清理可能已创建的临时文件
                 try {
@@ -201,12 +203,38 @@ export class ConfigLoader {
         return config.rules || [];
       }
     } catch (error) {
-      logger.warn(`加载规则文件失败 ${filePath}:`, error.message);
+      logger.warn(t(undefined, 'load_rule_file_failed_warn', { file: filePath, error: error?.message || String(error) }));
     }
     
     return [];
   }
 
+  /**
+   * 按当前语言对规则 name/message/suggestion 进行本地化。
+   * 若翻译键不存在则保留原始内容。
+   */
+  localizeRules(rules, configOrLocale) {
+    if (!Array.isArray(rules) || rules.length === 0) return rules;
+    return rules.map((rule) => {
+      const id = rule?.id;
+      if (!id) return rule;
+
+      const nameKey = `rule_${id}_name`;
+      const msgKey = `rule_${id}_message`;
+      const sugKey = `rule_${id}_suggestion`;
+
+      const maybeName = t(configOrLocale, nameKey);
+      const maybeMsg = t(configOrLocale, msgKey);
+      const maybeSug = t(configOrLocale, sugKey);
+
+      const localized = { ...rule };
+      if (typeof maybeName === 'string' && maybeName !== nameKey) localized.name = maybeName;
+      if (typeof maybeMsg === 'string' && maybeMsg !== msgKey) localized.message = maybeMsg;
+      if (typeof maybeSug === 'string' && maybeSug !== sugKey) localized.suggestion = maybeSug;
+      return localized;
+    });
+  }
+
   deepMerge(target, source) {
     const result = { ...target };
     

package/lib/default-config.js

@@ -1,3 +1,5 @@
+import { t } from './utils/i18n.js';
+
 export const defaultConfig = {
   // AI配置
   ai: {
@@ -26,6 +28,13 @@ export const defaultConfig = {
     contextMergeLines: 10 // 上下文合并行长度（大概值），用于在diff审查时提供足够的上下文
   },
 
+  // Git 行为配置
+  git: {
+    // 在 merge/rebase 过程中，默认仅审查“冲突并由开发者手动处理过”的文件；
+    // 对于无冲突的自动合并文件，默认跳过审查。
+    skipNonConflictOnMergeRebase: true
+  },
+
   // 风险等级配置
   riskLevels: {
     critical: { block: true },
@@ -123,29 +132,29 @@ export const defaultRules = {
   security: [
     {
       id: 'SEC001',
-      name: '硬编码密码',
+      name: t(undefined, 'rule_SEC001_name'),
       pattern: '(password|pwd|pass)\\s*=\\s*[\'"][^\'"]+[\'"]',
       risk: 'high',
-      message: '发现硬编码的密码，建议使用环境变量或安全的配置管理',
-      suggestion: '使用环境变量或加密的配置存储',
+      message: t(undefined, 'rule_SEC001_message'),
+      suggestion: t(undefined, 'rule_SEC001_suggestion'),
       flags: 'gi'
     },
     {
       id: 'SEC002',
-      name: 'SQL注入风险',
+      name: t(undefined, 'rule_SEC002_name'),
       pattern: '(execute|query)\\s*\\(\\s*[fF]?[\'"][^\']*\\+.*[\'"]',
       risk: 'critical',
-      message: '发现可能的SQL注入风险，字符串拼接SQL查询',
-      suggestion: '使用参数化查询或ORM的安全方法',
+      message: t(undefined, 'rule_SEC002_message'),
+      suggestion: t(undefined, 'rule_SEC002_suggestion'),
       flags: 'gi'
     },
     {
       id: 'SEC003',
-      name: 'XSS风险',
+      name: t(undefined, 'rule_SEC003_name'),
       pattern: 'innerHTML\\s*=|document\\.write\\s*\\(',
       risk: 'high',
-      message: '发现直接操作HTML内容，可能存在XSS风险',
-      suggestion: '使用textContent或安全的DOM操作方法',
+      message: t(undefined, 'rule_SEC003_message'),
+      suggestion: t(undefined, 'rule_SEC003_suggestion'),
       flags: 'gi'
     }
   ],
@@ -153,20 +162,20 @@ export const defaultRules = {
   performance: [
     {
       id: 'PERF001',
-      name: '循环内数据库查询',
+      name: t(undefined, 'rule_PERF001_name'),
       pattern: 'for\\s*\\([^)]*\\)\\s*\\{[^}]*\\.(find|query|select)[^}]*\\}',
       risk: 'medium',
-      message: '在循环内执行数据库查询，可能导致N+1查询问题',
-      suggestion: '使用批量查询或预加载数据',
+      message: t(undefined, 'rule_PERF001_message'),
+      suggestion: t(undefined, 'rule_PERF001_suggestion'),
       flags: 'gi'
     },
     {
       id: 'PERF002',
-      name: '内存泄漏风险',
+      name: t(undefined, 'rule_PERF002_name'),
       pattern: 'setInterval\\s*\\([^)]*\\)|setTimeout\\s*\\([^)]*\\)',
       risk: 'medium',
-      message: '发现定时器使用，可能存在内存泄漏风险',
-      suggestion: '确保在组件卸载时清理定时器',
+      message: t(undefined, 'rule_PERF002_message'),
+      suggestion: t(undefined, 'rule_PERF002_suggestion'),
       flags: 'gi'
     }
   ],
@@ -174,29 +183,29 @@ export const defaultRules = {
   'best-practices': [
     {
       id: 'BP001',
-      name: '调试代码',
+      name: t(undefined, 'rule_BP001_name'),
       pattern: 'console\\.log|print\\(|alert\\(',
       risk: 'low',
-      message: '发现调试代码，建议在提交前移除',
-      suggestion: '使用日志系统替代console.log',
+      message: t(undefined, 'rule_BP001_message'),
+      suggestion: t(undefined, 'rule_BP001_suggestion'),
       flags: 'gi'
     },
     {
       id: 'BP002',
-      name: '魔法数字',
+      name: t(undefined, 'rule_BP002_name'),
       pattern: '\\b(?<!\\.)(?!(?:0|1|10|12|24|30|60|100|200|201|300|400|401|403|404|500|503|1000|3000|5000|8080|9000)\\b)\\d{3,}(?!\\.\\d)\\b',
       risk: 'low',
-      message: '检测到魔法数字，建议使用常量定义',
-      suggestion: '将数字定义为有意义的常量',
+      message: t(undefined, 'rule_BP002_message'),
+      suggestion: t(undefined, 'rule_BP002_suggestion'),
       flags: 'g'
     },
     {
       id: 'BP013',
-      name: '使用var声明',
+      name: t(undefined, 'rule_BP013_name'),
       pattern: '\\bvar\\s+\\w+',
       risk: 'medium',
-      message: '检测到使用var声明变量，可能导致作用域问题',
-      suggestion: '使用let或const替代var，提高代码安全性',
+      message: t(undefined, 'rule_BP013_message'),
+      suggestion: t(undefined, 'rule_BP013_suggestion'),
       flags: 'gi'
     }
   ]