smart-home-engine 1.20.2 → 1.20.3

package/dist/web/assets/{tsMode-wYM5jYsY.js → tsMode-DBmTyMNv.js}

@@ -1,4 +1,4 @@
-import{m as O}from"./monaco-langs-Dt8a9eeo.js";import{t as I}from"./index-C31bVgVn.js";/*!-----------------------------------------------------------------------------
+import{m as O}from"./monaco-langs-Dt8a9eeo.js";import{t as I}from"./index-BbXC7eVn.js";/*!-----------------------------------------------------------------------------
  * Copyright (c) Microsoft Corporation. All rights reserved.
  * Version: 0.52.2(404545bded1df6ffa41ea0af4e8ddb219018c6c1)
  * Released under the MIT license

package/dist/web/index.html

@@ -172,10 +172,10 @@
                 }
             })();
         </script>
-      <script type="module" crossorigin src="/assets/index-C31bVgVn.js"></script>
+      <script type="module" crossorigin src="/assets/index-BbXC7eVn.js"></script>
       <link rel="modulepreload" crossorigin href="/assets/monaco-langs-Dt8a9eeo.js">
       <link rel="stylesheet" crossorigin href="/assets/monaco-langs-DyX1CsEw.css">
-      <link rel="stylesheet" crossorigin href="/assets/index-CjRDTePT.css">
+      <link rel="stylesheet" crossorigin href="/assets/index-B4M4MeEk.css">
     </head>
     <body>
         <div id="app"></div>

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "smart-home-engine",
-    "version": "1.20.2",
+    "version": "1.20.3",
     "description": "Node.js based script runner for use in MQTT based Smart Home environments",
     "main": "src/index.js",
     "scripts": {

package/src/matter/controller.js

@@ -326,6 +326,11 @@ async function _commissionInner(options) {
     if (!addr) throw new Error('Commission succeeded but node has no peerAddress');
     const nodeId = _nodeIdStr(addr.nodeId);
     _subscribeNodeLifecycle(clientNode, nodeId);
+    // A freshly commissioned node is already online, so the lifecycle 'online'
+    // event (the other place this is wired) will not fire again — attach the
+    // attribute watchers now or the node stays without live updates until the
+    // next daemon restart.
+    _broadcastNodeAttributes(clientNode, nodeId);
     _broadcast?.({ type: 'matter:deviceList', devices: listPaired() });
     return nodeId;
 }
@@ -394,11 +399,77 @@ async function getAttribute(nodeId, endpointId, clusterName, attrName) {
     return clusterState[attrName];
 }
 
+/**
+ * Write a single attribute value (a remote write for client nodes — the
+ * attribute must be writable per the device's Matter data model).
+ *
+ * @param {string}  nodeId
+ * @param {number}  endpointId
+ * @param {string}  clusterName  camelCase cluster name, e.g. "basicInformation"
+ * @param {string}  attrName     camelCase attribute name, e.g. "nodeLabel"
+ * @param {*}       value
+ * @returns {Promise<void>}
+ */
+async function setAttribute(nodeId, endpointId, clusterName, attrName, value) {
+    const node = _findClientNode(nodeId);
+    const endpoint = _resolveEndpoint(node, endpointId);
+    await endpoint.set({ [_clusterName(clusterName)]: { [attrName]: value } });
+}
+
+/**
+ * Rename a device by writing basicInformation.nodeLabel on the root endpoint —
+ * the Matter-standard writable user label (max 32 chars), persisted on the
+ * device itself. she prefers nodeLabel over productName wherever names are
+ * shown or matched, so the new name is immediately usable in scripts.
+ *
+ * @param {string} nodeId
+ * @param {string} name
+ * @returns {Promise<void>}
+ */
+async function rename(nodeId, name) {
+    await setAttribute(nodeId, 0, 'basicInformation', 'nodeLabel', String(name));
+    _log?.info(`matter: renamed node ${nodeId} to "${name}"`);
+    _broadcast?.({ type: 'matter:deviceList', devices: listPaired() });
+}
+
 // ── Commands ──────────────────────────────────────────────────────────────────
 
+/**
+ * Best-effort: list the mandatory field names (camelCase) of a command's
+ * request schema. Handles both shapes matter.js uses: a TLV ObjectSchema
+ * (fieldDefinitions, camelCase keys) and a CommandModel (children with
+ * PascalCase names and conformance flags). Returns [] when unresolvable.
+ * @param {object} cluster      the behavior's cluster definition
+ * @param {string} commandName
+ * @returns {string[]}
+ */
+function _mandatoryCommandFields(cluster, commandName) {
+    try {
+        const cmd = cluster?.commands?.[commandName];
+        const schema = cmd?.schema ?? cmd?.requestSchema;
+        if (schema?.fieldDefinitions) {
+            return Object.entries(schema.fieldDefinitions)
+                .filter(([, def]) => !def?.optional)
+                .map(([name]) => name);
+        }
+        if (schema?.children) {
+            return [...schema.children].filter((c) => c.effectiveConformance?.isMandatory !== false).map((c) => c.name.charAt(0).toLowerCase() + c.name.slice(1));
+        }
+    } catch {
+        /* best-effort — fall through */
+    }
+    return [];
+}
+
 /**
  * Invoke a cluster command.
  *
+ * Mandatory boilerplate fields that scripts rarely care about are filled with
+ * neutral defaults when omitted: optionsMask/optionsOverride → {} (bitmap 0,
+ * "obey the device's options") and transitionTime → 0 (instant). So
+ * she.matter.send('x', 1, 'levelControl', 'moveToLevel', { level: 128 }) works
+ * without spelling out the full Matter command schema.
+ *
  * @param {string}  nodeId
  * @param {number}  endpointId
  * @param {string}  clusterName  camelCase cluster name, e.g. "onOff"
@@ -416,10 +487,17 @@ async function sendCommand(nodeId, endpointId, clusterName, commandName, args) {
         if (!clusterAgent) throw new Error(`Cluster "${clusterName}" not found on endpoint ${endpointId}`);
         const cmd = clusterAgent[commandName];
         if (typeof cmd !== 'function') throw new Error(`Command "${commandName}" not found in cluster "${clusterName}"`);
-        // Only pass args when the caller actually provided non-empty args.
+        // Fill neutral defaults for mandatory boilerplate fields the caller omitted.
+        const merged = args !== undefined && args !== null && typeof args === 'object' ? { ...args } : {};
+        for (const field of _mandatoryCommandFields(clusterAgent.cluster, commandName)) {
+            if (merged[field] !== undefined) continue;
+            if (field === 'optionsMask' || field === 'optionsOverride') merged[field] = {};
+            else if (field === 'transitionTime') merged[field] = 0;
+        }
+        // Only pass args when there is actually a payload.
         // Void commands (e.g. onOff.off) fail TLV validation if passed an empty object.
-        const hasArgs = args !== undefined && args !== null && Object.keys(args).length > 0;
-        return hasArgs ? cmd.call(clusterAgent, args) : cmd.call(clusterAgent);
+        const hasArgs = Object.keys(merged).length > 0;
+        return hasArgs ? cmd.call(clusterAgent, merged) : cmd.call(clusterAgent);
     });
 }
 
@@ -467,7 +545,14 @@ function _broadcastNodeAttributes(node, nodeId) {
                 }
             }
         }
-        _log?.info(`matter: watching ${count} attribute(s) on node ${nodeId}`);
+        if (count === 0) {
+            // Endpoint structure not populated yet (e.g. right after commissioning)
+            // — drop the guard so the next lifecycle 'online' event retries.
+            _attrBroadcastNodes.delete(nodeId);
+            _log?.debug(`matter: no watchable attributes on node ${nodeId} yet, will retry on next online event`);
+        } else {
+            _log?.info(`matter: watching ${count} attribute(s) on node ${nodeId}`);
+        }
     } catch (err) {
         _attrBroadcastNodes.delete(nodeId); // allow retry
         _log?.warn(`matter: attribute broadcast setup failed for ${nodeId}: ${err.message}`);
@@ -586,6 +671,8 @@ module.exports = {
     getEndpoints,
     getDeviceSubtitle,
     getAttribute,
+    setAttribute,
+    rename,
     sendCommand,
     subscribeAttribute,
     unsubscribe,

package/src/web/matter-api.js

@@ -58,6 +58,25 @@ router.post('/commission', async (req, res) => {
     }
 });
 
+// POST /she/matter/devices/:nodeId/rename — { name } → writes basicInformation.nodeLabel
+router.post('/devices/:nodeId/rename', async (req, res) => {
+    if (!isReady()) return notReady(res);
+    const name = req.body?.name;
+    if (typeof name !== 'string' || !name.trim()) {
+        return res.status(400).json({ error: 'body must contain a non-empty name' });
+    }
+    if (name.trim().length > 32) {
+        return res.status(400).json({ error: 'name must be at most 32 characters (Matter nodeLabel limit)' });
+    }
+    try {
+        await getController().rename(req.params.nodeId, name.trim());
+        res.json({ ok: true });
+    } catch (err) {
+        if (err.message.includes('not found')) return res.status(404).json({ error: err.message });
+        res.status(500).json({ error: err.message });
+    }
+});
+
 // GET /she/matter/devices/:nodeId — node detail
 router.get('/devices/:nodeId', (req, res) => {
     if (!isReady()) return notReady(res);