slopbrick 0.41.0 → 0.43.0

package/dist/engine/worker.js

@@ -6868,6 +6868,26 @@ function dispatchNode(node, parent, path, vctx) {
 // src/engine/parser-rust.ts
 import Parser from "tree-sitter";
 import Rust from "tree-sitter-rust";
+
+// src/engine/parser-shared.ts
+function parseTreeSitterSource(parserResult, source) {
+  if (!parserResult.ok) return null;
+  if (!source || source.trim() === "") return null;
+  try {
+    const rawTree = parserResult.parser.parse(source);
+    if (!rawTree) return null;
+    const tree = rawTree;
+    if (!tree || !tree.rootNode) return null;
+    if (tree.rootNode.type === "ERROR" && tree.rootNode.childCount === 0) {
+      return null;
+    }
+    return tree;
+  } catch {
+    return null;
+  }
+}
+
+// src/engine/parser-rust.ts
 var cachedParser = null;
 var rustLanguage = null;
 var loadError = null;
@@ -6894,21 +6914,7 @@ function effectiveParser() {
   return getRustParser();
 }
 function parseRust(source) {
-  const result = effectiveParser();
-  if (!result.ok) return null;
-  if (!source || source.trim() === "") return null;
-  try {
-    const rawTree = result.parser.parse(source);
-    if (!rawTree) return null;
-    const tree = rawTree;
-    if (!tree || !tree.rootNode) return null;
-    if (tree.rootNode.type === "ERROR" && tree.rootNode.childCount === 0) {
-      return null;
-    }
-    return tree;
-  } catch {
-    return null;
-  }
+  return parseTreeSitterSource(effectiveParser(), source);
 }
 function isRustParserAvailable() {
   const result = getRustParser();
@@ -7522,8 +7528,6 @@ function mergeTemplateClassNames(filePath, source, facts, templateClassNames) {
 }
 function extractFacts(filePath, ast, source, supportsRsc = true, framework = "react", config) {
   const lineOffsets = buildLineOffsets(source);
-  const isTypeScript = /\.tsx?$/i.test(filePath);
-  const NON_JSX_FRAMEWORKS = /* @__PURE__ */ new Set(["vue", "svelte", "astro"]);
   const facts = {
     filePath,
     components: [],
@@ -32947,7 +32951,7 @@ var aiCommentRatioRule = createRule({
         message: `Comment-line ratio is ${direction} (${ratio.toFixed(2)} vs corpus mean ${mean3}). Reductive LLMs (GPT-3.5, Claude 3 Haiku) skip comments; expansive LLMs (Claude Haiku 4.5, GPT-OSS) over-comment when prompted for "well-commented code".`,
         line: 1,
         column: 1,
-        advice: direction === "low" ? "Add doc comments explaining intent (not just restating the next line) for non-obvious logic." : "Trim comments that just restate the next line. Keep comments that explain WHY, not WHAT."
+        advice: direction === "low" ? "Add doc comments explaining intent (not just restating the next line) for non-obvious logic." : "High comment ratio \u2014 consider whether the comments are intentional (api docs, type defs, tutorials). For functional code, trim comments that just restate the next line. Keep comments that explain WHY, not WHAT."
       }
     ];
     return issues;
@@ -33721,7 +33725,6 @@ function buildTrigramLM(samples, alpha = 1) {
     logProb(context, t) {
       const ctxKey = context.slice(-2).join("|");
       const triKey = `${ctxKey}|${t}`;
-      const biKey = context.slice(-1).join("|") + "|" + t;
       const triCount = tri.get(triKey) ?? 0;
       const biCount = bi.get(ctxKey) ?? 0;
       const V = uni.size;
@@ -35514,7 +35517,7 @@ var RESERVED = /* @__PURE__ */ new Set([
 ]);
 var SOURCE_EXTS = /* @__PURE__ */ new Set([".ts", ".tsx", ".js", ".jsx", ".mjs", ".cjs"]);
 var SOURCE_ROOTS = ["src", "lib", "app", "components"];
-var CAP = 200;
+var CAP = 4e3;
 function walk(dir, out, cap) {
   if (!existsSync(dir) || out.length >= cap) return;
   let entries;
@@ -35594,6 +35597,7 @@ var staleFunctionReferenceRule = createRule({
     if (!source) return issues;
     for (const span of extractInlineCodeSpans(source)) {
       const text = span.text;
+      if (span.inBlockComment || span.inComment) continue;
       if (!/^[A-Za-z_$][A-Za-z0-9_$]*$/.test(text)) continue;
       if (text.length < 3) continue;
       if (RESERVED.has(text.toLowerCase())) continue;
@@ -35756,6 +35760,7 @@ var stalePackageReferenceRule = createRule({
     if (!source) return issues;
     const spans = extractInlineCodeSpans(source);
     for (const span of spans) {
+      if (span.inComment) continue;
       const lineStart = source.lastIndexOf("\n", span.index) + 1;
       const lineEnd = source.indexOf("\n", span.index);
       const line = source.slice(lineStart, lineEnd === -1 ? source.length : lineEnd);
@@ -35801,6 +35806,8 @@ var stalePackageReferenceRule = createRule({
 function extractInlineCodeSpans(source) {
   const hits = [];
   const re = /`([^`\n]+?)`/g;
+  const blockRanges = findBlockCommentRanges(source);
+  const commentLines = findCommentLineRanges(source);
   let m;
   while ((m = re.exec(source)) !== null) {
     const text = m[1] ?? "";
@@ -35808,13 +35815,22 @@ function extractInlineCodeSpans(source) {
     const line = upTo.split("\n").length;
     const lastNl = upTo.lastIndexOf("\n");
     const column = lastNl === -1 ? m.index + 1 : m.index - lastNl;
-    hits.push({ text, line, column, index: m.index });
+    hits.push({
+      text,
+      line,
+      column,
+      index: m.index,
+      inBlockComment: isInBlockComment(blockRanges, m.index),
+      inComment: commentLines.has(line)
+    });
   }
   return hits;
 }
 function extractMarkdownLinks(source) {
   const hits = [];
   const re = /(?<!\!)\[([^\]]*)\]\(([^)\s]+)(?:\s+"[^"]*")?\)/g;
+  const blockRanges = findBlockCommentRanges(source);
+  const commentLines = findCommentLineRanges(source);
   let m;
   while ((m = re.exec(source)) !== null) {
     const target = m[2] ?? "";
@@ -35822,10 +35838,55 @@ function extractMarkdownLinks(source) {
     const line = upTo.split("\n").length;
     const lastNl = upTo.lastIndexOf("\n");
     const column = lastNl === -1 ? m.index + 1 : m.index - lastNl;
-    hits.push({ target, line, column });
+    hits.push({
+      target,
+      line,
+      column,
+      index: m.index,
+      inBlockComment: isInBlockComment(blockRanges, m.index),
+      inComment: commentLines.has(line)
+    });
   }
   return hits;
 }
+function findBlockCommentRanges(source) {
+  const ranges = [];
+  const stack = [];
+  let i = 0;
+  while (i < source.length) {
+    if (source[i] === "/" && source[i + 1] === "/") {
+      const eol = source.indexOf("\n", i);
+      i = eol === -1 ? source.length : eol + 1;
+      continue;
+    }
+    if (source[i] === "/" && source[i + 1] === "*") {
+      stack.push(i);
+      i += 2;
+      continue;
+    }
+    if (source[i] === "*" && source[i + 1] === "/" && stack.length > 0) {
+      const start = stack.pop();
+      ranges.push([start, i + 2]);
+      i += 2;
+      continue;
+    }
+    i += 1;
+  }
+  ranges.sort((a, b) => a[0] - b[0]);
+  return ranges;
+}
+function isInBlockComment(ranges, pos) {
+  let lo = 0;
+  let hi = ranges.length - 1;
+  while (lo <= hi) {
+    const mid = lo + hi >>> 1;
+    const [start, end] = ranges[mid];
+    if (pos < start) hi = mid - 1;
+    else if (pos >= end) lo = mid + 1;
+    else return true;
+  }
+  return false;
+}
 function declaredPackages(cwd) {
   const out = /* @__PURE__ */ new Set();
   const pkgPath = join5(cwd, "package.json");
@@ -35845,8 +35906,63 @@ function declaredPackages(cwd) {
   }
   return out;
 }
+function findCommentLineRanges(source) {
+  const out = /* @__PURE__ */ new Set();
+  const stack = [];
+  let inLineComment = false;
+  const lines = source.split("\n");
+  for (let i = 0; i < lines.length; i++) {
+    const line = lines[i];
+    const lineNo = i + 1;
+    let j = 0;
+    while (j < line.length) {
+      const c = line[j];
+      const next = line[j + 1];
+      if (!stack.length && c === "/" && next === "/") {
+        inLineComment = true;
+        out.add(lineNo);
+        break;
+      }
+      if (c === "/" && next === "*") {
+        stack.push(lineNo);
+        out.add(lineNo);
+        j += 2;
+        continue;
+      }
+      if (c === "*" && next === "/" && stack.length > 0) {
+        stack.pop();
+        j += 2;
+        continue;
+      }
+      if (c === '"' || c === "'" || c === "`") {
+        const quote = c;
+        j += 1;
+        while (j < line.length) {
+          if (line[j] === "\\") {
+            j += 2;
+            continue;
+          }
+          if (line[j] === quote) {
+            j += 1;
+            break;
+          }
+          j += 1;
+        }
+        continue;
+      }
+      j += 1;
+    }
+    if (stack.length > 0) {
+      out.add(lineNo);
+    }
+  }
+  return out;
+}
 
 // src/rules/docs/broken-link.ts
+function looksLikeRegexSyntax(target) {
+  return /\[[^\]]*\]/.test(target) || /^\s*[?:=!]/.test(target) || /\\(?:s|d|w|S|D|W|t|n|r|[^\\])/.test(target) || /[{}|]/.test(target);
+}
 var brokenLinkRule = createRule({
   id: "docs/broken-link",
   category: "docs",
@@ -35869,6 +35985,8 @@ var brokenLinkRule = createRule({
       if (target.startsWith("#")) continue;
       if (target.startsWith("//")) continue;
       if (target.startsWith("/")) continue;
+      if (link.inBlockComment) continue;
+      if (looksLikeRegexSyntax(target)) continue;
       const filePart = target.split("#")[0] ?? target;
       if (filePart === "") continue;
       const resolved = join6(docDir, filePart);
@@ -37193,8 +37311,16 @@ var DEFAULT_CONFIG3 = {
       // rule definitions are meta-code
       "**/snippet/**",
       // RULE_HINTS examples are intentional bad code
-      "**/tests/**"
+      "**/tests/**",
       // all test files (fixtures + unit + integration)
+      // v0.42.0 (post-self-scan cleanup): language visitors are
+      // intentional clones — see the §3 v0.42.0 release notes for
+      // the design rationale. `dup/identical-block` fires 100+
+      // times during self-scan because each visitor shares the
+      // same service-suffix arrays and import-walking preamble.
+      // Suppress these from the self-scan noise floor; they
+      // remain on for user codebases.
+      "**/src/engine/visitors/**"
     ]
   }
 };
@@ -41095,23 +41221,16 @@ var builtinRules = [
 // src/rules/registry.ts
 var RuleRegistry = class {
   rules = /* @__PURE__ */ new Map();
-  register(ruleOrId, factory) {
-    if (typeof ruleOrId === "string") {
-      if (!factory) {
-        throw new Error("Factory is required when registering by id");
-      }
-      const rule = {
-        id: ruleOrId,
-        category: factory.category,
-        severity: factory.severity,
-        aiSpecific: factory.aiSpecific,
-        create: factory.create,
-        analyze: factory.analyze
-      };
-      this.rules.set(ruleOrId, rule);
-    } else {
-      this.rules.set(ruleOrId.id, ruleOrId);
-    }
+  /**
+   * Register a rule. The 2-arg overload `register(id, factory)` was
+   * deleted in v0.42.0 (architecture review F6): no callers used it,
+   * every `Rule` carries its own `id`, and the per-id registration
+   * was ergonomically redundant with the 1-arg form (`register(rule)`).
+   * External consumers that needed `register-by-id` semantics can
+   * construct a `Rule` directly and pass it in.
+   */
+  register(rule) {
+    this.rules.set(rule.id, rule);
   }
   loadBuiltins(onlyRuleId) {
     for (const rule of builtinRules) {
@@ -41140,6 +41259,15 @@ var RuleRegistry = class {
   all() {
     return Array.from(this.rules.values());
   }
+  /** v0.42.0 (§3b.5): look up a registered rule by id.
+   *  Returns undefined if not registered. */
+  get(id) {
+    return this.rules.get(id);
+  }
+  /** v0.42.0 (§3b.5): check whether a rule id is registered. */
+  has(id) {
+    return this.rules.has(id);
+  }
   createContexts(config, filePath, cwd, hotspotIssues = []) {
     const context = {
       config,
@@ -44834,6 +44962,36 @@ async function scanFile(filePath, config, registry, cwd = process.cwd()) {
     const issues = applyRuleOverrides(rawIssues, config.rules);
     const triggeredRuleIds = Array.from(new Set(issues.map((i) => i.ruleId)));
     const compScore = compositeScore(triggeredRuleIds, loadSignalStrength());
+    const fireSet = new Set(triggeredRuleIds);
+    const factsWithFireSet = Object.assign(facts, {
+      compositeFireSet: fireSet
+    });
+    for (const { rule } of rules) {
+      if (!rule.id.startsWith("composite/")) continue;
+      try {
+        const compositeIssues = rule.analyze(
+          rule.create({
+            config,
+            filePath,
+            cwd,
+            framework: config.framework,
+            uiLibraries: config.uiLibraries,
+            hasTailwind: config.hasTailwind,
+            supportsRsc: config.supportsRsc,
+            hotspotIssues: []
+          }),
+          factsWithFireSet
+        );
+        if (compositeIssues.length > 0) {
+          issues.push(...compositeIssues);
+          for (const ci of compositeIssues) fireSet.add(ci.ruleId);
+        }
+      } catch (err) {
+        if (process.env.SLOP_AUDIT_DEBUG === "1") {
+          console.error(`[worker] composite ${rule.id} threw: ${err.message}`);
+        }
+      }
+    }
     const gapValues = collectGapValues(facts);
     const styleSources = collectStyleSources(facts);
     const elementTags = facts.v2.jsx.elements.map((e) => e.tag);