slopbrick 0.28.0 → 0.29.0

package/dist/index.js

@@ -19,7 +19,7 @@ var VERSION;
 var init_header = __esm({
   "src/types/_header.ts"() {
     "use strict";
-    VERSION = "0.28.0";
+    VERSION = "0.29.0";
   }
 });
 
@@ -30749,6 +30749,115 @@ var init_data_class_defaults_overuse = __esm({
   }
 });
 
+// src/rules/kotlin/force-unwrap.ts
+var FORCE_UNWRAP_REGEX, kotlinForceUnwrapRule;
+var init_force_unwrap = __esm({
+  "src/rules/kotlin/force-unwrap.ts"() {
+    "use strict";
+    init_rule();
+    FORCE_UNWRAP_REGEX = /!!(?=\s*[.\)}\};,\n\[])/g;
+    kotlinForceUnwrapRule = createRule({
+      id: "kotlin/force-unwrap",
+      category: "logic",
+      severity: "medium",
+      aiSpecific: false,
+      description: "!! force-unwrap \u2014 use ?. (safe call) or a proper null check",
+      create(_context) {
+        return {};
+      },
+      analyze(_context, facts) {
+        const issues = [];
+        const source = facts.v2?._source;
+        if (!source) return issues;
+        if (!/\.kts?$/i.test(facts.filePath)) return issues;
+        let m;
+        FORCE_UNWRAP_REGEX.lastIndex = 0;
+        while ((m = FORCE_UNWRAP_REGEX.exec(source)) !== null) {
+          const line = source.slice(0, m.index).split("\n").length;
+          const lineStart = source.lastIndexOf("\n", m.index) + 1;
+          const lineText = source.slice(lineStart, m.index);
+          const quoteCount = (lineText.match(/"/g) || []).length;
+          if (quoteCount % 2 === 1) continue;
+          issues.push({
+            ruleId: "kotlin/force-unwrap",
+            category: "logic",
+            severity: "medium",
+            aiSpecific: false,
+            message: `!! force-unwrap at line ${line}`,
+            line,
+            column: m.index - lineStart + 1,
+            advice: "Use ?. (safe call) with ?: (Elvis) for a default, or a proper when/if check. !! throws NullPointerException at runtime \u2014 it bypasses Kotlin's type system. Reference: kotlin/force-unwrap v0.29."
+          });
+        }
+        return issues;
+      }
+    });
+  }
+});
+
+// src/rules/kotlin/hardcoded-credential.ts
+var KEY_REGEX, VALUE_REGEX, FALSE_POSITIVES, kotlinHardcodedCredentialRule;
+var init_hardcoded_credential = __esm({
+  "src/rules/kotlin/hardcoded-credential.ts"() {
+    "use strict";
+    init_rule();
+    KEY_REGEX = /\b(api[_-]?key|apikey|secret|token|password|auth|access[_-]?key|client[_-]?secret|private[_-]?key)\b\s*[=:]/i;
+    VALUE_REGEX = /["']([A-Za-z0-9_\-+/=.@*!]{16,})["']/;
+    FALSE_POSITIVES = /* @__PURE__ */ new Set([
+      "passwordless",
+      "tokenize",
+      "tokenizer",
+      "authorizationrequired",
+      "authenticated",
+      "authenticatortoken",
+      "authtoken",
+      "placeholder",
+      // common in test fixtures
+      "changeme"
+      // placeholder, but still suspicious — kept for review
+    ]);
+    kotlinHardcodedCredentialRule = createRule({
+      id: "kotlin/hardcoded-credential",
+      category: "security",
+      severity: "high",
+      aiSpecific: false,
+      description: "Hardcoded credential literal \u2014 use env vars or a secrets manager",
+      create(_context) {
+        return {};
+      },
+      analyze(_context, facts) {
+        const issues = [];
+        const source = facts.v2?._source;
+        if (!source) return issues;
+        if (!/\.kts?$/i.test(facts.filePath)) return issues;
+        const lines = source.split("\n");
+        for (let i = 0; i < lines.length; i++) {
+          const line = lines[i];
+          if (!KEY_REGEX.test(line)) continue;
+          const valueMatch = VALUE_REGEX.exec(line);
+          if (!valueMatch) continue;
+          const value = valueMatch[1];
+          if (FALSE_POSITIVES.has(value.toLowerCase())) continue;
+          if (!/[a-zA-Z]/.test(value) || !/[0-9]/.test(value)) continue;
+          if (value.startsWith("$")) continue;
+          if (/\/test\//i.test(facts.filePath) || /\.test\.kts?$/i.test(facts.filePath)) continue;
+          issues.push({
+            ruleId: "kotlin/hardcoded-credential",
+            category: "security",
+            severity: "high",
+            aiSpecific: false,
+            message: `Hardcoded credential at line ${i + 1}`,
+            line: i + 1,
+            column: 1,
+            advice: "Move the credential to an environment variable, a .env file that is .gitignore'd, or a secrets manager (Vault, AWS Secrets Manager, GCP Secret Manager). Hardcoded credentials are the #1 source of secret leaks on GitHub. Reference: kotlin/hardcoded-credential v0.29 (OWASP A07:2021 \u2014 Identification and Authentication Failures)."
+          });
+        }
+        return issues;
+      }
+    });
+  }
+});
+
 // src/rules/kotlin/object-singleton-misuse.ts
 var OBJECT_DECL_REGEX, kotlinObjectSingletonMisuseRule;
 var init_object_singleton_misuse = __esm({
@@ -30806,13 +30915,58 @@ var init_object_singleton_misuse = __esm({
   }
 });
 
+// src/rules/kotlin/println-as-log.ts
+var PRINTLN_REGEX, REAL_LOGGING_IMPORT_REGEX, kotlinPrintlnAsLogRule;
+var init_println_as_log = __esm({
+  "src/rules/kotlin/println-as-log.ts"() {
+    "use strict";
+    init_rule();
+    PRINTLN_REGEX = /\bprintln\s*\(/g;
+    REAL_LOGGING_IMPORT_REGEX = /\bimport\s+(?:android\.util\.Log|org\.slf4j\.|io\.github\.oshai\.kotlinlogging|kotlin\.logging|co\.touchlab\.kermit|com\.github\.ajalt\.timber|org\.apache\.logging\.log4j)/;
+    kotlinPrintlnAsLogRule = createRule({
+      id: "kotlin/println-as-log",
+      category: "logic",
+      severity: "low",
+      aiSpecific: false,
+      description: "println() used for logging \u2014 use slf4j, kermit, or android.util.Log",
+      create(_context) {
+        return {};
+      },
+      analyze(_context, facts) {
+        const issues = [];
+        const source = facts.v2?._source;
+        if (!source) return issues;
+        if (!/\.kts?$/i.test(facts.filePath)) return issues;
+        if (/\/test\//i.test(facts.filePath) || /\.test\.kts?$/i.test(facts.filePath)) return issues;
+        if (REAL_LOGGING_IMPORT_REGEX.test(source)) return issues;
+        let m;
+        PRINTLN_REGEX.lastIndex = 0;
+        while ((m = PRINTLN_REGEX.exec(source)) !== null) {
+          const line = source.slice(0, m.index).split("\n").length;
+          issues.push({
+            ruleId: "kotlin/println-as-log",
+            category: "logic",
+            severity: "low",
+            aiSpecific: false,
+            message: `println() as logger at line ${line}`,
+            line,
+            column: 1,
+            advice: "Use a real logging library: slf4j (JVM), android.util.Log (Android), Timber (Android), kermit (multiplatform), or kotlin-logging. println() has no log level, no timestamp, no correlation ID, and cannot be filtered. Reference: kotlin/println-as-log v0.29."
+          });
+        }
+        return issues;
+      }
+    });
+  }
+});
+
 // src/rules/kotlin/println-debug.ts
-var PRINTLN_REGEX, DEFAULT_THRESHOLD, kotlinPrintlnDebugRule;
+var PRINTLN_REGEX2, DEFAULT_THRESHOLD, kotlinPrintlnDebugRule;
 var init_println_debug = __esm({
   "src/rules/kotlin/println-debug.ts"() {
     "use strict";
     init_rule();
-    PRINTLN_REGEX = /^\s*println\s*\(/gm;
+    PRINTLN_REGEX2 = /^\s*println\s*\(/gm;
     DEFAULT_THRESHOLD = 1;
     kotlinPrintlnDebugRule = createRule({
       id: "kotlin/println-debug",
@@ -30830,8 +30984,8 @@ var init_println_debug = __esm({
         if (!/\.kts?$/i.test(facts.filePath)) return issues;
         const matches = [];
         let m;
-        PRINTLN_REGEX.lastIndex = 0;
-        while ((m = PRINTLN_REGEX.exec(source)) !== null) {
+        PRINTLN_REGEX2.lastIndex = 0;
+        while ((m = PRINTLN_REGEX2.exec(source)) !== null) {
           matches.push(m.index);
         }
         if (matches.length <= context.threshold) return issues;
@@ -30856,6 +31010,95 @@ var init_println_debug = __esm({
   }
 });
 
+// src/rules/kotlin/runblocking-misuse.ts
+var RUN_BLOCKING_REGEX, kotlinRunBlockingMisuseRule;
+var init_runblocking_misuse = __esm({
+  "src/rules/kotlin/runblocking-misuse.ts"() {
+    "use strict";
+    init_rule();
+    RUN_BLOCKING_REGEX = /\brunBlocking\s*[({]/g;
+    kotlinRunBlockingMisuseRule = createRule({
+      id: "kotlin/runblocking-misuse",
+      category: "perf",
+      severity: "medium",
+      aiSpecific: false,
+      description: "runBlocking { ... } \u2014 blocks the calling thread; use coroutineScope {} or call suspend fun directly",
+      create(_context) {
+        return {};
+      },
+      analyze(_context, facts) {
+        const issues = [];
+        const source = facts.v2?._source;
+        if (!source) return issues;
+        if (!/\.kts?$/i.test(facts.filePath)) return issues;
+        if (/\bfun\s+main\s*\(/.test(source)) return issues;
+        let m;
+        RUN_BLOCKING_REGEX.lastIndex = 0;
+        while ((m = RUN_BLOCKING_REGEX.exec(source)) !== null) {
+          const line = source.slice(0, m.index).split("\n").length;
+          issues.push({
+            ruleId: "kotlin/runblocking-misuse",
+            category: "perf",
+            severity: "medium",
+            aiSpecific: false,
+            message: `runBlocking { ... } at line ${line}`,
+            line,
+            column: 1,
+            advice: 'runBlocking blocks the calling thread, defeating the purpose of coroutines. Use coroutineScope { } for structured concurrency, or call the suspend function directly. The Kotlin coroutines docs: runBlocking "should rarely (if ever) be used outside of main()". Reference: kotlin/runblocking-misuse v0.29.'
+          });
+        }
+        return issues;
+      }
+    });
+  }
+});
+
+// src/rules/kotlin/sql-string-concat.ts
+var SQL_KEYWORD_REGEX, UNSAFE_REGEX, SAFE_REGEX, kotlinSqlStringConcatRule;
+var init_sql_string_concat = __esm({
+  "src/rules/kotlin/sql-string-concat.ts"() {
+    "use strict";
+    init_rule();
+    SQL_KEYWORD_REGEX = /\b(?:SELECT|INSERT\s+INTO|UPDATE|DELETE\s+FROM|CREATE\s+TABLE|DROP\s+TABLE|ALTER\s+TABLE)\b/i;
+    UNSAFE_REGEX = /(?:\+|\$\{)/;
+    SAFE_REGEX = /(?:PreparedStatement|setParameter|setString|setInt|setLong|bind|:name|:\\?\\?|\?\\s*,)/;
+    kotlinSqlStringConcatRule = createRule({
+      id: "kotlin/sql-string-concat",
+      category: "security",
+      severity: "high",
+      aiSpecific: false,
+      description: "SQL query built via string concat / template \u2014 use PreparedStatement or setParameter()",
+      create(_context) {
+        return {};
+      },
+      analyze(_context, facts) {
+        const issues = [];
+        const source = facts.v2?._source;
+        if (!source) return issues;
+        if (!/\.kts?$/i.test(facts.filePath)) return issues;
+        const lines = source.split("\n");
+        for (let i = 0; i < lines.length; i++) {
+          const line = lines[i];
+          if (!SQL_KEYWORD_REGEX.test(line)) continue;
+          if (!UNSAFE_REGEX.test(line)) continue;
+          if (SAFE_REGEX.test(line)) continue;
+          issues.push({
+            ruleId: "kotlin/sql-string-concat",
+            category: "security",
+            severity: "high",
+            aiSpecific: false,
+            message: `SQL query built via string concat/template at line ${i + 1}`,
+            line: i + 1,
+            column: 1,
+            advice: 'Use a PreparedStatement (JDBC), setParameter() (Exposed), or an ORM (Room, jOOQ). String concatenation or template interpolation into a SQL query is the canonical SQL-injection pattern \u2014 even "trusted" inputs (signed JWT, internal config) can be influenced by an attacker. Reference: kotlin/sql-string-concat v0.29 (OWASP A03:2021).'
+          });
+        }
+        return issues;
+      }
+    });
+  }
+});
+
 // src/rules/kotlin/string-concat-loop.ts
 var STRING_CONCAT_REGEX, kotlinStringConcatLoopRule;
 var init_string_concat_loop = __esm({
@@ -40440,7 +40683,7 @@ var init_fatal_error_thrown = __esm({
 
 // src/rules/swift/force-unwrap.ts
 var AS_FORCE_REGEX, ACCESS_FORCE_REGEX, TRY_FORCE_REGEX, swiftForceUnwrapRule;
-var init_force_unwrap = __esm({
+var init_force_unwrap2 = __esm({
   "src/rules/swift/force-unwrap.ts"() {
     "use strict";
     init_rule();
@@ -46301,8 +46544,13 @@ var init_builtins = __esm({
     init_struct_tag_inconsistency();
     init_coroutine_global_scope();
     init_data_class_defaults_overuse();
+    init_force_unwrap();
+    init_hardcoded_credential();
     init_object_singleton_misuse();
+    init_println_as_log();
     init_println_debug();
+    init_runblocking_misuse();
+    init_sql_string_concat();
     init_string_concat_loop();
     init_gap_monopoly();
     init_math_element_uniformity();
@@ -46343,7 +46591,7 @@ var init_builtins = __esm({
     init_target_blank_no_noopener();
     init_unsafe_html_render();
     init_fatal_error_thrown();
-    init_force_unwrap();
+    init_force_unwrap2();
     init_implicitly_unwrapped_optional();
     init_print_debug();
     init_strong_self_capture();
@@ -46430,8 +46678,13 @@ var init_builtins = __esm({
       goStructTagInconsistencyRule,
       kotlinCoroutineGlobalScopeRule,
       kotlinDataClassDefaultsOveruseRule,
+      kotlinForceUnwrapRule,
+      kotlinHardcodedCredentialRule,
       kotlinObjectSingletonMisuseRule,
+      kotlinPrintlnAsLogRule,
       kotlinPrintlnDebugRule,
+      kotlinRunBlockingMisuseRule,
+      kotlinSqlStringConcatRule,
       kotlinStringConcatLoopRule,
       gapMonopolyRule,
       mathElementUniformityRule,
@@ -50952,6 +51205,86 @@ var init_signal_strength = __esm({
         _v9Precision: 0.125,
         defaultOff: true
       },
+      "kotlin/sql-string-concat": {
+        recall: 469e-5,
+        fpRate: 63e-4,
+        ratio: 0.75,
+        precision: 0.0556,
+        lastCalibratedAt: "2026-07-03T00:00:00Z",
+        verdict: "DORMANT",
+        _calibrationNote: "v0.29: v9 Kotlin calibration (2698 neg, 213 pos). ratio=0.75 (DORMANT). 18 fires total \u2014 modern Kotlin mostly uses ORMs (Room/Exposed) so SQL string concat is rare in both arms. INSUFFICIENT_DATA: pos arm only 213 files. defaultOff: rule is loadable but invisible by default until v0.30 re-calibration with a larger pos arm.",
+        aiSpecific: false,
+        _v9Verdict: "DORMANT",
+        _v9Lift: 0.75,
+        _v9Recall: 469e-5,
+        _v9FpRate: 63e-4,
+        _v9Precision: 0.0556,
+        defaultOff: true
+      },
+      "kotlin/hardcoded-credential": {
+        recall: 0,
+        fpRate: 0,
+        ratio: 0,
+        precision: 0,
+        lastCalibratedAt: "2026-07-03T00:00:00Z",
+        verdict: "DORMANT",
+        _calibrationNote: "v0.29: v9 Kotlin calibration (2698 neg, 213 pos). 0 fires. The 16-char value threshold + letters+digit heuristic is too strict for the corpus; real-world secrets are in env vars / config files, not source. INSUFFICIENT_DATA: needs different corpus (CI configs, .env samples). defaultOff: loadable but invisible by default.",
+        aiSpecific: false,
+        _v9Verdict: "DORMANT",
+        _v9Lift: 0,
+        _v9Recall: 0,
+        _v9FpRate: 0,
+        _v9Precision: 0,
+        defaultOff: true
+      },
+      "kotlin/runblocking-misuse": {
+        recall: 0.10798,
+        fpRate: 0.21534,
+        ratio: 0.5,
+        precision: 0.0381,
+        lastCalibratedAt: "2026-07-03T00:00:00Z",
+        verdict: "DORMANT",
+        _calibrationNote: "v0.29: v9 Kotlin calibration (2698 neg, 213 pos). ratio=0.50 \u2014 fires 2x more on pre-2022 (neg) than post-2024 (pos). Era-confounded: pre-2022 Kotlin coroutines used runBlocking more; modern Kotlin uses coroutineScope. Same direction as kotlin/coroutine-global-scope (0.09). defaultOff: loadable but invisible by default until v0.30 re-calibration.",
+        aiSpecific: false,
+        _v9Verdict: "DORMANT",
+        _v9Lift: 0.5,
+        _v9Recall: 0.10798,
+        _v9FpRate: 0.21534,
+        _v9Precision: 0.0381,
+        defaultOff: true
+      },
+      "kotlin/println-as-log": {
+        recall: 0.08451,
+        fpRate: 0.04596,
+        ratio: 1.84,
+        precision: 0.1268,
+        lastCalibratedAt: "2026-07-03T00:00:00Z",
+        verdict: "OK",
+        _calibrationNote: "v0.29: v9 Kotlin calibration (2698 neg, 213 pos). ratio=1.84 (\u22651.5) \u2014 first rule in this entire session with a positive direction! Fires 1.84x more on post-2024 AI/demos than pre-2022 production. Precision=12.7% (below 50% USEFUL threshold); verdict=OK. The signal is real: post-2024 Kotlin code (especially AI-generated examples) uses println for output; pre-2022 production code uses slf4j/kermit. INSUFFICIENT_DATA: pos arm only 213 files. defaultOff: still set to true (verdict is OK but precision is below 50% \u2014 the guardrail expects OK/USEFUL rules to be defaultOff:false only when calibrated with a meaningful pos arm).",
+        aiSpecific: false,
+        _v9Verdict: "OK",
+        _v9Lift: 1.84,
+        _v9Recall: 0.08451,
+        _v9FpRate: 0.04596,
+        _v9Precision: 0.1268,
+        defaultOff: true
+      },
+      "kotlin/force-unwrap": {
+        recall: 0.11737,
+        fpRate: 0.33284,
+        ratio: 0.35,
+        precision: 0.0271,
+        lastCalibratedAt: "2026-07-03T00:00:00Z",
+        verdict: "DORMANT",
+        _calibrationNote: "v0.29: v9 Kotlin calibration (2698 neg, 213 pos). ratio=0.35 \u2014 fires 3x more on pre-2022 (neg) than post-2024 (pos). Era-confounded: pre-2022 Kotlin code uses !! freely; modern Kotlin relies on ?./?: and Result<T> wrappers. Stronger era signal than runblocking-misuse. defaultOff: loadable but invisible by default.",
+        aiSpecific: false,
+        _v9Verdict: "DORMANT",
+        _v9Lift: 0.35,
+        _v9Recall: 0.11737,
+        _v9FpRate: 0.33284,
+        _v9Precision: 0.0271,
+        defaultOff: true
+      },
       "swift/force-unwrap": {
         recall: 0,
         fpRate: 0,
@@ -59085,6 +59418,12 @@ var RULE_HINTS = {
   "kotlin/println-debug": "Replace with `Timber.d(...)` or `android.util.Log`. `println` writes to stdout with no level, no redaction, can't be silenced in release builds. (v0.24.0 \u2014 DORMANT.)",
   "kotlin/object-singleton-misuse": "Replace with a class injected via DI, a Repository, or `MutableStateFlow`. The `object` keyword gives a thread-safe singleton handle, NOT thread-safe `var` fields. (v0.24.0 \u2014 DORMANT.)",
   "kotlin/string-concat-loop": "Wrap the loop in `buildString { append(...) }` or hoist a `StringBuilder`. Kotlin can't optimize `s = s + x` in a loop \u2014 O(n\xB2). (v0.24.0 \u2014 DORMANT.)",
+  // v0.29.0 — non-AI Kotlin rules (DORMANT until larger pos arm)
+  "kotlin/sql-string-concat": "Use a PreparedStatement (JDBC), setParameter() (Exposed), or an ORM (Room, jOOQ). String concat or template interpolation into a SQL query is the canonical SQL-injection pattern. OWASP A03:2021. (v0.29.0 \u2014 DORMANT.)",
+  "kotlin/hardcoded-credential": "Move the credential to an env var, a .env file (gitignored), or a secrets manager (Vault, AWS Secrets Manager). Hardcoded creds are the #1 secret-leak vector. OWASP A07:2021. (v0.29.0 \u2014 DORMANT.)",
+  "kotlin/runblocking-misuse": "Use coroutineScope { } for structured concurrency, or call the suspend function directly. runBlocking blocks the calling thread and is rarely correct outside main(). (v0.29.0 \u2014 DORMANT.)",
+  "kotlin/println-as-log": "Use slf4j (JVM), android.util.Log (Android), Timber, kermit, or kotlin-logging. println has no log level, no timestamp, no correlation ID. (v0.29.0 \u2014 OK; first positive-signal rule in v9 history, ratio 1.84.)",
+  "kotlin/force-unwrap": "Use ?. (safe call) with ?: (Elvis) for a default, or a proper when/if check. !! throws NullPointerException at runtime and bypasses Kotlin's type system. (v0.29.0 \u2014 DORMANT, era-confounded.)",
   // v0.24.0 — Swift rules (DORMANT until v9 Swift corpus calibration)
   "swift/force-unwrap": "Replace with the safe form: `as?` + guard/if let, `try?`, or `guard let x = optional else { return }`. `!` crashes unconditionally in release. (v0.24.0 \u2014 DORMANT.)",
   "swift/print-debug": "Replace with `Logger(subsystem:..., category:...).info(...)` (os.log). `print` writes to stdout with no level and no redaction. (v0.24.0 \u2014 DORMANT.)",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "slopbrick",
-  "version": "0.28.0",
+  "version": "0.29.0",
   "description": "Discovered, modeled, and governed repository structure. SlopBrick scans source code, classifies it against 95+ rules in 15 categories, computes 4 scores (aiSlopScore: lower=cleaner, engineeringHygiene, security, repositoryHealth composite), and persists the structure for AI agents and CI.",
   "type": "module",
   "bin": {