slidemind 0.3.17 → 0.3.18

package/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "slidemind",
-  "version": "0.3.17",
+  "version": "0.3.18",
   "description": "Connect Claude Code to the slidemind PowerPoint add-in — build and edit native, on-brand PowerPoint decks against the active corporate design, from the terminal.",
   "author": {
     "name": "statworx",

package/.codex-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "slidemind",
-  "version": "0.3.17",
+  "version": "0.3.18",
   "description": "Connect Codex to the slidemind PowerPoint add-in — build and edit native, on-brand PowerPoint decks against the active corporate design. Requires the slidemind CLI (npm install -g slidemind); the skills explain the install when it is missing.",
   "author": {
     "name": "statworx",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "slidemind",
-  "version": "0.3.17",
+  "version": "0.3.18",
   "description": "Connect Claude Code, Codex & opencode to the slidemind PowerPoint add-in — let your coding agent build and edit native, on-brand PowerPoint decks against your active corporate design, from the terminal.",
   "type": "module",
   "bin": {

package/src/builders/build.mjs

@@ -106,7 +106,7 @@ function convertedHostStubs(slideFiles, conversions) {
   return [...hosts].map(
     ([name, { w, h }]) =>
       `<script type="text/jsx-template" data-kind="layout" data-name="${name}" data-binding="${name}">\n` +
-      `function ${name}({ background, children }) { return <div style={{ position: "relative", width: "${w}", height: "${h}", overflow: "hidden", background: background || "#FFFFFF" }}>{children}</div>; }\n` +
+      `export default function ${name}({ background, children }) { return <div style={{ position: "relative", width: "${w}", height: "${h}", overflow: "hidden", background: background || "#FFFFFF" }}>{children}</div>; }\n` +
       `</script>`,
   );
 }

package/src/lib/adopt.mjs

@@ -30,7 +30,14 @@ import { decodeSourceTags, mintSlideGuid, readSlideTags } from "../pptx/tags.mjs
 import { foldPickedSlides } from "../pptx/slide-swap.mjs";
 import { readDeckBundleRef, writeDeckBundleRef } from "../bridge/bundle.mjs";
 import { loadSlideGuids, saveSlideGuids, slideGuidEntry } from "./slide-guids.mjs";
-import { hasSourcedChart, writeConversionRecord } from "./conversions.mjs";
+import { writeConversionRecord } from "./conversions.mjs";
+
+// Converted JSX needs a fresh baseline against the imported PPTX. Source tags
+// alone cannot recover the original conversion evidence or preserved natives.
+export function needsConversion(decoded) {
+  return !decoded || /<ConvertedHost\d+x\d+\b/.test(decoded.jsx) ||
+    /^\s*\/\/\s*SLIDEMIND_DIALECT:\s*converted\b/m.test(decoded.jsx);
+}
 
 export const LIVE_DECK_UNSUPPORTED =
   "conversion of live presentations requires the add-in path in v1 — " +
@@ -174,21 +181,13 @@ export function adoptDeckFromPptx({ pptxPath, deckDir, converted = null, source
   const native = [];
   let bundle = null;
 
-  // Fold in ONE pass: foldPickedSlides unzips and prunes the whole source
-  // package per call, so folding slide by slide redid that work for the entire
-  // deck on every native slide. Three kinds of pick share the pass — a slide
-  // that stays native, a CONVERTED slide whose preserved natives (OLE /
-  // SmartArt / unsupported chart kinds) need their verbatim source package kept
-  // for the render-time splice (design D4/D6), and a converted slide carrying
-  // the deck's own chart as `<Chart data-sm-source-id>`, which the render
-  // patches against that same package (native-charts 5.4a).
+  // Fold every converted slide in one pass. The package supplies preserved
+  // natives AND the original envelope (layouts, passive third-party tags,
+  // relationships). Tagged converted JSX alone cannot restore either safely.
   const picks = [];
   decodedByIndex.forEach((decoded, index) => {
-    if (decoded) return;
-    const conv = convertedSlides.get(index + 1);
-    if (!conv || conv.preserved?.length > 0 || hasSourcedChart(conv.jsx)) {
-      picks.push(index + 1);
-    }
+    if (!needsConversion(decoded)) return;
+    picks.push(index + 1);
   });
   const foldByPick = new Map(
     (picks.length
@@ -229,7 +228,7 @@ export function adoptDeckFromPptx({ pptxPath, deckDir, converted = null, source
   }
 
   decodedByIndex.forEach((decoded, index) => {
-    if (decoded) {
+    if (decoded && !needsConversion(decoded)) {
       const stem = stemFor(decoded.meta.name, index, taken);
       let jsx = decoded.jsx;
       for (const asset of decoded.assets) {
@@ -251,11 +250,14 @@ export function adoptDeckFromPptx({ pptxPath, deckDir, converted = null, source
     if (conv) {
       // Deterministically converted: editable jsx in the converted dialect,
       // plus the identity/evidence record push threads back to the server.
-      const stem = stemFor(conv.name ?? `${pad2(index + 1)}-converted`, index, taken);
+      const stem = stemFor(decoded?.meta.name ?? conv.name ?? `${pad2(index + 1)}-converted`, index, taken);
       let jsx = conv.jsx;
       for (const [from, to] of convAssetRenames) jsx = jsx.split(from).join(to);
       fs.writeFileSync(path.join(slidesDir, `${stem}.jsx`), jsx, "utf8");
-      const guid = conv.guid && !seenGuids.has(conv.guid) ? conv.guid : mintSlideGuid();
+      const candidateGuid = decoded?.guid ?? conv.guid;
+      const owns = !decoded || ownerIndexByGuid.get(decoded.guid)?.index === index;
+      const guid = owns && candidateGuid && !seenGuids.has(candidateGuid)
+        ? candidateGuid : mintSlideGuid();
       seenGuids.add(guid);
       guids[`slides/${stem}.jsx`] = slideGuidEntry(guid, jsx);
       writeConversionRecord(
@@ -277,6 +279,7 @@ export function adoptDeckFromPptx({ pptxPath, deckDir, converted = null, source
         },
         fold?.bytes ?? null,
       );
+      bundle ??= decoded?.meta.bundle ?? null;
       convertedFiles.push(`${stem}.jsx`);
       return;
     }
@@ -329,7 +332,10 @@ export function adoptDeckFromPptx({ pptxPath, deckDir, converted = null, source
 }
 
 /**
- * Deterministically convert a FILE deck's untagged slides through the add-in's
+ * Convert foreign slides and re-convert embedded converted slides against the
+ * CURRENT imported PPTX. This recovers a fresh baseline/evidence pair without
+ * pretending the original conversion was reviewed. Ordinary authored JSX is
+ * restored verbatim. Requests go through the add-in's
  * `POST /api/cli/brands/:brandId/convert-pptx` route. Returns the route result
  * (`{ slides, assets, skipped, warnings }` + the `brandId` it ran against) to
  * hand to {@link adoptDeckFromPptx}, or null when conversion is not available
@@ -349,7 +355,7 @@ export async function convertUntaggedSlides({
   const { buffer, decodedByIndex } = source ?? readSourceDeck(pptxPath);
   const slides = [];
   decodedByIndex.forEach((decoded, i) => {
-    if (!decoded) slides.push(i + 1);
+    if (needsConversion(decoded)) slides.push(i + 1);
   });
   if (slides.length === 0) return null;
 
@@ -372,7 +378,7 @@ export async function convertUntaggedSlides({
     if (brands.length !== 1) {
       note(
         brands.length === 0
-          ? "no corporate design available to convert against — untagged slides stay native"
+          ? "no corporate design available to convert against — slides requiring conversion stay native"
           : "several corporate designs available — pass `--brand <presFP>` to convert the untagged slides",
       );
       return null;
@@ -383,7 +389,7 @@ export async function convertUntaggedSlides({
     // capability probe — do it here, so a whole .pptx is never shipped to a
     // backend that will just 404 the route.
     if (backendURL && !(await client.backendSupportsConvertPptx(backendURL))) {
-      note("this add-in does not convert foreign slides — untagged slides stay native");
+      note("this add-in does not convert foreign slides — slides requiring conversion stay native");
       return null;
     }
   }
@@ -396,15 +402,15 @@ export async function convertUntaggedSlides({
       backendURL,
     });
     if (result?.ok === false) {
-      note("the add-in declined to convert this file — untagged slides stay native");
+      note("the add-in declined to convert this file — slides requiring conversion stay native");
       return null;
     }
     return { ...result, brandId: resolved };
   } catch (err) {
     note(
       err?.code === "convert_route_unavailable"
-        ? "this add-in does not convert foreign slides — untagged slides stay native"
-        : `slide conversion unavailable (${err?.message ?? err}) — untagged slides stay native`,
+        ? "this add-in does not convert foreign slides — slides requiring conversion stay native"
+        : `slide conversion unavailable (${err?.message ?? err}) — slides requiring conversion stay native`,
     );
     return null;
   }

package/src/pptx/app-props.mjs

@@ -20,7 +20,6 @@ import { unzip, zip, readText } from "./zip.mjs";
 import { slideOrderPaths, decodeXmlEntities } from "./ooxml.mjs";
 import { slideText } from "./read-local.mjs";
 import { stripHiddenOleGraphicFrames } from "./hidden-ole.mjs";
-import { stripRiskyImageExtensions } from "./image-extensions.mjs";
 
 const APP_PROPS = "docProps/app.xml";
 
@@ -61,9 +60,6 @@ export function normalizePptxAppProperties(buffer) {
   if (stripHiddenOleGraphicFrames(entries)) {
     changed = true;
   }
-  if (stripRiskyImageExtensions(entries)) {
-    changed = true;
-  }
 
   return {
     bytes: changed ? zip(entries) : buffer,

package/src/pptx/slide-swap.mjs

@@ -30,7 +30,6 @@ import {
   resolvePartPath,
 } from "./ooxml.mjs";
 import { stripHiddenOleGraphicFrames } from "./hidden-ole.mjs";
-import { stripRiskyImageExtensions } from "./image-extensions.mjs";
 import {
   slideHasForeignTags,
   slideReferencesEmbeddedWorkbook,
@@ -112,7 +111,6 @@ export function foldPickedSlides(buffer, picks, { sourceName = "reused" } = {})
           part === lowest ? picked : part === picked ? lowest : part,
         ) ?? false,
     });
-    const riskyImagesStripped = stripRiskyImageExtensions(copy);
 
     // Prune to the lowest slide's dependency closure + trimmed skeleton.
     const { entries: pruned, changed } = pruneToLowest(copy);
@@ -123,7 +121,6 @@ export function foldPickedSlides(buffer, picks, { sourceName = "reused" } = {})
       !swapped &&
       !notesStripped &&
       !hiddenOleStripped &&
-      !riskyImagesStripped &&
       !changed
     ) {
       return { selection: n, slideId, bytes: buffer };

package/src/pptx/image-extensions.mjs

@@ -1,190 +0,0 @@
-import { readText } from "./zip.mjs";
-import { relsFor, relsPathFor, resolvePartPath } from "./ooxml.mjs";
-
-const CONTENT_TYPES = "[Content_Types].xml";
-
-export function stripRiskyImageExtensions(files) {
-  let changed = false;
-  const removedTargets = new Set();
-  const candidates = Object.keys(files).filter((part) =>
-    /^ppt\/(?:slides|slideMasters|slideLayouts)\/[^/]+\.xml$/.test(part),
-  );
-
-  for (const part of candidates) {
-    const before = readText(files, part);
-    if (!before) continue;
-
-    const removedIds = new Set();
-    const relsById = new Map(relsFor(files, part).map((rel) => [rel.id, rel]));
-    const partDir = part.includes("/") ? part.slice(0, part.lastIndexOf("/")) : "";
-    let after = before.replace(
-      /<a:ext\b[\s\S]*?<\/a:ext>/g,
-      (ext) => {
-        if (!/<(?:asvg:svgBlip|a14:imgLayer)\b/.test(ext)) return ext;
-        for (const id of relationshipIdsIn(ext)) removedIds.add(id);
-        return "";
-      },
-    );
-    after = after.replace(/<a:extLst\b[^>]*>\s*<\/a:extLst>/g, "");
-    after = after.replace(
-      /<p:pic\b[\s\S]*?<\/p:pic>/g,
-      (pic) => {
-        if (!/<a:blip\b(?![^>]*\br:(?:embed|link)=)[^>]*>\s*<\/a:blip>/.test(pic)) {
-          return pic;
-        }
-        for (const id of relationshipIdsIn(pic)) removedIds.add(id);
-        return "";
-      },
-    );
-    after = after.replace(
-      /<p:pic\b[\s\S]*?<\/p:pic>/g,
-      (pic) => {
-        for (const id of relationshipIdsIn(pic)) {
-          const rel = relsById.get(id);
-          if (
-            rel &&
-            rel.targetMode !== "External" &&
-            /\.svg(?:$|[?#])/i.test(rel.target ?? "")
-          ) {
-            removedIds.add(id);
-            return "";
-          }
-        }
-        return pic;
-      },
-    );
-    const relsPath = relsPathFor(part);
-    const relsXml = readText(files, relsPath);
-    const remainingIds = relationshipIdsIn(after);
-    if (relsXml) {
-      for (const rel of relsById.values()) {
-        if (
-          rel.targetMode !== "External" &&
-          !remainingIds.has(rel.id) &&
-          /\.(?:svg|wdp)(?:$|[?#])/i.test(rel.target ?? "")
-        ) {
-          removedIds.add(rel.id);
-        }
-      }
-    }
-
-    if (after === before && removedIds.size === 0) continue;
-
-    if (after !== before) {
-      files[part] = new TextEncoder().encode(after);
-      changed = true;
-    }
-    if (!relsXml) continue;
-
-    let nextRels = relsXml;
-    for (const id of removedIds) {
-      if (remainingIds.has(id)) continue;
-      nextRels = removeRelationshipById(nextRels, id);
-      const rel = relsById.get(id);
-      if (rel && rel.targetMode !== "External") {
-        removedTargets.add(resolvePartPath(partDir, rel.target));
-      }
-    }
-    if (nextRels !== relsXml) {
-      files[relsPath] = new TextEncoder().encode(nextRels);
-    }
-  }
-
-  const deleted = deleteUnreferencedTargets(files, removedTargets);
-  if (deleted.size > 0) {
-    removeContentTypeOverrides(files, deleted);
-    changed = true;
-  }
-  if (removeUnusedMediaDefaults(files, ["svg", "wdp"])) {
-    changed = true;
-  }
-
-  return changed;
-}
-
-function deleteUnreferencedTargets(files, removedTargets) {
-  const remainingRefs = referencedInternalTargets(files);
-  const deleted = new Set();
-  for (const part of removedTargets) {
-    if (!part || remainingRefs.has(part) || files[part] === undefined) continue;
-    delete files[part];
-    const sidecar = relsPathFor(part);
-    if (files[sidecar] !== undefined) delete files[sidecar];
-    deleted.add(part);
-  }
-  return deleted;
-}
-
-function referencedInternalTargets(files) {
-  const refs = new Set();
-  for (const relsPath of Object.keys(files)) {
-    if (!relsPath.endsWith(".rels")) continue;
-    const dir = relsPath.replace(/\/?_rels\/[^/]+$/, "");
-    const owner =
-      dir === ""
-        ? relsPath.replace(/^_rels\/(.*)\.rels$/, "$1")
-        : `${dir}/${relsPath.replace(/^.*_rels\/(.*)\.rels$/, "$1")}`;
-    for (const rel of relsFor(files, owner)) {
-      if (rel.targetMode === "External") continue;
-      refs.add(resolvePartPath(dir, rel.target));
-    }
-  }
-  return refs;
-}
-
-function removeContentTypeOverrides(files, deletedParts) {
-  const before = readText(files, CONTENT_TYPES);
-  if (!before) return;
-  let after = before;
-  for (const part of deletedParts) {
-    after = after.replace(
-      new RegExp(
-        `<Override\\b(?=[^>]*\\bPartName="/${escapeRe(part)}")[^>]*?/>`,
-        "g",
-      ),
-      "",
-    );
-  }
-  if (after !== before) files[CONTENT_TYPES] = new TextEncoder().encode(after);
-}
-
-function removeUnusedMediaDefaults(files, exts) {
-  const before = readText(files, CONTENT_TYPES);
-  if (!before) return false;
-  let after = before;
-  for (const ext of exts) {
-    const hasPart = Object.keys(files).some((part) =>
-      part.toLowerCase().endsWith(`.${ext}`),
-    );
-    if (hasPart) continue;
-    after = after.replace(
-      new RegExp(`<Default\\b(?=[^>]*\\bExtension="${escapeRe(ext)}")[^>]*?/>`, "g"),
-      "",
-    );
-  }
-  if (after !== before) {
-    files[CONTENT_TYPES] = new TextEncoder().encode(after);
-    return true;
-  }
-  return false;
-}
-
-function relationshipIdsIn(xml) {
-  const ids = new Set();
-  for (const m of String(xml).matchAll(/\br:(?:id|embed|link)\s*=\s*"([^"]+)"/g)) {
-    ids.add(m[1]);
-  }
-  return ids;
-}
-
-function removeRelationshipById(xml, id) {
-  return xml.replace(
-    new RegExp(
-      `<Relationship\\b(?=[^>]*\\bId="${escapeRe(id)}")[^>]*?(?:/>|>[\\s\\S]*?</Relationship>)`,
-      "g",
-    ),
-    "",
-  );
-}
-
-const escapeRe = (s) => s.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");