slidemind 0.2.4 → 0.3.0

package/src/pptx/hidden-ole.mjs

@@ -1,9 +1,10 @@
 import { readText } from "./zip.mjs";
 import { relsFor, relsPathFor, resolvePartPath } from "./ooxml.mjs";
+import { slideHasForeignTags, slideReferencesEmbeddedWorkbook } from "./tags.mjs";
 
 const CONTENT_TYPES = "[Content_Types].xml";
 
-export function stripHiddenOleGraphicFrames(files) {
+export function stripHiddenOleGraphicFrames(files, { keepSlideOle = null } = {}) {
   let changed = false;
   const removedTargets = new Set();
   const candidates = Object.keys(files).filter((part) =>
@@ -14,6 +15,26 @@ export function stripHiddenOleGraphicFrames(files) {
     const before = readText(files, part);
     if (!before) continue;
 
+    // Coexistence rule C4 (intern-slidemind docs/deck-embedded-source-spec.md
+    // §13): a SLIDE that carries another add-in's state — foreign tags or an
+    // embedded workbook/OLE part (think-cell "slide workbook" pattern) — keeps
+    // its hidden OLE frames untouched; stripping them would destroy that
+    // add-in's data. Slidemind's own rendered/template output never has
+    // foreign tags, so the strip stays fully active there. Masters/layouts
+    // (template chain) keep the old behavior. The verdict is constant per
+    // slide CONTENT, so a caller running the strip once per pick over the
+    // same package (foldPickedSlides) precomputes it and passes `keepSlideOle`
+    // instead of paying the rels + tag-part parse again on every pick.
+    if (
+      part.startsWith("ppt/slides/") &&
+      (keepSlideOle
+        ? keepSlideOle(part)
+        : slideHasForeignTags(files, part) ||
+          slideReferencesEmbeddedWorkbook(files, part))
+    ) {
+      continue;
+    }
+
     const removedIds = new Set();
     const after = before.replace(
       /<p:graphicFrame\b[\s\S]*?<\/p:graphicFrame>/g,

package/src/pptx/slide-swap.mjs

@@ -31,6 +31,10 @@ import {
 } from "./ooxml.mjs";
 import { stripHiddenOleGraphicFrames } from "./hidden-ole.mjs";
 import { stripRiskyImageExtensions } from "./image-extensions.mjs";
+import {
+  slideHasForeignTags,
+  slideReferencesEmbeddedWorkbook,
+} from "./tags.mjs";
 
 // The four package parts we always keep and rewrite for standalone validity.
 const SKELETON = [
@@ -63,6 +67,19 @@ export function foldPickedSlides(buffer, picks, { sourceName = "reused" } = {})
   const lowest = firstSlidePath(files);
   const lowestRels = relsPathFor(lowest);
 
+  // The C4 keep-OLE verdict (foreign tags / embedded workbook) is per slide
+  // CONTENT and constant across picks — computed inside the strip it re-parsed
+  // every slide's rels and tag parts once per pick, O(picks × slides) on a big
+  // adopt. One pass here; the per-pick lookup follows the slide swap below
+  // (the lowest slot holds the picked slide's content).
+  const keepOleByPart = new Map(
+    order.map((part) => [
+      part,
+      slideHasForeignTags(files, part) ||
+        slideReferencesEmbeddedWorkbook(files, part),
+    ]),
+  );
+
   return picks.map((n) => {
     const picked = order[n - 1];
     const sldId = entries[n - 1] ? entries[n - 1].sldId : null;
@@ -89,7 +106,12 @@ export function foldPickedSlides(buffer, picks, { sourceName = "reused" } = {})
       copy[lowestRels] = stripNotesRel(copy[lowestRels]);
       notesStripped = true;
     }
-    const hiddenOleStripped = stripHiddenOleGraphicFrames(copy);
+    const hiddenOleStripped = stripHiddenOleGraphicFrames(copy, {
+      keepSlideOle: (part) =>
+        keepOleByPart.get(
+          part === lowest ? picked : part === picked ? lowest : part,
+        ) ?? false,
+    });
     const riskyImagesStripped = stripRiskyImageExtensions(copy);
 
     // Prune to the lowest slide's dependency closure + trimmed skeleton.