slicejs-cli 2.9.5 → 3.0.2

package/tests/client-update-flow-contract.test.js

@@ -0,0 +1,272 @@
+import { test } from 'node:test';
+import assert from 'node:assert/strict';
+import fs from 'node:fs';
+import path from 'node:path';
+import { fileURLToPath } from 'node:url';
+import { parse } from '@babel/parser';
+
+const __dirname = path.dirname(fileURLToPath(import.meta.url));
+const clientPath = path.join(__dirname, '..', 'client.js');
+const clientSource = fs.readFileSync(clientPath, 'utf-8');
+const ast = parse(clientSource, {
+  sourceType: 'module',
+  errorRecovery: true,
+  loc: true,
+  ranges: true
+});
+
+function lineOf(node) {
+  return node && node.loc && node.loc.start ? node.loc.start.line : null;
+}
+
+function walk(node, visit) {
+  if (!node || typeof node !== 'object') {
+    return;
+  }
+
+  visit(node);
+
+  for (const value of Object.values(node)) {
+    if (Array.isArray(value)) {
+      for (const item of value) {
+        walk(item, visit);
+      }
+      continue;
+    }
+
+    walk(value, visit);
+  }
+}
+
+function isMethodCall(node, methodName) {
+  return (
+    node &&
+    node.type === 'CallExpression' &&
+    node.callee &&
+    node.callee.type === 'MemberExpression' &&
+    node.callee.property &&
+    node.callee.property.type === 'Identifier' &&
+    node.callee.property.name === methodName
+  );
+}
+
+function isCommandUpdateExpression(node) {
+  if (!node || node.type !== 'CallExpression') {
+    return false;
+  }
+
+  if (
+    node.callee &&
+    node.callee.type === 'MemberExpression' &&
+    node.callee.property &&
+    node.callee.property.type === 'Identifier' &&
+    node.callee.property.name === 'command' &&
+    node.arguments[0] &&
+    node.arguments[0].type === 'StringLiteral' &&
+    node.arguments[0].value === 'update'
+  ) {
+    return true;
+  }
+
+  if (node.callee && node.callee.type === 'MemberExpression') {
+    return isCommandUpdateExpression(node.callee.object);
+  }
+
+  return false;
+}
+
+function getRunWithVersionCheckNode() {
+  let foundNode = null;
+
+  walk(ast, (node) => {
+    if (
+      node.type === 'FunctionDeclaration' &&
+      node.id &&
+      node.id.type === 'Identifier' &&
+      node.id.name === 'runWithVersionCheck'
+    ) {
+      foundNode = node;
+      return;
+    }
+
+    if (node.type !== 'VariableDeclarator') {
+      return;
+    }
+
+    if (!node.id || node.id.type !== 'Identifier' || node.id.name !== 'runWithVersionCheck') {
+      return;
+    }
+
+    if (
+      node.init &&
+      (node.init.type === 'ArrowFunctionExpression' || node.init.type === 'FunctionExpression')
+    ) {
+      foundNode = node.init;
+    }
+  });
+
+  return foundNode;
+}
+
+function getFunctionBodyNode(fnNode) {
+  if (!fnNode) {
+    return null;
+  }
+
+  if (fnNode.type === 'FunctionDeclaration' || fnNode.type === 'FunctionExpression' || fnNode.type === 'ArrowFunctionExpression') {
+    return fnNode.body;
+  }
+
+  return null;
+}
+
+function getFunctionLikeByName(name) {
+  let foundNode = null;
+
+  walk(ast, (node) => {
+    if (
+      node.type === 'FunctionDeclaration' &&
+      node.id &&
+      node.id.type === 'Identifier' &&
+      node.id.name === name
+    ) {
+      foundNode = node;
+      return;
+    }
+
+    if (node.type !== 'VariableDeclarator') {
+      return;
+    }
+
+    if (!node.id || node.id.type !== 'Identifier' || node.id.name !== name) {
+      return;
+    }
+
+    if (
+      node.init &&
+      (node.init.type === 'ArrowFunctionExpression' || node.init.type === 'FunctionExpression')
+    ) {
+      foundNode = node.init;
+    }
+  });
+
+  return foundNode;
+}
+
+test('runWithVersionCheck uses non-blocking update notifications', () => {
+  const runWithVersionCheckNode = getRunWithVersionCheckNode();
+  const runWithVersionCheckBody = getFunctionBodyNode(runWithVersionCheckNode);
+
+  assert.ok(
+    runWithVersionCheckNode,
+    'runWithVersionCheck function should exist as a declaration or function-valued variable'
+  );
+  assert.ok(runWithVersionCheckBody, 'runWithVersionCheck should have a traversable function body');
+
+  let hasNotifyCall = false;
+  let hasAwaitedNotifyCall = false;
+  let notifyCallLine = null;
+  let hasPromptCall = false;
+  let promptCallLine = null;
+
+  walk(runWithVersionCheckBody, (node) => {
+    if (isMethodCall(node, 'notifyAvailableUpdates')) {
+      hasNotifyCall = true;
+      notifyCallLine = notifyCallLine ?? lineOf(node);
+    }
+    if (
+      node.type === 'AwaitExpression' &&
+      isMethodCall(node.argument, 'notifyAvailableUpdates')
+    ) {
+      hasAwaitedNotifyCall = true;
+    }
+    if (isMethodCall(node, 'checkAndPromptUpdates')) {
+      hasPromptCall = true;
+      promptCallLine = promptCallLine ?? lineOf(node);
+    }
+  });
+
+  assert.equal(
+    hasNotifyCall,
+    true,
+    `runWithVersionCheck must call updateManager.notifyAvailableUpdates() (found at line ${notifyCallLine ?? 'unknown'})`
+  );
+  assert.equal(
+    hasAwaitedNotifyCall,
+    false,
+    `runWithVersionCheck should fire-and-forget notifyAvailableUpdates() without await (notify call line ${notifyCallLine ?? 'unknown'})`
+  );
+  assert.equal(
+    hasPromptCall,
+    false,
+    `runWithVersionCheck must not call updateManager.checkAndPromptUpdates() (found at line ${promptCallLine ?? 'unknown'})`
+  );
+});
+
+test('update command remains explicitly interactive', () => {
+  let foundAwaitedInteractiveUpdateAction = false;
+  let updateActionHandlerLine = null;
+  let relatedPromptCallLine = null;
+  let handlerReferenceName = null;
+
+  walk(ast, (node) => {
+    if (
+      node.type === 'CallExpression' &&
+      node.callee &&
+      node.callee.type === 'MemberExpression' &&
+      node.callee.property &&
+      node.callee.property.type === 'Identifier' &&
+      node.callee.property.name === 'action' &&
+      isCommandUpdateExpression(node.callee.object)
+    ) {
+      const actionHandler = node.arguments[0];
+      if (!actionHandler) {
+        return;
+      }
+
+      let resolvedHandler = null;
+
+      if (actionHandler.type === 'Identifier') {
+        handlerReferenceName = actionHandler.name;
+        resolvedHandler = getFunctionLikeByName(actionHandler.name);
+      } else if (
+        actionHandler.type === 'ArrowFunctionExpression' ||
+        actionHandler.type === 'FunctionExpression'
+      ) {
+        resolvedHandler = actionHandler;
+      }
+
+      if (!resolvedHandler || resolvedHandler.async !== true) {
+        return;
+      }
+
+      const resolvedBody = getFunctionBodyNode(resolvedHandler);
+      if (!resolvedBody) {
+        return;
+      }
+
+      updateActionHandlerLine = updateActionHandlerLine ?? lineOf(resolvedHandler);
+
+      walk(resolvedBody, (actionNode) => {
+        if (isMethodCall(actionNode, 'checkAndPromptUpdates')) {
+          relatedPromptCallLine = relatedPromptCallLine ?? lineOf(actionNode);
+        }
+
+        if (
+          actionNode.type !== 'AwaitExpression' ||
+          !isMethodCall(actionNode.argument, 'checkAndPromptUpdates')
+        ) {
+          return;
+        }
+
+        foundAwaitedInteractiveUpdateAction = true;
+      });
+    }
+  });
+
+  assert.equal(
+    foundAwaitedInteractiveUpdateAction,
+    true,
+    `update command action must await checkAndPromptUpdates(...) (action line ${updateActionHandlerLine ?? 'unknown'}, related call line ${relatedPromptCallLine ?? 'unknown'}${handlerReferenceName ? `, handler reference ${handlerReferenceName}` : ''})`
+  );
+});

package/tests/local-cli-delegation.test.js

@@ -0,0 +1,79 @@
+import { test } from 'node:test';
+import assert from 'node:assert/strict';
+import fs from 'node:fs';
+import os from 'node:os';
+import path from 'node:path';
+import {
+  findNearestLocalCliEntry,
+  resolveLocalCliCandidate,
+  shouldDelegateToLocalCli,
+  isLocalDelegationDisabled
+} from '../commands/utils/LocalCliDelegation.js';
+
+test('isLocalDelegationDisabled returns true when env flag is set', () => {
+  const env = { SLICE_NO_LOCAL_DELEGATION: '1' };
+  assert.equal(isLocalDelegationDisabled(env), true);
+});
+
+test('isLocalDelegationDisabled returns false when env flag is missing', () => {
+  const env = {};
+  assert.equal(isLocalDelegationDisabled(env), false);
+});
+
+test('shouldDelegateToLocalCli is false when candidate is null', () => {
+  assert.equal(shouldDelegateToLocalCli('/tmp/current/client.js', null), false);
+});
+
+test('shouldDelegateToLocalCli is false when candidate realpath equals current realpath', () => {
+  const same = '/tmp/current/client.js';
+  assert.equal(shouldDelegateToLocalCli(same, same), false);
+});
+
+test('shouldDelegateToLocalCli is true when candidate differs from current', () => {
+  const current = '/tmp/global/client.js';
+  const local = '/tmp/project/node_modules/slicejs-cli/client.js';
+  assert.equal(shouldDelegateToLocalCli(current, local), true);
+});
+
+test('findNearestLocalCliEntry returns null when no candidate resolver hits', () => {
+  const cwd = path.join('/tmp', 'slice-nonexistent-project');
+  const resolver = () => null;
+  const result = findNearestLocalCliEntry(cwd, resolver);
+  assert.equal(result, null);
+});
+
+test('findNearestLocalCliEntry returns first match while traversing upward', () => {
+  const cwd = '/repo/apps/web/src';
+  const calls = [];
+  const resolver = (dir) => {
+    calls.push(dir);
+    if (dir === '/repo/apps/web') {
+      return '/repo/apps/web/node_modules/slicejs-cli/client.js';
+    }
+    return null;
+  };
+
+  const result = findNearestLocalCliEntry(cwd, resolver);
+
+  assert.equal(result, '/repo/apps/web/node_modules/slicejs-cli/client.js');
+  assert.deepEqual(calls, ['/repo/apps/web/src', '/repo/apps/web']);
+});
+
+test('findNearestLocalCliEntry returns null when resolver is not a function', () => {
+  const result = findNearestLocalCliEntry('/repo/apps/web/src', null);
+  assert.equal(result, null);
+});
+
+test('resolveLocalCliCandidate returns null when candidate path is a directory', () => {
+  const tempRoot = fs.mkdtempSync(path.join(os.tmpdir(), 'slice-cli-delegation-'));
+  const candidateDirectory = path.join(tempRoot, 'node_modules', 'slicejs-cli', 'client.js');
+
+  fs.mkdirSync(candidateDirectory, { recursive: true });
+
+  try {
+    const result = resolveLocalCliCandidate(tempRoot);
+    assert.equal(result, null);
+  } finally {
+    fs.rmSync(tempRoot, { recursive: true, force: true });
+  }
+});

package/tests/update-manager-notifications.test.js

@@ -0,0 +1,88 @@
+import { test } from 'node:test';
+import assert from 'node:assert/strict';
+import Print from '../commands/Print.js';
+import { UpdateManager } from '../commands/utils/updateManager.js';
+
+test('notifyAvailableUpdates shows advisory output and never invokes interactive update flow', async () => {
+  const manager = new UpdateManager();
+  const calls = {
+    display: 0,
+    prompted: 0,
+    info: [],
+    error: []
+  };
+
+  manager.checkForUpdates = async () => ({
+    hasUpdates: true,
+    updates: [
+      {
+        name: 'slicejs-web-framework',
+        displayName: 'Slice.js Framework',
+        current: '2.4.3',
+        latest: '2.5.0',
+        type: 'framework'
+      }
+    ],
+    allCurrent: false
+  });
+
+  manager.displayUpdates = () => {
+    calls.display += 1;
+  };
+
+  manager.checkAndPromptUpdates = async () => {
+    calls.prompted += 1;
+    return true;
+  };
+
+  const originalInfo = Print.info;
+  const originalError = Print.error;
+
+  Print.info = (message) => calls.info.push(message);
+  Print.error = (message) => calls.error.push(message);
+
+  try {
+    const result = await manager.notifyAvailableUpdates();
+
+    assert.equal(result, true);
+    assert.equal(calls.display, 1);
+    assert.equal(calls.prompted, 0);
+    assert.equal(calls.error.length, 0);
+    assert.equal(calls.info.length, 1);
+    assert.match(calls.info[0], /slice update/);
+  } finally {
+    Print.info = originalInfo;
+    Print.error = originalError;
+  }
+});
+
+test('notifyAvailableUpdates returns false and prints nothing when no updates are available', async () => {
+  const manager = new UpdateManager();
+  const calls = {
+    display: 0,
+    info: []
+  };
+
+  manager.checkForUpdates = async () => ({
+    hasUpdates: false,
+    updates: [],
+    allCurrent: true
+  });
+
+  manager.displayUpdates = () => {
+    calls.display += 1;
+  };
+
+  const originalInfo = Print.info;
+  Print.info = (message) => calls.info.push(message);
+
+  try {
+    const result = await manager.notifyAvailableUpdates();
+
+    assert.equal(result, false);
+    assert.equal(calls.display, 0);
+    assert.equal(calls.info.length, 0);
+  } finally {
+    Print.info = originalInfo;
+  }
+});