slice-machine-ui 2.16.2-alpha.jp-fix-cr-modal-rules-of-hooks.1 → 2.16.2-alpha.xru-remove-review-form.1

package/test/src/modules/userContext.test.ts

@@ -1,11 +1,6 @@
 import { describe, expect, it } from "vitest";
 
-import {
-  sendAReviewCreator,
-  skipReviewCreator,
-  userContextReducer,
-} from "@/modules/userContext";
-import { UserContextStoreType } from "@/modules/userContext/types";
+import { userContextReducer } from "@/modules/userContext";
 
 describe("[UserContext module]", () => {
   describe("[Reducer]", () => {
@@ -18,49 +13,5 @@ describe("[UserContext module]", () => {
       // @ts-expect-error TS(2345) FIXME: Argument of type '{}' is not assignable to paramet... Remove this comment to see the full error message
       expect(userContextReducer({}, { type: "NO.MATCH" })).toEqual({});
     });
-
-    it("should update user review onboarding to true when given USER_CONTEXT/SEND_REVIEW action", () => {
-      // @ts-expect-error TS(2739) FIXME: Type '{ hasSendAReview: false;... Remove this comment to see the full error message
-      const initialState: UserContextStoreType = {
-        userReview: {
-          onboarding: false,
-        },
-      };
-
-      const action = sendAReviewCreator({
-        reviewType: "onboarding",
-      });
-
-      const expectedState: UserContextStoreType = {
-        ...initialState,
-        userReview: {
-          onboarding: true,
-        },
-      };
-
-      expect(userContextReducer(initialState, action)).toEqual(expectedState);
-    });
-
-    it("should update user review onboarding to true when given USER_CONTEXT/SKIP_REVIEW action", () => {
-      // @ts-expect-error TS(2739) FIXME: Type '{ hasSendAReview: false;... Remove this comment to see the full error message
-      const initialState: UserContextStoreType = {
-        userReview: {
-          onboarding: false,
-        },
-      };
-
-      const action = skipReviewCreator({
-        reviewType: "onboarding",
-      });
-
-      const expectedState: UserContextStoreType = {
-        ...initialState,
-        userReview: {
-          onboarding: true,
-        },
-      };
-
-      expect(userContextReducer(initialState, action)).toEqual(expectedState);
-    });
   });
 });

package/out/_next/static/b5TDcD5T7XZWO6tB8rLgd/_buildManifest.js

@@ -1 +0,0 @@
-self.__BUILD_MANIFEST=function(s,c,a,e,t,i,d,n,b,u,f,h,l,k,p,j,g,o,r){return{__rewrites:{afterFiles:[],beforeFiles:[],fallback:[]},"/":[a,p,j,"static/chunks/pages/index-0e27ae9805b59004.js"],"/_error":["static/chunks/pages/_error-fedd2c6ebd3d27b9.js"],"/changelog":[s,e,"static/chunks/870-a72b74312773efea.js","static/chunks/pages/changelog-80a618708f44f25f.js"],"/changes":[s,t,"static/chunks/8eec4907-b712959d9f984b68.js","static/chunks/918-fa4f2563cb5fd014.js",c,d,"static/css/d98ebc475f8423a3.css","static/chunks/pages/changes-d40c17939854b984.js"],"/custom-types":[a,p,j,"static/chunks/pages/custom-types-093f2e2213561492.js"],"/custom-types/[customTypeId]":[s,n,b,u,f,e,i,h,g,c,a,l,k,o,r,"static/chunks/pages/custom-types/[customTypeId]-61a3846ae1654f54.js"],"/labs":["static/chunks/pages/labs-c6df252ea5d8fb6f.js"],"/page-types/[pageTypeId]":[s,n,b,u,f,e,i,h,g,c,a,l,k,o,r,"static/chunks/pages/page-types/[pageTypeId]-91a4eb622fa3cb7c.js"],"/settings":["static/css/e5f781f20e24a5ea.css","static/chunks/pages/settings-0da3553b3a0acc99.js"],"/slices":[s,t,i,c,d,k,"static/css/efa5152b7c0f35c0.css","static/chunks/pages/slices-7e816c2b32cc6f19.js"],"/slices/[lib]/[sliceName]/[variation]":[s,t,n,b,u,f,e,i,h,c,l,d,"static/css/cdee5b195444f185.css","static/chunks/pages/slices/[lib]/[sliceName]/[variation]-c71823bf02dc292d.js"],"/slices/[lib]/[sliceName]/[variation]/simulator":[t,"static/chunks/72585f70-28b4d7d5384b3703.js","static/chunks/157-fca2f00f6df07660.js","static/chunks/pages/slices/[lib]/[sliceName]/[variation]/simulator-063fa88ba75f483e.js"],sortedPages:["/","/_app","/_error","/changelog","/changes","/custom-types","/custom-types/[customTypeId]","/labs","/page-types/[pageTypeId]","/settings","/slices","/slices/[lib]/[sliceName]/[variation]","/slices/[lib]/[sliceName]/[variation]/simulator"]}}("static/chunks/59b4e022-ef680789f7cc9b11.js","static/chunks/34-2911c905c8a6e9d9.js","static/chunks/867-8164160c810122c6.js","static/chunks/183-85de38d65a85dc2c.js","static/chunks/c8eae200-966ce352f7b5d2b9.js","static/chunks/44-a2056f993381ad0f.js","static/chunks/658-8231c0b729e0124a.js","static/chunks/f36c6662-1f3a854183168b10.js","static/chunks/4c744e84-480e426e4b1cfef3.js","static/chunks/065a3ddb-9a38ca0d60f0bf2f.js","static/chunks/1cc2734a-09fb3b997ad1eb70.js","static/chunks/349-7118116b93278f73.js","static/chunks/630-93339694ef30b82d.js","static/chunks/268-6d5fc7642a1b87c8.js","static/chunks/895-8c214ba470a4e23c.js","static/css/4e475d945cf8a890.css","static/chunks/385-b949173dfa03dd3e.js","static/chunks/882-28837678beff7e51.js","static/css/56f2a6684a524374.css"),self.__BUILD_MANIFEST_CB&&self.__BUILD_MANIFEST_CB();

package/src/legacy/components/ReviewModal/ReviewForm.tsx

@@ -1,169 +0,0 @@
-import { Field, Form, Formik } from "formik";
-import { FC } from "react";
-import Modal from "react-modal";
-import { useSelector } from "react-redux";
-import {
-  Box,
-  Button,
-  Card,
-  Close,
-  Flex,
-  Heading,
-  Text,
-  Textarea,
-} from "theme-ui";
-
-import { telemetry } from "@/apiClient";
-import SliceMachineModal from "@/legacy/components/SliceMachineModal";
-import { isLoading } from "@/modules/loading";
-import { LoadingKeysEnum } from "@/modules/loading/types";
-import { isModalOpen } from "@/modules/modal";
-import { ModalKeysEnum } from "@/modules/modal/types";
-import useSliceMachineActions from "@/modules/useSliceMachineActions";
-import { SliceMachineStoreType } from "@/redux/type";
-
-import { ReviewFormSelect } from "./ReviewFormSelect";
-
-Modal.setAppElement("#__next");
-
-const reviewType = "onboarding";
-
-export const ReviewForm: FC = () => {
-  const { isReviewLoading, isLoginModalOpen } = useSelector(
-    (store: SliceMachineStoreType) => ({
-      isReviewLoading: isLoading(store, LoadingKeysEnum.REVIEW),
-      isLoginModalOpen: isModalOpen(store, ModalKeysEnum.LOGIN),
-    }),
-  );
-  const { skipReview, sendAReview, startLoadingReview, stopLoadingReview } =
-    useSliceMachineActions();
-
-  const onSendAReview = (rating: number, comment: string): void => {
-    startLoadingReview();
-    void telemetry.track({
-      event: "review",
-      rating,
-      comment,
-      type: reviewType,
-    });
-    sendAReview(reviewType);
-    stopLoadingReview();
-  };
-
-  const validateReview = ({ rating }: { rating: number; comment: string }) => {
-    if (!rating) {
-      return { id: "Please choose a rating" };
-    }
-  };
-
-  return (
-    <SliceMachineModal
-      isOpen
-      shouldCloseOnOverlayClick={false}
-      onRequestClose={() => skipReview(reviewType)}
-      closeTimeoutMS={500}
-      contentLabel={"Review Modal"}
-      portalClassName={"ReviewModal"}
-      style={{
-        content: {
-          display: "flex",
-          position: "initial",
-          padding: "none",
-          top: "initial",
-          left: "initial",
-          minHeight: "initial",
-        },
-        overlay: {
-          top: "initial",
-          left: "initial",
-          right: 16,
-          bottom: 16,
-          position: "absolute",
-          height: "fit-content",
-          width: "fit-content",
-          backgroundColor: "unset",
-        },
-      }}
-    >
-      <Formik
-        validateOnMount
-        initialValues={{
-          rating: 0,
-          comment: "",
-        }}
-        validate={validateReview}
-        onSubmit={(values) => {
-          onSendAReview(values.rating, values.comment);
-        }}
-      >
-        {({ isValid }) => (
-          <Form id="review-form">
-            <Card>
-              <Flex
-                sx={{
-                  p: "16px",
-                  pl: 4,
-                  bg: "headSection",
-                  alignItems: "center",
-                  justifyContent: "space-between",
-                  borderRadius: "8px 8px 0px 0px",
-                  // eslint-disable-next-line @typescript-eslint/restrict-template-expressions
-                  borderBottom: (t) => `1px solid ${t.colors?.borders}`,
-                }}
-              >
-                <Heading sx={{ fontSize: "20px", mr: 4 }}>
-                  Share feedback
-                </Heading>
-                <Close type="button" onClick={() => skipReview(reviewType)} />
-              </Flex>
-              <Flex
-                sx={{
-                  flexDirection: "column",
-                  padding: "16px 24px 32px",
-                  bg: "headSection",
-                }}
-              >
-                <Text variant={"xs"} as={"p"} sx={{ maxWidth: 302, mb: 3 }}>
-                  Overall, how satisfied or dissatisfied are you with your Slice
-                  Machine experience so far?
-                </Text>
-                <Box
-                  mb={2}
-                  sx={{
-                    display: "flex",
-                    flex: 1,
-                    justifyContent: "space-between",
-                  }}
-                >
-                  <Text variant={"xs"} as={"p"}>
-                    Very unsatisfied
-                  </Text>
-                  <Text variant={"xs"} as={"p"}>
-                    Very satisfied
-                  </Text>
-                </Box>
-                <Field name={"rating"} component={ReviewFormSelect} />
-                <Field
-                  name={"comment"}
-                  type="text"
-                  placeholder="Tell us more..."
-                  as={Textarea}
-                  autoComplete="off"
-                  sx={{ height: 80, mb: 3 }}
-                  data-testid="review-form-comment"
-                />
-                <Button
-                  form={"review-form"}
-                  type="submit"
-                  disabled={!isValid || isReviewLoading || isLoginModalOpen}
-                >
-                  Submit
-                </Button>
-              </Flex>
-            </Card>
-          </Form>
-        )}
-      </Formik>
-    </SliceMachineModal>
-  );
-};

package/src/legacy/components/ReviewModal/ReviewFormSelect.tsx

@@ -1,35 +0,0 @@
-import { FieldProps } from "formik";
-import { FC } from "react";
-import { Box, Button } from "theme-ui";
-
-const ratingSelectable = [1, 2, 3, 4, 5];
-
-export const ReviewFormSelect: FC<FieldProps> = (props) => {
-  const { field, form } = props;
-
-  return (
-    <Box sx={{ mb: 3, display: "flex", justifyContent: "space-between" }}>
-      {ratingSelectable.map((rating, index) => (
-        <Button
-          variant="secondary"
-          type="button"
-          key={index}
-          onClick={() => void form.setFieldValue("rating", rating)}
-          className={field.value === rating ? "selected" : ""}
-          sx={{
-            "&:not(:last-of-type)": {
-              mr: 1,
-            },
-            "&.selected": {
-              backgroundColor: "code.gray",
-              color: "white",
-            },
-          }}
-          data-testid={`review-form-score-${rating}`}
-        >
-          {rating}
-        </Button>
-      ))}
-    </Box>
-  );
-};

package/src/legacy/components/ReviewModal/ReviewModal.tsx

@@ -1,56 +0,0 @@
-import { FC } from "react";
-import { useSelector } from "react-redux";
-
-import { hasLocal } from "@/legacy/lib/models/common/ModelData";
-import { selectAllCustomTypes } from "@/modules/availableCustomTypes";
-import { getLibraries } from "@/modules/slices";
-import { getLastSyncChange, getUserReview } from "@/modules/userContext";
-import { SliceMachineStoreType } from "@/redux/type";
-
-import { ReviewForm } from "./ReviewForm";
-
-export const ReviewModal: FC = () => {
-  const { userReview, customTypes, libraries, lastSyncChange } = useSelector(
-    (store: SliceMachineStoreType) => ({
-      userReview: getUserReview(store),
-      customTypes: selectAllCustomTypes(store),
-      libraries: getLibraries(store),
-      lastSyncChange: getLastSyncChange(store),
-    }),
-  );
-
-  const sliceCount =
-    // eslint-disable-next-line @typescript-eslint/strict-boolean-expressions
-    libraries && libraries.length
-      ? libraries.reduce((count, lib) => {
-          // eslint-disable-next-line @typescript-eslint/strict-boolean-expressions
-          if (!lib) return count;
-          return count + lib.components.length;
-        }, 0)
-      : 0;
-
-  const hasSliceWithinCustomType = customTypes.some(
-    (customType) =>
-      hasLocal(customType) &&
-      customType.local.tabs.some(
-        (tab) => tab.sliceZone && tab.sliceZone?.value.length > 0,
-      ),
-  );
-
-  const hasPushedAnHourAgo = Boolean(
-    // eslint-disable-next-line @typescript-eslint/strict-boolean-expressions
-    lastSyncChange && Date.now() - lastSyncChange >= 3600000,
-  );
-
-  const isOnboardingDone =
-    sliceCount >= 1 &&
-    customTypes.length >= 1 &&
-    hasSliceWithinCustomType &&
-    hasPushedAnHourAgo;
-
-  if (!userReview.onboarding && isOnboardingDone) {
-    return <ReviewForm />;
-  }
-
-  return null;
-};

package/src/legacy/components/ReviewModal/index.ts

@@ -1 +0,0 @@
-export { ReviewModal } from "./ReviewModal";