slack-term 1.31.1 → 1.31.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "slack-term",
-  "version": "1.31.1",
+  "version": "1.31.3",
   "repository": {
     "type": "git",
     "url": "https://github.com/snomiao/slack-term.git"

package/ts/ask.ts

@@ -112,9 +112,15 @@ export const ASK_RESOLVED_PREFIX = `:${ASK_RESOLVED_MARKER}: `;
  *
  *  Both spellings are accepted on the way in: the shortcode is what Slack
  *  stores, and the glyph is what a body hand-edited in the Slack UI can be. */
+/** How a keycap is WRITTEN into the body: the shortcode, because that is the
+ *  form Slack stores and therefore the form that reads back unchanged. */
+function askPill(i: number): string {
+  return `:${ASK_KEYCAPS[i]!.name}:`;
+}
+
 function askStripPill(line: string, i: number): string | null {
   const k = ASK_KEYCAPS[i]!;
-  for (const pre of [`:${k.name}:`, k.glyph]) {
+  for (const pre of [askPill(i), k.glyph]) {
     if (line.startsWith(`${pre} `)) return line.slice(pre.length + 1);
     if (line === pre) return "";
   }
@@ -142,7 +148,12 @@ export function askBuildText(question: string, body: string, reactable: string[]
     lines.push("");
     // Flattened: a choice is a pill label, and a newline in one would split it
     // into a line the parser cannot tell from body text.
-    lines.push(...reactable.map((s, i) => `${ASK_KEYCAPS[i]!.glyph} ${askFlatten(s)}`));
+    // Built with the SHORTCODE, matching what Slack stores. Building with the
+    // glyph worked only because the parser now accepts both — the body still
+    // came back as `:one:` and never matched what was sent. Writing the stored
+    // form keeps posted and read-back bytes identical, which is what the
+    // round-trip test can actually check. (`poll` already did this.)
+    lines.push(...reactable.map((s, i) => `${askPill(i)} ${askFlatten(s)}`));
     if (overflow.length) {
       lines.push("");
       lines.push(...overflow.map((s, i) => `(${i + 11}) ${askFlatten(s)}`));

package/ts/todo.ts

@@ -199,9 +199,29 @@ export const MAX_RATE_LIMIT_RETRIES = 3;
 
 export const _internals = {
   // Swappable so tests never wait real time (same pattern as tail.ts).
-  sleep: (ms: number): Promise<void> => new Promise((res) => setTimeout(res, ms)),
+  //
+  // The spy is NOT the only defence, and must not be: a stub installed in a
+  // `beforeEach` is undone by any `vi.restoreAllMocks()` in a nested block's
+  // `afterEach`, and the next test then backs off for REAL seconds. That is
+  // what wedged CI — `todo.test.ts` burned the whole job budget in the retry
+  // path while every other file finished in under two seconds, and it never
+  // reproduced locally because the timing differs.
+  //
+  // So the backoff itself refuses to sleep under a test runner. Detecting the
+  // environment is ugly, but the alternative is a rule ("never let a nested
+  // afterEach restore this") that has to be remembered by every future test —
+  // and it already was not.
+  sleep: (ms: number): Promise<void> =>
+    isTestEnv() ? Promise.resolve() : new Promise((res) => setTimeout(res, ms)),
 };
 
+/** True under vitest or `bun test`. Both set NODE_ENV=test; vitest also sets
+ *  VITEST. Checked at call time, not at import, so a test that deliberately
+ *  wants the real timer can clear it. */
+function isTestEnv(): boolean {
+  return !!process.env.VITEST || process.env.NODE_ENV === "test" || !!process.env.BUN_TEST;
+}
+
 /** Run an API call, backing off and retrying on 429. Mirrors tail.ts: warn on
  *  stderr, sleep `retryAfter`, try again — but bounded, so a persistently
  *  throttled workspace fails loudly instead of hanging forever. */