slack-term 1.31.0 → 1.31.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "slack-term",
-  "version": "1.31.0",
+  "version": "1.31.2",
   "repository": {
     "type": "git",
     "url": "https://github.com/snomiao/slack-term.git"

package/ts/ask.ts

@@ -101,6 +101,38 @@ export function isInvalidNotice(line: string | undefined): boolean {
 export const ASK_RESOLVED_MARKER = "white_check_mark";
 export const ASK_RESOLVED_PREFIX = `:${ASK_RESOLVED_MARKER}: `;
 
+/** How a keycap is WRITTEN into the body, and how it is read back.
+ *
+ *  Slack NORMALISES a unicode keycap in the stored `text`: post `1️⃣` and
+ *  `conversations.history` returns `:one:`. So a body built with glyphs never
+ *  reads back as what was sent, and `--waitFor` cannot recognise its own
+ *  question. `poll` already handled this; `ask` did not, which made every
+ *  pill-answered question uncollectable (reported from real use 2026-08-31:
+ *  four questions answered, nothing collected for ~20 minutes).
+ *
+ *  Both spellings are accepted on the way in: the shortcode is what Slack
+ *  stores, and the glyph is what a body hand-edited in the Slack UI can be. */
+/** How a keycap is WRITTEN into the body: the shortcode, because that is the
+ *  form Slack stores and therefore the form that reads back unchanged. */
+function askPill(i: number): string {
+  return `:${ASK_KEYCAPS[i]!.name}:`;
+}
+
+function askStripPill(line: string, i: number): string | null {
+  const k = ASK_KEYCAPS[i]!;
+  for (const pre of [askPill(i), k.glyph]) {
+    if (line.startsWith(`${pre} `)) return line.slice(pre.length + 1);
+    if (line === pre) return "";
+  }
+  return null;
+}
+
+/** True if the line opens with ANY keycap — used only to find where the choice
+ *  block starts; WHICH keycap it is gets checked afterwards, in order. */
+function askIsPillLine(line: string): boolean {
+  return ASK_KEYCAPS.some((_k, i) => askStripPill(line, i) !== null);
+}
+
 /** One line, always: newlines inside a choice would break the line-based body. */
 export function askFlatten(s: string): string {
   return s.replace(/\s*\n\s*/g, " ");
@@ -116,7 +148,12 @@ export function askBuildText(question: string, body: string, reactable: string[]
     lines.push("");
     // Flattened: a choice is a pill label, and a newline in one would split it
     // into a line the parser cannot tell from body text.
-    lines.push(...reactable.map((s, i) => `${ASK_KEYCAPS[i]!.glyph} ${askFlatten(s)}`));
+    // Built with the SHORTCODE, matching what Slack stores. Building with the
+    // glyph worked only because the parser now accepts both — the body still
+    // came back as `:one:` and never matched what was sent. Writing the stored
+    // form keeps posted and read-back bytes identical, which is what the
+    // round-trip test can actually check. (`poll` already did this.)
+    lines.push(...reactable.map((s, i) => `${askPill(i)} ${askFlatten(s)}`));
     if (overflow.length) {
       lines.push("");
       lines.push(...overflow.map((s, i) => `(${i + 11}) ${askFlatten(s)}`));
@@ -154,6 +191,29 @@ export type AskParsed =
  *  by a loose heuristic: it is the one part of the body this command wrote
  *  verbatim, so matching it exactly is what keeps an unrelated message from
  *  being polled as if it were an ask. */
+/** Why `askParseMessage` rejected a body, in the reader's terms.
+ *
+ *  The single generic "this is not an ask" line sent a real user re-checking
+ *  permalinks that were fine, and cost ~20 minutes while pressed answers went
+ *  uncollected (2026-08-31). A rejection has to say WHICH check failed, because
+ *  the three causes have completely different fixes: wrong link, a body someone
+ *  edited, or a bug here. */
+export function askExplainReject(text: string): string {
+  if (!text.trim()) return "本文が空です (bot 投稿や添付のみのメッセージかもしれません)";
+  const lines = text.split("\n");
+  const last = lines[lines.length - 1] ?? "";
+  if (text.startsWith(ASK_RESOLVED_PREFIX)) {
+    return "回答済みマーク付きですが、引用された回答本文が見つかりません";
+  }
+  if (!/_$/.test(last)) {
+    return "末尾が `ask` の案内文ではありません — このメッセージは `slack ask` で投稿されたものではないか、本文が編集されています";
+  }
+  if (!lines[0]!.startsWith(ASK_MARKER_PREFIX) && !lines[0]!.startsWith("*")) {
+    return "先頭が質問文 (太字) ではありません — 本文が編集されている可能性があります";
+  }
+  return "選択肢の並びを読み取れません — 番号が 1 から連番になっていないか、本文が編集されています";
+}
+
 export function askParseMessage(text: string): AskParsed {
   const lines = text.split("\n");
 
@@ -221,7 +281,7 @@ export function askParseMessage(text: string): AskParsed {
     const raw: string[] = [];
     while (i >= 0) {
       const line = lines[i]!;
-      if (!ASK_KEYCAPS.some((k) => line.startsWith(`${k.glyph} `) || line === k.glyph)) break;
+      if (!askIsPillLine(line)) break;
       raw.unshift(line);
       i--;
     }
@@ -231,9 +291,9 @@ export function askParseMessage(text: string): AskParsed {
     // block starting at 2️⃣ would have it waiting on a pill nobody can press.
     if (!raw.length || raw.length > ASK_MAX_REACTION_CHOICES) return { kind: "other" };
     for (let k = 0; k < raw.length; k++) {
-      const glyph = ASK_KEYCAPS[k]!.glyph;
-      if (!(raw[k]!.startsWith(`${glyph} `) || raw[k] === glyph)) return { kind: "other" };
-      reactable.push(raw[k]!.slice(glyph.length + 1));
+      const rest = askStripPill(raw[k]!, k);
+      if (rest === null) return { kind: "other" };
+      reactable.push(rest);
     }
     if (lines[i] !== "") return { kind: "other" };
     if (i < end + 1) return { kind: "other" };

package/ts/cli.ts

@@ -21,6 +21,7 @@ import {
   askBuildText,
   askBuildResolvedText,
   askParseMessage,
+  askExplainReject,
   askFlatten,
   applyInvalidNotice,
   readInvalidNotice,
@@ -295,6 +296,17 @@ function slimMsg(m: Record<string, Json>): Record<string, Json> {
     // Thread stats, present only on thread parents. Without these a caller
     // reading top-level history cannot tell a post with replies from one
     // without, and silently misses everything said inside the thread.
+    // Reactions, when the message carries any. `ask` and `poll` record ANSWERS
+    // as reactions, so omitting them made `--json` useless as the fallback
+    // people reach for when a poller fails — the pressed pills were right there
+    // in the API response and the CLI dropped them (reported 2026-08-31).
+    ...(Array.isArray(m.reactions) && m.reactions.length
+      ? { reactions: asArray(m.reactions).map(asRecord).map((r) => ({
+          name: r.name ?? null,
+          count: r.count ?? null,
+          users: Array.isArray(r.users) ? r.users : [],
+        })) }
+      : {}),
     ...(m.reply_count !== undefined ? { reply_count: m.reply_count } : {}),
     ...(m.reply_users_count !== undefined ? { reply_users_count: m.reply_users_count } : {}),
     ...(m.latest_reply !== undefined ? { latest_reply: m.latest_reply } : {}),
@@ -2235,8 +2247,12 @@ async function cmdAskWaitFor(token: string, args: { link: string; timeout: numbe
   const parsed = askParseMessage(text);
   if (parsed.kind === "other") {
     console.error(
-      `Error: これは \`slack ask\` の質問ではありません (回答の読み取り方が分かりません)。\n` +
-      `  ${stripTerminalControls(args.link)}`,
+      `Error: これは \`slack ask\` の質問として読み取れません。\n` +
+      `  理由: ${askExplainReject(text)}\n` +
+      `  ${stripTerminalControls(args.link)}\n` +
+      // The pills are still readable by hand, so a failure here is not a dead
+      // end — say so, because the reported cost was not knowing that.
+      `  (押されたリアクションは残っています: slack read '${stripTerminalControls(args.link)}' で確認できます)`,
     );
     process.exit(ASK_EXIT_ERROR);
   }