skuba 5.0.1 → 5.1.0

package/template/lambda-sqs-worker/src/services/pipelineEventSender.test.ts

@@ -1,33 +1,35 @@
+import { PublishCommand } from '@aws-sdk/client-sns';
+
 import { sns } from 'src/testing/services';
 import { chance } from 'src/testing/types';
 
 import { sendPipelineEvent } from './pipelineEventSender';
 
 describe('sendPipelineEvent', () => {
-  beforeAll(sns.spy);
-
-  afterEach(sns.clear);
+  afterEach(() => {
+    jest.clearAllMocks();
+  });
 
   it('handles happy path', async () => {
     const messageId = chance.guid({ version: 4 });
 
-    sns.publish.mockPromise(Promise.resolve({ MessageId: messageId }));
+    sns.publish.resolves({ MessageId: messageId });
 
     await expect(sendPipelineEvent({})).resolves.toBe(messageId);
 
-    expect(sns.publish).toHaveBeenCalledTimes(1);
+    expect(sns.client).toReceiveCommandTimes(PublishCommand, 1);
   });
 
   it('bubbles up SNS error', () => {
     const err = Error(chance.sentence());
 
-    sns.publish.mockPromise(Promise.reject(err));
+    sns.publish.rejects(err);
 
     return expect(sendPipelineEvent({})).rejects.toThrow(err);
   });
 
   it('throws on missing message ID', () => {
-    sns.publish.mockPromise(Promise.resolve({}));
+    sns.publish.resolves({});
 
     return expect(
       sendPipelineEvent({}),

package/template/lambda-sqs-worker/src/services/pipelineEventSender.ts

@@ -1,3 +1,5 @@
+import { PublishCommand } from '@aws-sdk/client-sns';
+
 import { config } from 'src/config';
 
 import { sns } from './aws';
@@ -6,8 +8,8 @@ export const sendPipelineEvent = async (
   event: unknown,
   smokeTest: boolean = false,
 ): Promise<string> => {
-  const snsResponse = await sns
-    .publish({
+  const snsResponse = await sns.send(
+    new PublishCommand({
       Message: JSON.stringify(event),
       ...(smokeTest && {
         MessageAttributes: {
@@ -20,8 +22,8 @@ export const sendPipelineEvent = async (
         },
       }),
       TopicArn: config.destinationSnsTopicArn,
-    })
-    .promise();
+    }),
+  );
 
   if (snsResponse.MessageId === undefined) {
     throw Error('SNS did not return a message ID');

package/template/lambda-sqs-worker/src/testing/services.ts

@@ -1,4 +1,9 @@
-import * as aws from 'src/services/aws';
+import 'aws-sdk-client-mock-jest';
+
+import { PublishCommand } from '@aws-sdk/client-sns';
+import { mockClient } from 'aws-sdk-client-mock';
+
+import { sns as snsClient } from 'src/services/aws';
 import * as jobScorer from 'src/services/jobScorer';
 
 export const scoringService = {
@@ -12,13 +17,12 @@ export const scoringService = {
       .mockImplementation(scoringService.request),
 };
 
+const snsMock = mockClient(snsClient);
+
 export const sns = {
-  publish: Object.assign(jest.fn(), {
-    mockPromise: (promise: Promise<unknown>) =>
-      sns.publish.mockReturnValue({ promise: () => promise } as any),
-  }),
+  publish: snsMock.on(PublishCommand),
 
-  clear: () => sns.publish.mockClear(),
+  clear: () => snsMock.resetHistory(),
 
-  spy: () => jest.spyOn(aws.sns, 'publish').mockImplementation(sns.publish),
+  client: snsMock,
 };

package/template/lambda-sqs-worker/tsconfig.json

@@ -1,12 +1,12 @@
 {
   "compilerOptions": {
     "baseUrl": ".",
-    "lib": ["ES2020"],
+    "lib": ["ES2022"],
     "outDir": "lib",
     "paths": {
       "src": ["src"]
     },
-    "target": "ES2020"
+    "target": "ES2022"
   },
   "exclude": ["lib*/**/*"],
   "extends": "skuba/config/tsconfig.json"

package/template/lambda-sqs-worker-cdk/.buildkite/pipeline.yml

@@ -26,13 +26,13 @@ configs:
         - yarn deploy
       concurrency: 1
       plugins:
-        - artifacts#v1.7.0:
+        - artifacts#v1.8.0:
             build: ${BUILDKITE_BUILD_ID}
             download: lib/*
         - *aws-sm
         - *private-npm
         - *docker-ecr-cache
-        - docker-compose#v4.5.0:
+        - docker-compose#v4.9.0:
             dependencies: false
             run: app
       retry:
@@ -57,13 +57,13 @@ steps:
       - *aws-sm
       - *private-npm
       - *docker-ecr-cache
-      - docker-compose#v4.5.0:
+      - docker-compose#v4.9.0:
           run: app
     timeout_in_minutes: 10
 
   - agents:
       queue: <%- devBuildkiteQueueName %>
-    branches: '!renovate--*'
+    branches: '!renovate-*'
     label: 🧖‍♀️ Warm Dev
     command: ':'
     plugins:

package/template/lambda-sqs-worker-cdk/.nvmrc

@@ -1 +1 @@
-16
+18

package/template/lambda-sqs-worker-cdk/Dockerfile

@@ -1,6 +1,6 @@
 # syntax=docker/dockerfile:1.2
 
-FROM --platform=${BUILDPLATFORM:-arm64} node:16-alpine AS dev-deps
+FROM --platform=${BUILDPLATFORM:-<%- platformName %>} node:18-alpine AS dev-deps
 
 WORKDIR /workdir
 

package/template/lambda-sqs-worker-cdk/infra/__snapshots__/appStack.test.ts.snap

@@ -157,7 +157,6 @@ exports[`returns expected CloudFormation stack for dev 1`] = `
         },
         "Environment": {
           "Variables": {
-            "AWS_NODEJS_CONNECTION_REUSE_ENABLED": "1",
             "NODE_ENV": "production",
             "NODE_OPTIONS": "--enable-source-maps",
             "SOMETHING": "dev",
@@ -177,7 +176,7 @@ exports[`returns expected CloudFormation stack for dev 1`] = `
             "Arn",
           ],
         },
-        "Runtime": "nodejs16.x",
+        "Runtime": "nodejs18.x",
       },
       "Type": "AWS::Lambda::Function",
     },
@@ -519,7 +518,6 @@ exports[`returns expected CloudFormation stack for prod 1`] = `
         },
         "Environment": {
           "Variables": {
-            "AWS_NODEJS_CONNECTION_REUSE_ENABLED": "1",
             "NODE_ENV": "production",
             "NODE_OPTIONS": "--enable-source-maps",
             "SOMETHING": "prod",
@@ -539,7 +537,7 @@ exports[`returns expected CloudFormation stack for prod 1`] = `
             "Arn",
           ],
         },
-        "Runtime": "nodejs16.x",
+        "Runtime": "nodejs18.x",
       },
       "Type": "AWS::Lambda::Function",
     },

package/template/lambda-sqs-worker-cdk/infra/appStack.ts

@@ -50,16 +50,16 @@ export class AppStack extends Stack {
       encryptionMasterKey: kmsKey,
     });
 
+    const architecture = '<%- lambdaCdkArchitecture %>';
+
     const worker = new aws_lambda.Function(this, 'worker', {
-      architecture: aws_lambda.Architecture.ARM_64,
+      architecture: aws_lambda.Architecture[architecture],
       code: new aws_lambda.AssetCode('./lib'),
-      runtime: aws_lambda.Runtime.NODEJS_16_X,
+      runtime: aws_lambda.Runtime.NODEJS_18_X,
       handler: 'app.handler',
       functionName: '<%- serviceName %>',
       environmentEncryption: kmsKey,
       environment: {
-        // https://docs.aws.amazon.com/sdk-for-javascript/v2/developer-guide/node-reusing-connections.html
-        AWS_NODEJS_CONNECTION_REUSE_ENABLED: '1',
         NODE_ENV: 'production',
         // https://nodejs.org/api/cli.html#cli_node_options_options
         NODE_OPTIONS: '--enable-source-maps',

package/template/lambda-sqs-worker-cdk/package.json

@@ -18,13 +18,13 @@
   "devDependencies": {
     "@aws-cdk/assert": "^2.24.0",
     "@types/aws-lambda": "^8.10.82",
-    "@types/node": "16.11.64",
-    "aws-cdk": "^2.24.0",
-    "aws-cdk-lib": "^2.24.0",
+    "@types/node": "^18.11.9",
+    "aws-cdk": "^2.51.1",
+    "aws-cdk-lib": "^2.51.1",
     "constructs": "^10.0.17",
     "skuba": "*"
   },
   "engines": {
-    "node": ">=16"
+    "node": ">=18"
   }
 }

package/template/lambda-sqs-worker-cdk/tsconfig.json

@@ -1,12 +1,12 @@
 {
   "compilerOptions": {
     "baseUrl": ".",
-    "lib": ["ES2020"],
+    "lib": ["ES2022"],
     "outDir": "lib",
     "paths": {
       "src": ["src"]
     },
-    "target": "ES2020"
+    "target": "ES2022"
   },
   "exclude": ["lib*/**/*"],
   "extends": "skuba/config/tsconfig.json"

package/template/oss-npm-package/_package.json

@@ -2,7 +2,7 @@
   "dependencies": {},
   "description": "<%- description %>",
   "devDependencies": {
-    "@types/node": "16.11.64",
+    "@types/node": "^16.18.3",
     "commitizen": "^4.2.4",
     "skuba": "*"
   },

package/template/private-npm-package/_package.json

@@ -2,7 +2,7 @@
   "dependencies": {},
   "description": "<%- description %>",
   "devDependencies": {
-    "@types/node": "16.11.64",
+    "@types/node": "^16.18.3",
     "commitizen": "^4.2.4",
     "skuba": "*"
   },