sku 12.1.0 → 12.1.2

package/CHANGELOG.md

@@ -1,5 +1,22 @@
 # sku
 
+## 12.1.2
+
+### Patch Changes
+
+- Don't use `.git` folder to find root, only glob PNPM virtual store if PNPM is detected as the package manager ([#845](https://github.com/seek-oss/sku/pull/845))
+
+## 12.1.1
+
+### Patch Changes
+
+- Improve compile package detection in PNPM apps ([#840](https://github.com/seek-oss/sku/pull/840))
+
+- Makes some more of the array types in the sku config type into readonly versions. ([#843](https://github.com/seek-oss/sku/pull/843))
+  This allows for arrays that have been declared with `as const` to be passed in.
+
+  Affected fields are `sites`, `sites[].routes`, `site[].languages`, `routes`, and `routes[].languages`.
+
 ## 12.1.0
 
 ### Minor Changes

package/context/defaultCompilePackages.js

@@ -1,19 +1,44 @@
-const path = require('path');
+const { posix: path } = require('path');
 const chalk = require('chalk');
 const glob = require('fast-glob');
 
-const { cwd } = require('../lib/cwd');
+const { cwd: skuCwd } = require('../lib/cwd');
+const toPosixPath = require('../lib/toPosixPath');
+
+const { findRootSync } = require('@manypkg/find-root');
 
 /** @type {string[]} */
 let detectedCompilePackages = [];
 
 try {
+  const globs = ['node_modules/@seek/*/package.json'];
+  const cwd = skuCwd();
+
+  const { rootDir, tool } = findRootSync(cwd);
+
+  if (tool === 'pnpm') {
+    const pnpmVirtualStorePath = path.join(
+      toPosixPath(rootDir),
+      'node_modules/.pnpm',
+    );
+    const pnpmVirtualStoreRelativePath = path.relative(
+      '.',
+      pnpmVirtualStorePath,
+    );
+    const pnpmVirtualStoreGlob = path.join(
+      pnpmVirtualStoreRelativePath,
+      '@seek*/node_modules/@seek/*/package.json',
+    );
+
+    globs.push(pnpmVirtualStoreGlob);
+  }
+
   detectedCompilePackages = glob
-    .sync([`node_modules/@seek/*/package.json`], {
-      cwd: cwd(),
+    .sync(globs, {
+      cwd,
     })
     .map((packagePath) => {
-      const packageJson = require(path.join(cwd(), packagePath));
+      const packageJson = require(path.join(cwd, packagePath));
 
       return {
         isCompilePackage: Boolean(packageJson.skuCompilePackage),
@@ -29,4 +54,8 @@ try {
   console.error(e);
 }
 
-module.exports = ['sku', 'braid-design-system', ...detectedCompilePackages];
+module.exports = [
+  'sku',
+  'braid-design-system',
+  ...new Set(detectedCompilePackages),
+];

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "sku",
-  "version": "12.1.0",
+  "version": "12.1.2",
   "description": "Front-end development toolkit, powered by Webpack, Babel, CSS Modules, Less and Jest",
   "main": "index.js",
   "bin": {
@@ -37,6 +37,7 @@
     "@loadable/component": "^5.14.1",
     "@loadable/server": "^5.14.0",
     "@loadable/webpack-plugin": "^5.14.0",
+    "@manypkg/find-root": "^2.2.0",
     "@pmmmwh/react-refresh-webpack-plugin": "0.5.10",
     "@storybook/builder-webpack5": "^7.0.17",
     "@storybook/cli": "^7.0.17",

package/sku-types.d.ts

@@ -39,7 +39,7 @@ interface SkuRouteObject {
   route: string;
   name?: string;
   entry?: string;
-  languages?: string[];
+  languages?: ReadonlyArray<string>;
 }
 
 type SkuRoute = string | SkuRouteObject;
@@ -47,8 +47,8 @@ type SkuRoute = string | SkuRouteObject;
 interface SkuSiteObject {
   name: string;
   host?: string;
-  routes?: Array<SkuRoute>;
-  languages?: string[];
+  routes?: ReadonlyArray<SkuRoute>;
+  languages?: ReadonlyArray<string>;
 }
 
 type SkuSite = string | SkuSiteObject;
@@ -320,7 +320,7 @@ export interface SkuConfig {
    * @default ['/']
    * @link https://seek-oss.github.io/sku/#/./docs/configuration?id=routes
    */
-  routes?: Array<SkuRoute>;
+  routes?: ReadonlyArray<SkuRoute>;
 
   /**
    * **Only for SSR apps**
@@ -357,7 +357,7 @@ export interface SkuConfig {
    * @default []
    * @link https://seek-oss.github.io/sku/#/./docs/configuration?id=sites
    */
-  sites?: Array<SkuSite>;
+  sites?: ReadonlyArray<SkuSite>;
 
   /**
    * When running `sku build`, sku will compile all your external packages (`node_modules`) through `@babel/preset-env`.