skopix 2.0.84 → 2.0.86

package/cli/commands/dashboard.js

@@ -1036,11 +1036,13 @@ export async function dashboardCommand(options) {
         const { scope, name, url, steps, playwrightJs, playwrightTs, tags } = JSON.parse(body);
         if (!name) { sendJSON(res, 400, { error: 'name is required' }); return; }
         try {
-          const testData = { name, type: 'recorded', url: url || '', steps: steps || [], playwrightJs: playwrightJs || '', playwrightTs: playwrightTs || '', tags: tags || [] };
+          // Match steps against library before saving
+          const matched = await matchStepsToLibrary(suitesDir, steps || []);
+          const testData = { name, type: 'recorded', url: url || '', steps: matched.steps, playwrightJs: playwrightJs || '', playwrightTs: playwrightTs || '', tags: tags || [] };
           const result = await createTest(suitesDir, scope || 'saved', testData);
           if (teamMode && currentUser) { teamMode.db.logAudit({ userId: currentUser.id, action: 'test.created', targetType: 'test', targetId: result.id, metadata: { scope: scope || 'saved', type: 'recorded' } }); }
-          // Auto-extract steps to library in background (non-blocking)
-          extractStepsToLibrary(suitesDir, steps || [], name).catch(() => {});
+          // Auto-extract unmatched steps to pending review
+          extractStepsToLibrary(suitesDir, matched.steps, name).catch(() => {});
           sendJSON(res, 200, result);
         } catch (err) { sendJSON(res, 400, { error: err.message }); }
         return;
@@ -1575,8 +1577,11 @@ export async function dashboardCommand(options) {
         const body = await readBody(req);
         const data = JSON.parse(body);
         try {
+          // Match steps against library before saving
+          const matched = await matchStepsToLibrary(suitesDir, data.steps || []);
+          data.steps = matched.steps;
           const result = await updateTest(suitesDir, scope, testId, data);
-          // Extract any new steps to pending review queue
+          // Extract any new unmatched steps to pending review queue
           extractStepsToLibrary(suitesDir, data.steps || [], data.name || testId).catch(() => {});
           sendJSON(res, 200, result);
         } catch (err) {
@@ -3878,21 +3883,40 @@ async function matchStepsToLibrary(suitesDir, steps) {
 
   let count = 0;
   const matched = steps.map(step => {
-    const sSel = (step.stableSelector || step.selector || '').toLowerCase();
+    const sSel = (step.stableSelector || step.selector || '').toLowerCase().trim();
     if (!sSel) return step;
 
-    // Find matching library element
     const match = library.find(lib => {
-      const lSel = (lib.stableSelector || lib.selector || '').toLowerCase();
+      const lSel = (lib.stableSelector || lib.selector || '').toLowerCase().trim();
       if (!lSel) return false;
-      // Exact match
+
+      // 1. Exact match
       if (sSel === lSel) return true;
-      // One contains the other (handles i.fa-plus vs a[title="x"] i.fa-plus)
-      if (sSel.includes(lSel) || lSel.includes(sSel)) return true;
-      // Shared key tokens
-      const keyTokens = lSel.match(/\.[a-z][a-z0-9_-]+|\[[\w-]+=["'][^"']+["']\]|#[a-z][a-z0-9_-]+/g) || [];
-      const strongTokens = keyTokens.filter(t => t.length > 8);
-      if (strongTokens.length > 0 && strongTokens.some(tok => sSel.includes(tok))) return true;
+
+      // 2. Extract pi-test-identifier values from both and compare
+      const piFrom = (sSel.match(/pi-test-identifier[*^]?=["']([^"']+)["']/) || [])[1];
+      const piLib = (lSel.match(/pi-test-identifier[*^]?=["']([^"']+)["']/) || [])[1];
+      if (piFrom && piLib) {
+        if (piFrom === piLib) return true;
+        // One starts with the other (handles *= vs =)
+        if (piFrom.startsWith(piLib) || piLib.startsWith(piFrom)) return true;
+      }
+
+      // 3. Both use same has-text value (e.g. :has-text("Mariadb"))
+      const textFrom = (sSel.match(/has-text\(["']([^"']+)["']\)/) || [])[1];
+      const textLib = (lSel.match(/has-text\(["']([^"']+)["']\)/) || [])[1];
+      if (textFrom && textLib && textFrom.toLowerCase() === textLib.toLowerCase()) {
+        // Only match if same element type or one contains the other
+        const tagFrom = sSel.split(':')[0].split(' ').pop();
+        const tagLib = lSel.split(':')[0].split(' ').pop();
+        if (tagFrom === tagLib || sSel.includes(lSel) || lSel.includes(sSel)) return true;
+      }
+
+      // 4. Step selector is a child/descendant of library selector
+      // e.g. "a[title='x'] i.fa-plus" should match "a[title='x']"
+      if (lSel.length > 10 && sSel.includes(lSel)) return true;
+      if (sSel.length > 10 && lSel.includes(sSel)) return true;
+
       return false;
     });
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "skopix",
-  "version": "2.0.84",
+  "version": "2.0.86",
   "description": "Browser-based QA tool — record tests by using your app, replay them deterministically, generate Playwright code automatically",
   "main": "cli/index.js",
   "bin": {