skopix 2.0.31 → 2.0.32

package/cli/commands/dashboard.js

@@ -1800,14 +1800,14 @@ export async function dashboardCommand(options) {
         return;
       }
       if (pathname === '/api/step-library' && method === 'POST') {
-        const data = await readBody(req);
+        const data = JSON.parse(await readBody(req));
         const step = await addLibraryStep(suitesDir, data);
         sendJSON(res, 200, step);
         return;
       }
       if (pathname.match(/^\/api\/step-library\/[^/]+$/) && method === 'PUT') {
         const id = decodeURIComponent(pathname.split('/')[3]);
-        const data = await readBody(req);
+        const data = JSON.parse(await readBody(req));
         const step = await updateLibraryStep(suitesDir, id, data);
         if (!step) sendJSON(res, 404, { error: 'Not found' });
         else sendJSON(res, 200, step);
@@ -3650,11 +3650,12 @@ async function addLibraryStep(suitesDir, stepData) {
   const id = 'lib-' + Math.random().toString(36).slice(2, 10);
   const step = {
     id,
-    name: stepData.name || stepData.description || 'Unnamed step',
-    action: stepData.action,
+    name: stepData.name || stepData.description || 'Unnamed element',
     selector: stepData.stableSelector || stepData.selector || null,
     stableSelector: stepData.stableSelector || stepData.selector || null,
-    value: stepData.value || null,
+    // Store default action as hint but element is primary
+    defaultAction: stepData.action || stepData.defaultAction || null,
+    defaultValue: stepData.value || stepData.defaultValue || null,
     assertType: stepData.assertType || null,
     attribute: stepData.attribute || null,
     description: stepData.description || null,
@@ -3682,53 +3683,50 @@ async function deleteLibraryStep(suitesDir, id) {
   await saveLibrarySteps(filtered);
 }
 
-// Similarity check — returns 0-1 score
+// Similarity check — element-based, matches on selector only
 function stepSimilarity(a, b) {
-  if (a.action !== b.action) return 0;
   const selA = (a.stableSelector || a.selector || '').toLowerCase();
   const selB = (b.stableSelector || b.selector || '').toLowerCase();
-  if (selA && selB) {
-    if (selA === selB) return 1;
-    // Check if one contains the other
-    if (selA.includes(selB) || selB.includes(selA)) return 0.85;
-    // Check shared tokens
-    const tokA = selA.split(/[\s>+~.,#\[\]()=]/).filter(Boolean);
-    const tokB = selB.split(/[\s>+~.,#\[\]()=]/).filter(Boolean);
-    const shared = tokA.filter(t => tokB.includes(t) && t.length > 2);
-    if (shared.length > 0) return Math.min(0.8, shared.length / Math.max(tokA.length, tokB.length));
-  }
-  const descA = (a.description || '').toLowerCase();
-  const descB = (b.description || '').toLowerCase();
-  if (descA && descB && descA === descB) return 0.9;
+  if (!selA || !selB) return 0;
+  if (selA === selB) return 1;
+  if (selA.includes(selB) || selB.includes(selA)) return 0.85;
+  const tokA = selA.split(/[\s>+~.,#\[\]()=]/).filter(Boolean);
+  const tokB = selB.split(/[\s>+~.,#\[\]()=]/).filter(Boolean);
+  const shared = tokA.filter(t => tokB.includes(t) && t.length > 2);
+  if (shared.length > 0) return Math.min(0.8, shared.length / Math.max(tokA.length, tokB.length));
   return 0;
 }
 
-// Extract unique steps from a test and add to library (skip duplicates)
+// Extract unique elements from a test and add to library (skip duplicates)
 async function extractStepsToLibrary(suitesDir, steps, testName) {
   if (!steps || steps.length === 0) return;
   const existing = await listLibrarySteps(suitesDir);
   const toAdd = [];
+  const seenSelectors = new Set(existing.map(e => (e.stableSelector || e.selector || '').toLowerCase()));
 
   for (const step of steps) {
-    if (!step.action || step.action === 'navigate') continue;
-    // Skip steps with no selector (e.g. scroll)
+    if (!step.action || step.action === 'navigate' || step.action === 'scroll') continue;
     const sel = step.stableSelector || step.selector;
-    if (!sel && step.action !== 'type') continue;
-    // Check if similar step already exists
-    const similar = existing.find(e => stepSimilarity(e, step) >= 0.9);
-    if (similar) {
-      // Increment usage count
-      similar.usageCount = (similar.usageCount || 0) + 1;
+    if (!sel) continue;
+    const selLower = sel.toLowerCase();
+    // Skip click steps if we already have this selector from a type step (deduplicate click/type pairs)
+    if (seenSelectors.has(selLower)) {
+      const existing2 = existing.find(e => (e.stableSelector||e.selector||'').toLowerCase() === selLower) ||
+                        toAdd.find(e => (e.stableSelector||e.selector||'').toLowerCase() === selLower);
+      if (existing2) { existing2.usageCount = (existing2.usageCount || 0) + 1; }
       continue;
     }
-    // New unique step
+    seenSelectors.add(selLower);
+    // Generate clean name — strip action prefix
+    let name = step.description || '';
+    name = name.replace(/^(click|type|check|assert|select)\s+/i, '').trim() || sel.slice(0, 50);
     toAdd.push({
       id: 'lib-' + Math.random().toString(36).slice(2, 10),
-      name: step.description || (step.action + ' ' + (sel || '').slice(0, 40)),
-      action: step.action,
-      selector: sel || null,
-      stableSelector: step.stableSelector || sel || null,
-      value: step.value || null,
+      name,
+      selector: sel,
+      stableSelector: step.stableSelector || sel,
+      defaultAction: step.action,
+      defaultValue: step.value || null,
       assertType: step.assertType || null,
       attribute: step.attribute || null,
       description: step.description || null,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "skopix",
-  "version": "2.0.31",
+  "version": "2.0.32",
   "description": "Browser-based QA tool — record tests by using your app, replay them deterministically, generate Playwright code automatically",
   "main": "cli/index.js",
   "bin": {