skopix 2.0.106 → 2.0.107

package/cli/commands/agent.js

@@ -390,61 +390,27 @@ export async function agentCommand(options) {
     const sendRun = (data) => { try { ws.send(JSON.stringify({ type: 'runUpdate', runId, data })); } catch {} };
     const sendRec = (data) => { try { ws.send(JSON.stringify({ type: 'recordingUpdate', recordingId, data })); } catch {} };
     const steps = [];
+    let chromiumBrowser = null;
+    let page = null;
+    let ctx = null;
 
     sendRun({ type: 'stdout', text: '' });
     sendRun({ type: 'stdout', text: '  Replaying ' + replaySteps.length + ' steps to reach debug point...' });
     sendRun({ type: 'stdout', text: '\u2501'.repeat(60) });
 
-    let chromiumBrowser = null;
-    let page = null;
-    let ctx = null;
-
     try {
       const { chromium } = await import('playwright');
       chromiumBrowser = await chromium.launch({ headless: false, args: ['--no-sandbox', '--disable-blink-features=AutomationControlled', '--allow-insecure-localhost'] });
       ctx = await chromiumBrowser.newContext({ viewport: { width: 1280, height: 800 } });
       page = await ctx.newPage();
 
-      if (startUrl) {
-        await page.goto(startUrl, { waitUntil: 'domcontentloaded', timeout: 30000 });
-        await page.waitForTimeout(1000);
-      }
-
-      // Replay steps to debug point
-      let stepNum = 0;
-      let browserClosed = false;
-      for (const step of replaySteps) {
-        if (browserClosed) break;
-        stepNum++;
-        const sel = sanitiseSelector(step.stableSelector || step.selector);
-        const desc = step.description || (step.action + ' ' + (sel || ''));
-        sendRun({ type: 'stdout', text: '  [' + stepNum + '/' + replaySteps.length + '] ' + step.action.toUpperCase() + ' \u2014 ' + desc });
-        try {
-          await executeStep(step, sel, page, { url: startUrl || '' });
-          sendRun({ type: 'stdout', text: '    \u2713 Done' });
-        } catch (err) {
-          const msg2 = err.message || '';
-          if (msg2.includes('closed') || msg2.includes('destroyed') || msg2.includes('detached')) {
-            browserClosed = true;
-            sendRun({ type: 'stdout', text: '    \u2716 Browser closed' });
-          } else {
-            sendRun({ type: 'stdout', text: '    \u26a0 Skipped: ' + msg2.slice(0, 100) });
-          }
-        }
-      }
-
-      sendRun({ type: 'stdout', text: '' });
-      sendRun({ type: 'stdout', text: '  \u2714 Reached debug point \u2014 recording started' });
-      sendRun({ type: 'stdout', text: '  Use the browser, then click Stop.' });
-
-      // Wire up capture — exposeFunction on context persists across navigations
+      // Wire up capture FIRST — must be on context before any page loads
       await ctx.exposeFunction('__skopixCapture', async (actionData) => {
         if (actionData.action === 'stop') {
-          // Send done to close replay SSE, then send recording done
-          sendRun({ type: 'done', exitCode: 0, status: 'passed', recordingId });
-          // Save steps
-          const screenshotDir = path.join(os.homedir(), '.skopix', 'recordings', recordingId);
+          // Mirror stopDebugRecording: send done with steps, then stopped
           sendRec({ type: 'done', steps });
+          sendRec({ type: 'stopped' });
+          try { await ctx.close(); } catch {}
           try { await chromiumBrowser.close(); } catch {}
           ws.send(JSON.stringify({ type: 'jobDone', runId }));
           console.log(chalk.green('  \u2714 Debug recording done \u2014 ' + steps.length + ' new steps'));
@@ -467,7 +433,6 @@ export async function agentCommand(options) {
         sendRec({ type: 'step', step: recStep });
         process.stdout.write(chalk.cyan('    \u23fa ') + (recStep.action || '') + '\n');
         try { await page.evaluate(n => { if (window.__skopixUpdateCount) window.__skopixUpdateCount(n); }, steps.length); } catch {}
-        // Screenshot
         setTimeout(async () => {
           try {
             const screenshotDir = path.join(os.homedir(), '.skopix', 'recordings', recordingId);
@@ -480,9 +445,13 @@ export async function agentCommand(options) {
         }, 400);
       });
 
-      // Inject toolbar + all listeners directly into live page via evaluate
-      // (same approach as solo debug mode in dashboard.js — no reload needed)
-      await page.evaluate(() => {
+      if (startUrl) {
+        await page.goto(startUrl, { waitUntil: 'domcontentloaded', timeout: 30000 });
+        await page.waitForTimeout(500);
+      }
+
+      // Inject toolbar into page BEFORE replay — visible throughout
+            await page.evaluate(() => {
         if (window.__skopixRecording) return;
         window.__skopixRecording = true;
 
@@ -628,7 +597,36 @@ export async function agentCommand(options) {
         });
       });
 
-      // Tell dashboard recording is live — frontend switches to recording SSE
+
+
+      // Replay steps to debug point
+      let stepNum = 0;
+      let browserClosed = false;
+      for (const step of replaySteps) {
+        if (browserClosed) break;
+        stepNum++;
+        const sel = sanitiseSelector(step.stableSelector || step.selector);
+        const desc = step.description || (step.action + ' ' + (sel || ''));
+        sendRun({ type: 'stdout', text: '  [' + stepNum + '/' + replaySteps.length + '] ' + step.action.toUpperCase() + ' \u2014 ' + desc });
+        try {
+          await executeStep(step, sel, page, { url: startUrl || '' });
+          sendRun({ type: 'stdout', text: '    \u2713 Done' });
+        } catch (err) {
+          const emsg = err.message || '';
+          if (emsg.includes('closed') || emsg.includes('destroyed') || emsg.includes('detached')) {
+            browserClosed = true;
+            sendRun({ type: 'stdout', text: '    \u2716 Browser closed' });
+          } else {
+            sendRun({ type: 'stdout', text: '    \u26a0 Skipped: ' + emsg.slice(0, 100) });
+          }
+        }
+      }
+
+      sendRun({ type: 'stdout', text: '' });
+      sendRun({ type: 'stdout', text: '  \u2714 Reached debug point \u2014 now recording' });
+      sendRun({ type: 'stdout', text: '  Use the browser, then click Stop.' });
+
+      // Tell dashboard replay is done — frontend switches to recording SSE
       sendRun({ type: 'done', exitCode: 0, status: 'passed', recordingId });
       process.stderr.write('[debug] toolbar injected, waiting for user actions\n');
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "skopix",
-  "version": "2.0.106",
+  "version": "2.0.107",
   "description": "Browser-based QA tool — record tests by using your app, replay them deterministically, generate Playwright code automatically",
   "main": "cli/index.js",
   "bin": {