skillrepo 3.2.0 → 4.1.0

package/src/test/commands/update.test.mjs

@@ -157,16 +157,26 @@ describe("runUpdate — flag handling", () => {
     assert.ok(dir.startsWith(process.env.HOME));
   });
 
-  it("--ide cursor writes to the project /skills/ fallback", async () => {
+  it("--agent cursor writes to .agents/skills/", async () => {
     server.setLibraryResponse({
       skills: [makeSkill("cursor-test")],
       removals: [],
       syncedAt: "x",
     });
-    await runUpdate(["--key", VALID_KEY, "--url", serverUrl, "--ide", "cursor"]);
-    const dir = resolvePlacementDir("projectFallback", "cursor-test");
+    await runUpdate(["--key", VALID_KEY, "--url", serverUrl, "--agent", "cursor"]);
+    const dir = resolvePlacementDir("agentsProject", "cursor-test");
     assert.ok(existsSync(dir));
   });
+
+  it("rejects --agent none with a validation error (no targets to sync)", async () => {
+    await assert.rejects(
+      () => runUpdate(["--key", VALID_KEY, "--url", serverUrl, "--agent", "none"]),
+      (err) =>
+        err instanceof CliError &&
+        err.exitCode === EXIT_VALIDATION &&
+        /--agent none has no effect on `skillrepo update`/.test(err.message),
+    );
+  });
 });
 
 // ── --session-hook mode (#884) ────────────────────────────────────────
@@ -326,3 +336,138 @@ describe("runUpdate — --session-hook contract", () => {
     assert.equal(stdout.text(), "", "zero-delta 200 is silent");
   });
 });
+
+// ── --silent mode (#1240) ─────────────────────────────────────────────
+//
+// Silent mode is what the cohort SessionStart hooks Cursor / Gemini CLI /
+// Codex CLI / VS Code + Copilot install via the universal command
+// `npx --yes skillrepo update --silent`. Contract:
+//
+//   - stdout produces ONE line on success: `{}` (Gemini's hook stdout
+//     must be valid JSON; the others tolerate empty JSON).
+//   - On failure, stdout writes nothing extra; the typed CliError
+//     propagates and the dispatcher exits non-zero with an stderr
+//     message.
+//   - sync.mjs's non-fatal warnings (e.g. "failed to persist last-sync
+//     state") still go to stderr — operators running `update --silent`
+//     in a terminal still see them.
+//
+// Distinct from `--session-hook`. That mode is exit-0-on-everything
+// because Claude Code blocks session start on hook failures. Cohort
+// vendors do not block, so `--silent` propagates real exit codes.
+
+describe("runUpdate — --silent contract", () => {
+  beforeEach(setup);
+  afterEach(teardown);
+
+  it("accepts the --silent flag without throwing Unknown argument", async () => {
+    // Same regression-guard pattern as the --session-hook test —
+    // resolveFlags would normally reject the flag, so an
+    // acceptPositional callback must consume it.
+    server.setLibraryResponse({ skills: [], removals: [], syncedAt: "x" });
+    await assert.doesNotReject(
+      () =>
+        runUpdate(
+          ["--key", VALID_KEY, "--url", serverUrl, "--silent"],
+          { stdout },
+        ),
+      "update --silent must NOT throw Unknown argument",
+    );
+  });
+
+  it("emits exactly `{}\\n` on a successful empty sync (Gemini contract)", async () => {
+    // INTENT: Gemini specifically requires hook stdout to be valid JSON.
+    // The minimal valid value `{}` injects no model context.
+    server.setLibraryResponse({ skills: [], removals: [], syncedAt: "x" });
+    await runUpdate(
+      ["--key", VALID_KEY, "--url", serverUrl, "--silent"],
+      { stdout },
+    );
+    assert.equal(stdout.text(), "{}\n");
+  });
+
+  it("emits `{}\\n` even when the sync produced changes (no progress lines on stdout)", async () => {
+    server.setLibraryResponse({
+      skills: [makeSkill("silent-test")],
+      removals: [],
+      syncedAt: "x",
+    });
+    await runUpdate(
+      ["--key", VALID_KEY, "--url", serverUrl, "--silent"],
+      { stdout },
+    );
+    // Stdout still ONLY `{}` — progress is not part of the hook
+    // contract. The skill files themselves still landed on disk
+    // (verified separately in the integration tests).
+    assert.equal(stdout.text(), "{}\n");
+  });
+
+  it("propagates a real exit code on failure (does NOT silently swallow errors)", async () => {
+    // INTENT: distinct from --session-hook. Cohort vendors do not
+    // block session start on non-zero hook exit, so a failure should
+    // surface as a typed CliError that the dispatcher maps to the
+    // documented exit code. Silent-on-success does NOT mean
+    // silent-on-failure.
+    server.setForcedStatus(401, { error: "Invalid access key" });
+    await assert.rejects(
+      () =>
+        runUpdate(
+          ["--key", VALID_KEY, "--url", serverUrl, "--silent"],
+          { stdout },
+        ),
+      (err) => err instanceof CliError && err.exitCode === EXIT_AUTH,
+      "auth error must propagate as CliError under --silent",
+    );
+    // No `{}` was written — failure surfaces via the throw, not a
+    // half-success stdout line.
+    assert.equal(stdout.text(), "", "no stdout on failure");
+  });
+
+  it("propagates validation error (e.g. missing --agent value) under --silent", async () => {
+    // resolveFlags throws validationError on a malformed --agent.
+    // Silent mode must NOT catch that — same rationale as the auth
+    // error case.
+    await assert.rejects(
+      () =>
+        runUpdate(
+          ["--key", VALID_KEY, "--url", serverUrl, "--silent", "--agent"],
+          { stdout },
+        ),
+      (err) => err instanceof CliError && err.exitCode === EXIT_VALIDATION,
+    );
+  });
+
+  it("--silent + --session-hook simultaneously: session-hook wins (defensive precedence) (#1239 QA)", async () => {
+    // INTENT: defensive precedence test. The two flags have different
+    // exit-code contracts: --session-hook is exit-0-on-everything
+    // (Claude blocks session start on non-zero), --silent propagates
+    // real exit codes. Today no installer writes a hook command
+    // containing both flags, but a future code path or manual user
+    // edit could. The branches in update.mjs check sessionHook FIRST,
+    // so when both are present, the session-hook contract wins.
+    //
+    // We force a failure (unreachable server) and assert the
+    // resolveFlags-doesnt-throw + emit-failure-line-on-stdout pattern
+    // of session-hook mode, NOT silent mode's exit-non-zero pattern.
+    server.setForcedStatus(401, { error: "bad key" });
+    await assert.doesNotReject(
+      () =>
+        runUpdate(
+          [
+            "--key", VALID_KEY,
+            "--url", serverUrl,
+            "--silent",
+            "--session-hook",
+          ],
+          { stdout },
+        ),
+      "session-hook precedence over --silent must NOT throw on auth failure",
+    );
+    // Session-hook mode emits the one-line failure marker on stdout
+    assert.match(
+      stdout.text(),
+      /\[SkillRepo\] Sync failed:/,
+      "session-hook precedence must produce the session-hook failure line, not silent's empty stdout",
+    );
+  });
+});