skillrepo 2.0.0 → 3.1.0

package/src/lib/write-configs.mjs

@@ -1,202 +0,0 @@
-/**
- * Orchestrates writing all config files based on detected IDEs.
- * Calls individual mergers and collects results.
- *
- * Phase C (#535): Simplified to install standalone hooks and global config.
- * Skill mapping files (.claude/skillrepo.md, .claude/skillrepo-index.json,
- * .claude/skillrepo-config.json) are no longer written — the sync hook
- * handles all skill delivery via .claude/rules/ files.
- */
-
-import { resolve, join } from "node:path";
-import { existsSync, mkdirSync, readdirSync, unlinkSync } from "node:fs";
-import { readFileSafe, writeFileSafe } from "./fs-utils.mjs";
-import { globalSkillrepoDir, globalConfigPath, claudeRulesDir } from "./paths.mjs";
-
-import { mergeClaudeMcpConfig } from "./mergers/claude-mcp.mjs";
-import { mergeCursorMcpConfig } from "./mergers/cursor-mcp.mjs";
-import { mergeWindsurfMcpConfig } from "./mergers/windsurf-mcp.mjs";
-import { mergeVscodeMcpConfig } from "./mergers/vscode-mcp.mjs";
-import { mergeEnvLocal } from "./mergers/env-local.mjs";
-import { mergeGitignore } from "./mergers/gitignore.mjs";
-
-/**
- * Write all configuration files.
- * @param {object} options
- * @param {string[]} options.ides - IDE keys to configure (claudeCode, cursor, windsurf, vscode)
- * @param {string} options.mcpUrl - The MCP endpoint URL
- * @param {string} options.apiKey - The access key
- * @param {string} options.serverUrl - The SkillRepo server URL (e.g. https://skillrepo.dev)
- * @param {string} [options.userId] - The authenticated user's SkillRepo ID
- * @returns {{ path: string; action: string }[]}
- */
-export function writeAllConfigs({ ides, mcpUrl, apiKey, serverUrl, userId }) {
-  const results = [];
-
-  // ── Global config (shared across all projects) ────────────────────────
-  const globalConfigAction = writeGlobalConfig(apiKey, serverUrl, userId);
-  results.push({ path: "~/.claude/skillrepo/config.json", action: globalConfigAction });
-
-  // Claude Code
-  if (ides.includes("claudeCode")) {
-    results.push(mergeClaudeMcpConfig(mcpUrl));
-
-    // Create .claude/rules/ directory for skill delivery
-    const rulesDir = claudeRulesDir();
-    if (!existsSync(rulesDir)) {
-      mkdirSync(rulesDir, { recursive: true });
-      results.push({ path: ".claude/rules/", action: "created" });
-    } else {
-      results.push({ path: ".claude/rules/", action: "skipped" });
-    }
-
-    // Add .gitignore entry for skillrepo rules files
-    results.push(mergeGitignore());
-
-    // Clean up old-format files from pre-Phase C installs.
-    // Write a migration marker BEFORE cleanup so the sync hook can detect
-    // the upgrade and show a one-time "restart session" message.
-    writeMigrationMarker();
-    cleanupLegacyFiles(results);
-  }
-
-  // Cursor
-  if (ides.includes("cursor")) {
-    results.push(mergeCursorMcpConfig(mcpUrl));
-
-    // Clean up old-format ownerless Cursor rules files
-    cleanupLegacyCursorRules(results);
-  }
-
-  // Windsurf
-  if (ides.includes("windsurf")) {
-    results.push(mergeWindsurfMcpConfig(mcpUrl));
-  }
-
-  // VS Code + Copilot
-  if (ides.includes("vscode")) {
-    results.push(mergeVscodeMcpConfig(mcpUrl));
-  }
-
-  // .env.local (always — backward compat for hooks' config fallback)
-  results.push(mergeEnvLocal(apiKey));
-
-  return results;
-}
-
-/**
- * Write the global SkillRepo config file.
- * This is the primary config source for standalone hooks.
- * @returns {"created" | "updated"} The action taken.
- */
-function writeGlobalConfig(apiKey, serverUrl, userId) {
-  const configDir = globalSkillrepoDir();
-  if (!existsSync(configDir)) {
-    mkdirSync(configDir, { recursive: true });
-  }
-
-  const configPath = globalConfigPath();
-  const existingRaw = readFileSafe(configPath);
-
-  // Preserve existing config fields (e.g. maxRulesFiles, maxRulesBudgetBytes)
-  // while always overwriting apiKey, serverUrl, and userId with the new values.
-  let preserved = {};
-  if (existingRaw !== null) {
-    try { preserved = JSON.parse(existingRaw); }
-    catch { /* corrupt config — start fresh */ }
-  }
-  // Always overwrite userId — even if the new value is undefined/null — to
-  // prevent a stale userId from a previous account persisting across re-inits.
-  const { userId: _prevUserId, ...preservedWithoutUserId } = preserved;
-  const config = { ...preservedWithoutUserId, apiKey, serverUrl };
-  if (userId) config.userId = userId;
-
-  writeFileSafe(configPath, JSON.stringify(config, null, 2) + "\n");
-  return existingRaw !== null ? "updated" : "created";
-}
-
-/**
- * Write a migration marker if old-format files exist.
- * The sync hook checks this marker to show a one-time "restart session"
- * message, then deletes it. This is needed because init cleans up old
- * files before the sync hook runs, so the hook can't detect the upgrade
- * by looking for old files directly.
- */
-function writeMigrationMarker() {
-  const markerPath = join(process.cwd(), ".claude", "skillrepo-migrated");
-  const oldFiles = [
-    join(process.cwd(), ".claude", "skillrepo-config.json"),
-    join(process.cwd(), ".claude", "skillrepo.md"),
-  ];
-
-  const hasOldFiles = oldFiles.some(f => existsSync(f));
-  if (hasOldFiles) {
-    writeFileSafe(markerPath, new Date().toISOString() + "\n");
-  }
-}
-
-/**
- * Remove old-format files from pre-Phase C installs.
- * These files are replaced by the sync hook's rules-based delivery.
- */
-function cleanupLegacyFiles(results) {
-  const legacyFiles = [
-    { path: ".claude/skillrepo.md", abs: join(process.cwd(), ".claude", "skillrepo.md") },
-    { path: ".claude/skillrepo-index.json", abs: join(process.cwd(), ".claude", "skillrepo-index.json") },
-    { path: ".claude/skillrepo-config.json", abs: join(process.cwd(), ".claude", "skillrepo-config.json") },
-  ];
-
-  for (const file of legacyFiles) {
-    try {
-      unlinkSync(file.abs);
-      results.push({ path: file.path, action: "removed" });
-    } catch {
-      // File doesn't exist — nothing to clean up
-    }
-  }
-}
-
-/**
- * Remove old-format ownerless Cursor rules files.
- * Pre-Phase C used `.cursor/rules/skillrepo-{name}.mdc` without owner prefix.
- * Phase B+ uses `.cursor/rules/skillrepo-{owner}-{name}.mdc`.
- *
- * Heuristic: a file is old-format if its name after "skillrepo-" contains
- * no hyphen (single segment = name only) or matches known ownerless patterns.
- * Since owner slugs always contain at least one character and names always
- * contain at least one character, the new format always has at least two
- * segments after "skillrepo-" separated by a hyphen.
- *
- * We detect ownerless files by checking: after stripping "skillrepo-" prefix
- * and ".mdc" suffix, if the remainder has no hyphen, it's definitely ownerless.
- * If it has hyphens, we can't distinguish (could be owner-name or multi-word name).
- * For safety, we only clean up the definitely-ownerless ones.
- */
-function cleanupLegacyCursorRules(results) {
-  const cursorRulesDir = join(process.cwd(), ".cursor", "rules");
-  let entries;
-  try { entries = readdirSync(cursorRulesDir); }
-  catch { return; }
-
-  for (const entry of entries) {
-    if (!entry.startsWith("skillrepo-") || !entry.endsWith(".mdc")) continue;
-
-    // The aggregate file (skillrepo.mdc) is also legacy — handled by sync hook
-    const baseName = entry.slice("skillrepo-".length, -".mdc".length);
-
-    // Old format: skillrepo-{name}.mdc (no owner prefix, no hyphen in baseName)
-    // New format: skillrepo-{owner}-{name}.mdc (at least one hyphen)
-    if (!baseName.includes("-")) {
-      try {
-        unlinkSync(join(cursorRulesDir, entry));
-        results.push({ path: `.cursor/rules/${entry}`, action: "removed" });
-      } catch { /* ignore */ }
-    }
-  }
-
-  // Also remove the aggregate skillrepo.mdc (no longer used)
-  try {
-    unlinkSync(join(cursorRulesDir, "skillrepo.mdc"));
-    results.push({ path: ".cursor/rules/skillrepo.mdc", action: "removed" });
-  } catch { /* doesn't exist */ }
-}

package/src/test/e2e/HANDOFF.md

@@ -1,223 +0,0 @@
-# CLI E2E Test Harness — Handoff
-
-## What This Is
-
-A new agent needs to build a CLI E2E test platform for SkillRepo's `npx skillrepo init` command. The feature code is complete and merged (PR #479). The CLI E2E tests are the missing piece — no test code has been written yet, only the branch and directory exist.
-
-## Current State
-
-**Branch:** `feat/457-cli-e2e-tests` (off `feat/457-integration`)
-**Directory created:** `packages/cli/src/test/e2e/` (empty)
-**Approved plan:** `/Users/jpace/.claude/plans/valiant-scribbling-whisper.md`
-
-## What Was Built (the feature being tested)
-
-Epic #457: "Deterministic Skill Injection — Cross-Integration Architecture"
-
-The CLI (`npx skillrepo init`) now generates:
-
-**Claude Code files:**
-- `.claude/skillrepo.md` — skill reference
-- `.claude/skillrepo-index.json` — skill index with `contextSignals` (files, project, tasks)
-- `.claude/skillrepo-config.json` — version 2 config with `signals` array and `companions` map
-- `.claude/hooks/skillrepo-pretool-match.mjs` — PreToolUse hook (dynamic signal map + glob matching)
-- `.claude/settings.local.json` — hook registration (merged with existing)
-- `.mcp.json` — MCP server config
-
-**Cursor files:**
-- `.cursor/rules/skillrepo-{name}.mdc` — per-skill rules with `globs` for file-based activation
-- `.cursor/rules/skillrepo.mdc` — aggregate `alwaysApply` rule for skills without file signals
-- `.cursor/hooks.json` — registers `sessionStart` hook
-- `.cursor/hooks/skillrepo-session.mjs` — session hook with repo profiling + project-aware context
-- `.cursor/skillrepo-index.json` — skill index (same as Claude Code)
-- `.cursor/mcp.json` — MCP server config
-
-**Both:**
-- `.env.local` — `SKILLREPO_ACCESS_KEY=...`
-
-## Key Code Paths
-
-| File | What it does |
-|------|-------------|
-| `packages/cli/bin/skillrepo.mjs` | CLI entry point |
-| `packages/cli/src/commands/init.mjs` | Init command: detect IDEs → prompt for key → fetch payload → write configs |
-| `packages/cli/src/lib/http.mjs` | `fetchSetupPayload(apiKey, baseUrl)` — GET `/api/v1/setup` with Bearer auth |
-| `packages/cli/src/lib/write-configs.mjs` | Orchestrates all file writes per IDE, includes path traversal protection |
-| `packages/cli/src/lib/paths.mjs` | All output file path constants |
-| `packages/cli/src/lib/detect-ides.mjs` | Scans for `.claude/`, `.cursor/`, `.vscode/` directories |
-| `packages/cli/src/lib/fs-utils.mjs` | `readFileSafe()`, `writeFileSafe()` |
-| `packages/cli/src/lib/mergers/` | Individual mergers for settings.local.json, mcp.json, etc. |
-| `src/lib/setup/generate.ts` | Server-side: `generateSetupPayload()` produces the full payload |
-
-## The HTTP Contract
-
-The CLI makes ONE HTTP call:
-
-```
-GET {baseUrl}/api/v1/setup
-Authorization: Bearer sk_live_...
-Accept: application/json
-User-Agent: skillrepo-cli/1.0.0
-```
-
-Response is a `SetupPayload` JSON object (see `src/lib/setup/generate.ts` for the type).
-
-## What To Build
-
-### Approach: Subprocess + Mock HTTP Server
-
-Tests run the actual CLI binary (`node bin/skillrepo.mjs init`) as a child process against a lightweight mock HTTP server. This tests what users actually experience.
-
-### Test Runner
-
-Use `node:test` (Node.js built-in) — consistent with existing CLI tests in `packages/cli/src/test/`. Coverage via `c8` wrapping the subprocess.
-
-### Files To Create
-
-| File | Purpose |
-|------|---------|
-| `packages/cli/src/test/e2e/mock-server.mjs` | Minimal `node:http` server returning configurable `SetupPayload` |
-| `packages/cli/src/test/e2e/payload-factory.mjs` | Builds realistic payloads with various skill configurations |
-| `packages/cli/src/test/e2e/cli-init.test.mjs` | Full init flow E2E tests |
-
-### Mock Server Requirements
-
-- Listens on random available port
-- Serves `GET /api/v1/setup` with configurable payload
-- Validates `Authorization: Bearer sk_live_...` header
-- Returns 401 for invalid/missing keys
-- Returns 200 with payload for valid keys
-- Shuts down cleanly after tests
-
-### Payload Factory Requirements
-
-Must generate `SetupPayload` objects matching what `generateSetupPayload()` produces.
-
-Phase D (#534) stripped the payload to a minimal shape — the CLI only uses `skillCount`.
-All other setup work (hooks, rules, sync) is handled by standalone scripts bundled
-with the CLI package.
-
-Reference `src/lib/setup/generate.ts` for the exact `SetupPayload` type:
-
-```typescript
-interface SetupPayload {
-  skillCount: number;
-  mcpUrl: string;
-}
-```
-
-### Test Cases (goal-driven, not implementation-driven)
-
-Tests verify OUTCOMES ("does this produce a working setup?") not IMPLEMENTATION ("does the string contain this function name?").
-
-**1. Full Init Flow**
-- `init --yes --url http://localhost:{port} --key sk_live_test` in a temp dir produces all expected files
-- Running init twice produces correct merge behavior (updated, not duplicated)
-- Invalid API key returns clean auth error message
-- Unreachable server returns clean network error message
-
-**2. Generated Files Are Structurally Valid**
-- All JSON files (`skillrepo-config.json`, `skillrepo-index.json`, `hooks.json`, `settings.local.json`, `mcp.json`) parse without error
-- YAML frontmatter in `.mdc` files parses correctly (including descriptions with colons)
-- Hook scripts compile as valid JavaScript (`vm.compileFunction` or `new Function()`)
-
-**3. Signal Map Works End-to-End**
-- Extract `matchGlob` from the generated PreToolUse hook script, eval it, and test against real file paths:
-  - `**/*.tsx` matches `src/components/Button.tsx` ✓
-  - `**/*.tsx` does NOT match `src/utils/helper.ts` ✗
-  - `**/*.test.*` matches `tests/foo.test.ts` ✓
-  - `**/api/**/route.ts` matches `src/app/api/users/route.ts` ✓
-  - `**/*.{ts,tsx}` does not crash (regex metachar escaping) ✓
-- Extract `extractFilePath` and verify it parses tool input correctly
-- Extract `scoreSkills` and verify: task signals = 3x weight, keywords = 1x
-- Extract `applyProfileMultiplier` and verify: matching project = 1.5x, no match = 0.3x, no tags = 1.0x
-
-**4. Cursor Output Goals**
-- Skills with `contextSignals.files` produce per-skill `.mdc` with `globs` frontmatter
-- Skills without file signals go to aggregate `skillrepo.mdc` with `alwaysApply: true`
-- No skill appears in both per-skill AND aggregate files
-- `hooks.json` is valid JSON with `sessionStart` event
-- Session hook script produces valid `additional_context` JSON when executed
-
-**5. Claude Code Output Goals**
-- Config has `version: 2` and parseable `signals` array
-- Signal entries have toolName, files, project, tasks fields
-- Companions are correctly resolved
-- All three hooks registered in `settings.local.json`
-- Sync hook contains repo profiling logic
-
-**6. Repo Profiling**
-- In a simulated Next.js project (temp dir with `package.json` containing `next`, `react`), the sync hook's profiling code detects the correct frameworks
-- Execute the profiling section of the generated sync hook and verify the output
-
-**7. Security**
-- Server-supplied `.mdc` path outside `.cursor/` is rejected with error (path traversal protection)
-
-### How To Extract and Test Generated Functions
-
-The generated hook scripts are JavaScript strings. To test functions like `matchGlob`:
-
-```javascript
-import { readFileSync } from 'fs';
-
-// Read the generated hook script
-const script = readFileSync('.claude/hooks/skillrepo-pretool-match.mjs', 'utf-8');
-
-// Extract matchGlob function
-const matchGlobMatch = script.match(/function matchGlob\(filePath, pattern\) \{[\s\S]*?\n\}/);
-const matchGlobBody = matchGlobMatch[0]
-  .replace(/^function matchGlob\(filePath, pattern\) \{/, '')
-  .replace(/\}$/, '');
-const matchGlob = new Function('filePath', 'pattern', matchGlobBody);
-
-// Now test it
-assert.strictEqual(matchGlob('src/components/Button.tsx', '**/*.tsx'), true);
-assert.strictEqual(matchGlob('src/utils/helper.ts', '**/*.tsx'), false);
-```
-
-### Existing Test Patterns to Follow
-
-Look at `packages/cli/src/test/` for the established patterns:
-- `detect-ides.test.mjs` — temp directory creation, `process.cwd()` override
-- `env-local.test.mjs` — `.env.local` merge behavior
-
-All use `node:test`, `node:assert`, `mkdtempSync`, `rmSync` for cleanup.
-
-### Coverage
-
-Use `c8` to instrument the CLI subprocess. Add to root `package.json`:
-
-```json
-"test:cli-e2e": "cd packages/cli && c8 node --test src/test/e2e/*.test.mjs"
-```
-
-Coverage output should be merged into the overall codecov upload in `.github/workflows/e2e.yml`.
-
-### Running the Tests
-
-```bash
-# From repo root
-cd packages/cli && node --test src/test/e2e/cli-init.test.mjs
-
-# With coverage
-cd packages/cli && c8 node --test src/test/e2e/cli-init.test.mjs
-```
-
-## Important Rules (from CLAUDE.md and memory)
-
-- NEVER edit `.claude/` generated files directly — modify generators in `src/lib/setup/generate.ts`
-- NEVER run tests against production — require explicit `DATABASE_URL_E2E` (this harness doesn't need a DB since it mocks the HTTP server)
-- Always use GitHub Issues, never Asana
-- Run `npm run check` before considering work complete
-- CLI is at `packages/cli/` — it's a standalone package with its own `package.json`
-- CLI version is currently 1.6.0 — bump if CLI code changes
-
-## References
-
-- Epic: https://github.com/atxpace/skill-repo/issues/457
-- Integration PR (merged): https://github.com/atxpace/skill-repo/pull/479
-- Review fixes PR: https://github.com/atxpace/skill-repo/pull/480
-- Approved plan: `/Users/jpace/.claude/plans/valiant-scribbling-whisper.md`
-- Existing CLI tests: `packages/cli/src/test/`
-- Server-side generator: `src/lib/setup/generate.ts`
-- CLI write orchestrator: `packages/cli/src/lib/write-configs.mjs`

package/src/test/e2e/cli-init.test.mjs

@@ -1,213 +0,0 @@
-/**
- * CLI E2E tests for `skillrepo init`.
- *
- * Spins up a mock HTTP server, runs the real CLI binary as a subprocess,
- * and verifies the generated setup actually works — not just that files exist.
- *
- * Uses node:test + node:assert — zero external dependencies.
- *
- * IMPORTANT: The CLI is run via async `execFile` (not `execFileSync`).
- * execFileSync would block the Node event loop and starve the mock HTTP
- * server running in the same process, causing the CLI's fetch to hang.
- */
-
-import { describe, it, before, after, beforeEach, afterEach } from "node:test";
-import assert from "node:assert/strict";
-import {
-  mkdtempSync, mkdirSync, rmSync, readFileSync, writeFileSync,
-  existsSync,
-} from "node:fs";
-import { join, resolve, dirname } from "node:path";
-import { tmpdir } from "node:os";
-import { execFile } from "node:child_process";
-import { fileURLToPath } from "node:url";
-
-import { createMockServer } from "./mock-server.mjs";
-import { buildPayload } from "./payload-factory.mjs";
-
-const __dirname = dirname(fileURLToPath(import.meta.url));
-const CLI_BIN = resolve(__dirname, "../../../bin/skillrepo.mjs");
-const API_KEY = "sk_live_test123";
-
-// ---------------------------------------------------------------------------
-// Helpers
-// ---------------------------------------------------------------------------
-
-/**
- * Run the CLI init command against a mock server in a given cwd.
- * Returns a promise that resolves with stdout on success.
- */
-function runInit(cwd, port, { key = API_KEY, extraArgs = [] } = {}) {
-  return new Promise((resolve, reject) => {
-    execFile(
-      process.execPath,
-      [CLI_BIN, "init", "--url", `http://127.0.0.1:${port}`, "--key", key, "--yes", ...extraArgs],
-      { cwd, encoding: "utf-8", timeout: 15_000, env: { ...process.env, NODE_NO_WARNINGS: "1" } },
-      (err, stdout, stderr) => {
-        if (err) return reject(Object.assign(err, { stdout, stderr }));
-        resolve(stdout);
-      },
-    );
-  });
-}
-
-/** Run the CLI and expect it to fail. Returns { stdout, stderr, status }. */
-function runInitExpectFail(cwd, port, { key = API_KEY } = {}) {
-  return new Promise((resolve) => {
-    execFile(
-      process.execPath,
-      [CLI_BIN, "init", "--url", `http://127.0.0.1:${port}`, "--key", key, "--yes"],
-      { cwd, encoding: "utf-8", timeout: 15_000, env: { ...process.env, NODE_NO_WARNINGS: "1" } },
-      (err, stdout, stderr) => {
-        if (err) {
-          resolve({ stdout: stdout ?? "", stderr: stderr ?? "", status: err.code ?? 1 });
-        } else {
-          resolve({ stdout, stderr: "", status: 0 });
-        }
-      },
-    );
-  });
-}
-
-/** Read a file from the temp dir. */
-function readFile(dir, relPath) {
-  return readFileSync(join(dir, relPath), "utf-8");
-}
-
-/** Check if a file exists in the temp dir. */
-function fileExists(dir, relPath) {
-  return existsSync(join(dir, relPath));
-}
-
-/** Parse JSON from a file in the temp dir. */
-function readJSON(dir, relPath) {
-  return JSON.parse(readFile(dir, relPath));
-}
-
-/** Create a fresh temp dir with .claude/ and .cursor/ markers. */
-function makeTempDir() {
-  const dir = mkdtempSync(join(tmpdir(), "cli-e2e-"));
-  mkdirSync(join(dir, ".claude"), { recursive: true });
-  mkdirSync(join(dir, ".cursor"), { recursive: true });
-  return dir;
-}
-
-// ---------------------------------------------------------------------------
-// Test suite
-// ---------------------------------------------------------------------------
-
-describe("CLI E2E: skillrepo init", () => {
-  let server;
-  let port;
-  let tempDir;
-
-  before(async () => {
-    server = createMockServer({});
-    port = await server.start();
-    const payload = buildPayload({ baseUrl: `http://127.0.0.1:${port}` });
-    server.setPayload(payload);
-  });
-
-  after(async () => {
-    if (server) await server.stop();
-  });
-
-  beforeEach(() => {
-    tempDir = makeTempDir();
-  });
-
-  afterEach(() => {
-    if (tempDir) rmSync(tempDir, { recursive: true, force: true });
-  });
-
-  // =========================================================================
-  // 1. MCP Config
-  // =========================================================================
-
-  it(".mcp.json is created with MCP server config", async () => {
-    await runInit(tempDir, port);
-
-    const mcp = readJSON(tempDir, ".mcp.json");
-    assert.ok(mcp.mcpServers?.skillrepo, "Should have skillrepo MCP server entry");
-  });
-
-  it(".env.local contains the API key", async () => {
-    await runInit(tempDir, port);
-
-    const envContent = readFile(tempDir, ".env.local");
-    assert.ok(envContent.includes(`SKILLREPO_ACCESS_KEY=${API_KEY}`));
-  });
-
-  // =========================================================================
-  // 2. Error Handling
-  // =========================================================================
-
-  it("invalid API key (401) exits with error", async () => {
-    const srv = createMockServer({}, { validKey: "sk_live_onlythisone" });
-    const p = await srv.start();
-    const payload = buildPayload({ baseUrl: `http://127.0.0.1:${p}` });
-    srv.setPayload(payload);
-
-    try {
-      const result = await runInitExpectFail(tempDir, p, { key: "sk_live_wrongkey" });
-      assert.notEqual(result.status, 0);
-      const output = result.stdout + result.stderr;
-      assert.ok(output.toLowerCase().includes("invalid") || output.toLowerCase().includes("error"));
-    } finally {
-      await srv.stop();
-    }
-  });
-
-  it("unreachable server exits with error", async () => {
-    const result = await runInitExpectFail(tempDir, 19999);
-    assert.notEqual(result.status, 0);
-    const output = result.stdout + result.stderr;
-    assert.ok(
-      output.toLowerCase().includes("cannot reach") ||
-      output.toLowerCase().includes("error") ||
-      output.toLowerCase().includes("econnrefused"),
-    );
-  });
-
-  // =========================================================================
-  // 3. Generated Files Are Structurally Valid
-  // =========================================================================
-
-  it("all JSON files parse without error", async () => {
-    await runInit(tempDir, port);
-
-    for (const f of [".mcp.json"]) {
-      assert.doesNotThrow(() => readJSON(tempDir, f), `Invalid JSON: ${f}`);
-    }
-  });
-
-  // =========================================================================
-  // 4. .gitignore and old format cleanup
-  // =========================================================================
-
-  it("old format files are cleaned up during migration", async () => {
-    // Create old format files before init
-    writeFileSync(join(tempDir, ".claude/skillrepo.md"), "# Old skillrepo md");
-    writeFileSync(join(tempDir, ".claude/skillrepo-index.json"), '{"version":1}');
-    writeFileSync(join(tempDir, ".claude/skillrepo-config.json"), '{"version":2}');
-
-    await runInit(tempDir, port);
-
-    // Old format files should be removed
-    assert.ok(!fileExists(tempDir, ".claude/skillrepo.md"), "Old .claude/skillrepo.md should be removed");
-    assert.ok(!fileExists(tempDir, ".claude/skillrepo-index.json"), "Old .claude/skillrepo-index.json should be removed");
-    assert.ok(!fileExists(tempDir, ".claude/skillrepo-config.json"), "Old .claude/skillrepo-config.json should be removed");
-  });
-
-  // =========================================================================
-  // 5. No hook files generated (hooks removed in v1)
-  // =========================================================================
-
-  it("does not generate hook files", async () => {
-    await runInit(tempDir, port);
-
-    assert.ok(!fileExists(tempDir, ".claude/hooks/skillrepo-sync.mjs"), "Sync hook should not exist");
-    assert.ok(!fileExists(tempDir, ".claude/hooks/skillrepo-prompt-match.mjs"), "Prompt-match hook should not exist");
-    assert.ok(!fileExists(tempDir, ".claude/hooks/skillrepo-pretool-activation.mjs"), "PreToolUse hook should not exist");
-  });
-});

package/src/test/e2e/payload-factory.mjs

@@ -1,22 +0,0 @@
-/**
- * Factory for SetupPayload objects used in CLI E2E tests.
- *
- * Phase D (#534): The setup endpoint now returns only `skillCount` and
- * `mcpUrl`. All hook/rule/config generation was removed — standalone
- * scripts bundled with the CLI handle everything.
- */
-
-/**
- * Build a SetupPayload for E2E tests.
- *
- * @param {object} [options]
- * @param {string} [options.baseUrl] - The base URL for the mock server
- * @returns {object} A SetupPayload
- */
-export function buildPayload(options = {}) {
-  const baseUrl = options.baseUrl ?? "http://localhost:9999";
-  return {
-    skillCount: 5,
-    mcpUrl: `${baseUrl}/api/mcp`,
-  };
-}