skillmds 1.0.16 → 1.0.18

package/CHANGELOG.md

@@ -2,6 +2,11 @@
 
 All notable changes to `skillmds` are documented here. Versions follow [semver](https://semver.org).
 
+## 1.0.18
+
+- **Cleaner tool output for agents.** `skillmd_search`, `skillmd_trending`, and `skillmd_recommend` no longer echo site-oriented fields (`avg_rating`, `rating_count`, `install_count`, `save_count`, `verified`, `type`, `owner_avatar`, `category_slug`, and the internal `confident` ranker flag). Results now carry just what an agent needs to pick a skill: slug, title, description, category, agents, repo stars, and the install snippet.
+- **Quality score no longer punishes ordinary skills.** The security flags (`reads_secrets`, `network_calls`, `executes_scripts`) are pattern matches against prose and code samples, not proof of anything unsafe — they now cost 2/1/5 points respectively (was 25/8/15), so a skill that merely documents an env var or a URL keeps its high score. Verified skills are floored at 85 (unless the content fails to parse). `skillmd_lint` passes a skill's verified status through to the score.
+
 ## 1.0.16
 
 - **Installs are no longer gated on verification.** Any skill installs directly — verified or not — with no flag, no prompt, and no second step, from both the CLI (`skillmd add`) and the MCP `skillmd_install` tool. Security flags (network_calls, executes_scripts, reads_secrets, docs_only) are still shown on the result as information, but never block. `--deny <flag>` remains available as an opt-in for anyone who wants to exclude a flag; `--allow-unverified` is now a no-op kept for backward compatibility.

package/bin/skillmd-mcp.mjs

@@ -14,7 +14,7 @@ import { CallToolRequestSchema, ListToolsRequestSchema } from "@modelcontextprot
 import { mkdir, writeFile } from "node:fs/promises";
 import { readFileSync } from "node:fs";
 import { homedir } from "node:os";
-import { join, resolve } from "node:path";
+import { join, resolve, dirname, sep } from "node:path";
 import { stringify as stringifyYaml } from "yaml";
 
 const VERSION = (() => {
@@ -45,10 +45,27 @@ async function api(path, init = {}) {
 }
 const text = (obj) => ({ content: [{ type: "text", text: typeof obj === "string" ? obj : JSON.stringify(obj, null, 2) }] });
 
+// The public API returns site-oriented fields (ratings, counters, avatars,
+// ranker internals) that are noise for an agent picking a skill. Strip them
+// from every list-returning tool so results stay compact and rankable only
+// on what matters to the caller.
+const OMIT_FIELDS = new Set([
+  "type",
+  "verified",
+  "avg_rating",
+  "rating_count",
+  "install_count",
+  "save_count",
+  "owner_avatar",
+  "confident",
+  "category_slug",
+]);
+const trimItems = (items) => (items ?? []).map((s) => Object.fromEntries(Object.entries(s).filter(([k]) => !OMIT_FIELDS.has(k))));
+
 const TOOLS = [
   {
     name: "skillmd_search",
-    description: "Search SkillMD for Agent Skills by name, description, or task. Returns matching skills with ratings and install snippets.",
+    description: "Search SkillMD for Agent Skills by name, description, or task. Returns matching skills with their owner/name slug and install snippets.",
     inputSchema: {
       type: "object",
       properties: {
@@ -138,7 +155,7 @@ async function handleCall(name, args) {
       if (args.type) p.set("type", args.type);
       if (args.min_rating != null) p.set("min_rating", String(args.min_rating));
       const r = await api(`/api/search?${p}`);
-      return text(r.items ?? []);
+      return text(trimItems(r.items));
     }
     case "skillmd_get": {
       const [owner, slugName] = String(args.slug).split("/");
@@ -149,7 +166,7 @@ async function handleCall(name, args) {
       const p = new URLSearchParams({ range: args.range ?? "all", limit: String(args.limit ?? 20) });
       if (args.category) p.set("category", args.category);
       const r = await api(`/api/leaderboard?${p}`);
-      return text(r.items ?? []);
+      return text(trimItems(r.items));
     }
     case "skillmd_recommend": {
       if (args.based_on) {
@@ -157,11 +174,11 @@ async function handleCall(name, args) {
         const base = await api(`/api/skills/${owner}/${slugName}`).catch(() => null);
         if (base?.category_slug) {
           const r = await api(`/api/leaderboard?range=all&limit=${args.limit ?? 10}&category=${base.category_slug}`);
-          return text((r.items ?? []).filter((s) => s.slug !== args.based_on));
+          return text(trimItems(r.items).filter((s) => s.slug !== args.based_on));
         }
       }
       const r = await api(`/api/leaderboard?range=30d&limit=${args.limit ?? 10}`);
-      return text(r.items ?? []);
+      return text(trimItems(r.items));
     }
     case "skillmd_list_saved": {
       if (!TOKEN) return text("Set SKILLMD_TOKEN (a SkillMD personal access token) to list your saved skills.");
@@ -172,14 +189,16 @@ async function handleCall(name, args) {
       if (!lint) return text("Validation engine unavailable — run `npm run build` in the skillmds package.");
       let raw = args.content;
       let slug;
+      let verified = false;
       if (!raw && args.slug) {
         const [owner, slugName] = String(args.slug).split("/");
         const skill = await api(`/api/skills/${owner}/${slugName}`);
         raw = reconstructSkillMd(skill);
         slug = slugName;
+        verified = !!skill.verified;
       }
       if (!raw) return text("Provide `content` (raw SKILL.md) or `slug` (owner/name).");
-      const result = lint(raw, slug ? { slug } : {});
+      const result = lint(raw, { ...(slug ? { slug } : {}), verified });
       return text({ ok: result.ok, score: result.score, diagnostics: result.diagnostics, security: result.security });
     }
     case "skillmd_install": {
@@ -205,13 +224,45 @@ async function handleCall(name, args) {
       const baseDir = args.dest ? resolve(args.dest) : join(homedir(), ".claude", "skills");
       const dir = join(baseDir, slugName);
       await mkdir(dir, { recursive: true });
-      const file = join(dir, "SKILL.md");
-      await writeFile(file, raw, "utf8");
+      const root = resolve(dir);
+
+      // Zip-slip guard: refuse any path that resolves outside the skill's dir.
+      const writeSafe = async (relPath, contents) => {
+        const fp = resolve(dir, relPath);
+        if (fp !== root && !fp.startsWith(root + sep)) throw new Error(`unsafe path: ${relPath}`);
+        await mkdir(dirname(fp), { recursive: true });
+        await writeFile(fp, contents);
+      };
+
+      let written = 1;
+      let note = "";
+      if (skill.type === "pack") {
+        // Pull the full pack (SKILL.md + companion files) in one call. The JSON
+        // bundle avoids adding an unzip dependency to this standalone binary.
+        try {
+          const bundle = await api(`/api/skills/${owner}/${slugName}/bundle?format=json`);
+          for (const f of bundle.files ?? []) {
+            if (f.path.includes("..") || f.path.startsWith("/")) continue;
+            let buf;
+            if (f.content_base64 != null) buf = Buffer.from(f.content_base64, "base64");
+            else if (f.source_url) {
+              const r = await fetch(f.source_url).catch(() => null);
+              if (!r || !r.ok) continue;
+              buf = Buffer.from(await r.arrayBuffer());
+            } else continue;
+            await writeSafe(f.path, f.path === "SKILL.md" ? raw : buf);
+          }
+          written = (bundle.files ?? []).length || 1;
+          if (!(bundle.files ?? []).some((f) => f.path === "SKILL.md")) await writeSafe("SKILL.md", raw);
+        } catch {
+          await writeSafe("SKILL.md", raw);
+          note = ` NOTE: pack assets could not be fetched — only SKILL.md was written. For the full pack run: npx skillmds add ${args.slug}`;
+        }
+      } else {
+        await writeSafe("SKILL.md", raw);
+      }
       api(`/api/skills/${owner}/${slugName}/install`, { method: "POST", body: JSON.stringify({ via: "mcp" }) }).catch(() => {});
-      const note = skill.type === "pack"
-        ? ` NOTE: this is a pack and only SKILL.md was written — its assets/references are missing. For the full pack run: npx skillmds add ${args.slug}`
-        : "";
-      return text(`Installed ${args.slug} → ${file} (security: ${flags.join(", ") || "unscanned"})${note}`);
+      return text(`Installed ${args.slug} → ${dir} (${written} file${written === 1 ? "" : "s"}; security: ${flags.join(", ") || "unscanned"})${note}`);
     }
     default:
       throw new Error(`Unknown tool: ${name}`);

package/dist/cli.js

@@ -163,16 +163,19 @@ var WEIGHT = {
 };
 var RISK = {
   docs_only: 0,
-  reads_secrets: 25,
-  executes_scripts: 15,
-  network_calls: 8
+  reads_secrets: 2,
+  network_calls: 1,
+  executes_scripts: 5
 };
-function qualityScore(diagnostics, security) {
+var VERIFIED_FLOOR = 85;
+function qualityScore(diagnostics, security, opts = {}) {
   let penalty = diagnostics.reduce((sum, d) => sum + WEIGHT[d.severity], 0);
   if (security) {
     for (const flag of security.flags) penalty += RISK[flag] ?? 0;
   }
-  return Math.max(0, Math.min(100, 100 - penalty));
+  const score = Math.max(0, Math.min(100, 100 - penalty));
+  const hasError = diagnostics.some((d) => d.severity === "error");
+  return opts.verified && !hasError ? Math.max(score, VERIFIED_FLOOR) : score;
 }
 
 // ../../packages/core/src/lint.ts
@@ -185,14 +188,14 @@ function lint(raw, opts = {}) {
       ok: false,
       diagnostics: diagnostics2,
       security: security2,
-      score: qualityScore(diagnostics2, security2)
+      score: qualityScore(diagnostics2, security2, { verified: opts.verified })
     };
   }
   const ctx = opts.slug !== void 0 ? { slug: opts.slug } : {};
   const diagnostics = runRules(parsed, ctx);
   const security = scanSecurity(parsed.body);
   const ok = !diagnostics.some((d) => d.severity === "error");
-  return { ok, skill: parsed, diagnostics, security, score: qualityScore(diagnostics, security) };
+  return { ok, skill: parsed, diagnostics, security, score: qualityScore(diagnostics, security, { verified: opts.verified }) };
 }
 
 // ../../packages/core/src/format/text.ts
@@ -779,7 +782,25 @@ function createClient(flags = {}) {
     }
     return await res.json();
   }
-  return { api, base, hasToken: Boolean(token) };
+  return { api, base, token, hasToken: Boolean(token) };
+}
+async function fetchBundle(base, slug, token) {
+  const headers = { accept: "application/json" };
+  if (token) headers.authorization = `Bearer ${token}`;
+  const res = await fetch(`${base}/api/skills/${slug}/bundle?format=json`, { headers }).catch(() => null);
+  if (!res || !res.ok) return null;
+  const data = await res.json().catch(() => null);
+  if (!data?.files) return null;
+  const out = [];
+  for (const f of data.files) {
+    if (f.content_base64 != null) {
+      out.push({ path: f.path, contents: Buffer.from(f.content_base64, "base64") });
+    } else if (f.source_url) {
+      const r = await fetch(f.source_url).catch(() => null);
+      if (r && r.ok) out.push({ path: f.path, contents: Buffer.from(await r.arrayBuffer()) });
+    }
+  }
+  return out;
 }
 function skillMdFor(skill) {
   if (skill.raw_md) return skill.raw_md;
@@ -901,7 +922,7 @@ import pc7 from "picocolors";
 // ../cli/src/agents.ts
 import { mkdirSync as mkdirSync3, writeFileSync as writeFileSync4, rmSync as rmSync2, symlinkSync, existsSync as existsSync3, readdirSync as readdirSync2, statSync as statSync2, readFileSync as readFileSync3 } from "fs";
 import { homedir as homedir3 } from "os";
-import { join as join4, resolve as resolve2, dirname as dirname2 } from "path";
+import { join as join4, resolve as resolve2, dirname as dirname2, sep as sep2 } from "path";
 var AGENTS = [
   { id: "claude-code", segments: [".claude", "skills"] },
   { id: "cursor", segments: [".cursor", "skills"] },
@@ -919,6 +940,9 @@ function detectAgents(opts = {}) {
   return AGENTS.filter((a) => existsSync3(agentDir(a.id, opts))).map((a) => a.id);
 }
 function writeSkill(skillName, files, targetDir, opts = {}) {
+  if (!/^[a-zA-Z0-9][a-zA-Z0-9._-]*$/.test(skillName) || skillName.includes("..")) {
+    throw new Error(`refused unsafe skill name: "${skillName}"`);
+  }
   const dest = join4(targetDir, skillName);
   if (opts.mode === "symlink" && opts.canonicalDir) {
     mkdirSync3(dirname2(dest), { recursive: true });
@@ -927,8 +951,12 @@ function writeSkill(skillName, files, targetDir, opts = {}) {
     return dest;
   }
   mkdirSync3(dest, { recursive: true });
+  const root = resolve2(dest);
   for (const f of files) {
-    const fp = join4(dest, f.path);
+    const fp = resolve2(dest, f.path);
+    if (fp !== root && !fp.startsWith(root + sep2)) {
+      throw new Error(`refused unsafe path in skill "${skillName}": ${f.path}`);
+    }
     mkdirSync3(dirname2(fp), { recursive: true });
     writeFileSync4(fp, f.contents);
   }
@@ -974,12 +1002,12 @@ var defaultDeps = {
       return rs2.map((r) => ({ name: r.slug, raw: r.raw, slug: r.slug }));
     }
     if (/^[^/\s:]+\/[^/\s:]+$/.test(arg)) {
-      const { api } = createClient(flags);
+      const { api, base: apiBase, token } = createClient(flags);
       const [owner, name] = arg.split("/");
       try {
         const skill = await api(`/api/skills/${owner}/${name}`);
         const skillName = skill.slug.split("/")[1] || name;
-        const base = {
+        const meta = {
           name: skillName,
           slug: skillName,
           registrySlug: arg,
@@ -988,10 +1016,15 @@ var defaultDeps = {
           securityFlags: skill.security_flags
         };
         if (skill.type === "pack") {
+          const bundle = await fetchBundle(apiBase, arg, token);
+          if (bundle && bundle.length) {
+            const sk = bundle.find((f) => f.path === "SKILL.md");
+            return [{ ...meta, raw: sk ? sk.contents.toString("utf8") : skillMdFor(skill), files: bundle }];
+          }
           const pack = await resolvePackFiles(skill);
-          if (pack) return [{ ...base, ...pack }];
+          if (pack) return [{ ...meta, ...pack }];
         }
-        return [{ ...base, raw: skillMdFor(skill) }];
+        return [{ ...meta, raw: skillMdFor(skill) }];
       } catch {
       }
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "skillmds",
-  "version": "1.0.16",
+  "version": "1.0.18",
   "description": "SkillMD for agents: the `skillmds` MCP server + the `skillmd` CLI (lint, scan, search, install, publish Agent Skills) from skillmd.com.",
   "type": "module",
   "bin": {

package/vendor/index.js

@@ -169,16 +169,19 @@ var WEIGHT = {
 };
 var RISK = {
   docs_only: 0,
-  reads_secrets: 25,
-  executes_scripts: 15,
-  network_calls: 8
+  reads_secrets: 2,
+  network_calls: 1,
+  executes_scripts: 5
 };
-function qualityScore(diagnostics, security) {
+var VERIFIED_FLOOR = 85;
+function qualityScore(diagnostics, security, opts = {}) {
   let penalty = diagnostics.reduce((sum, d) => sum + WEIGHT[d.severity], 0);
   if (security) {
     for (const flag of security.flags) penalty += RISK[flag] ?? 0;
   }
-  return Math.max(0, Math.min(100, 100 - penalty));
+  const score = Math.max(0, Math.min(100, 100 - penalty));
+  const hasError = diagnostics.some((d) => d.severity === "error");
+  return opts.verified && !hasError ? Math.max(score, VERIFIED_FLOOR) : score;
 }
 
 // ../../packages/core/src/lint.ts
@@ -191,14 +194,14 @@ function lint(raw, opts = {}) {
       ok: false,
       diagnostics: diagnostics2,
       security: security2,
-      score: qualityScore(diagnostics2, security2)
+      score: qualityScore(diagnostics2, security2, { verified: opts.verified })
     };
   }
   const ctx = opts.slug !== void 0 ? { slug: opts.slug } : {};
   const diagnostics = runRules(parsed, ctx);
   const security = scanSecurity(parsed.body);
   const ok = !diagnostics.some((d) => d.severity === "error");
-  return { ok, skill: parsed, diagnostics, security, score: qualityScore(diagnostics, security) };
+  return { ok, skill: parsed, diagnostics, security, score: qualityScore(diagnostics, security, { verified: opts.verified }) };
 }
 
 // ../../packages/core/src/format/text.ts