skillmds 1.0.16 → 1.0.17

package/bin/skillmd-mcp.mjs

@@ -1,4 +1,4 @@
-#!/usr/bin/env node
+#!/usr/bin/env node
 // SkillMD MCP server (stdio). Wraps the public SkillMD API so any MCP-capable agent
 // can search, fetch, install, and discover Agent Skills by name or task.
 //
@@ -14,7 +14,7 @@ import { CallToolRequestSchema, ListToolsRequestSchema } from "@modelcontextprot
 import { mkdir, writeFile } from "node:fs/promises";
 import { readFileSync } from "node:fs";
 import { homedir } from "node:os";
-import { join, resolve } from "node:path";
+import { join, resolve, dirname, sep } from "node:path";
 import { stringify as stringifyYaml } from "yaml";
 
 const VERSION = (() => {
@@ -205,13 +205,45 @@ async function handleCall(name, args) {
       const baseDir = args.dest ? resolve(args.dest) : join(homedir(), ".claude", "skills");
       const dir = join(baseDir, slugName);
       await mkdir(dir, { recursive: true });
-      const file = join(dir, "SKILL.md");
-      await writeFile(file, raw, "utf8");
+      const root = resolve(dir);
+
+      // Zip-slip guard: refuse any path that resolves outside the skill's dir.
+      const writeSafe = async (relPath, contents) => {
+        const fp = resolve(dir, relPath);
+        if (fp !== root && !fp.startsWith(root + sep)) throw new Error(`unsafe path: ${relPath}`);
+        await mkdir(dirname(fp), { recursive: true });
+        await writeFile(fp, contents);
+      };
+
+      let written = 1;
+      let note = "";
+      if (skill.type === "pack") {
+        // Pull the full pack (SKILL.md + companion files) in one call. The JSON
+        // bundle avoids adding an unzip dependency to this standalone binary.
+        try {
+          const bundle = await api(`/api/skills/${owner}/${slugName}/bundle?format=json`);
+          for (const f of bundle.files ?? []) {
+            if (f.path.includes("..") || f.path.startsWith("/")) continue;
+            let buf;
+            if (f.content_base64 != null) buf = Buffer.from(f.content_base64, "base64");
+            else if (f.source_url) {
+              const r = await fetch(f.source_url).catch(() => null);
+              if (!r || !r.ok) continue;
+              buf = Buffer.from(await r.arrayBuffer());
+            } else continue;
+            await writeSafe(f.path, f.path === "SKILL.md" ? raw : buf);
+          }
+          written = (bundle.files ?? []).length || 1;
+          if (!(bundle.files ?? []).some((f) => f.path === "SKILL.md")) await writeSafe("SKILL.md", raw);
+        } catch {
+          await writeSafe("SKILL.md", raw);
+          note = ` NOTE: pack assets could not be fetched — only SKILL.md was written. For the full pack run: npx skillmds add ${args.slug}`;
+        }
+      } else {
+        await writeSafe("SKILL.md", raw);
+      }
       api(`/api/skills/${owner}/${slugName}/install`, { method: "POST", body: JSON.stringify({ via: "mcp" }) }).catch(() => {});
-      const note = skill.type === "pack"
-        ? ` NOTE: this is a pack and only SKILL.md was written — its assets/references are missing. For the full pack run: npx skillmds add ${args.slug}`
-        : "";
-      return text(`Installed ${args.slug} → ${file} (security: ${flags.join(", ") || "unscanned"})${note}`);
+      return text(`Installed ${args.slug} → ${dir} (${written} file${written === 1 ? "" : "s"}; security: ${flags.join(", ") || "unscanned"})${note}`);
     }
     default:
       throw new Error(`Unknown tool: ${name}`);

package/dist/cli.js

@@ -779,7 +779,25 @@ function createClient(flags = {}) {
     }
     return await res.json();
   }
-  return { api, base, hasToken: Boolean(token) };
+  return { api, base, token, hasToken: Boolean(token) };
+}
+async function fetchBundle(base, slug, token) {
+  const headers = { accept: "application/json" };
+  if (token) headers.authorization = `Bearer ${token}`;
+  const res = await fetch(`${base}/api/skills/${slug}/bundle?format=json`, { headers }).catch(() => null);
+  if (!res || !res.ok) return null;
+  const data = await res.json().catch(() => null);
+  if (!data?.files) return null;
+  const out = [];
+  for (const f of data.files) {
+    if (f.content_base64 != null) {
+      out.push({ path: f.path, contents: Buffer.from(f.content_base64, "base64") });
+    } else if (f.source_url) {
+      const r = await fetch(f.source_url).catch(() => null);
+      if (r && r.ok) out.push({ path: f.path, contents: Buffer.from(await r.arrayBuffer()) });
+    }
+  }
+  return out;
 }
 function skillMdFor(skill) {
   if (skill.raw_md) return skill.raw_md;
@@ -901,7 +919,7 @@ import pc7 from "picocolors";
 // ../cli/src/agents.ts
 import { mkdirSync as mkdirSync3, writeFileSync as writeFileSync4, rmSync as rmSync2, symlinkSync, existsSync as existsSync3, readdirSync as readdirSync2, statSync as statSync2, readFileSync as readFileSync3 } from "fs";
 import { homedir as homedir3 } from "os";
-import { join as join4, resolve as resolve2, dirname as dirname2 } from "path";
+import { join as join4, resolve as resolve2, dirname as dirname2, sep as sep2 } from "path";
 var AGENTS = [
   { id: "claude-code", segments: [".claude", "skills"] },
   { id: "cursor", segments: [".cursor", "skills"] },
@@ -927,8 +945,12 @@ function writeSkill(skillName, files, targetDir, opts = {}) {
     return dest;
   }
   mkdirSync3(dest, { recursive: true });
+  const root = resolve2(dest);
   for (const f of files) {
-    const fp = join4(dest, f.path);
+    const fp = resolve2(dest, f.path);
+    if (fp !== root && !fp.startsWith(root + sep2)) {
+      throw new Error(`refused unsafe path in skill "${skillName}": ${f.path}`);
+    }
     mkdirSync3(dirname2(fp), { recursive: true });
     writeFileSync4(fp, f.contents);
   }
@@ -974,12 +996,12 @@ var defaultDeps = {
       return rs2.map((r) => ({ name: r.slug, raw: r.raw, slug: r.slug }));
     }
     if (/^[^/\s:]+\/[^/\s:]+$/.test(arg)) {
-      const { api } = createClient(flags);
+      const { api, base: apiBase, token } = createClient(flags);
       const [owner, name] = arg.split("/");
       try {
         const skill = await api(`/api/skills/${owner}/${name}`);
         const skillName = skill.slug.split("/")[1] || name;
-        const base = {
+        const meta = {
           name: skillName,
           slug: skillName,
           registrySlug: arg,
@@ -988,10 +1010,15 @@ var defaultDeps = {
           securityFlags: skill.security_flags
         };
         if (skill.type === "pack") {
+          const bundle = await fetchBundle(apiBase, arg, token);
+          if (bundle && bundle.length) {
+            const sk = bundle.find((f) => f.path === "SKILL.md");
+            return [{ ...meta, raw: sk ? sk.contents.toString("utf8") : skillMdFor(skill), files: bundle }];
+          }
           const pack = await resolvePackFiles(skill);
-          if (pack) return [{ ...base, ...pack }];
+          if (pack) return [{ ...meta, ...pack }];
         }
-        return [{ ...base, raw: skillMdFor(skill) }];
+        return [{ ...meta, raw: skillMdFor(skill) }];
       } catch {
       }
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "skillmds",
-  "version": "1.0.16",
+  "version": "1.0.17",
   "description": "SkillMD for agents: the `skillmds` MCP server + the `skillmd` CLI (lint, scan, search, install, publish Agent Skills) from skillmd.com.",
   "type": "module",
   "bin": {