skilldrop-cli 0.16.31 → 0.16.32

package/packs/dev-team/skills/dependency-upgrade-review/evals/files/7/pr.diff

@@ -0,0 +1,146 @@
+diff --git a/package.json b/package.json
+index 1c2e8f0..5ad91b3 100644
+--- a/package.json
++++ b/package.json
+@@ -17,11 +17,11 @@
+   "devDependencies": {
+-    "bundlecrate": "6.0.1",
+-    "lintwright": "4.2.0",
+-    "prettyquill": "3.1.2",
+-    "tsforge-types": "1.4.0",
+-    "vellum-test": "2.7.3"
++    "bundlecrate": "6.1.0",
++    "lintwright": "4.3.1",
++    "prettyquill": "3.1.4",
++    "tsforge-types": "1.4.2",
++    "vellum-test": "2.8.0"
+   }
+ }
+diff --git a/package-lock.json b/package-lock.json
+index 9e04a1d..c3b7f52 100644
+--- a/package-lock.json
++++ b/package-lock.json
+@@ -12,11 +12,11 @@
+       "devDependencies": {
+-        "bundlecrate": "6.0.1",
+-        "lintwright": "4.2.0",
+-        "prettyquill": "3.1.2",
+-        "tsforge-types": "1.4.0",
+-        "vellum-test": "2.7.3"
++        "bundlecrate": "6.1.0",
++        "lintwright": "4.3.1",
++        "prettyquill": "3.1.4",
++        "tsforge-types": "1.4.2",
++        "vellum-test": "2.8.0"
+       },
+       "engines": {
+         "node": ">=20"
+       }
+     },
++    "node_modules/@bundlecrate/resolver-core": {
++      "version": "1.0.0",
++      "resolved": "https://registry.npmjs.org/@bundlecrate/resolver-core/-/resolver-core-1.0.0.tgz",
++      "integrity": "sha512-Xk3bP9vQm2LrT7wZ1sNc4HfJ8eYd0GaU6oKiE5rBtWqV2nM7xL1pR9sT3vW8cZ4yH6jF0dK2gA5eN1bQ7uI3oP==",
++      "dev": true,
++      "license": "MIT",
++      "engines": {
++        "node": ">=18.18"
++      }
++    },
+     "node_modules/bundlecrate": {
+-      "version": "6.0.1",
+-      "resolved": "https://registry.npmjs.org/bundlecrate/-/bundlecrate-6.0.1.tgz",
+-      "integrity": "sha512-Lm7nQ2vKp9cRz4Wt1bXe8JdH3yGa0fUu6oNiE5rCtYqW2sM7xP1kR9tT3vV8bZ4yJ6hF0dL2gA5eN1cQ7uO3iP==",
++      "version": "6.1.0",
++      "resolved": "https://registry.npmjs.org/bundlecrate/-/bundlecrate-6.1.0.tgz",
++      "integrity": "sha512-Pq4rT8wXn1cLz6Vs2mBe9KdJ7hYf3aGu0oNiE5rDtUqX2nL7wM1pS9vT4bW8cZ3yK6jG0eH2fA5dN1aQ7iU3oR==",
+       "dev": true,
+       "license": "MIT",
+       "dependencies": {
+-        "bundlecrate-legacy-resolver": "^2.3.0",
++        "@bundlecrate/resolver-core": "^1.0.0",
+         "picolabel": "^0.9.0"
+       },
+       "bin": {
+         "bundlecrate": "bin/bundlecrate.js"
+       },
+       "engines": {
+-        "node": ">=16"
++        "node": ">=18.18"
+       }
+     },
+-    "node_modules/bundlecrate-legacy-resolver": {
+-      "version": "2.3.4",
+-      "resolved": "https://registry.npmjs.org/bundlecrate-legacy-resolver/-/bundlecrate-legacy-resolver-2.3.4.tgz",
+-      "integrity": "sha512-Ab2cD4eF6gH8iJ0kL2mN4oP6qR8sT0uV2wX4yZ6aB8cD0eF2gH4iJ6kL8mN0oP2qR4sT6uV8wX0yZ2aB4cD6eF8==",
+-      "dev": true,
+-      "license": "MIT"
+-    },
+     "node_modules/lintwright": {
+-      "version": "4.2.0",
+-      "resolved": "https://registry.npmjs.org/lintwright/-/lintwright-4.2.0.tgz",
+-      "integrity": "sha512-Hn5mR2xLq8cTz3Wv1bYe7KdF4hJa9gUu0oNiE6rBtWpX3sM2wL1kQ8vT5cV9bZ7yG4hF0dJ2eA6nN1aR3uI7oS==",
++      "version": "4.3.1",
++      "resolved": "https://registry.npmjs.org/lintwright/-/lintwright-4.3.1.tgz",
++      "integrity": "sha512-Ty8kW3vNp2cQz5Ls1mXe6RdJ9hGa4fUu7oNiE0rBtVqY2sK3wM1pL8vS5cT9bZ6yH4jF0eG2dA7nN1bR3iU5oQ==",
+       "dev": true,
+       "license": "MIT",
+       "dependencies": {
+-        "picolabel": "0.9.1"
++        "picolabel": "0.9.2"
+       },
+       "bin": {
+         "lintwright": "bin/lintwright.js"
+       }
+     },
+     "node_modules/picolabel": {
+-      "version": "0.9.1",
+-      "resolved": "https://registry.npmjs.org/picolabel/-/picolabel-0.9.1.tgz",
+-      "integrity": "sha512-Cd3eF5gH7iJ9kL1mN3oP5qR7sT9uV1wX3yZ5aB7cD9eF1gH3iJ5kL7mN9oP1qR3sT5uV7wX9yZ1aB3cD5eF7gH==",
++      "version": "0.9.2",
++      "resolved": "https://registry.npmjs.org/picolabel/-/picolabel-0.9.2.tgz",
++      "integrity": "sha512-Ef4gH6iJ8kL0mN2oP4qR6sT8uV0wX2yZ4aB6cD8eF0gH2iJ4kL6mN8oP0qR2sT4uV6wX8yZ0aB2cD4eF6gH8iJ==",
+       "dev": true,
+       "license": "MIT"
+     },
+     "node_modules/prettyquill": {
+-      "version": "3.1.2",
+-      "resolved": "https://registry.npmjs.org/prettyquill/-/prettyquill-3.1.2.tgz",
+-      "integrity": "sha512-Gh6iJ8kL0mN2oP4qR6sT8uV0wX2yZ4aB6cD8eF0gH2iJ4kL6mN8oP0qR2sT4uV6wX8yZ0aB2cD4eF6gH8iJ0kL==",
++      "version": "3.1.4",
++      "resolved": "https://registry.npmjs.org/prettyquill/-/prettyquill-3.1.4.tgz",
++      "integrity": "sha512-Ij7kL9mN1oP3qR5sT7uV9wX1yZ3aB5cD7eF9gH1iJ3kL5mN7oP9qR1sT3uV5wX7yZ9aB1cD3eF5gH7iJ9kL1mN==",
+       "dev": true,
+       "license": "MIT",
+       "bin": {
+         "prettyquill": "bin/prettyquill.js"
+       }
+     },
+     "node_modules/tsforge-types": {
+-      "version": "1.4.0",
+-      "resolved": "https://registry.npmjs.org/tsforge-types/-/tsforge-types-1.4.0.tgz",
+-      "integrity": "sha512-Kl8mN0oP2qR4sT6uV8wX0yZ2aB4cD6eF8gH0iJ2kL4mN6oP8qR0sT2uV4wX6yZ8aB0cD2eF4gH6iJ8kL0mN2oP==",
++      "version": "1.4.2",
++      "resolved": "https://registry.npmjs.org/tsforge-types/-/tsforge-types-1.4.2.tgz",
++      "integrity": "sha512-Mn9oP1qR3sT5uV7wX9yZ1aB3cD5eF7gH9iJ1kL3mN5oP7qR9sT1uV3wX5yZ7aB9cD1eF3gH5iJ7kL9mN1oP3qR==",
+       "dev": true,
+       "license": "MIT"
+     },
+     "node_modules/vellum-test": {
+-      "version": "2.7.3",
+-      "resolved": "https://registry.npmjs.org/vellum-test/-/vellum-test-2.7.3.tgz",
+-      "integrity": "sha512-Op0qR2sT4uV6wX8yZ0aB2cD4eF6gH8iJ0kL2mN4oP6qR8sT0uV2wX4yZ6aB8cD0eF2gH4iJ6kL8mN0oP2qR4sT==",
++      "version": "2.8.0",
++      "resolved": "https://registry.npmjs.org/vellum-test/-/vellum-test-2.8.0.tgz",
++      "integrity": "sha512-Qr1sT3uV5wX7yZ9aB1cD3eF5gH7iJ9kL1mN3oP5qR7sT9uV1wX3yZ5aB7cD9eF1gH3iJ5kL7mN9oP1qR3sT5uV==",
+       "dev": true,
+       "license": "MIT",
+       "bin": {
+         "vellum": "bin/vellum.js"
+       },
+       "engines": {
+         "node": ">=18"
+       }
+     }
+   }
+ }

package/packs/dev-team/skills/dependency-upgrade-review/evals/files/7/src/due-date.ts

@@ -0,0 +1,16 @@
+import type { Brand } from "tsforge-types";
+
+export type IsoDate = Brand<string, "IsoDate">;
+
+const DAY_MS = 24 * 60 * 60 * 1000;
+
+export function isOverdue(inv: { dueAt: string }): boolean {
+  return Date.now() > Date.parse(inv.dueAt);
+}
+
+export function formatDue(inv: { dueAt: string }): string {
+  const days = Math.round((Date.parse(inv.dueAt) - Date.now()) / DAY_MS);
+  if (days < 0) return `overdue by ${-days} days`;
+  if (days === 0) return "due today";
+  return `due in ${days} days`;
+}

package/packs/dev-team/skills/dependency-upgrade-review/evals/files/7/src/totals.ts

@@ -0,0 +1,11 @@
+import type { DeepReadonly } from "tsforge-types";
+
+export type Line = DeepReadonly<{ qty: number; unitMinor: number }>;
+
+export function lineTotal(l: Line): number {
+  return l.qty * l.unitMinor;
+}
+
+export function invoiceTotal(lines: readonly Line[]): number {
+  return lines.reduce((sum, l) => sum + lineTotal(l), 0);
+}

package/packs/dev-team/skills/dependency-upgrade-review/evals/files/7/tests/due-date.test.ts

@@ -0,0 +1,17 @@
+import { describe, it, expect, vt } from "vellum-test";
+import { isOverdue, formatDue } from "../src/due-date";
+
+describe("due dates", () => {
+  it("flags invoices past their due date", () => {
+    vt.fakeTimers({ now: new Date("2026-03-15T09:00:00Z") });
+    expect(isOverdue({ dueAt: "2026-03-14T23:59:59Z" })).toBe(true);
+    expect(isOverdue({ dueAt: "2026-03-16T00:00:00Z" })).toBe(false);
+    vt.restoreTimers();
+  });
+
+  it("formats relative due text", () => {
+    vt.fakeTimers({ now: new Date("2026-03-15T09:00:00Z") });
+    expect(formatDue({ dueAt: "2026-03-18T09:00:00Z" })).toBe("due in 3 days");
+    vt.restoreTimers();
+  });
+});

package/packs/dev-team/skills/dependency-upgrade-review/evals/files/7/tests/totals.test.ts

@@ -0,0 +1,12 @@
+import { describe, it, expect } from "vellum-test";
+import { lineTotal, invoiceTotal } from "../src/totals";
+
+describe("totals", () => {
+  it("multiplies quantity by unit price in minor units", () => {
+    expect(lineTotal({ qty: 3, unitMinor: 1250 })).toBe(3750);
+  });
+
+  it("sums lines", () => {
+    expect(invoiceTotal([{ qty: 1, unitMinor: 100 }, { qty: 2, unitMinor: 50 }])).toBe(200);
+  });
+});

package/packs/dev-team/skills/dependency-upgrade-review/examples/ledgerline-tidyparse.md

@@ -67,25 +67,34 @@ No install scripts, sources, licences or pins appear. The floor says only that t
 
 ## Review (what the agent hands back)
 
-**MERGE.** A two-release patch bump whose only behaviour change, the new 10 MB line limit in 2.2.2, raises an error the import code already handles, and CI runs that code.
+**MERGE.** Two patch releases; the only behaviour change, 2.2.2's new 10 MB line limit, raises an error the import code already handles, and the PR's tests run that code.
 
-🟨 Notes
+- Both releases read. 2.2.1 fixes quoted newlines splitting rows, covered by `test_quoted_newline_stays_one_row` (`tests/test_ingest.py:9`). 2.2.2 is a security fix: lines over 10 MB raise `RowTooLongError`, a subclass of `ParseError`.
+- `git grep -n "tidyparse" -- '*.py'` finds one call, `app/ingest.py:14`, inside `except tidyparse.ParseError` (`app/ingest.py:15`), so the new error becomes `StatementRejected` like any malformed file.
+- `ci.yml` runs `pytest -q` on the PR and `tests/test_ingest.py:3` imports `import_statement`, so the changed code ran.
 
-- Both releases read. 2.2.1 fixes quoted newlines splitting rows, which `test_quoted_newline_stays_one_row` (`tests/test_ingest.py:9`) covers. 2.2.2 is a security fix: lines over 10 MB now raise `RowTooLongError`, a subclass of `ParseError`.
-- Search: `git grep -n "tidyparse" -- '*.py'` finds one call, `app/ingest.py:14`, inside `except tidyparse.ParseError` (`app/ingest.py:15`). The new error is caught there and becomes `StatementRejected`, the same path as any malformed file.
-- CI: `ci.yml` runs `pytest -q` on the PR, and `tests/test_ingest.py:3` imports `import_statement`, so the changed code ran. No test feeds a 10 MB line; that is the library's limit, not a change in this repo's behaviour.
-- Beyond the title: `charset-sniff` 1.4.0 → 1.4.1, a transitive patch, listed and not read.
-- No new packages, install scripts, registry changes or pins.
+Also in the lockfile: `charset-sniff` 1.4.0 → 1.4.1 (transitive patch). No new packages, install scripts, sources, runtime changes or pins.
 
-| Package | Old → New | Class | Direct? |
-|---|---|---|---|
-| tidyparse | 2.2.0 → 2.2.2 | patch | direct |
-| charset-sniff | 1.4.0 → 1.4.1 | patch | transitive |
+Rollback: `git revert` the merge commit, or `poetry add tidyparse@2.2.0` and commit `pyproject.toml` and `poetry.lock`; that reopens the 2.2.2 memory issue, so treat it as a stopgap.
 
-Rollback: `git revert` the merge commit, or `poetry add tidyparse@2.2.0` and commit `pyproject.toml` and `poetry.lock`. Nothing persists to undo, but rolling back reopens the 2.2.2 memory issue, so pin back to 2.2.0 only as a stopgap.
-
-To confirm: nothing.
+About 150 words. No package table: two packages fit in a line. No "To confirm": nothing is open.
 
 ## Why this is MERGE and not MERGE AFTER CHECKS
 
 Every check in the verdict rule is closed with evidence in the reply: both releases read, the one changed behaviour searched and found handled, the calling code run by a PR test, no pins, no install-time code, no new source. Remove any one of those (no repo to search, a release with no notes, a test that does not import `app/ingest.py`) and the verdict drops to MERGE AFTER CHECKS with that item as the check.
+
+## The same shape when it blocks
+
+Suppose instead the PR moved tidyparse to 3.0.0 and the notes (invented for this illustration) said 3.0.0 requires Python 3.11 and `parse_rows()` now returns a `RowSet` instead of a list. The reply keeps the order and stays short:
+
+> **DO NOT MERGE.** 3.0.0 needs Python 3.11 and the production image runs 3.10, and the import code indexes a result that is no longer a list.
+>
+> 🟥 1. `Dockerfile:1` builds on `python:3.10-slim`; CI runs 3.12 (`ci.yml:12`), so the PR passed and the image build fails at install. Move the image to 3.11 in this PR.
+> 🟥 2. `app/ingest.py:17` does `rows[0]` on what is now a `RowSet`; no test reads the first row, so CI missed it. Use `rows.first()`.
+>
+> Also in the lockfile: `charset-sniff` 1.4.0 → 1.4.1.
+> Rollback: `git revert` the merge commit and rebuild the image.
+>
+> I can make both changes on this branch.
+
+The lead names both blockers; each blocker says what breaks, where, why CI missed it and the fix; nothing is in the reply that does not change the decision.

package/packs/dev-team/skills/dependency-upgrade-review/manifest.json

@@ -1,7 +1,7 @@
 {
   "name": "dependency-upgrade-review",
-  "version": "0.1.0",
-  "description": "Give a merge verdict on a dependency-upgrade pull request (Dependabot, Renovate or a hand-made bump) across npm, pip, Go, Cargo and Maven lockfiles and GitHub Actions pins. Reads the release notes for every skipped version, lists what the lockfile changes beyond the PR title (transitive bumps, new and removed packages, install scripts, registry changes), checks that each SHA pin is the commit its release tag points to, says whether CI ran the changed code, finds the repo's uses of changed APIs and writes the rollback, ending in MERGE, MERGE AFTER CHECKS or DO NOT MERGE. Use when the user says \"review this Dependabot PR\", \"is this Renovate bump safe to merge\", \"can I merge this dependency upgrade\", \"check this lockfile diff\", or \"is this action SHA pin right\".",
+  "version": "0.2.0",
+  "description": "Give a merge verdict on a dependency-upgrade pull request (Dependabot, Renovate or a hand-made bump) across npm, pip, Go, Cargo and Maven lockfiles and GitHub Actions pins. Reads the release notes for every skipped version, lists what the lockfile changes beyond the PR title (transitive bumps, new and removed packages, install scripts, registry changes), checks each SHA pin against its release tag and against the PR's other pins, checks raised runtime floors against the images and runners that install it, says whether CI ran the changed code, traces what each caller of a changed API now does and writes the rollback. The reply leads with MERGE, MERGE AFTER CHECKS or DO NOT MERGE and the reasons that decide it. Use when the user says \"review this Dependabot PR\", \"is this Renovate bump safe to merge\", \"can I merge this dependency upgrade\", \"check this lockfile diff\", or \"is this action SHA pin right\".",
   "entrypoint": "SKILL.md",
   "deps": {
     "npm": [],
@@ -38,10 +38,22 @@
     "github-actions"
   ],
   "permissions": {
-    "network": [],
-    "commands": [],
+    "network": [
+      "github.com",
+      "api.github.com",
+      "registry.npmjs.org",
+      "pypi.org",
+      "proxy.golang.org"
+    ],
+    "commands": [
+      "git",
+      "gh",
+      "npm",
+      "pip",
+      "go"
+    ],
     "files": "named-paths",
-    "notes": "Reads only the diff path it is given, or stdin; writes only the -o path when given. No network: SHA verification and changelog reading are printed as commands for the reviewer to run."
+    "notes": "The script reads only the diff path it is given, or stdin, writes only the -o path when given, and makes no network calls. The instructions read the PR with gh or git, list a package's releases with npm, pip, go or gh, and verify a SHA pin with git ls-remote against github.com; gh reaches api.github.com and the package managers their registries; with no network those become commands in the reply for the reviewer to run."
   },
   "model": {
     "tier": "standard",

package/packs/dev-team/skills/dependency-upgrade-review/reference.md

@@ -1,6 +1,6 @@
 # dependency-upgrade-review reference
 
-Long-form material for the steps in `SKILL.md`: what each ecosystem's diff shows, where the risky signals live, how to list the releases between two versions, how to verify a pin, and how to roll back.
+Long-form material for the steps in `SKILL.md`: what each ecosystem's diff shows, where the risky signals live, how to list the releases between two versions, how to trace a behaviour change to its callers, where runtime floors bite, how to verify a pin, and how to roll back.
 
 ## Reading a lockfile diff, by ecosystem
 
@@ -44,6 +44,36 @@ What to pull from each release, in this order:
 3. **Deprecations:** still works, removed later. A deprecated call the repo makes is a 🟧, not a 🟥.
 4. **Licence:** a changed `license` field or a LICENSE file change. Moves between permissive licences (MIT, BSD, Apache-2.0, ISC) are a note. A move to a copyleft licence (GPL, AGPL, MPL at file level, LGPL) or a source-available licence (BUSL, SSPL, Elastic, "Commons Clause") needs a sign-off from whoever owns licence policy before merge.
 
+## Tracing a behaviour change to its callers
+
+A search hit is where the review starts. Read the calling function and write what it does under the new version.
+
+| Change in the notes | What to look for in the caller | What breaks |
+|---|---|---|
+| Returns `None` / `-1` / `false` → raises | `if result is None`, `== -1`, `if not ok` branches; retry loops and fallbacks built on them | The branch never runs; the first failure escapes as an exception and the retry or fallback is dead code |
+| Raises → returns a sentinel | `try` / `except` around the call | The error is swallowed; the code carries on with the sentinel |
+| Exception class renamed or re-parented | `except OldError`, `catch (e instanceof OldError)` | The handler stops catching it |
+| Tuple or dict → object | `a, b = f(...)`, `result["key"]` | Unpacking or key access fails at runtime |
+| Changed default | Every call that does not pass the option | Each one gets the new behaviour silently |
+| Module or function removed | Imports at the top of a file, and imports inside functions | A top-level import fails at startup and in tests; an import inside a function fails only when that function runs |
+
+Name the fix in the repo's code, and any migration aid an intermediate release ships (an opt-in flag that turns on the new behaviour early). Moving to that release first lets the code change land and be tested before the major.
+
+## Runtime floors
+
+A release that drops a runtime version breaks wherever the old runtime still runs, and CI usually runs a newer one.
+
+| Floor raised in | Compare with |
+|---|---|
+| Release notes ("requires Python 3.10"), `python_requires`, `python-versions` in `poetry.lock`, `requires-python` in `uv.lock` | Dockerfile `FROM`, `setup-python` version and matrix, `.python-version`, the Python the lockfile was compiled on |
+| `engines.node` in `package-lock.json` or `package.json` | `.nvmrc`, `setup-node` / toolchain version, Dockerfile `FROM`, `engine-strict` in `.npmrc` |
+| `go` directive in `go.mod`, `toolchain` line | `setup-go` version, Dockerfile builder image |
+| `rust-version` (MSRV) in a crate | `rust-toolchain.toml`, CI toolchain |
+| Wheels or prebuilt binaries only for some versions or platforms | Every image and runner that installs it; elsewhere it builds from source and needs a compiler or toolchain |
+| An action's runtime (`node20` → `node24`) | Self-hosted runner versions; GitHub-hosted runners update themselves |
+
+A lockfile generated on a newer runtime than production can resolve versions production cannot install. `pip install --require-hashes` and `npm ci` fail at build time, not at review time.
+
 ## Verifying a pin
 
 ```bash
@@ -57,6 +87,7 @@ git ls-remote https://github.com/<owner>/<repo> refs/tags/<tag> 'refs/tags/<tag>
 - A SHA with no `# vX.Y.Z` comment: list the tags (`git ls-remote --tags https://github.com/<owner>/<repo>`) and find the SHA. No tag points to it means it is not a release.
 - Tag-only pin (`uses: owner/repo@v3`): the maintainer, or anyone who takes over the account, can point `v3` at new code after review. Pin to the commit the `^{}` line returns and keep the tag as a comment.
 - Branch pin (`@main`): every run gets whatever was pushed last. A PR that introduces one is DO NOT MERGE.
+- Two SHAs for one tag: when the same `owner/repo` and `# vX.Y.Z` comment appear with different SHAs across workflow files, at most one is the tag's commit. Run the command once and compare both; until then, the PR is DO NOT MERGE. Read the PR's commit list: a bot writes every pin the same way, so a pin that differs from the bot's usually came from a hand-made commit.
 
 Stakes come from the job, not the action: look at `permissions:` (`contents: write`, `id-token: write`, `packages: write`), the `secrets.*` it receives, and the `environment:` it runs in.
 
@@ -70,6 +101,10 @@ Stakes come from the job, not the action: look at `permissions:` (`contents: wri
 | A build or publish step (bundler, packager, uploader) not in the PR workflow | No |
 | A source file no test imports | No |
 | A test that imports the file but never hits the changed behaviour (a default, an edge case the notes name) | Not the part that changed |
+| A test that mocks the dependency with the old contract (a fake that returns a value where the new version raises) | No; it tests the old behaviour |
+| An import inside a function no test calls | No; it never fails at import or collection |
+| An install script, when the PR job installs with `--ignore-scripts` and the release job does not | No; it first runs in the release job, with that job's secrets and permissions |
+| A runtime older than the one CI uses (production image, self-hosted runner) | No |
 
 Ways to exercise an unrun path before merge: a `workflow_dispatch` dry run on the PR branch, a release to a test index (TestPyPI, a scratch npm scope), or a test that covers the changed behaviour, added in the same PR.
 

package/packs/dev-team/skills/dependency-upgrade-review/scripts/upgrade_diff.py

@@ -161,6 +161,7 @@ def host_of(url):
 class Report:
     def __init__(self):
         self.changes, self.flags, self.files, self.unattributed = [], [], [], {}
+        self.sha_pins = {}  # (repo, tag) -> {sha: [files]}, from added `uses:` lines
 
     def change(self, path, eco, where, name, old, new, note=None):
         if old == new:
@@ -256,6 +257,12 @@ def merge_blocks(rep, path, eco, hunks, key_fn, field_res, name_fn, reset_re=Non
                     rep.flag("source", path, f"{label}: {f} moved from {oh} to {nh}")
                 elif nh and not o and f != "index" and nh not in DEFAULT_HOSTS:
                     rep.flag("source", path, f"{label}: new package comes from {nh}, not the default registry")
+            for f in ("node", "python-versions"):
+                orv, nrv = of.get(f, (None,))[0], nf.get(f, (None,))[0]
+                if o and nrv and orv != nrv:
+                    rt = "Node" if f == "node" else "Python"
+                    rep.flag("runtime", path, f"{label}: requires {rt} {nrv} (was {orv or 'unstated'}); check every "
+                                              f"place it installs and runs (base images, CI versions, runners)")
             ol, nl = of.get("license", (None,))[0], nf.get("license", (None,))[0]
             if ol and nl and ol != nl:
                 rep.flag("licence", path, f"{label}: licence changed from {ol} to {nl}")
@@ -317,7 +324,7 @@ def npm_lock_name(key):
 
 
 NPM_FIELDS = {f: re.compile(rf'^\s*"{f}":\s*"?([^",]+)"?,?\s*$') for f in
-              ("version", "resolved", "license", "hasInstallScript", "dev", "optional", "gypfile")}
+              ("version", "resolved", "license", "hasInstallScript", "dev", "optional", "gypfile", "node")}
 
 
 def h_package_lock(rep, path, hunks):
@@ -360,7 +367,8 @@ def h_pnpm_lock(rep, path, hunks):
 
 TOML_PKG_FIELDS = {"version": re.compile(r'^version\s*=\s*"([^"]+)"'),
                    "source": re.compile(r'^source\s*=\s*"([^"]+)"'),
-                   "url": re.compile(r'^(?:url|source\s*=\s*\{\s*(?:registry|git|url))\s*=\s*"([^"]+)"')}
+                   "url": re.compile(r'^(?:url|source\s*=\s*\{\s*(?:registry|git|url))\s*=\s*"([^"]+)"'),
+                   "python-versions": re.compile(r'^python-versions\s*=\s*"([^"]+)"')}
 
 
 def h_toml_lock(eco):
@@ -527,6 +535,7 @@ def h_workflow(rep, path, hunks):
             if n and SHA40.fullmatch(n[0]):
                 tag_ = re.match(r"^(v?[\w.\-]+)", n[1]).group(1) if n[1] else None
                 if tag_:
+                    rep.sha_pins.setdefault((repo, tag_), {}).setdefault(n[0], []).append(path)
                     rep.flag("pin", path, f"{name}@{n[0]} claims {tag_}. UNVERIFIED until the tag resolves to this commit: "
                                           f"`git ls-remote https://github.com/{repo} refs/tags/{tag_} 'refs/tags/{tag_}^{{}}'` "
                                           f"(the `^{{}}` line is the commit for an annotated tag; it must equal {n[0]})")
@@ -591,9 +600,16 @@ def analyse(files, title):
         for r in rep.changes:
             short = r["name"].split("/")[-1].lower()
             r["in_title"] = r["name"].lower() in t or (len(short) > 3 and re.search(rf"\b{re.escape(short)}\b", t) is not None)
+    for (repo, tag_), shas in rep.sha_pins.items():
+        if len(shas) > 1:
+            where = "; ".join(f"{s} in {', '.join(dict.fromkeys(ps))}" for s, ps in shas.items())
+            rep.flag("pin-conflict", next(iter(shas.values()))[0],
+                     f"{repo} {tag_} is pinned to {len(shas)} different commits ({where}). A tag points to one "
+                     f"commit, so at most one of these is {tag_}; find which with "
+                     f"`git ls-remote https://github.com/{repo} refs/tags/{tag_} 'refs/tags/{tag_}^{{}}'`")
     reasons_stop, reasons_check = [], []
     for fl in rep.flags:
-        if fl["kind"] in ("install-script", "source"):
+        if fl["kind"] in ("install-script", "source", "pin-conflict"):
             reasons_stop.append(f"{fl['kind']}: {fl['text']}")
         elif fl["kind"] == "pin":
             reasons_check.append("pin: " + fl["text"].split(". ")[0])
@@ -662,9 +678,11 @@ def render_md(rep, floor, stop, check, title):
         out += ["", f"## Beyond the title ({len(beyond)})", ""]
         out += [f"- `{r['name']}` {r['kind']}: {r['old'] or '—'} → {r['new'] or '—'} ({r['file']})" for r in beyond] or ["None."]
     labels = (("install-script", "Install scripts"), ("native", "Native code"), ("source", "Sources and registries"),
-              ("licence", "Licences"), ("pin", "Pins (verify every SHA; the script cannot)"))
+              ("licence", "Licences"), ("runtime", "Runtime requirements"), ("pin", "Pins (verify every SHA; the script cannot)"))
     for kind, heading in labels:
         rows = [f for f in rep.flags if f["kind"] == kind]
+        if kind == "pin":
+            rows = [f for f in rep.flags if f["kind"] == "pin-conflict"] + rows
         out += ["", f"## {heading} ({len(rows)})", ""]
         out += [f"- `{f['file']}`: {f['text']}" for f in rows] or ["None seen in the diff."]
     if rep.unattributed:

package/packs/dev-team/skills/sonar-review/manifest.json

@@ -33,5 +33,17 @@
   "model": {
     "tier": "standard",
     "rationale": "Formats Sonar API findings into a report. The hard analysis is Sonar's; this is synthesis. Escalates on very large diffs."
+  },
+  "permissions": {
+    "network": [
+      "sonarcloud.io"
+    ],
+    "commands": [
+      "sonar-scanner",
+      "git",
+      "curl"
+    ],
+    "files": "none",
+    "notes": "No scripts. Its instructions run sonar-scanner and query the Sonar API with curl, using SONAR_TOKEN from the environment, against sonarcloud.io or the self-hosted SonarQube URL the user configures."
   }
 }

package/packs/infra-as-code/skills/terraform-module/manifest.json

@@ -37,5 +37,16 @@
   "model": {
     "tier": "standard",
     "rationale": "Structured generation against fixed module conventions and a secure-defaults checklist; the judgment is bounded to choosing defaults and validation rules for a described need."
+  },
+  "permissions": {
+    "network": [
+      "registry.terraform.io",
+      "releases.hashicorp.com"
+    ],
+    "commands": [
+      "terraform"
+    ],
+    "files": "none",
+    "notes": "No scripts. Its instructions run `terraform fmt`, `terraform init -backend=false` and `terraform validate` on the module it writes. `init` downloads the providers from the Terraform registry; none of the commands contacts a cloud account."
   }
 }

package/packs/infra-as-code/skills/terraform-plan-review/manifest.json

@@ -40,7 +40,14 @@
     "iam",
     "drift"
   ],
-  "permissions": {"network": [], "commands": [], "files": "named-paths", "notes": "Reads a plan JSON, which can hold secrets in clear text; the script never prints attribute values."},
+  "permissions": {
+    "network": [],
+    "commands": [
+      "terraform"
+    ],
+    "files": "named-paths",
+    "notes": "Reads a plan JSON, which can hold secrets in clear text; the script never prints attribute values. Its instructions run `terraform show -json` to produce that plan JSON."
+  },
   "model": {
     "tier": "heavy",
     "rationale": "Adversarial review of a destructive change: judging which replacements lose data, which access changes widen exposure, and what is out of scope needs careful reasoning; a missed destroy costs far more than the model."

package/packs/solution-architect/skills/figma-diagrams/manifest.json

@@ -28,7 +28,18 @@
     "design",
     "api"
   ],
-  "permissions": {"network": ["api.figma.com"], "commands": [], "files": "named-paths", "notes": "Reads FIGMA_TOKEN from the environment to call the Figma REST API."},
+  "permissions": {
+    "network": [
+      "api.figma.com",
+      "pypi.org",
+      "files.pythonhosted.org"
+    ],
+    "commands": [
+      "pip"
+    ],
+    "files": "named-paths",
+    "notes": "Reads FIGMA_TOKEN from the environment to call the Figma REST API. Its instructions install the pinned requirements once with `python3 -m pip install -r requirements.txt`, which reaches PyPI."
+  },
   "model": {
     "tier": "standard",
     "rationale": "API calls + spec generation. Bounded transformation."