skill-creator 2.0.0 → 2.0.1

package/CHANGELOG.md

@@ -1,5 +1,21 @@
 # Changelog
 
+## 2.0.1 (2026-09-15)
+
+Hotfix for the native file picker shipped in 2.0.0.
+
+### Fixed
+
+- **Native file picker never opened (macOS)** — the `@xmorse/rfd` async dialog
+  panics off the main thread in non-GUI host processes, leaving the RPC promise
+  pending forever: the attach buttons went dead with no dialog, no error, and no
+  way to recover without a restart. The picker now runs the synchronous dialog
+  in a dedicated child process (main-thread-safe, panic-isolated, watchdog at
+  10 minutes). Verified live: dialog opens and returns real paths, and picker
+  failures now surface a toast instead of failing silently.
+- Concurrent picker requests from a second client get a typed
+  "dialog is already open" rejection instead of queueing invisibly.
+
 ## 2.0.0 (2026-09-14)
 
 A major rewrite of the Skill Creator experience: model configuration rebuilt around

package/dist/cli.js

@@ -812,7 +812,9 @@ var init_image_codec = __esm({
 });
 
 // src/daemon/agent-files.ts
+import { spawn as spawn3 } from "node:child_process";
 import { readFile as readFile2, readdir, realpath, stat } from "node:fs/promises";
+import { createRequire as createRequire2 } from "node:module";
 import os3 from "node:os";
 import path6 from "node:path";
 function toDomainError(error, what, target) {
@@ -854,25 +856,87 @@ function compareEntries(a, b) {
   if (a.kind !== b.kind) return a.kind === "dir" ? -1 : 1;
   return a.name.localeCompare(b.name, "en", { sensitivity: "base", numeric: true });
 }
-function createAgentFilesService(deps = {}) {
-  const defaultDir = deps.defaultDir ?? (() => os3.homedir());
-  async function pickFiles(input) {
-    const { AsyncFileDialog } = await import("@xmorse/rfd");
-    let builder = new AsyncFileDialog();
-    builder = builder.setTitle(input.mode === "image" ? "Select images" : "Select files");
-    if (input.mode === "image") {
-      builder = builder.addFilter("Images", ["png", "jpg", "jpeg", "webp", "gif"]);
-    }
-    const handles = await builder.pickFiles();
-    if (handles === null) return { paths: [] };
-    const paths = [];
-    for (const handle of handles) {
+function resolveRfdEntry() {
+  if (cachedRfdEntry !== null) return cachedRfdEntry;
+  try {
+    cachedRfdEntry = createRequire2(import.meta.url).resolve("@xmorse/rfd");
+  } catch {
+    throw new DomainError("UNAVAILABLE", "native file picker runtime is not installed");
+  }
+  return cachedRfdEntry;
+}
+function runPickerChild(request, options2 = {}) {
+  const entry = options2.entry ?? resolveRfdEntry();
+  const timeoutMs = options2.timeoutMs ?? PICKER_TIMEOUT_MS;
+  const child = spawn3(process.execPath, ["-e", PICKER_CHILD_CODE, JSON.stringify(request), entry], {
+    stdio: ["ignore", "pipe", "pipe"],
+    windowsHide: true
+  });
+  return new Promise((resolve2) => {
+    let stdout = "";
+    let stderrTail = "";
+    const timer = setTimeout(() => {
+      child.kill();
+      resolve2({ status: "failed", message: `picker timed out after ${String(timeoutMs)}ms` });
+    }, timeoutMs);
+    child.stdout.on("data", (chunk) => {
+      if (stdout.length < PICKER_STDOUT_LIMIT) stdout += chunk.toString("utf8");
+    });
+    child.stderr.on("data", (chunk) => {
+      stderrTail = (stderrTail + chunk.toString("utf8")).slice(-300);
+    });
+    child.on("error", (error) => {
+      clearTimeout(timer);
+      resolve2({ status: "failed", message: String(error) });
+    });
+    child.on("close", (code) => {
+      clearTimeout(timer);
       try {
-        paths.push(handle.path());
+        const parsed = JSON.parse(stdout);
+        if (parsed.ok === true && Array.isArray(parsed.paths)) {
+          const paths = parsed.paths.filter((value) => typeof value === "string");
+          resolve2(paths.length === 0 ? { status: "canceled" } : { status: "picked", paths });
+          return;
+        }
+        if (parsed.ok === false && typeof parsed.message === "string") {
+          resolve2({ status: "failed", message: parsed.message });
+          return;
+        }
       } catch {
       }
+      const detail = stderrTail.trim();
+      resolve2({
+        status: "failed",
+        message: `picker exited with code ${String(code)}${detail.length > 0 ? `: ${detail}` : ""}`
+      });
+    });
+  });
+}
+function createAgentFilesService(deps = {}) {
+  const defaultDir = deps.defaultDir ?? (() => os3.homedir());
+  const runNativePicker = deps.runNativePicker ?? runPickerChild;
+  let pickerInFlight = null;
+  async function pickFiles(input) {
+    if (pickerInFlight !== null) {
+      throw new DomainError("INVALID_OPERATION", "file picker dialog is already open");
+    }
+    const request = input.mode === "image" ? {
+      title: "Select images",
+      filters: [{ name: "Images", exts: ["png", "jpg", "jpeg", "webp", "gif"] }]
+    } : { title: "Select files", filters: [] };
+    const inFlight = runNativePicker(request);
+    pickerInFlight = inFlight;
+    try {
+      const outcome = await inFlight;
+      if (outcome.status === "picked") return { paths: outcome.paths ?? [] };
+      if (outcome.status === "canceled") return { paths: [] };
+      throw new DomainError(
+        "UNAVAILABLE",
+        `native file picker failed: ${outcome.message ?? "unknown error"}`
+      );
+    } finally {
+      if (pickerInFlight === inFlight) pickerInFlight = null;
     }
-    return { paths };
   }
   async function list2(input) {
     const target = input.dir === void 0 ? defaultDir() : input.dir;
@@ -1022,7 +1086,7 @@ function createAgentFilesService(deps = {}) {
   }
   return { pickFiles, list: list2, preview: preview2, resolvePromptAttachments };
 }
-var LIST_ENTRY_LIMIT, PREVIEW_IMAGE_MAX_BYTES, PREVIEW_TEXT_MAX_BYTES, PREVIEW_TEXT_HEAD_BYTES, PROMPT_IMAGE_MAX_BYTES, PROMPT_FILE_MAX_BYTES;
+var LIST_ENTRY_LIMIT, PREVIEW_IMAGE_MAX_BYTES, PREVIEW_TEXT_MAX_BYTES, PREVIEW_TEXT_HEAD_BYTES, PROMPT_IMAGE_MAX_BYTES, PROMPT_FILE_MAX_BYTES, PICKER_CHILD_CODE, PICKER_TIMEOUT_MS, PICKER_STDOUT_LIMIT, cachedRfdEntry;
 var init_agent_files = __esm({
   "src/daemon/agent-files.ts"() {
     "use strict";
@@ -1034,6 +1098,22 @@ var init_agent_files = __esm({
     PREVIEW_TEXT_HEAD_BYTES = 4096;
     PROMPT_IMAGE_MAX_BYTES = 4 * 1024 * 1024;
     PROMPT_FILE_MAX_BYTES = 512 * 1024;
+    PICKER_CHILD_CODE = `"use strict";
+const write = (payload) => process.stdout.write(JSON.stringify(payload));
+try {
+  const spec = JSON.parse(process.argv[1]);
+  const rfd = require(process.argv[2]);
+  let dialog = new rfd.FileDialog();
+  if (spec.title) dialog = dialog.setTitle(spec.title);
+  for (const filter of spec.filters) dialog = dialog.addFilter(filter.name, filter.exts);
+  const paths = dialog.pickFiles();
+  write({ ok: true, paths: Array.isArray(paths) ? paths : [] });
+} catch (error) {
+  write({ ok: false, message: String((error && error.message) || error).slice(0, 300) });
+}`;
+    PICKER_TIMEOUT_MS = 10 * 60 * 1e3;
+    PICKER_STDOUT_LIMIT = 64 * 1024;
+    cachedRfdEntry = null;
   }
 });
 
@@ -1327,7 +1407,7 @@ var init_creator_service = __esm({
 });
 
 // node_modules/.pnpm/ccski@2.5.0/node_modules/ccski/dist/create-prompt-CIJV_96B.mjs
-import { createRequire as createRequire2 } from "node:module";
+import { createRequire as createRequire3 } from "node:module";
 import { stripVTControlCharacters } from "node:util";
 import { AsyncLocalStorage, AsyncResource } from "node:async_hooks";
 import process$1 from "node:process";
@@ -1609,7 +1689,7 @@ var init_create_prompt_CIJV_96B = __esm({
       value: mod,
       enumerable: true
     }) : target, mod));
-    __require2 = /* @__PURE__ */ createRequire2(import.meta.url);
+    __require2 = /* @__PURE__ */ createRequire3(import.meta.url);
     isUpKey = (key, keybindings = []) => key.name === "up" || keybindings.includes("vim") && key.name === "k" || keybindings.includes("emacs") && key.ctrl && key.name === "p";
     isDownKey = (key, keybindings = []) => key.name === "down" || keybindings.includes("vim") && key.name === "j" || keybindings.includes("emacs") && key.ctrl && key.name === "n";
     isSpaceKey = (key) => key.name === "space";
@@ -5026,7 +5106,7 @@ import { TextDecoder } from "node:util";
 import { homedir, tmpdir } from "node:os";
 import { dirname, isAbsolute, join, relative, resolve, sep } from "node:path";
 import * as tty from "tty";
-import { spawn as spawn3 } from "node:child_process";
+import { spawn as spawn4 } from "node:child_process";
 import process$12 from "node:process";
 import { randomUUID } from "node:crypto";
 import { URL as URL$1 } from "url";
@@ -6792,7 +6872,7 @@ function registerInstallCleanupHandlers() {
 }
 async function getRemoteCommitHash(repo, ref = "HEAD", timeoutMs = 3e4) {
   return new Promise((resolve$3, reject) => {
-    const child = spawn3("git", [
+    const child = spawn4("git", [
       "ls-remote",
       repo,
       ref
@@ -6845,7 +6925,7 @@ async function gitCloneWithTimeout(repo, dest, branch, timeoutMs, output) {
     ];
     if (branch) args.push("--branch", branch);
     args.push(repo, dest);
-    const child = spawn3("git", args, { stdio: [
+    const child = spawn4("git", args, { stdio: [
       "ignore",
       "pipe",
       "pipe"
@@ -47635,7 +47715,7 @@ var init_provider_icons_generated = __esm({
 // src/daemon/model-catalog.ts
 import fs18 from "node:fs";
 import path22 from "node:path";
-import { createRequire as createRequire3 } from "node:module";
+import { createRequire as createRequire4 } from "node:module";
 function labelOf(provider) {
   for (const [id, label] of KNOWN_LABELS) {
     if (id === provider) return label;
@@ -47646,7 +47726,7 @@ function labelOf(provider) {
   return cn ? `${pretty} \xB7 CN` : pretty;
 }
 function resolveCatalogDataDir() {
-  const require2 = createRequire3(import.meta.url);
+  const require2 = createRequire4(import.meta.url);
   const basePkg = require2.resolve("@deepseek-ai/dsh-base/package.json");
   const baseNm = path22.dirname(path22.dirname(path22.dirname(basePkg)));
   const hostReal = fs18.realpathSync(path22.join(baseNm, "@deepseek-ai/dsh-llm-pi-ai"));
@@ -48765,7 +48845,7 @@ var init_proposals = __esm({
 });
 
 // src/daemon/steward/jsonrpc-stdio.ts
-import { spawn as spawn4 } from "node:child_process";
+import { spawn as spawn5 } from "node:child_process";
 function parseFrame2(raw) {
   let value;
   try {
@@ -48784,7 +48864,7 @@ function onceAbort(signal, onAbort) {
   return () => signal.removeEventListener("abort", listener);
 }
 function defaultStdioSpawn(command, args, options2) {
-  return spawn4(command, args, { cwd: options2.cwd, stdio: ["pipe", "pipe", "pipe"] });
+  return spawn5(command, args, { cwd: options2.cwd, stdio: ["pipe", "pipe", "pipe"] });
 }
 function parseCommandSpec(spec) {
   const trimmed = spec.trim();
@@ -50376,7 +50456,7 @@ var init_skill_creator_mcp = __esm({
 
 // src/cli/cli.ts
 init_daemon();
-import { spawn as spawn5 } from "node:child_process";
+import { spawn as spawn6 } from "node:child_process";
 import fs22 from "node:fs";
 import path28 from "node:path";
 import { fileURLToPath as fileURLToPath3 } from "node:url";
@@ -50707,7 +50787,7 @@ function spawnDaemon(webFlag = void 0) {
   const isTs = entry.endsWith(".ts");
   const baseEnv = { ...process.env };
   const env2 = webFlag === void 0 ? baseEnv : { ...baseEnv, [SKILL_CREATOR_WEB_ENV]: webFlag ? "1" : "0" };
-  const child = isTs ? spawn5("bun", [entry], { detached: true, stdio: "ignore", env: env2 }) : spawn5(process.execPath, [entry], { detached: true, stdio: "ignore", env: env2 });
+  const child = isTs ? spawn6("bun", [entry], { detached: true, stdio: "ignore", env: env2 }) : spawn6(process.execPath, [entry], { detached: true, stdio: "ignore", env: env2 });
   child.unref();
 }
 async function ipcRequest(command, timeoutMs = 4e3, endpoint = socketPath()) {