skalpel 3.4.19 → 4.0.0

package/npm-bin/colors.js

@@ -1,125 +0,0 @@
-'use strict';
-
-// colors.js — Catppuccin Frappé palette wrapper for the npm-side
-// surfaces (npx wizard banner, postinstall success line). Reads the
-// canonical hex values from design-tokens.json (Wave 1 artifact) and
-// wraps Picocolors so NO_COLOR is honoured automatically. The box()
-// helper draws a rounded Unicode-art frame around content; structure
-// chars are emitted unconditionally, only the ANSI sequences are
-// suppressed under NO_COLOR.
-
-const path = require('path');
-const pc = require('picocolors');
-
-const tokens = require(path.resolve(__dirname, '..', 'design-tokens.json'));
-
-const palette = (tokens.themes && tokens.themes['tokyo-night-storm']) || {};
-
-function rgbFromHex(hex) {
-  const m = String(hex || '').replace('#', '').match(/^([0-9a-fA-F]{6})$/);
-  if (!m) return null;
-  const v = parseInt(m[1], 16);
-  return [(v >> 16) & 0xff, (v >> 8) & 0xff, v & 0xff];
-}
-
-function colorize(hex) {
-  const rgb = rgbFromHex(hex);
-  if (!rgb) {
-    return (s) => String(s);
-  }
-  return (s) => {
-    if (process.env.NO_COLOR) return String(s);
-    return `\x1b[38;2;${rgb[0]};${rgb[1]};${rgb[2]}m${s}\x1b[39m`;
-  };
-}
-
-const theme = {};
-for (const name of Object.keys(palette)) {
-  theme[name] = colorize(palette[name]);
-}
-
-function attr(open, close) {
-  return (s) => {
-    if (process.env.NO_COLOR) return String(s);
-    return `\x1b[${open}m${s}\x1b[${close}m`;
-  };
-}
-
-theme.bold = attr(1, 22);
-theme.italic = attr(3, 23);
-theme.dim = attr(2, 22);
-
-const semantic = (tokens.semantic) || {};
-
-function semanticHelper(key) {
-  const ref = semantic[key];
-  if (!ref) return (s) => String(s);
-  const parts = ref.split('.');
-  if (parts.length !== 2) return (s) => String(s);
-  const colorName = parts[1];
-  return theme[colorName] || ((s) => String(s));
-}
-
-function semanticKey(name) {
-  return name
-    .replace(/[^a-zA-Z0-9]+([a-zA-Z0-9])/g, (_, c) => c.toUpperCase())
-    .replace(/^([A-Z])/, (m) => m.toLowerCase());
-}
-
-for (const k of Object.keys(semantic)) {
-  const camel = semanticKey(k);
-  theme[camel] = semanticHelper(k);
-}
-
-const BORDERS = {
-  topLeft: '╭',
-  topRight: '╮',
-  bottomLeft: '╰',
-  bottomRight: '╯',
-  horizontal: '─',
-  vertical: '│',
-};
-
-function visibleLength(s) {
-  return String(s).replace(/\x1b\[[0-9;]*m/g, '').length;
-}
-
-function box(content, borderColor, options) {
-  const opts = options || {};
-  const padding = typeof opts.padding === 'number' ? opts.padding : 1;
-  const lines = String(content).split('\n');
-
-  let inner;
-  if (opts.width === 'fit' || opts.width == null) {
-    inner = 0;
-    for (const ln of lines) {
-      const len = visibleLength(ln);
-      if (len > inner) inner = len;
-    }
-    inner += padding * 2;
-  } else {
-    inner = Math.max(0, Number(opts.width) - 2);
-  }
-
-  const colorOK = pc.isColorSupported && !process.env.NO_COLOR;
-  const colorFn = (colorOK && typeof borderColor === 'string' && theme[borderColor])
-    ? theme[borderColor]
-    : (s) => String(s);
-
-  const horiz = BORDERS.horizontal.repeat(inner);
-  const top = colorFn(BORDERS.topLeft + horiz + BORDERS.topRight);
-  const bottom = colorFn(BORDERS.bottomLeft + horiz + BORDERS.bottomRight);
-  const v = colorFn(BORDERS.vertical);
-  const pad = ' '.repeat(padding);
-
-  const rendered = [top];
-  for (const ln of lines) {
-    const visLen = visibleLength(ln);
-    const fill = ' '.repeat(Math.max(0, inner - padding * 2 - visLen));
-    rendered.push(`${v}${pad}${ln}${fill}${pad}${v}`);
-  }
-  rendered.push(bottom);
-  return rendered.join('\n');
-}
-
-module.exports = { theme, box, BORDERS, palette };

package/npm-bin/skalpel.bug-0039.test.js

@@ -1,232 +0,0 @@
-#!/usr/bin/env node
-// BUG-0039 — Windows daemon missing → Defender-aware warning test.
-//
-// What we're testing: the sibling-check branch in resolveBinary. When
-// the user runs `skalpel <anything>` on Windows AND skalpeld.exe is
-// missing from the platform package's bin/, the CLI must:
-//   - emit a clear actionable warning to stderr
-//   - NOT exit (so --version / --help still work)
-//   - include the PowerShell Add-MpPreference command
-//   - use single-quoted path (neutralises NTFS-legal $ / backtick / ')
-//
-// Stdlib-only, no test framework. Builds a fake @skalpelai/skalpel-*
-// package layout in a tmpdir inside the repo's node_modules so Node's
-// resolver finds it, then patches Module._resolveLookupPaths to prefer
-// the sandbox.
-//
-// Run:  node npm-bin/skalpel.bug-0039.test.js
-'use strict';
-
-const assert = require('assert');
-const fs = require('fs');
-const os = require('os');
-const path = require('path');
-
-let pass = 0;
-let fail = 0;
-
-function t(name, fn) {
-  try {
-    fn();
-    process.stdout.write(`  PASS ${name}\n`);
-    pass += 1;
-  } catch (err) {
-    process.stderr.write(`  FAIL ${name}\n    ${err && err.stack ? err.stack : err}\n`);
-    fail += 1;
-  }
-}
-
-// Capture stderr + intercepted process.exit code.
-function captureStderr(fn) {
-  const original = process.stderr.write.bind(process.stderr);
-  let buf = '';
-  process.stderr.write = (chunk) => {
-    buf += String(chunk);
-    return true;
-  };
-  const origExit = process.exit;
-  let exitCode = null;
-  process.exit = (code) => {
-    exitCode = code;
-    throw new Error('__BUG0039_TEST_EXIT__');
-  };
-  try {
-    try { fn(); } catch (e) {
-      if (e && e.message !== '__BUG0039_TEST_EXIT__') throw e;
-    }
-  } finally {
-    process.stderr.write = original;
-    process.exit = origExit;
-  }
-  return { stderr: buf, exitCode };
-}
-
-function withFakeWin32Package(opts) {
-  // Use os.tmpdir() (NOT in-repo node_modules) so a test crash between
-  // mkdir and finally-cleanup can't leave a stub that shadows the real
-  // platform package on subsequent dev runs.
-  const sandboxRoot = fs.mkdtempSync(path.join(os.tmpdir(), 'bug0039-'));
-  const platDir = path.join(sandboxRoot, 'node_modules', '@skalpelai', 'skalpel-win32-x64');
-  const binDir = path.join(platDir, 'bin');
-  fs.mkdirSync(binDir, { recursive: true });
-  fs.writeFileSync(
-    path.join(platDir, 'package.json'),
-    JSON.stringify({ name: '@skalpelai/skalpel-win32-x64', version: '3.2.2-test' })
-  );
-  fs.writeFileSync(path.join(binDir, 'skalpel.exe'), 'stub');
-  if (opts.daemonPresent) fs.writeFileSync(path.join(binDir, 'skalpeld.exe'), 'stub');
-  return {
-    sandboxRoot,
-    cleanup: () => fs.rmSync(sandboxRoot, { recursive: true, force: true }),
-  };
-}
-
-function withResolveOverride(sandboxRoot, fn) {
-  const Module = require('module');
-  const orig = Module._resolveLookupPaths;
-  Module._resolveLookupPaths = function (request, parent) {
-    const base = orig.call(this, request, parent);
-    if (request && request.startsWith('@skalpelai/skalpel-')) {
-      const inject = path.join(sandboxRoot, 'node_modules');
-      return base && Array.isArray(base) ? [inject, ...base] : [inject];
-    }
-    return base;
-  };
-  try { return fn(); } finally { Module._resolveLookupPaths = orig; }
-}
-
-const skalpel = require('./skalpel.js');
-Object.defineProperty(process, 'platform', { value: 'win32', configurable: true });
-Object.defineProperty(process, 'arch', { value: 'x64', configurable: true });
-
-// ── Test 1: skalpel-resolve + missing sibling daemon → warning, no exit
-t('resolveBinary(\'skalpel\') with missing skalpeld.exe emits warning and returns', () => {
-  const fake = withFakeWin32Package({ daemonPresent: false });
-  try {
-    let returned = null;
-    const { stderr, exitCode } = captureStderr(() => {
-      withResolveOverride(fake.sandboxRoot, () => {
-        returned = skalpel.resolveBinary('skalpel', []);
-      });
-    });
-    // MUST return the resolved skalpel.exe path (no exit)
-    assert.ok(returned, `expected non-null return, got ${returned}`);
-    assert.ok(returned.endsWith('skalpel.exe'), `expected skalpel.exe, got ${returned}`);
-    assert.strictEqual(exitCode, null, `expected NO process.exit, got code=${exitCode}`);
-    // MUST emit Defender-aware warning
-    assert.ok(stderr.includes('skalpel daemon missing'), `expected daemon-missing title:\n${stderr}`);
-    assert.ok(stderr.includes('Defender'), `expected Defender mention:\n${stderr}`);
-    assert.ok(stderr.includes('Add-MpPreference'), `expected PowerShell command:\n${stderr}`);
-    assert.ok(stderr.includes('Authenticode'), `expected code-sign mention:\n${stderr}`);
-    assert.ok(stderr.includes('Restore'), `expected restore path:\n${stderr}`);
-    // PowerShell path is single-quoted (the critical quoting fix)
-    const dirLine = stderr.split('\n').find((l) => l.includes('$dir ='));
-    assert.ok(dirLine, `expected $dir = line, got:\n${stderr}`);
-    assert.ok(/\$dir = '/.test(dirLine), `expected single-quoted path in $dir line: ${dirLine}`);
-    // The Add-MpPreference line should reference $dir (not embed the path)
-    const mpLine = stderr.split('\n').find((l) => l.includes('Add-MpPreference'));
-    assert.ok(mpLine, `expected Add-MpPreference line:\n${stderr}`);
-    assert.ok(/-ExclusionPath \$dir/.test(mpLine), `expected -ExclusionPath $dir: ${mpLine}`);
-  } finally { fake.cleanup(); }
-});
-
-// ── Test 2: happy path (daemon present) → returns path, NO warning
-t('resolveBinary(\'skalpel\') with daemon present: silent, returns path', () => {
-  const fake = withFakeWin32Package({ daemonPresent: true });
-  try {
-    let returned = null;
-    const { stderr, exitCode } = captureStderr(() => {
-      withResolveOverride(fake.sandboxRoot, () => {
-        returned = skalpel.resolveBinary('skalpel', []);
-      });
-    });
-    assert.ok(returned && returned.endsWith('skalpel.exe'), `expected skalpel.exe, got ${returned}`);
-    assert.strictEqual(exitCode, null);
-    assert.ok(!stderr.includes('Defender'), `expected no Defender warning on happy path, got:\n${stderr}`);
-    assert.ok(!stderr.includes('quarantine'), `expected no quarantine mention on happy path:\n${stderr}`);
-  } finally { fake.cleanup(); }
-});
-
-// ── Test 3: skalpel.exe itself missing → generic Binary missing error
-t('resolveBinary(\'skalpel\') with skalpel.exe missing: generic error, NOT Defender block', () => {
-  const fake = withFakeWin32Package({ daemonPresent: false });
-  // Also remove skalpel.exe
-  fs.unlinkSync(path.join(fake.sandboxRoot, 'node_modules', '@skalpelai', 'skalpel-win32-x64', 'bin', 'skalpel.exe'));
-  try {
-    const { stderr, exitCode } = captureStderr(() => {
-      withResolveOverride(fake.sandboxRoot, () => {
-        skalpel.resolveBinary('skalpel', []);
-      });
-    });
-    assert.strictEqual(exitCode, 1, 'expected exit 1 on missing CLI binary');
-    assert.ok(stderr.includes('Binary missing'), `expected generic title:\n${stderr}`);
-    // The Defender block is gated on a successful candidate-exists check,
-    // so it should NOT fire when skalpel.exe itself is missing.
-    assert.ok(!stderr.includes('Defender'), `Defender warning should NOT fire when CLI itself missing:\n${stderr}`);
-  } finally { fake.cleanup(); }
-});
-
-// ── Test 4: non-Windows platform → no sibling check fires
-t('resolveBinary(\'skalpel\') on linux: no sibling check, silent on success', () => {
-  // Temporarily flip to linux + reset PLATFORM_PACKAGES key check
-  Object.defineProperty(process, 'platform', { value: 'linux', configurable: true });
-  try {
-    const sandboxRoot = fs.mkdtempSync(path.join(os.tmpdir(), 'bug0039-linux-'));
-    const platDir = path.join(sandboxRoot, 'node_modules', '@skalpelai', 'skalpel-linux-x64');
-    const binDir = path.join(platDir, 'bin');
-    fs.mkdirSync(binDir, { recursive: true });
-    fs.writeFileSync(path.join(platDir, 'package.json'), JSON.stringify({ name: '@skalpelai/skalpel-linux-x64', version: '3.2.2-test' }));
-    fs.writeFileSync(path.join(binDir, 'skalpel'), 'stub');
-    // daemon intentionally missing
-    try {
-      const { stderr, exitCode } = captureStderr(() => {
-        withResolveOverride(sandboxRoot, () => {
-          skalpel.resolveBinary('skalpel', []);
-        });
-      });
-      assert.strictEqual(exitCode, null, 'expected no exit on linux happy path');
-      assert.ok(!stderr.includes('Defender'), `linux must NOT emit Defender warning:\n${stderr}`);
-    } finally { fs.rmSync(sandboxRoot, { recursive: true, force: true }); }
-  } finally {
-    Object.defineProperty(process, 'platform', { value: 'win32', configurable: true });
-  }
-});
-
-// ── Test 5: PowerShell escape of literal apostrophe in path
-t("PowerShell '' escape activates when path contains a literal apostrophe", () => {
-  // Build a sandbox under a parent dir whose NAME contains an apostrophe.
-  // NTFS allows ' in filenames, and POSIX paths do too. The Defender
-  // exclusion path will be path.dirname(siblingDaemon) — which on this
-  // sandbox includes a "with'apos" segment. The PowerShell single-quote
-  // literal MUST escape the inner ' as '' to remain valid PS syntax.
-  const parent = fs.mkdtempSync(path.join(os.tmpdir(), "bug0039-apos-"));
-  const aposDir = path.join(parent, "with'apos");
-  const platDir = path.join(aposDir, 'node_modules', '@skalpelai', 'skalpel-win32-x64');
-  const binDir = path.join(platDir, 'bin');
-  fs.mkdirSync(binDir, { recursive: true });
-  fs.writeFileSync(path.join(platDir, 'package.json'), JSON.stringify({ name: '@skalpelai/skalpel-win32-x64', version: '3.2.2-test' }));
-  fs.writeFileSync(path.join(binDir, 'skalpel.exe'), 'stub');
-  // skalpeld.exe intentionally missing
-  try {
-    const { stderr } = captureStderr(() => {
-      withResolveOverride(aposDir, () => {
-        skalpel.resolveBinary('skalpel', []);
-      });
-    });
-    const dirLine = stderr.split('\n').find((l) => l.includes('$dir ='));
-    assert.ok(dirLine, `expected $dir = line, got:\n${stderr}`);
-    // The literal ' in the path must be DOUBLED inside the single-quoted PS literal
-    assert.ok(
-      dirLine.includes("with''apos"),
-      `expected '' escape for literal apostrophe, got: ${dirLine}`
-    );
-    // And the path must still be wrapped in single quotes
-    assert.ok(/\$dir = '.*'$/.test(dirLine.trim()), `expected single-quoted: ${dirLine}`);
-  } finally {
-    fs.rmSync(parent, { recursive: true, force: true });
-  }
-});
-
-// ── summary
-process.stdout.write(`\n  results: ${pass} passed, ${fail} failed\n`);
-if (fail > 0) process.exit(1);