sitespeed.io 33.3.0 → 33.5.0

package/CHANGELOG.md

@@ -1,5 +1,27 @@
 # CHANGELOG - sitespeed.io  (we use [semantic versioning](https://semver.org))
 
+## 33.5.0 - 2024-04-04
+### Added
+* Updated to Edge 123 in the Docker container [#4135](https://github.com/sitespeedio/sitespeed.io/pull/4135).
+* Added missing default green/yellow/red limits for CLS and TTFB on the start page [#4120](https://github.com/sitespeedio/sitespeed.io/pull/4120).
+* Browsertime 21.7.0 with Edgedriver 123.
+
+### Fixed
+* The summary page alway showed blue color for AXE violations. This PR makes them green/yellow/red [#4123](https://github.com/sitespeedio/sitespeed.io/pull/4123).
+* Updated dependencies:
+ * Axe-core 4.9.0 [#4126](https://github.com/sitespeedio/sitespeed.io/pull/4126)
+ * CO2 0.14.4 [#4127](https://github.com/sitespeedio/sitespeed.io/pull/4127)
+ * import-global 1.1.0 [#4129](https://github.com/sitespeedio/sitespeed.io/pull/4129)
+ * AWS SDK 2.1591.0 [#4130](https://github.com/sitespeedio/sitespeed.io/pull/4130)
+ * dayjs 1.11.10, fs-extra 11.2.0, uuid 9.0.1, junit-report-builder 3.2.1, [#4131](https://github.com/sitespeedio/sitespeed.io/pull/4131).
+ * cli-color 2.0.4, node-scp 0.0.23, ora 8.0.1, os-name 5.0.0 and p-limit 5.0.0 [#4132](https://github.com/sitespeedio/sitespeed.io/pull/4132).
+ * tape 5.7.5, find-up 7.0.0, sass 1.72.0 and clean-css-cli 5.6.3 [#4133](https://github.com/sitespeedio/sitespeed.io/pull/4133)
+
+## 33.4.0 - 2024-03-20
+### Added
+* Chrome 123, Firefox 124 and Edge 122 in the Docker container [#4114](https://github.com/sitespeedio/sitespeed.io/pull/4114).
+* Browsertime [21.6.0](https://github.com/sitespeedio/browsertime/blob/main/CHANGELOG.md#2160---2024-03-20) with updated Chrome/Edgedriver and a fix for running `.stopAsError`.
+
 ## 33.3.0 - 2024-03-16
 ### Added
 * Show Long Animation frames (enabled in Chrome 123) [#4180](https://github.com/sitespeedio/sitespeed.io/pull/4108). Using the timeline/profiling is still best doing your tests but long animation frames can help you if you do not have it turned on or familiar with thart data in RUM. Please create an issue if you have any ideas on how we shoudl display the metrics/information!

package/Dockerfile

@@ -1,4 +1,4 @@
-FROM sitespeedio/webbrowsers:chrome-122.0-firefox-123.0-edge-121.0
+FROM sitespeedio/webbrowsers:chrome-123.0-firefox-124.0-edge-123.0
 
 ARG TARGETPLATFORM=linux/amd64
 

package/lib/core/pluginLoader.js

@@ -2,8 +2,7 @@ import { join, basename, resolve, dirname } from 'node:path';
 import { readdir as _readdir } from 'node:fs';
 import { promisify } from 'node:util';
 
-import pkg from 'import-global';
-const { silent } = pkg;
+import { importGlobalSilent } from 'import-global';
 const readdir = promisify(_readdir);
 const __dirname = dirname(import.meta.url);
 
@@ -78,7 +77,7 @@ export async function loadPlugins(pluginNames, options, context, queue) {
           plugins.push(p);
         } catch (error) {
           // try global
-          let plugin = silent(name);
+          let plugin = await importGlobalSilent(name);
           if (plugin) {
             let p = new plugin(options, context, queue);
             plugins.push(p);

package/lib/core/resultsStorage/index.js

@@ -8,7 +8,7 @@ function getDomainOrFileName(input) {
   let domainOrFile = input;
   domainOrFile = domainOrFile.startsWith('http')
     ? parse(domainOrFile).hostname
-    : basename(domainOrFile).replace(/\./g, '_');
+    : basename(domainOrFile).replaceAll('.', '_');
   return domainOrFile;
 }
 

package/lib/core/resultsStorage/pathToFolder.js

@@ -8,7 +8,7 @@ const log = intel.getLogger('sitespeedio.file');
 
 function toSafeKey(key) {
   // U+2013 : EN DASH – as used on https://en.wikipedia.org/wiki/2019–20_coronavirus_pandemic
-  return key.replace(/[ %&()+,./:?|~–]|%7C/g, '-');
+  return key.replaceAll(/[ %&()+,./:?|~–]|%7C/g, '-');
 }
 
 export function pathToFolder(url, options, alias) {
@@ -60,7 +60,7 @@ export function pathToFolder(url, options, alias) {
 
   for (const [index, segment] of pathSegments.entries()) {
     if (segment) {
-      pathSegments[index] = segment.replace(/[^\w.\u0621-\u064A-]/gi, '-');
+      pathSegments[index] = segment.replaceAll(/[^\w.\u0621-\u064A-]/gi, '-');
     }
   }
 

package/lib/plugins/browsertime/analyzer.js

@@ -159,9 +159,8 @@ export async function analyzeUrl(
     }
   }
   const scriptCategories = await browserScripts.allScriptCategories();
-  let scriptsByCategory = await browserScripts.getScriptsForCategories(
-    scriptCategories
-  );
+  let scriptsByCategory =
+    await browserScripts.getScriptsForCategories(scriptCategories);
 
   if (btOptions.script) {
     const userScripts = await parseUserScripts(btOptions.script);

package/lib/plugins/browsertime/filmstrip.js

@@ -194,10 +194,10 @@ export async function getFilmstrip(
     const files = await readdir(join(dir, 'data', 'filmstrip', run + ''));
     const timings = [];
     for (let file of files) {
-      timings.push({ time: file.replace(/\D/g, ''), file });
+      timings.push({ time: file.replaceAll(/\D/g, ''), file });
     }
 
-    const maxTiming = timings.slice(-1)[0].time;
+    const maxTiming = timings.at(-1).time;
 
     // We step 100 ms each step ... but if you wanna show all and the last change is late
     // use 200 ms

package/lib/plugins/budget/junit.js

@@ -18,9 +18,9 @@ export function writeJunit(results, dir, options) {
     if (url.startsWith('http')) {
       const parsedUrl = parse(url);
       name = url.startsWith('http') ? url : url;
-      parsedUrl.hostname.replace(/\./g, '_') +
+      parsedUrl.hostname.replaceAll('.', '_') +
         '.' +
-        parsedUrl.path.replace(/\./g, '_').replace(/\//g, '_');
+        parsedUrl.path.replaceAll('.', '_').replaceAll('/', '_');
     }
 
     const suite = jrp

package/lib/plugins/gcs/index.js

@@ -114,7 +114,7 @@ export default class GcsPlugin extends SitespeedioPlugin {
         if (this.options.copyLatestFilesToBase) {
           const rootPath = resolve(baseDir, '..');
           const directoriesAsArray = rootPath.split(sep);
-          const rootName = directoriesAsArray.slice(-1)[0];
+          const rootName = directoriesAsArray.at(-1);
           await uploadLatestFiles(rootPath, gcsOptions, rootName);
         }
         log.info('Finished upload to Google Cloud Storage');

package/lib/plugins/html/metricHelper.js

@@ -78,8 +78,8 @@ export function getMetricsFromPageSummary(pageInfo) {
     return timings.loadEventEnd
       ? `Median LoadEventEnd: ${timings.loadEventEnd.median}`
       : '' + timings.fullyLoaded
-      ? `Median Fully loaded: ${timings.fullyLoaded.median}`
-      : '';
+        ? `Median Fully loaded: ${timings.fullyLoaded.median}`
+        : '';
   } else {
     return '';
   }

package/lib/plugins/html/setup/summaryBoxes.js

@@ -11,7 +11,7 @@ function infoBox(stat, name, formatter) {
     return;
   }
 
-  return _box(stat, name, 'info', formatter, name.replace(/\s/g, ''));
+  return _box(stat, name, 'info', formatter, name.replaceAll(/\s/g, ''));
 }
 
 function scoreBox(stat, name, formatter, box, limits) {
@@ -30,7 +30,7 @@ function scoreBox(stat, name, formatter, box, limits) {
       label = 'error';
     }
   }
-  return _box(stat, name, label, formatter, name.replace(/\s/g, ''));
+  return _box(stat, name, label, formatter, name.replaceAll(/\s/g, ''));
 }
 
 function timingBox(stat, name, formatter, box, limits) {
@@ -50,7 +50,7 @@ function timingBox(stat, name, formatter, box, limits) {
     }
   }
 
-  return _box(stat, name, label, formatter, name.replace(/\s/g, ''));
+  return _box(stat, name, label, formatter, name.replaceAll(/\s/g, ''));
 }
 
 function pagexrayBox(stat, name, formatter, box, limits) {
@@ -69,7 +69,7 @@ function pagexrayBox(stat, name, formatter, box, limits) {
     }
   }
 
-  return _box(stat, name, label, formatter, name.replace(/\s/g, ''));
+  return _box(stat, name, label, formatter, name.replaceAll(/\s/g, ''));
 }
 
 function axeBox(stat, name, formatter, url, limits) {
@@ -78,10 +78,10 @@ function axeBox(stat, name, formatter, url, limits) {
   }
   let label = 'info';
 
-  if (limits && limits.green) {
-    if (stat.median === limits.green) {
+  if (limits) {
+    if (stat.median < limits.green) {
       label = 'ok';
-    } else if (stat.median === limits.yellow) {
+    } else if (stat.median < limits.yellow) {
       label = 'warning';
     } else {
       label = 'error';

package/lib/plugins/html/setup/summaryBoxesDefaultLimits.js

@@ -25,6 +25,7 @@ export default {
     firstPaint: { green: 1000, yellow: 2000 },
     firstContentfulPaint: { green: 2000, yellow: 4000 },
     largestContentfulPaint: { green: 2500, yellow: 4000 },
+    backEndTime: { green: 800, yellow: 1800 },
     fullyLoaded: {},
     pageLoadTime: {},
     FirstVisualChange: { green: 1000, yellow: 2000 },
@@ -34,8 +35,8 @@ export default {
     VisualReadiness: { green: 500, yellow: 1000 },
     VisualComplete: {}
   },
-  pageinfo: {
-    cumulativeLayoutShift: {}
+  googleWebVitals: {
+    cumulativeLayoutShift: { green: 0.1, yellow: 0.25 }
   },
   requests: {
     total: { green: 80, yellow: 200 },
@@ -58,10 +59,10 @@ export default {
     transferSize: {}
   },
   axe: {
-    critical: { green: 0, yellow: 1 },
-    serious: { green: 0, yellow: 1 },
-    minor: { green: 0, yellow: 1 },
-    moderate: { green: 0, yellow: 1 }
+    critical: { green: 1, yellow: 2 },
+    serious: { green: 1, yellow: 2 },
+    minor: { green: 1, yellow: 2 },
+    moderate: { green: 1, yellow: 2 }
   },
   cpu: {
     longTasks: { green: 1, yellow: 3 },

package/lib/plugins/s3/index.js

@@ -104,6 +104,12 @@ export default class S3Plugin extends SitespeedioPlugin {
       throwIfMissing(this.s3Options, ['key', 'secret'], 's3');
     }
     this.storageManager = context.storageManager;
+
+    if (!this.s3Options.region) {
+      log.warning(
+        'You are missing region. We will soon upgrade to AWS SDK 3 and then you need to specify region.'
+      );
+    }
   }
   async processMessage(message, queue) {
     if (message.type === 'sitespeedio.setup') {
@@ -127,7 +133,7 @@ export default class S3Plugin extends SitespeedioPlugin {
         if (this.options.copyLatestFilesToBase) {
           const rootPath = _resolve(baseDir, '..');
           const directoriesAsArray = rootPath.split(sep);
-          const rootName = directoriesAsArray.slice(-1)[0];
+          const rootName = directoriesAsArray.at(-1);
           await uploadLatestFiles(rootPath, s3Options, rootName);
         }
         log.info('Finished upload to s3');

package/lib/plugins/text/textBuilder.js

@@ -43,7 +43,7 @@ function getBoxes(metrics, html) {
 // foo bar -> fb
 function abbr(string_) {
   if (/total|overall/i.test(string_)) return string_.trim();
-  return string_.replace(/\w+\s?/g, a => a[0]);
+  return string_.replaceAll(/\w+\s?/g, a => a[0]);
 }
 
 function noop(a) {

package/lib/plugins/thirdparty/aggregator.js

@@ -57,7 +57,7 @@ export class ThirdPartyAggregator {
     for (let tool of Object.keys(cpuPerTool)) {
       pushStats(
         this.cpuPerTool[url],
-        tool.replace(/\./g, '_'),
+        tool.replaceAll('.', '_'),
         cpuPerTool[tool]
       );
     }

package/lib/support/flattenMessage.js

@@ -8,7 +8,7 @@ function joinNonEmpty(strings, delimeter) {
 
 function toSafeKey(key) {
   // U+2013 : EN DASH – as used on https://en.wikipedia.org/wiki/2019–20_coronavirus_pandemic
-  return key.replace(/[ %&()+,./:?|~–]|%7C/g, '_');
+  return key.replaceAll(/[ %&()+,./:?|~–]|%7C/g, '_');
 }
 
 export function keypathFromUrl(url, includeQueryParameters, useHash, group) {

package/lib/support/tsdbUtil.js

@@ -2,7 +2,7 @@ import get from 'lodash.get';
 import { keypathFromUrl } from './flattenMessage.js';
 
 export function toSafeKey(key, safeChar = '_') {
-  return key.replace(/[ %&+,./:?|~–]|%7C/g, safeChar);
+  return key.replaceAll(/[ %&+,./:?|~–]|%7C/g, safeChar);
 }
 export function getConnectivity(options) {
   // if we have a friendly name for your connectivity, use that!