sitespeed.io 27.9.0 → 27.9.1

package/.github/workflows/linux.yml

@@ -65,6 +65,6 @@ jobs:
     - name: Run test without a CLI
       run: xvfb-run node test/runWithoutCli.js
     - name: Run test with Influx 1.8
-      run: bin/sitespeed.js http://127.0.0.1:3001/simple/ -n 1 --influxdb.host 127.0.0.1 --xvfb
+      run: bin/sitespeed.js http://127.0.0.1:3001/simple/ -n 1 --influxdb.host 127.0.0.1 --xvfb --logToFile
     - name: Run test with Influx 2.6.1
       run: bin/sitespeed.js http://127.0.0.1:3001/simple/ -n 1 --influxdb.host 127.0.0.1 --influxdb.port 8087 --influxdb.version 2 --influxdb.organisation sitespeed --influxdb.token sitespeed --xvfb

package/CHANGELOG.md

@@ -1,5 +1,10 @@
 # CHANGELOG - sitespeed.io  (we use [semantic versioning](https://semver.org))
 
+##  27.9.1 - 2023-06-12
+### Fixed
+* Upgraded Browsertime that logs if LCP is not present (instead of logging null)
+* Fix when configure to log to file (that was broken when we moved to ESM) [#3879](https://github.com/sitespeedio/sitespeed.io/pull/3879).
+
 ##  27.9.0 - 2023-06-12
 ### Added
 * Firefox and Edge 114 in the Docker container.

package/lib/core/logging.js

@@ -1,5 +1,6 @@
 import intel from 'intel';
-
+import { createWriteStream } from 'node:fs';
+import { inherits } from 'node:util';
 const {
   INFO,
   DEBUG,
@@ -7,11 +8,44 @@ const {
   TRACE,
   NONE,
   basicConfig,
-  addHandler,
-  handlers,
+  Logger,
+  Handler,
   Formatter
 } = intel;
 
+// FileHandler isn't exposed in Intel when we moved to ESM.
+// To fix that for now we just use the same code as Intel.
+
+function StreamHandler(options) {
+  options = options || {};
+  if (!options.stream) {
+    options = { stream: options };
+  }
+  Handler.call(this, options);
+  this._stream = options.stream;
+}
+
+inherits(StreamHandler, Handler);
+
+StreamHandler.prototype.emit = function streamEmit(record) {
+  this._stream.write(this.format(record) + '\n');
+};
+
+function FileHandler(options) {
+  if (typeof options === 'string') {
+    options = { file: options };
+  }
+  this._file = options.file;
+
+  options.stream = this._open();
+  StreamHandler.call(this, options);
+}
+inherits(FileHandler, StreamHandler);
+
+FileHandler.prototype._open = function open() {
+  return createWriteStream(this._file, { flags: 'a' });
+};
+
 export function configure(options, logDir) {
   options = options || {};
 
@@ -52,8 +86,9 @@ export function configure(options, logDir) {
   }
 
   if (options.logToFile) {
-    addHandler(
-      new handlers.File({
+    let logger = new Logger();
+    logger.addHandler(
+      new FileHandler({
         file: logDir + '/sitespeed.io.log',
         formatter: new Formatter({
           format: '[%(date)s] %(levelname)s: [%(name)s] %(message)s',

package/npm-shrinkwrap.json

@@ -1,12 +1,12 @@
 {
   "name": "sitespeed.io",
-  "version": "27.9.0",
+  "version": "27.9.1",
   "lockfileVersion": 2,
   "requires": true,
   "packages": {
     "": {
       "name": "sitespeed.io",
-      "version": "27.9.0",
+      "version": "27.9.1",
       "license": "MIT",
       "dependencies": {
         "@google-cloud/storage": "6.9.5",
@@ -15,7 +15,7 @@
         "@tgwf/co2": "0.13.4",
         "aws-sdk": "2.1327.0",
         "axe-core": "4.7.2",
-        "browsertime": "17.11.0",
+        "browsertime": "17.11.1",
         "cli-color": "2.0.3",
         "coach-core": "7.2.0",
         "concurrent-queue": "7.0.2",
@@ -1872,9 +1872,9 @@
       }
     },
     "node_modules/browsertime": {
-      "version": "17.11.0",
-      "resolved": "https://registry.npmjs.org/browsertime/-/browsertime-17.11.0.tgz",
-      "integrity": "sha512-IfLXxrNXEbpiPYlTeyIwjrhaSRkneqK91GLk1d47KSueE/e1yqRq+EQ8X9unl89QpUpP53IFzjhIIeTd1gBREQ==",
+      "version": "17.11.1",
+      "resolved": "https://registry.npmjs.org/browsertime/-/browsertime-17.11.1.tgz",
+      "integrity": "sha512-KcGnDH1pVEmfwh5x3A6ix1ZK5mWeSlZk5dG82ygW6JQ79mfVjteRKYXJcEV+SDY0k6sXg1qhZpEPobaciPAOwA==",
       "dependencies": {
         "@cypress/xvfb": "1.2.4",
         "@devicefarmer/adbkit": "2.11.3",
@@ -1900,7 +1900,7 @@
         "lodash.merge": "4.6.2",
         "lodash.pick": "4.4.0",
         "lodash.set": "4.3.2",
-        "selenium-webdriver": "4.9.2",
+        "selenium-webdriver": "4.10.0",
         "yargs": "17.7.2"
       },
       "bin": {
@@ -7999,9 +7999,9 @@
       "integrity": "sha1-e45lYZCyKOgaZq6nSEgNgozS03o="
     },
     "node_modules/selenium-webdriver": {
-      "version": "4.9.2",
-      "resolved": "https://registry.npmjs.org/selenium-webdriver/-/selenium-webdriver-4.9.2.tgz",
-      "integrity": "sha512-0gDswAgVn6qbCYckZetQQvQK9tWW1r7LaumhiqY1/Wl/7JEWG0JANsTbZKnmGc3+cUU76zAi5/p0P8LUweXlig==",
+      "version": "4.10.0",
+      "resolved": "https://registry.npmjs.org/selenium-webdriver/-/selenium-webdriver-4.10.0.tgz",
+      "integrity": "sha512-hSQPw6jgc+ej/UEcdQPG/iBwwMeCEgZr9HByY/J8ToyXztEqXzU9aLsIyrlj1BywBcStO4JQK/zMUWWrV8+riA==",
       "dependencies": {
         "jszip": "^3.10.1",
         "tmp": "^0.2.1",
@@ -10844,9 +10844,9 @@
       }
     },
     "browsertime": {
-      "version": "17.11.0",
-      "resolved": "https://registry.npmjs.org/browsertime/-/browsertime-17.11.0.tgz",
-      "integrity": "sha512-IfLXxrNXEbpiPYlTeyIwjrhaSRkneqK91GLk1d47KSueE/e1yqRq+EQ8X9unl89QpUpP53IFzjhIIeTd1gBREQ==",
+      "version": "17.11.1",
+      "resolved": "https://registry.npmjs.org/browsertime/-/browsertime-17.11.1.tgz",
+      "integrity": "sha512-KcGnDH1pVEmfwh5x3A6ix1ZK5mWeSlZk5dG82ygW6JQ79mfVjteRKYXJcEV+SDY0k6sXg1qhZpEPobaciPAOwA==",
       "requires": {
         "@cypress/xvfb": "1.2.4",
         "@devicefarmer/adbkit": "2.11.3",
@@ -10873,7 +10873,7 @@
         "lodash.merge": "4.6.2",
         "lodash.pick": "4.4.0",
         "lodash.set": "4.3.2",
-        "selenium-webdriver": "4.9.2",
+        "selenium-webdriver": "4.10.0",
         "yargs": "17.7.2"
       }
     },
@@ -15496,9 +15496,9 @@
       "integrity": "sha1-e45lYZCyKOgaZq6nSEgNgozS03o="
     },
     "selenium-webdriver": {
-      "version": "4.9.2",
-      "resolved": "https://registry.npmjs.org/selenium-webdriver/-/selenium-webdriver-4.9.2.tgz",
-      "integrity": "sha512-0gDswAgVn6qbCYckZetQQvQK9tWW1r7LaumhiqY1/Wl/7JEWG0JANsTbZKnmGc3+cUU76zAi5/p0P8LUweXlig==",
+      "version": "4.10.0",
+      "resolved": "https://registry.npmjs.org/selenium-webdriver/-/selenium-webdriver-4.10.0.tgz",
+      "integrity": "sha512-hSQPw6jgc+ej/UEcdQPG/iBwwMeCEgZr9HByY/J8ToyXztEqXzU9aLsIyrlj1BywBcStO4JQK/zMUWWrV8+riA==",
       "requires": {
         "jszip": "^3.10.1",
         "tmp": "^0.2.1",

package/package.json

@@ -5,7 +5,7 @@
     "sitespeed.io": "./bin/sitespeed.js",
     "sitespeed.io-wpr": "./bin/browsertimeWebPageReplay.js"
   },
-  "version": "27.9.0",
+  "version": "27.9.1",
   "description": "Analyze the web performance of your site",
   "keywords": [
     "performance",
@@ -83,7 +83,7 @@
     "@tgwf/co2": "0.13.4",
     "aws-sdk": "2.1327.0",
     "axe-core": "4.7.2",
-    "browsertime": "17.11.0",
+    "browsertime": "17.11.1",
     "coach-core": "7.2.0",
     "cli-color": "2.0.3",
     "concurrent-queue": "7.0.2",