sino-bc-cli 1.8.26 → 1.8.27

package/dist/skills/custom/biz-line-strategy-generate/scripts/test_database_output.py

@@ -0,0 +1,401 @@
+"""数据库输出离线回归：使用真实工作流和替代 CLI，不访问生产数据。"""
+import json
+import sys
+import tempfile
+import unittest
+from pathlib import Path
+from unittest.mock import patch
+
+sys.dont_write_bytecode = True
+sys.path.insert(0, str(Path(__file__).resolve().parent))
+
+from strategy_output import GenerationOutcome, precheck_projects, ready_body, save_result, validate_period
+from strategy_output import load_tags, effect_code, TagCache, industry_condition
+from concurrent.futures import ThreadPoolExecutor
+from run_workflow import run_batch, workflow_parser
+from test_workflow import arguments, small_payload
+from fetch_data import fetch_business, resolve_periods
+from datetime import date
+from argparse import Namespace
+
+
+class DatabaseRules(unittest.TestCase):
+    """明确业务分支及非幂等写入边界。"""
+
+    def test_content_review_handoff_and_real_tag_ids(self):
+        """真实文件协议：名称不同也能由内容分析选择，Excel 名称与入库 ID 同源。"""
+        import threading
+        from strategy_output import review_tags, attach_tags
+        row = {key + 'Strategy': '上调 5 个广告组出价，分布在 EN（5个）'
+               for key in ('budget', 'product', 'audience')}
+        dictionaries = {key: [{'id': index, 'name': '竞价增强'}, {'id': index + 10, 'name': '其他'}]
+                        for index, key in enumerate(('budget', 'product', 'audience'), 1)}
+        with tempfile.TemporaryDirectory() as tmp:
+            def respond(event):
+                self.assertEqual(event['event'], 'tag_review_required')
+                request = json.loads(Path(event['request_path']).read_text(encoding='utf-8'))
+                self.assertEqual(request['budget']['strategy'], row['budgetStrategy'])
+                self.assertEqual(request['budget']['labels'], dictionaries['budget'])
+                selection = {key: [{'id': labels[0]['id'], 'reason': '上调广告组出价对应竞价增强'}]
+                             for key, labels in dictionaries.items()}
+                Path(event['response_path']).write_text(json.dumps(selection), encoding='utf-8')
+            choices = review_tags(row, dictionaries, {}, Path(tmp), threading.Event(), respond)
+            attach_tags(row, dictionaries, {}, choices)
+            self.assertEqual(row['budgetTagIds'], [1])
+            self.assertEqual(row['budgetTags'], '竞价增强')
+
+    def test_tag_review_rejects_foreign_ids_and_other_mixed_with_match(self):
+        """不接受跨场景 ID、无理由、重复选择或具体标签同时带其他。"""
+        from strategy_output import reviewed_tags
+        labels = [{'id': 1, 'name': '拓展受众'}, {'id': 2, 'name': '其他'}]
+        for choices in ([], [{'id': 99, 'reason': '错误场景'}], [{'id': 1}],
+                        [{'id': 1, 'reason': '新增受众'}, {'id': 2, 'reason': '其他'}],
+                        [{'id': 1, 'reason': '新增受众'}, {'id': 1, 'reason': '重复'}]):
+            with self.subTest(choices=choices), self.assertRaises(ValueError):
+                reviewed_tags(labels, choices)
+        self.assertEqual(reviewed_tags(labels, [{'id': 2, 'reason': '正文未涉及受众拓展，其他标签均不适用'}]), [labels[1]])
+
+    def test_tag_review_cancellation(self):
+        """等待分析时取消可立即清理退出，不阻塞下一批。"""
+        import threading
+        from strategy_output import review_tags
+        cancel = threading.Event()
+        cancel.set()
+        keys = ('budget', 'product', 'audience')
+        with tempfile.TemporaryDirectory() as tmp, self.assertRaises(InterruptedError):
+            review_tags({key + 'Strategy': '内容' for key in keys},
+                        {key: [{'id': 1, 'name': '其他'}] for key in keys}, {}, Path(tmp), cancel, lambda _: None)
+
+    def test_all_zero_stops_before_channel_query(self):
+        with tempfile.TemporaryDirectory() as tmp, patch('strategy_output.run_cli', return_value={
+            'ok': True, 'data': {'result': [{'projectId': 1, 'lastWeekSpend': 0}], 'total': 1}
+        }) as api:
+            with self.assertRaises(GenerationOutcome) as caught:
+                precheck_projects(Path(tmp), 1)
+            self.assertEqual(caught.exception.code, 'NO_DELIVERY_DATA')
+            self.assertEqual(api.call_count, 1)
+            self.assertEqual(api.call_args.args[1], {'bizLineIdList': [1], 'pageNum': 1, 'pageSize': 100})
+
+    def test_explicit_skip_spend_still_checks_projects_and_channels(self):
+        """显式跳过只放行消耗门槛，不放行漏项目或未知渠道。"""
+        project = {'projectId': 1, 'lastWeekSpend': 0, 'channelIdList': ['f']}
+        page = {'ok': True, 'data': {'result': [project], 'total': 1}}
+        channels = {'ok': True, 'data': [{'channelId': 'f', 'channelName': 'Meta'}]}
+        with tempfile.TemporaryDirectory() as tmp:
+            with patch('strategy_output.run_cli', side_effect=[page, channels]) as api:
+                precheck_projects(Path(tmp), 1, [1], skip_spend_check=True)
+                self.assertEqual(api.call_count, 2)
+            with patch('strategy_output.run_cli', return_value=page):
+                with self.assertRaisesRegex(RuntimeError, '未覆盖'):
+                    precheck_projects(Path(tmp), 1, [1, 2], skip_spend_check=True)
+            with patch('strategy_output.run_cli', side_effect=[page, {'ok': True, 'data': []}]):
+                with self.assertRaises(GenerationOutcome) as caught:
+                    precheck_projects(Path(tmp), 1, [1], skip_spend_check=True)
+                self.assertEqual(caught.exception.code, 'UNSUPPORTED_CHANNEL')
+        self.assertFalse(workflow_parser().parse_args(['--id', '1']).skip_project_spend_check)
+        self.assertTrue(workflow_parser().parse_args(['--id', '1', '--skip-project-spend-check']).skip_project_spend_check)
+
+    def test_later_page_positive_checks_all_channels(self):
+        pages = [
+            {'ok': True, 'data': {'result': [{'projectId': 1, 'lastWeekSpend': 0, 'channelIdList': ['f']}], 'total': 2}},
+            {'ok': True, 'data': {'result': [{'projectId': 2, 'lastWeekSpend': 2, 'channelIdList': ['g']}], 'total': 2}},
+            {'ok': True, 'data': [{'channelId': 'f', 'channelName': 'Facebook'}, {'channelId': 'g', 'channelName': 'Google'}]},
+        ]
+        with tempfile.TemporaryDirectory() as tmp, patch('strategy_output.run_cli', side_effect=pages) as api:
+            precheck_projects(Path(tmp), 1)
+            self.assertEqual(api.call_count, 3)
+            self.assertEqual(api.call_args_list[1].args[1]['pageNum'], 2)
+
+    def test_missing_spend_and_failed_page_are_not_zero(self):
+        for env in ({'ok': True, 'data': {'result': [{'projectId': 1}], 'total': 1}}, {'ok': False, 'error': 'denied'}):
+            with self.subTest(env=env), tempfile.TemporaryDirectory() as tmp, patch('strategy_output.run_cli', return_value=env):
+                with self.assertRaises(RuntimeError) as caught:
+                    precheck_projects(Path(tmp), 1)
+                self.assertNotEqual(getattr(caught.exception, 'code', None), 'NO_DELIVERY_DATA')
+
+    def test_default_service_filter_cannot_hide_linked_projects(self):
+        """即使分页 total 完整，也要与业务线 projectIds 核对，不能遗漏其他服务项目。"""
+        with tempfile.TemporaryDirectory() as tmp, patch('strategy_output.run_cli', return_value={
+            'ok': True, 'data': {'result': [{'projectId': 1, 'lastWeekSpend': 0}], 'total': 1}
+        }):
+            with self.assertRaisesRegex(RuntimeError, '未覆盖业务线全部关联项目') as caught:
+                precheck_projects(Path(tmp), 1, [1, 2])
+            self.assertNotIsInstance(caught.exception, GenerationOutcome)
+
+    def test_calendar_periods_and_explicit_overrides(self):
+        """周一、周日及跨年均取已结束周，用户可分别覆盖两期。"""
+        args = Namespace(curr_start='', curr_end='', prev_start='', prev_end='')
+        for anchor in (date(2026, 9, 21), date(2026, 9, 22), date(2026, 9, 27)):
+            self.assertEqual(resolve_periods(args, anchor), {
+                'curr': ('2026-09-14', '2026-09-20'), 'prev': ('2026-09-07', '2026-09-13')})
+        self.assertEqual(resolve_periods(args, date(2026, 1, 1)), {
+            'curr': ('2025-12-22', '2025-12-28'), 'prev': ('2025-12-15', '2025-12-21')})
+        args.curr_start, args.curr_end = '2026-09-01', '2026-09-05'
+        self.assertEqual(resolve_periods(args, date(2026, 9, 22))['curr'], ('2026-09-01', '2026-09-05'))
+        self.assertEqual(resolve_periods(args, date(2026, 9, 22))['prev'], ('2026-09-07', '2026-09-13'))
+        args.prev_start, args.prev_end = '2026-08-25', '2026-08-29'
+        self.assertEqual(resolve_periods(args)['prev'], ('2026-08-25', '2026-08-29'))
+        args.prev_end = ''
+        with self.assertRaises(ValueError):
+            resolve_periods(args)
+
+    def test_invalid_week_rejected(self):
+        validate_period('2026-09-07', '2026-09-13')
+        for bounds in [('2026-09-08', '2026-09-13'), ('2026-09-07', '2026-09-20'), ('2026-08-31', '2026-09-06')]:
+            with self.subTest(bounds=bounds), self.assertRaises(ValueError):
+                validate_period(*bounds)
+
+    def test_full_ready_mapping_and_effect_validation(self):
+        row = {}
+        for key in ('budget', 'product', 'audience', 'creative'):
+            row.update({key + 'Strategy': '正文', key + 'Learning': '独立结论', key + 'Effect': 3})
+        for key in ('budget', 'product', 'audience'):
+            row[key + 'TagIds'] = [21]
+        context = {'bizLineId': 1, 'periodStart': '2026-09-07', 'periodEnd': '2026-09-13'}
+        body = ready_body(context, row, 'key.xlsx')
+        self.assertEqual(body['mediaStrategyTags'], [21])
+        self.assertEqual(body['mediaStrategyEffect'], 3)
+        self.assertEqual(body['creativeStrategy'], '正文')
+        self.assertEqual(body['fileStorageKey'], 'key.xlsx')
+        row['creativeEffect'] = 0
+        with self.assertRaises(ValueError):
+            ready_body(context, row, 'key.xlsx')
+
+    def test_save_failure_never_retries(self):
+        with tempfile.TemporaryDirectory() as tmp, patch('strategy_output.run_cli', return_value={'ok': False, 'error': 'timeout'}) as api:
+            with self.assertRaises(RuntimeError):
+                save_result(Path(tmp), {'generateCode': 'NO_PROJECT'})
+            self.assertEqual(api.call_count, 1)
+            self.assertEqual(api.call_args.args[0], ['biz-line', '+ai-strategy-save'])
+
+    def test_dictionary_requests_and_empty_results(self):
+        with tempfile.TemporaryDirectory() as tmp, patch('strategy_output.run_cli', return_value={'ok': True, 'data': [
+            {'id': 1, 'name': '其他', 'isOther': 1, 'children': None}
+        ]}) as api:
+            dictionaries = load_tags(Path(tmp), '11')
+            self.assertEqual(len(dictionaries), 3)
+            self.assertEqual([call.args[1]['sceneCode'] for call in api.call_args_list],
+                             ['BUDGET_STRATEGY', 'MEDIA_STRATEGY', 'AUDIENCE_STRATEGY'])
+            self.assertTrue(all(call.args[1]['filterCondition'] == '11' for call in api.call_args_list))
+            api.return_value = {'ok': True, 'data': []}
+            with self.assertRaises(ValueError):
+                load_tags(Path(tmp), '11')
+
+    def test_industry_cache_concurrent_reuse_and_isolation(self):
+        """多行业并发时同一行业只查三次，且多个行业只取首个。"""
+        with tempfile.TemporaryDirectory() as tmp, patch('strategy_output.run_cli', return_value={
+            'ok': True, 'data': [{'id': 1, 'name': '其他'}]
+        }) as api:
+            cache = TagCache(Path(tmp))
+            lines = [{'adCategoryIndustryIds': ids} for ids in ([11, 22], [11], [22], [33], [22])]
+            with ThreadPoolExecutor(max_workers=3) as executor:
+                values = list(executor.map(cache.get, lines))
+            self.assertIs(values[0], values[1])
+            self.assertEqual(api.call_count, 9)
+            for industry in ('11', '22', '33'):
+                queries = [call.args[1] for call in api.call_args_list if call.args[1]['filterCondition'] == industry]
+                self.assertEqual(queries, [{'sceneCode': scene, 'filterCondition': industry} for scene in
+                    ('BUDGET_STRATEGY', 'MEDIA_STRATEGY', 'AUDIENCE_STRATEGY')])
+            self.assertEqual(len({str(call.args[2]) for call in api.call_args_list}), 9)
+
+    def test_invalid_industry_and_failure_cache(self):
+        """不能改用第二个行业，失败仅缓存对应行业，不影响其他行业。"""
+        for ids in (None, [], [None, 11], [False], [-1], ['bad', 11]):
+            with self.assertRaises(ValueError):
+                industry_condition({'adCategoryIndustryIds': ids})
+        with tempfile.TemporaryDirectory() as tmp, patch('strategy_output.run_cli', return_value={'ok': True, 'data': []}) as api:
+            cache = TagCache(Path(tmp))
+            for _ in range(2):
+                with self.assertRaises((ValueError, RuntimeError)):
+                    cache.get({'adCategoryIndustryIds': [11]})
+            self.assertEqual(api.call_count, 1)
+            api.return_value = {'ok': True, 'data': [{'id': 1, 'name': '其他'}]}
+            cache.get({'adCategoryIndustryIds': [22]})
+            self.assertEqual(api.call_count, 4)
+
+    def test_effects_and_parser(self):
+        self.assertEqual([effect_code(v) for v in ('有效', '无效', '待观察', '待观察（预警）')], [1, 2, 3, 3])
+        self.assertEqual(workflow_parser().parse_args(['--id', '1']).output_mode, 'excel')
+        self.assertEqual(workflow_parser().parse_args(['--id', '1', '--output-mode', 'database']).output_mode, 'database')
+
+    def test_real_fetch_zero_precheck_creates_context_before_stopping(self):
+        """不替换 fetch_business，确认真实入口在广告拉数前结束且可写正确周期状态。"""
+        with tempfile.TemporaryDirectory() as tmp:
+            root = Path(tmp)
+            args = Namespace(**{**vars(arguments(root)), 'id': 1, 'request_dir': str(root), 'output_mode': 'database'})
+            with patch('fetch_data.date', wraps=date) as clock, patch('fetch_data.run_cli', return_value={'ok': True, 'data': {'result': [{
+                'id': 1, 'name': '匿名业务线', 'projectIds': [10],
+                'periodStart': '2026-09-07', 'periodEnd': '2026-09-13',
+            }], 'total': 1}}) as fetch_api, patch('strategy_output.run_cli', return_value={
+                'ok': True, 'data': {'result': [{'projectId': 10, 'lastWeekSpend': 0}], 'total': 1}
+            }):
+                clock.today.return_value = date(2026, 9, 22)
+                with self.assertRaises(GenerationOutcome) as outcome:
+                    fetch_business(args)
+                self.assertEqual(outcome.exception.code, 'NO_DELIVERY_DATA')
+                self.assertEqual(fetch_api.call_count, 1)
+                self.assertEqual(json.loads((root / 'save-context.json').read_text())['periodStart'], '2026-09-14')
+
+    def test_fetch_queries_industry_tags_before_project_precheck(self):
+        """真实 fetch 入口先解析业务线行业并查字典，再进入项目检查。"""
+        with tempfile.TemporaryDirectory() as tmp:
+            args = Namespace(**{**vars(arguments(Path(tmp))), 'id': 1, 'request_dir': tmp,
+                'output_mode': 'database', 'curr_start': '2026-09-07', 'curr_end': '2026-09-13',
+                'tag_cache': TagCache(Path(tmp) / 'tags')})
+            events = []
+            def lookup(*_):
+                events.append('biz')
+                return {'ok': True, 'data': {'result': [{'id': 1, 'projectIds': [10], 'adCategoryIndustryIds': [11, 22]}], 'total': 1}}
+            def tags(command, body, out):
+                events.append(body)
+                return {'ok': True, 'data': [{'id': 1, 'name': '其他'}]}
+            def precheck(*_, **kwargs):
+                events.append('projects')
+                raise GenerationOutcome('NO_DELIVERY_DATA', '全零')
+            with patch('fetch_data.run_cli', side_effect=lookup), patch('strategy_output.run_cli', side_effect=tags), patch('fetch_data.precheck_projects', side_effect=precheck):
+                with self.assertRaises(GenerationOutcome):
+                    fetch_business(args)
+            self.assertEqual(events, ['biz',
+                {'sceneCode': 'BUDGET_STRATEGY', 'filterCondition': '11'},
+                {'sceneCode': 'MEDIA_STRATEGY', 'filterCondition': '11'},
+                {'sceneCode': 'AUDIENCE_STRATEGY', 'filterCondition': '11'}, 'projects'])
+
+    def test_invalid_output_options_do_not_create_files(self):
+        with tempfile.TemporaryDirectory() as tmp:
+            args = arguments(Path(tmp) / 'out')
+            args.output_mode = 'database'
+            with self.assertRaises(ValueError):
+                run_batch(args, temp_parent=Path(tmp))
+            args.output_dir, args.curr_start = None, '2026-09-07'
+            with self.assertRaises(ValueError):
+                run_batch(args, temp_parent=Path(tmp))
+            self.assertFalse(list(Path(tmp).iterdir()))
+
+    def test_unknown_channel_is_not_dropped(self):
+        with tempfile.TemporaryDirectory() as tmp, patch('strategy_output.run_cli', side_effect=[
+            {'ok': True, 'data': {'result': [{'projectId': 1, 'lastWeekSpend': 5, 'channelIdList': ['unknown']}], 'total': 1}},
+            {'ok': True, 'data': [{'channelId': 1, 'channelName': 'Facebook'}]},
+        ]):
+            with self.assertRaises(GenerationOutcome) as outcome:
+                precheck_projects(Path(tmp), 1, [1])
+            self.assertEqual(outcome.exception.code, 'UNSUPPORTED_CHANNEL')
+
+
+class DatabaseWorkflow(unittest.TestCase):
+    """实际工作流导出真实 xlsx，仅替换外部 CLI；检查调用顺序与文件生命周期。"""
+
+    def run_fixture(self, root, *, failure=None, outcome=None):
+        args = arguments(root / 'desktop')
+        args.output_dir, args.output_mode = None, 'database'
+        payload = small_payload()
+        for key in ('budget', 'product', 'audience', 'creative'):
+            payload['rows'][0][key + 'Effect'] = 3
+        calls = []
+        def fetch(local):
+            # 上下文写入时机与生产 fetch_business 一致。
+            (Path(local.request_dir) / 'save-context.json').write_text(json.dumps({
+                'bizLineId': 1, 'periodStart': '2026-09-07', 'periodEnd': '2026-09-13',
+            }))
+            if outcome:
+                raise GenerationOutcome(outcome, 'fixture reason')
+            return {'id': 1, 'name': '匿名样本', 'adCategoryIndustryIds': [11]}
+        def api(command, body, out):
+            calls.append((command, body))
+            if command == ['biz-line', '+categories']:
+                return {'ok': True, 'data': [{'id': len(calls), 'name': '其他'}]}
+            if command == ['common-file', '+upload']:
+                self.assertTrue(Path(body['file']).is_file())
+                self.assertEqual(body['serviceName'], 'sino-opti-hive')
+                if failure == 'upload':
+                    return {'ok': False, 'error': 'upload failed'}
+                return {'ok': True, 'data': {'storageKey': '' if failure == 'empty_key' else 'saved.xlsx'}}
+            if command == ['biz-line', '+ai-strategy-save']:
+                if body['generateCode'] == 'READY':
+                    self.assertFalse((out.parent / 'final.xlsx').exists())
+                    self.assertEqual(body['fileStorageKey'], 'saved.xlsx')
+                    self.assertEqual(body['mediaStrategyEffect'], 3)
+                if failure == 'save':
+                    return {'ok': False, 'error': 'timeout'}
+                if failure == 'save_id':
+                    return {'ok': True, 'data': None}
+                return {'ok': True, 'data': 123}
+            self.fail(f'未知请求 {command}')
+        def progress(event):
+            """通过真实交接文件提供离线 Agent 选择，验证保存前确实完成内容分析交接。"""
+            if event.get('event') == 'tag_review_required':
+                request = json.loads(Path(event['request_path']).read_text(encoding='utf-8'))
+                selections = {key: [{'id': item['labels'][0]['id'], 'reason': '离线样本字典仅有其他'}]
+                              for key, item in request.items()}
+                Path(event['response_path']).write_text(json.dumps(selections), encoding='utf-8')
+        with patch('run_workflow.fetch_business', fetch), patch('run_workflow.summarize_request', return_value=(payload, {
+            'detail_count': 1, 'curr_total': 20, 'tag_evidence': {},
+        })), patch('strategy_output.run_cli', api):
+            result = run_batch(args, progress=progress, temp_parent=root)
+        return result, calls
+
+    def test_success_upload_delete_save_without_desktop(self):
+        with tempfile.TemporaryDirectory() as tmp:
+            root = Path(tmp)
+            result, calls = self.run_fixture(root)
+            self.assertTrue(result['ok'])
+            self.assertEqual(result['results'][0]['aiStrategyId'], 123)
+            self.assertIsNone(result['results'][0]['output_path'])
+            self.assertEqual([c[0] for c in calls][-2:], [['common-file', '+upload'], ['biz-line', '+ai-strategy-save']])
+            self.assertFalse(list(root.rglob('*.xlsx')))
+
+    def test_upload_errors_save_failure_status(self):
+        for failure in ('upload', 'empty_key'):
+            with self.subTest(failure=failure), tempfile.TemporaryDirectory() as tmp:
+                result, calls = self.run_fixture(Path(tmp), failure=failure)
+                self.assertFalse(result['ok'])
+                self.assertEqual(calls[-1][1]['generateCode'], 'GENERATION_FAILED')
+                self.assertNotIn('fileStorageKey', calls[-1][1])
+                self.assertEqual(result['results'][0]['attempts'], 3)
+                self.assertEqual(sum(c[0] == ['common-file', '+upload'] for c in calls), 3)
+
+    def test_save_failure_preserves_key_and_never_writes_again(self):
+        for failure in ('save', 'save_id'):
+            with self.subTest(failure=failure), tempfile.TemporaryDirectory() as tmp:
+                result, calls = self.run_fixture(Path(tmp), failure=failure)
+                self.assertFalse(result['ok'])
+                self.assertEqual(sum(c[0] == ['biz-line', '+ai-strategy-save'] for c in calls), 1)
+                self.assertEqual(result['results'][0]['storageKey'], 'saved.xlsx')
+                self.assertTrue(result['results'][0]['save_result_unknown'])
+                self.assertFalse(list(Path(tmp).rglob('*.xlsx')))
+
+    def test_failed_business_status_save_is_not_replayed(self):
+        """不可生成状态保存超时同样可能已落库，不整条重跑。"""
+        with tempfile.TemporaryDirectory() as tmp:
+            result, calls = self.run_fixture(Path(tmp), failure='save', outcome='NO_PROJECT')
+            self.assertFalse(result['ok'])
+            self.assertTrue(result['results'][0]['save_result_unknown'])
+            self.assertEqual(result['results'][0]['attempts'], 1)
+            self.assertEqual(len(calls), 1)
+
+    def test_business_outcomes_saved_without_excel_or_upload(self):
+        for code in ('NO_PROJECT', 'UNSUPPORTED_CHANNEL', 'NO_AD_ACCOUNT', 'NO_DELIVERY_DATA'):
+            with self.subTest(code=code), tempfile.TemporaryDirectory() as tmp:
+                result, calls = self.run_fixture(Path(tmp), outcome=code)
+                self.assertTrue(result['ok'])
+                self.assertEqual(len(calls), 1)
+                self.assertEqual(calls[0][1]['generateCode'], code)
+                self.assertFalse(list(Path(tmp).rglob('*.xlsx')))
+
+    def test_excel_delete_failure_is_reported(self):
+        """模拟文件被占用，不能宣称清理成功；测试结束后由临时目录清理样本。"""
+        real_unlink = Path.unlink
+        def locked(path, *args, **kwargs):
+            if path.name == 'final.xlsx':
+                raise PermissionError('fixture file locked')
+            return real_unlink(path, *args, **kwargs)
+        with tempfile.TemporaryDirectory() as tmp:
+            with patch.object(Path, 'unlink', locked):
+                result, calls = self.run_fixture(Path(tmp))
+            self.assertFalse(result['ok'])
+            self.assertTrue(result['results'][0]['cleanup_failed'])
+            self.assertIn('fixture file locked', str(result))
+            self.assertEqual(calls[-1][1]['generateCode'], 'GENERATION_FAILED')
+
+
+if __name__ == '__main__':
+    unittest.main()

package/dist/skills/custom/biz-line-strategy-generate/scripts/test_strategy_rules.py

@@ -58,13 +58,23 @@ def test_page_cap_covers_tiktok_bid_pages():
 
 
 def test_period_verdict_follows_qoq_not_kpi():
-    # 第二期：KPI 未达标也不能单独打成无效
-    assert period_verdict(first_period=False, qoq_label="变好", kpi_usable=True, kpi_hit=False) == "有效"
-    assert period_verdict(first_period=False, qoq_label="变差", kpi_usable=True, kpi_hit=False) == "待观察（预警）"
-    assert period_verdict(first_period=False, qoq_label="稳定", kpi_usable=True, kpi_hit=True) == "待观察"
-    # 首期：KPI 认不出 → 待观察
-    assert period_verdict(first_period=True, qoq_label="无法对比", kpi_usable=False, kpi_hit=None) == "待观察"
-    assert period_verdict(first_period=True, qoq_label="无法对比", kpi_usable=True, kpi_hit=True) == "有效"
+    # 四象限同时依赖达标与趋势；未知数据不能伪造有效或无效。
+    from cli_json import learning_text, amount_change
+    from strategy_output import effect_code
+    cases = [(True, '变好', '有效', '策略有效', 1), (True, '稳定', '有效', '策略有效', 1),
+             (True, '变差', '待观察（预警）', '警惕，再观察一周', 3),
+             (False, '变好', '待观察（潜力）', '再给一周机会', 3),
+             (False, '稳定', '无效', '需关停', 2), (False, '变差', '无效', '需关停', 2)]
+    for hit, trend, verdict, note, effect in cases:
+        actual = period_verdict(first_period=False, qoq_label=trend, kpi_usable=True, kpi_hit=hit)
+        assert actual == verdict
+        assert learning_text(actual) == f'结论：{verdict}\n说明：{note}'
+        assert effect_code(actual) == effect
+    for hit in (None, True, False):
+        assert period_verdict(first_period=False, qoq_label='无法对比', kpi_usable=True, kpi_hit=hit) == '待观察'
+    assert period_verdict(first_period=False, qoq_label='变好', kpi_usable=False) == '待观察'
+    assert amount_change(150, 100) == '环比 +50.00%'
+    assert '不可计算' in amount_change(100, 0)
 
 
 def test_is_first_period_uses_prev_dates():
@@ -115,7 +125,7 @@ def test_naming_patterns_picks_short_tokens():
         "KPOP测试-线下周边-803-东南亚仅马泰-自制-英语-登录-2609",
         "彩妆测试-整体妆容-东南亚-自制-英语-install-260916",
     ]
-    text = naming_patterns(names)
+    text = naming_patterns(names, limit=10)
     assert "KPOP" in text or "舞蹈" in text
     assert "彩妆" in text or "整体妆容" in text
     assert len(text) < 200