sino-bc-cli 1.8.20 → 1.8.21

package/dist/skills/custom/biz-line-strategy-generate/scripts/test_workflow.py

@@ -0,0 +1,345 @@
+"""离线回归：指标口径、分页、并发、最终文件和清理边界，不请求业务网关。"""
+import json
+import os
+import subprocess
+import sys
+import tempfile
+import threading
+import time
+import unittest
+from pathlib import Path
+from unittest.mock import patch
+
+sys.dont_write_bytecode = True
+sys.path.insert(0, str(Path(__file__).resolve().parent))
+
+from cli_json import run_cli
+from fetch_data import fetch_paged
+from summarize import bid_changes, dim_layer_text
+from cli_json import core_rule, metric_value, qoq_axis, cli_context, exec_cli_to_file, shim_entry
+from cleanup import OwnedDirectory
+from build_report import write_xlsx, validate_xlsx, prepare_layout, COLUMNS
+from run_workflow import run_batch, execute_business, publish
+from argparse import Namespace
+
+
+def arguments(output, ids=None):
+    """测试批次沿用真实入口参数，不访问业务接口。"""
+    return Namespace(id=ids or [1], name='', concurrency=3, output_dir=str(output), curr_start='', curr_end='', prev_start='', prev_end='', account_fb=[], account_gg=[], account_tt=[])
+
+
+def small_payload():
+    """只包含匿名样本的完整 12 列数据。"""
+    return {'rows': [{key: ('示例' if key == 'bizLine' else label) for key, label in COLUMNS}],
+            'details': [{'bizLine': '示例', 'kind': '广告', 'action': '新增', 'name': '同名', 'extra': 'ID=1'}]}
+
+
+class DataRules(unittest.TestCase):
+    """防止缺失值和失败回包被当作有效业务数据。"""
+
+    def test_no_default_cpm_kpi(self):
+        text, hit, _, _ = dim_layer_text("广告", [{"label": "A", "spend": 80, "imps": 10000, "cpm": 8}], [])
+        self.assertNotIn("未达标", text)
+        self.assertIsNone(hit)
+
+    def test_missing_bid_not_zero(self):
+        self.assertEqual(bid_changes([
+            {"adgroup_id": "1", "calendar_date": "2026-09-01", "bid_amount": None},
+            {"adgroup_id": "1", "calendar_date": "2026-09-02", "bid_amount": 2},
+        ], ["bid_amount"]), [])
+
+    def test_failed_page_never_writes_merged(self):
+        with tempfile.TemporaryDirectory() as tmp, patch("fetch_data.run_cli", return_value={"ok": False, "error": "失败"}):
+            with self.assertRaises(RuntimeError):
+                fetch_paged("+facebook-metrics", {}, "fixture", Path(tmp))
+            self.assertFalse((Path(tmp) / "fixture.merged.json").exists())
+
+    def test_short_page_still_fetches_total(self):
+        pages = [{"ok": True, "data": {"data": [{"id": 1}], "total": 2}}, {"ok": True, "data": {"data": [], "total": 2}}]
+        with tempfile.TemporaryDirectory() as tmp, patch("fetch_data.run_cli", side_effect=pages):
+            with self.assertRaises(RuntimeError):
+                fetch_paged("+facebook-metrics", {}, "fixture", Path(tmp))
+
+    def test_stderr_and_nonzero_override_success(self):
+        with tempfile.TemporaryDirectory() as tmp:
+            # 替身使用真实子进程证明退出码和 stderr 不被吞掉。
+            command = [sys.executable, "-c", 'import sys; print(\'{"ok": true}\'); sys.stderr.write("fixture denied"); sys.exit(2)']
+            with patch("cli_json.resolve_cli", return_value=command):
+                result = run_cli([], None, Path(tmp) / "response.out.json")
+            self.assertFalse(result["ok"])
+            self.assertIn("fixture denied", str(result))
+
+    def test_metric_units_denominator_and_direction(self):
+        self.assertFalse(core_rule('人民币 CPA≤30，次留>20%')['usable'])
+        rule = core_rule('CPI USD <= 3')
+        self.assertTrue(rule['usable'])
+        self.assertEqual(metric_value([{'spend_usd': 10, 'installs': 1}, {'spend_usd': 90, 'installs': 49}]), 2)
+        self.assertIsNone(metric_value([{'spend_usd': 10, 'installs': 0}]))
+        self.assertIsNone(metric_value([{'spend_usd': 10, 'installs': 10}, {'spend_usd': 50}]))
+        self.assertEqual(qoq_axis(2, 1, True)[0], '变好')
+
+    def test_page_cap_is_failure(self):
+        page = {'ok': True, 'data': {'data': [{'id': 1}], 'total': 2}}
+        with tempfile.TemporaryDirectory() as tmp, patch('fetch_data.PAGE_CAP', 1), patch('fetch_data.run_cli', return_value=page):
+            with self.assertRaises(RuntimeError):
+                fetch_paged('+facebook-metrics', {}, 'fixture', Path(tmp))
+
+    def test_zero_total_with_nonempty_rows_is_invalid(self):
+        with tempfile.TemporaryDirectory() as tmp, patch('fetch_data.run_cli', return_value={'ok': True, 'data': {'data': [{'id': 1}], 'total': 0}}):
+            with self.assertRaises(RuntimeError):
+                fetch_paged('+facebook-metrics', {}, 'fixture', Path(tmp))
+
+    def test_pnpm_shim_path(self):
+        with tempfile.TemporaryDirectory() as tmp:
+            root = Path(tmp)
+            entry = root / 'global/5/node_modules/sino-bc-cli/dist/index.js'
+            entry.parent.mkdir(parents=True)
+            entry.write_text('// fixture')
+            shim = root / 'sino-bc-cli.cmd'
+            shim.write_text('@node "%~dp0global/5/node_modules/sino-bc-cli/dist/index.js" %*')
+            self.assertEqual(shim_entry(shim), entry.resolve())
+            self.assertTrue(core_rule('CPI <= 2 usd')['usable'])
+
+    def test_multiple_bid_fields_count_changed_days_once(self):
+        changes = bid_changes([
+            {'adgroup_id': '1', 'calendar_date': '2026-09-01', 'cpc': 1, 'cpm': 5},
+            {'adgroup_id': '1', 'calendar_date': '2026-09-02', 'cpc': 2, 'cpm': 6},
+            {'adgroup_id': '1', 'calendar_date': '2026-09-03', 'cpc': 1, 'cpm': 5},
+        ], ['cpc', 'cpm'])
+        self.assertEqual(changes[0]['times'], 2)
+        self.assertEqual(changes[0]['from'], changes[0]['to'])
+
+    def test_complete_fetch_analysis_and_id_details(self):
+        from fetch_data import fetch_business
+        from summarize import summarize_request
+        with tempfile.TemporaryDirectory() as tmp:
+            root = Path(tmp)
+            args = arguments(root / 'output')
+            args.id, args.request_dir = 1, str(root)
+            biz = {'id': 1, 'name': '匿名样本', 'periodStart': '2026-09-08', 'periodEnd': '2026-09-14', 'prevPeriodStart': '2026-09-01', 'prevPeriodEnd': '2026-09-07', 'coreIndex': 'CPI USD <= 3'}
+            def api(command, body, out):
+                # 替身核对生产 shortcut/请求体，并像 CLI 一样落盘基础回包。
+                self.assertEqual(command[0], 'biz-line')
+                if command[1] == '+list':
+                    self.assertEqual(body['idList'], [1])
+                    env = {'ok': True, 'data': {'result': [biz], 'total': 1}}
+                elif command[1] == '+detail':
+                    env = {'ok': True, 'data': biz}
+                elif command[1] == '+project-list':
+                    env = {'ok': True, 'data': [{'projectName': '样本项目', 'adAccounts': [{'adAccountId': 'fixture', 'channelName': 'Facebook'}]}]}
+                else:
+                    self.assertIn(command[1], ('+facebook-dimension', '+facebook-metrics'))
+                    self.assertEqual(body['dimensionValues'], {'account_id': ['fixture']})
+                    self.assertEqual(body['size'], 1000)
+                    current = body['startDate'] == biz['periodStart']
+                    dim = body['dimensions']
+                    metrics = {'spend_usd': 100, 'installs': 50 if current else 25, 'impressions': 10000, 'clicks': 500, 'purchase': 10, 'purchase_value': 300}
+                    rows = []
+                    if dim == ['account_id']:
+                        rows = [metrics]
+                    elif dim == ['calendar_date']:
+                        first, count = (8, 6) if current else (1, 7)
+                        rows = [{**metrics, 'calendar_date': f'2026-09-{d:02d}'} for d in range(first, first + count)]
+                    elif dim == ['ad_id', 'ad_name'] or dim == ['adgroup_id', 'adgroup_name']:
+                        rows = [{**metrics, dim[0]: str(i), dim[1]: '同名'} for i in (1, 2)] if current else []
+                    elif dim == ['country_code']:
+                        rows = [{**metrics, 'country_code': 'US'}]
+                    elif dim[0] == 'calendar_date':
+                        rows = [{'adgroup_id': '1', 'adgroup_name': '同名', 'calendar_date': f'2026-09-{d:02d}', 'bid_amount': bid} for d, bid in ((8, 1), (9, 2), (10, 1))]
+                    env = {'ok': True, 'data': {'data': rows, 'total': len(rows)}}
+                out.parent.mkdir(parents=True, exist_ok=True)
+                out.write_text(json.dumps(env, ensure_ascii=False), encoding='utf-8')
+                return env
+            with patch('fetch_data.run_cli', api), cli_context(threading.Event(), lambda _: None):
+                fetch_business(args)
+            payload, summary = summarize_request(root)
+            self.assertEqual(summary['overall_cpi'], [2, 4])
+            self.assertEqual(summary['spend_verdict'], '有效')
+            self.assertIn('覆盖不完整', payload['rows'][0]['period'])
+            for kind in ('广告', '广告组'):
+                objects = [r for r in payload['details'] if r['kind'] == kind]
+                self.assertEqual(len(objects), 2)
+                self.assertIn('ID=1', objects[0]['extra'])
+                self.assertIn('ID=2', objects[1]['extra'])
+            bid = next(r for r in payload['details'] if r['kind'] == '出价')
+            self.assertNotEqual(bid['action'], '下调')
+            # 汇总前损坏已完成文件必须失败，不能重新退回第一页继续。
+            (root / 'bl-1/met_fb_curr_account_id.merged.json').write_text('[]')
+            with self.assertRaises(ValueError):
+                summarize_request(root)
+
+
+class CleanupAndExport(unittest.TestCase):
+    """真实文件验证不同扩展名、链接目标、锁失败和最终 Excel 保护。"""
+
+    def test_all_types_and_final_protected(self):
+        with tempfile.TemporaryDirectory() as tmp:
+            root = Path(tmp)
+            owned = OwnedDirectory.create(root, 'owned-')
+            final = root / 'final.xlsx'
+            final.write_text('final')
+            history = root / 'history.json'
+            history.write_text('history')
+            for name in ('raw.json', 'preview.png', 'temp.xlsx', 'run.py', 'log.txt', 'no-extension'):
+                (owned.path / name).write_text('temp')
+            (owned.path / 'cache').mkdir()
+            (owned.path / 'cache/a.pyc').write_bytes(b'cache')
+            self.assertTrue(owned.cleanup(final)['ok'])
+            self.assertFalse(owned.path.exists())
+            self.assertTrue(final.exists() and history.exists())
+
+    def test_final_inside_and_forged_owner_refused(self):
+        with tempfile.TemporaryDirectory() as tmp:
+            owned = OwnedDirectory.create(Path(tmp), 'owned-')
+            self.assertFalse(owned.cleanup(owned.path / 'final.xlsx')['ok'])
+            fake = OwnedDirectory(owned.path, owned.parent, 'wrong')
+            self.assertFalse(fake.cleanup()['ok'])
+            self.assertTrue(owned.cleanup()['ok'])
+
+    def test_external_junction_or_symlink_target_survives(self):
+        with tempfile.TemporaryDirectory() as tmp:
+            root = Path(tmp)
+            outside = root / 'external'
+            outside.mkdir()
+            (outside / 'keep').write_text('keep')
+            owned = OwnedDirectory.create(root, 'owned-')
+            link = owned.path / 'link'
+            if os.name == 'nt':
+                # 仅建立受控测试路径的 junction，不通过 shell 执行任何删除。
+                subprocess.run(['cmd', '/c', 'mklink', '/J', str(link), str(outside)], check=True, stdout=subprocess.DEVNULL)
+            else:
+                link.symlink_to(outside, target_is_directory=True)
+            self.assertTrue(owned.cleanup()['ok'])
+            self.assertEqual((outside / 'keep').read_text(), 'keep')
+
+    def test_delete_error_reported(self):
+        with tempfile.TemporaryDirectory() as tmp:
+            owned = OwnedDirectory.create(Path(tmp), 'owned-')
+            (owned.path / 'locked').write_text('locked')
+            real_unlink = Path.unlink
+            def locked(path, *args, **kwargs):
+                if path.name == 'locked':
+                    raise PermissionError('file in use')
+                return real_unlink(path, *args, **kwargs)
+            with patch.object(Path, 'unlink', locked):
+                result = owned.cleanup()
+            self.assertFalse(result['ok'])
+            self.assertIn('locked', str(result['residual']))
+            self.assertTrue(owned.cleanup()['ok'])
+
+    def test_long_text_full_export_and_no_overwrite(self):
+        with tempfile.TemporaryDirectory() as tmp:
+            payload = small_payload()
+            long_text = '完整说明与特殊字符 <&>\n' * 5000
+            payload['details'][0]['extra'] = long_text
+            payload['rows'][0]['budgetStrategy'] = long_text
+            path = Path(tmp) / 'out.xlsx'
+            write_xlsx(payload['rows'], str(path), payload['details'])
+            counts = validate_xlsx(path, payload['rows'], payload['details'])
+            self.assertGreater(counts['details'], 1)
+            _, details = prepare_layout(payload['rows'], payload['details'])
+            self.assertEqual(''.join(r['extra'] for r in details if r['kind'] == '广告'), long_text)
+            with self.assertRaises(FileExistsError):
+                write_xlsx(payload['rows'], str(path), payload['details'])
+            final = Path(tmp) / 'final.xlsx'
+            final.write_bytes(b'existing')
+            with self.assertRaises(FileExistsError):
+                publish(path, final, payload)
+            self.assertEqual(final.read_bytes(), b'existing')
+            with self.assertRaises(ValueError):
+                validate_xlsx(path, small_payload()['rows'], [])
+
+
+class BatchExecution(unittest.TestCase):
+    """通过阻塞屏障验证实际重叠、即时交付以及任务隔离。"""
+
+    def test_ten_jobs_peak_three_and_deduplicate(self):
+        with tempfile.TemporaryDirectory() as tmp:
+            root = Path(tmp)
+            args = arguments(root / 'output', list(range(1, 11)) + [1])
+            barrier = threading.Barrier(3)
+            lock = threading.Lock()
+            active = peak = 0
+            observed = []
+            def worker(target, args, batch, cancel, progress):
+                nonlocal active, peak
+                with lock:
+                    active += 1
+                    peak = max(peak, active)
+                owned = OwnedDirectory.create(batch.path, f'line-{target}-')
+                if target <= 3:
+                    barrier.wait(timeout=5)
+                time.sleep(0.02 if target != 1 else 0.12)
+                cleanup = owned.cleanup()
+                with lock:
+                    active -= 1
+                return {'id': target, 'ok': True, 'cleanup': cleanup}
+            result = run_batch(args, worker=worker, progress=observed.append, temp_parent=root)
+            self.assertTrue(result['ok'])
+            self.assertEqual(result['success'], 10)
+            self.assertEqual(peak, 3)
+            self.assertNotEqual(observed[0]['id'], 1)
+            self.assertFalse(list((root / 'sino-bc-strategy').iterdir()))
+
+    def test_mixed_real_worker_results_cleanup_immediate(self):
+        with tempfile.TemporaryDirectory() as tmp:
+            root = Path(tmp)
+            args = arguments(root / 'output', [1, 2, 3])
+            def fetch(local):
+                (Path(local.request_dir) / 'fixture.json').write_text('{}')
+                if local.id == 2:
+                    raise RuntimeError('fixture fetch failed')
+                return {'id': local.id, 'name': '同名'}
+            with patch('run_workflow.fetch_business', fetch), patch('run_workflow.summarize_request', return_value=(small_payload(), {'detail_count': 1})):
+                result = run_batch(args, progress=lambda _: None, temp_parent=root)
+            self.assertFalse(result['ok'])
+            self.assertEqual(result['success'], 2)
+            self.assertEqual(len(list((root / 'output').glob('*.xlsx'))), 2)
+            self.assertFalse(list((root / 'sino-bc-strategy').iterdir()))
+            self.assertIn('fixture fetch failed', str(result))
+
+    def test_invalid_concurrency_before_creating_directory(self):
+        with tempfile.TemporaryDirectory() as tmp:
+            args = arguments(Path(tmp) / 'output')
+            args.concurrency = 4
+            with self.assertRaises(ValueError):
+                run_batch(args, temp_parent=Path(tmp))
+            self.assertFalse(list(Path(tmp).iterdir()))
+
+    def test_cleanup_failure_keeps_final_and_fails_batch(self):
+        with tempfile.TemporaryDirectory() as tmp:
+            root = Path(tmp)
+            real_cleanup = OwnedDirectory.cleanup
+            def locked_cleanup(owned, final=None):
+                if owned.path.name.startswith('line-1-'):
+                    return {'ok': False, 'residual': [{'path': str(owned.path), 'error': 'fixture locked'}]}
+                return real_cleanup(owned, final)
+            with patch('run_workflow.fetch_business', return_value={'id': 1, 'name': '样本'}), patch('run_workflow.summarize_request', return_value=(small_payload(), {'detail_count': 1})), patch.object(OwnedDirectory, 'cleanup', locked_cleanup):
+                result = run_batch(arguments(root / 'output'), progress=lambda _: None, temp_parent=root)
+            self.assertFalse(result['ok'])
+            self.assertTrue(Path(result['results'][0]['output_path']).is_file())
+            self.assertTrue(result['results'][0]['cleanup_failed'])
+            self.assertTrue(result['cleanup']['residual'])
+
+    def test_cancel_terminates_cli_and_cleans(self):
+        with tempfile.TemporaryDirectory() as tmp:
+            cancel = threading.Event()
+            timer = threading.Timer(0.15, cancel.set)
+            timer.start()
+            try:
+                with cli_context(cancel, lambda _: None):
+                    with self.assertRaises(InterruptedError):
+                        exec_cli_to_file([sys.executable, '-c', 'import time; time.sleep(30)'], Path(tmp) / 'cancel.out.json')
+            finally:
+                timer.join()
+            # 子进程退出后输出文件可立即独占打开，证明不持有清理所需句柄。
+            with (Path(tmp) / 'cancel.out.json').open('wb') as stream:
+                stream.write(b'closed')
+            args = arguments(Path(tmp) / 'output', [1, 2, 3, 4])
+            result = run_batch(args, cancel=cancel, progress=lambda _: None, temp_parent=Path(tmp))
+            self.assertEqual(result['failed'], 4)
+            self.assertFalse(list((Path(tmp) / 'sino-bc-strategy').iterdir()))
+
+
+if __name__ == "__main__":
+    unittest.main()

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "sino-bc-cli",
-  "version": "1.8.20",
+  "version": "1.8.21",
   "description": "BeyondClick CLI - 命令行工具集合，提供快捷访问 BeyondClick 平台的命令行接口",
   "preferGlobal": true,
   "bin": {