sino-bc-cli 1.0.0-beta.0

package/dist/skills/biz-line-strategy-generate/scripts/test_tag_submission.py

@@ -0,0 +1,238 @@
+"""标签编号提交的真实文件、并发和命令行回归，不请求业务平台。"""
+import json
+import subprocess
+import sys
+import tempfile
+import time
+import unittest
+from concurrent.futures import ThreadPoolExecutor
+from pathlib import Path
+from unittest.mock import patch
+
+sys.dont_write_bytecode = True
+sys.path.insert(0, str(Path(__file__).resolve().parent))
+
+from strategy_output import choice_key, submit_tag_choices, close_tag_review, review_tags
+
+
+class TagSubmission(unittest.TestCase):
+    """编号必须属于当前请求和策略类别，提交不可覆盖或复活目录。"""
+
+    def request(self, root, number=1, review='review-one'):
+        """三类候选故意共用真实ID，检验只核对ID无法发现的错投。"""
+        root.mkdir(exist_ok=True)
+        packet = {'bizLineId': 340, 'attempt': 1, 'reviewId': review,
+                  'expiresAt': time.time() + 420, 'submissionMode': 'choice-key-v1',
+                  'strategies': {key: {'strategy': '本条正文', 'labels': [
+                      {'id': 1, 'name': '具体标签', 'choiceKey': choice_key(review, key, 1)},
+                      {'id': 2, 'name': '其他', 'isOther': 1, 'choiceKey': choice_key(review, key, 2)}]}
+                      for key in ('budget', 'product', 'audience')}}
+        path = root / f'tag-review.{number}.request.json'
+        path.write_text(json.dumps(packet, ensure_ascii=False), encoding='utf-8')
+        selection = {'selections': {key: [{'choiceKey': item['labels'][0]['choiceKey'],
+                                         'reason': '本条策略对应具体动作'}]
+                                    for key, item in packet['strategies'].items()}}
+        return path, selection
+
+    def test_valid_maps_id_and_rejects_duplicate_publish(self):
+        with tempfile.TemporaryDirectory() as tmp:
+            path, choices = self.request(Path(tmp))
+            response = submit_tag_choices(path, 'review-one', choices)
+            value = json.loads(response.read_text(encoding='utf-8'))
+            self.assertEqual(value['bizLineId'], 340)
+            self.assertEqual(value['selections']['budget'][0]['id'], 1)
+            self.assertEqual(value['selections']['budget'][0]['choiceKey'],
+                             choices['selections']['budget'][0]['choiceKey'])
+            before = response.read_bytes()
+            with self.assertRaises(ValueError):
+                submit_tag_choices(path, 'review-one', choices)
+            self.assertEqual(response.read_bytes(), before)
+
+    def test_foreign_request_scene_or_direct_id_cannot_publish(self):
+        for mutation in ('request', 'scene', 'id', 'reason', 'other'):
+            with self.subTest(mutation=mutation), tempfile.TemporaryDirectory() as tmp:
+                path, choices = self.request(Path(tmp))
+                budget = choices['selections']['budget']
+                if mutation == 'request':
+                    budget[0]['choiceKey'] = choice_key('another-review', 'budget', 1)
+                elif mutation == 'scene':
+                    budget[0]['choiceKey'] = choices['selections']['product'][0]['choiceKey']
+                elif mutation == 'id':
+                    budget[0] = {'id': 1, 'reason': '直接填ID'}
+                elif mutation == 'reason':
+                    budget[0]['reason'] = ''
+                else:
+                    budget.append({'choiceKey': choice_key('review-one', 'budget', 2), 'reason': '其他'})
+                with self.assertRaises(ValueError):
+                    submit_tag_choices(path, 'review-one', choices)
+                self.assertFalse(path.with_name('tag-review.1.response.json').exists())
+
+    def test_helper_field_error_can_be_corrected_in_same_request(self):
+        """提示具体位置和字段；错误输入不落响应，修正后仍可提交同一请求。"""
+        for field, invalid in (('choiceKey', None), ('reason', None), ('choiceKey', 123), ('reason', '')):
+            with self.subTest(field=field, invalid=invalid), tempfile.TemporaryDirectory() as tmp:
+                path, choices = self.request(Path(tmp))
+                broken = json.loads(json.dumps(choices))
+                item = broken['selections']['budget'][0]
+                if invalid is None:
+                    item.pop(field)
+                else:
+                    item[field] = invalid
+                with self.assertRaises(ValueError) as caught:
+                    submit_tag_choices(path, 'review-one', broken)
+                self.assertIn('budget[0]', str(caught.exception))
+                self.assertIn(field, str(caught.exception))
+                self.assertIn('submit_tags.py', str(caught.exception))
+                self.assertFalse(path.with_name('tag-review.1.response.json').exists())
+                response = submit_tag_choices(path, 'review-one', choices)
+                self.assertEqual(json.loads(response.read_text(encoding='utf-8'))['reviewId'], 'review-one')
+
+    def test_expired_replaced_closed_or_wrong_identity_cannot_publish(self):
+        for mutation in ('expired', 'replaced', 'closed', 'identity'):
+            with self.subTest(mutation=mutation), tempfile.TemporaryDirectory() as tmp:
+                path, choices = self.request(Path(tmp))
+                expected = 'review-one'
+                if mutation == 'expired':
+                    packet = json.loads(path.read_text(encoding='utf-8'))
+                    packet['expiresAt'] = time.time() - 1
+                    path.write_text(json.dumps(packet), encoding='utf-8')
+                elif mutation == 'replaced':
+                    self.request(Path(tmp), 2, 'review-two')
+                elif mutation == 'closed':
+                    close_tag_review(path)
+                else:
+                    expected = 'another-review'
+                with self.assertRaises(ValueError):
+                    submit_tag_choices(path, expected, choices)
+                self.assertFalse(path.with_name('tag-review.1.response.json').exists())
+
+    def test_submission_rereads_request_before_publish(self):
+        with tempfile.TemporaryDirectory() as tmp:
+            path, choices = self.request(Path(tmp))
+            from strategy_output import map_tag_choices
+            def changed(packet, selected):
+                mapped = map_tag_choices(packet, selected)
+                packet['strategies']['budget']['strategy'] = '请求在提交期间被改动'
+                path.write_text(json.dumps(packet), encoding='utf-8')
+                return mapped
+            with patch('strategy_output.map_tag_choices', side_effect=changed), self.assertRaises(ValueError):
+                submit_tag_choices(path, 'review-one', choices)
+            self.assertFalse(path.with_name('tag-review.1.response.json').exists())
+
+    def test_concurrent_publish_has_exactly_one_winner(self):
+        with tempfile.TemporaryDirectory() as tmp:
+            path, choices = self.request(Path(tmp))
+            def submit(_):
+                try:
+                    submit_tag_choices(path, 'review-one', choices)
+                    return True
+                except ValueError:
+                    return False
+            with ThreadPoolExecutor(max_workers=3) as pool:
+                self.assertEqual(sum(pool.map(submit, range(3))), 1)
+            json.loads(path.with_name('tag-review.1.response.json').read_text(encoding='utf-8'))
+            self.assertFalse(list(Path(tmp).glob('*.tmp')))
+
+    def test_removed_root_is_not_recreated(self):
+        with tempfile.TemporaryDirectory() as tmp:
+            # 使用临时目录自身的生命周期模拟已结束业务线，不删用户目录。
+            from cleanup import OwnedDirectory
+            owned = OwnedDirectory.create(Path(tmp), 'owned-')
+            other_path, other_choices = self.request(owned.path)
+            self.assertTrue(owned.cleanup()['ok'])
+            with self.assertRaises((ValueError, OSError)):
+                submit_tag_choices(other_path, 'review-one', other_choices)
+            self.assertFalse(owned.path.exists())
+
+    def test_consumer_rejects_direct_ids_or_mismatched_mapping(self):
+        """即使绕过helper写文件，也不能仅凭合法ID通过实际审核消费。"""
+        import threading
+        for mutation in ('direct-id', 'foreign-code', 'wrong-id', 'boolean-id', 'missing-id', 'missing-reason'):
+            with self.subTest(mutation=mutation), tempfile.TemporaryDirectory() as tmp:
+                row = {key + 'Strategy': '本条完整正文' for key in ('budget', 'product', 'audience')}
+                dictionaries = {key: [{'id': 1, 'name': '具体'}, {'id': 2, 'name': '其他', 'isOther': 1}]
+                                for key in ('budget', 'product', 'audience')}
+                events = []
+                def progress(event):
+                    events.append(event)
+                    if event.get('event') != 'tag_review_required':
+                        return
+                    packet = json.loads(Path(event['request_path']).read_text(encoding='utf-8'))
+                    selection = {key: [{'id': 1, 'choiceKey': item['labels'][0]['choiceKey'], 'reason': '依据'}]
+                                 for key, item in packet['strategies'].items()}
+                    item = selection['budget'][0]
+                    if mutation == 'direct-id':
+                        item.pop('choiceKey')
+                    elif mutation == 'foreign-code':
+                        item['choiceKey'] = choice_key('foreign', 'budget', 1)
+                    elif mutation == 'missing-id':
+                        item.pop('id')
+                    elif mutation == 'missing-reason':
+                        item.pop('reason')
+                    else:
+                        item['id'] = True if mutation == 'boolean-id' else 2
+                    reply = {key: packet[key] for key in ('bizLineId', 'attempt', 'reviewId')}
+                    Path(event['response_path']).write_text(json.dumps({**reply, 'selections': selection}), encoding='utf-8')
+                selected = review_tags(row, dictionaries, {}, Path(tmp), threading.Event(), progress,
+                                       biz_line_id=340, attempt=1)
+                rejected = [event for event in events if event['event'] == 'tag_review_rejected']
+                self.assertEqual(len(rejected), 2)
+                field = {'direct-id': 'choiceKey', 'boolean-id': 'id', 'missing-id': 'id', 'missing-reason': 'reason'}.get(mutation)
+                if field:
+                    for event in rejected:
+                        self.assertIn('budget[0]', event['reason'])
+                        self.assertIn(field, event['reason'])
+                        self.assertIn('submit_tags.py', event['reason'])
+                self.assertEqual(selected['budget'][0]['id'], 2)
+
+    def test_cancel_closes_request_and_rejects_late_submit(self):
+        """取消后即使原expiresAt尚未到期，也不能向旧请求补回包。"""
+        import threading
+        cancel = threading.Event()
+        seen = []
+        row = {key + 'Strategy': '正文' for key in ('budget', 'product', 'audience')}
+        dictionaries = {key: [{'id': 1, 'name': '其他'}] for key in ('budget', 'product', 'audience')}
+        with tempfile.TemporaryDirectory() as tmp:
+            def progress(event):
+                if event.get('event') == 'tag_review_required':
+                    seen.append(event)
+                    cancel.set()
+            with self.assertRaises(InterruptedError):
+                review_tags(row, dictionaries, {}, Path(tmp), cancel, progress, biz_line_id=340, attempt=1)
+            event = seen[0]
+            packet = json.loads(Path(event['request_path']).read_text(encoding='utf-8'))
+            choices = {'selections': {key: [{'choiceKey': item['labels'][0]['choiceKey'], 'reason': '迟到'}]
+                                      for key, item in packet['strategies'].items()}}
+            with self.assertRaises(ValueError):
+                submit_tag_choices(event['request_path'], event['reviewId'], choices)
+
+    def test_cli_real_utf8_arguments_and_stdin(self):
+        with tempfile.TemporaryDirectory() as tmp:
+            path, choices = self.request(Path(tmp))
+            result = subprocess.run([sys.executable, '-B', str(Path(__file__).with_name('submit_tags.py')),
+                                     '--request', str(path), '--review-id', 'review-one'],
+                                    input=json.dumps(choices, ensure_ascii=False), text=True,
+                                    encoding='utf-8', capture_output=True, timeout=10)
+            self.assertEqual(result.returncode, 0, result.stderr)
+            self.assertTrue(json.loads(result.stdout)['ok'])
+            self.assertIn('本条策略', path.with_name('tag-review.1.response.json').read_text(encoding='utf-8'))
+
+    def test_cli_reports_missing_field_in_stderr_without_publishing(self):
+        """实际CLI返回可修正的JSON错误，而非裸KeyError，也不提前生成响应。"""
+        with tempfile.TemporaryDirectory() as tmp:
+            path, choices = self.request(Path(tmp))
+            choices['selections']['budget'][0].pop('choiceKey')
+            result = subprocess.run([sys.executable, '-B', str(Path(__file__).with_name('submit_tags.py')),
+                                     '--request', str(path), '--review-id', 'review-one'],
+                                    input=json.dumps(choices, ensure_ascii=False), text=True,
+                                    encoding='utf-8', capture_output=True, timeout=10)
+            self.assertEqual(result.returncode, 1)
+            error = json.loads(result.stderr)
+            self.assertFalse(error['ok'])
+            for word in ('budget[0]', 'choiceKey', 'submit_tags.py'):
+                self.assertIn(word, error['error'])
+            self.assertFalse(path.with_name('tag-review.1.response.json').exists())
+
+
+if __name__ == '__main__':
+    unittest.main()