single-file-core 1.5.51 → 1.5.53

package/modules/css-rules-minifier.js

@@ -37,6 +37,7 @@ const NESTING_SELECTOR_TYPE = "NestingSelector";
 const PSEUDO_CLASS_SELECTOR_TYPE = "PseudoClassSelector";
 const DECLARATION_TYPE = "Declaration";
 const RAW_TYPE = "Raw";
+const VALUE_TYPE = "Value";
 const PSEUDO_ELEMENT_SELECTOR_TYPE = "PseudoElementSelector";
 const LAYER_NAME = "layer";
 const SCOPE_NAME = "scope";
@@ -64,6 +65,7 @@ const BLOCK_CLOSE = "}";
 const EMPTY_STRING = "";
 const CSS_IMPORTANCE_NOT_IMPORTANT = 0;
 const CSS_IMPORTANCE_IMPORTANT = 1;
+const INVALID_CSS_ESCAPE_TEST = /\\(?![0-9a-fA-F]{1,6}\s|[^0-9a-zA-Z])/;
 
 export {
 	process
@@ -355,7 +357,6 @@ function updateMatchingSelectors(matchedElements, selector, docContext) {
 
 function processNestedRules(ruleData, stylesheets, processingContext, docContext) {
 	expandRawCssRules(ruleData);
-	removeDuplicateDeclarations(ruleData.block);
 	const newProcessingContext = { ...processingContext, ancestorsSelectors: [...processingContext.ancestorsSelectors, ruleData.prelude] };
 	minifyStylesheetRules(ruleData.block.children, stylesheets, newProcessingContext, docContext);
 }
@@ -421,14 +422,19 @@ function collectDeclarationItemsForElement(element, docContext) {
 			const declarations = cssRule.block.children;
 			for (let declaration = declarations.head; declaration; declaration = declaration.next) {
 				const { type, value } = declaration.data;
-				if (type === DECLARATION_TYPE && value && value.type !== RAW_TYPE) {
-					allDeclarations.push({
-						declaration,
-						selector,
-						effectiveSpecificity: computeEffectiveSpecificity(
-							docContext.selectorData.get(selector), element, docContext),
-						isInline: false
-					});
+				if (type === DECLARATION_TYPE && value) {
+					const isRawValue = value.type === RAW_TYPE;
+					const isVendorValue = value.type === VALUE_TYPE && hasChildNodes(value) && value.children.head.data.name && value.children.head.data.name.startsWith(VENDOR_PREFIX);
+					const isInvalidValue = value.type === VALUE_TYPE && hasChildNodes(value) && value.children.head.data.name && INVALID_CSS_ESCAPE_TEST.test(value.children.head.data.name);
+					if (!isRawValue && !isVendorValue && !isInvalidValue) {
+						allDeclarations.push({
+							declaration,
+							selector,
+							effectiveSpecificity: computeEffectiveSpecificity(
+								docContext.selectorData.get(selector), element, docContext),
+							isInline: false
+						});
+					}
 				}
 			}
 		}
@@ -703,32 +709,6 @@ function removeUnmatchedSelectors(ruleData, removedSelectors, removedRules, cssR
 	return false;
 }
 
-function removeDuplicateDeclarations(block) {
-	const propertyMap = new Map();
-	const removedDeclarations = [];
-	for (let ruleChildNode = block.children.head; ruleChildNode; ruleChildNode = ruleChildNode.next) {
-		if (ruleChildNode.data.type === DECLARATION_TYPE) {
-			const property = ruleChildNode.data.property;
-			const isImportant = ruleChildNode.data.important;
-			if (propertyMap.has(property)) {
-				const existing = propertyMap.get(property);
-				if (existing.isImportant === isImportant) {
-					removedDeclarations.push(existing.node);
-					propertyMap.set(property, { node: ruleChildNode, isImportant });
-				} else if (isImportant && !existing.isImportant) {
-					removedDeclarations.push(existing.node);
-					propertyMap.set(property, { node: ruleChildNode, isImportant });
-				} else {
-					removedDeclarations.push(ruleChildNode);
-				}
-			} else {
-				propertyMap.set(property, { node: ruleChildNode, isImportant });
-			}
-		}
-	}
-	removedDeclarations.forEach(declaration => block.children.remove(declaration));
-}
-
 function removeLosingDeclarations(winningDeclarations, docContext) {
 	const allDeclarations = new Map();
 	const protectedDeclarations = new Set();

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "single-file-core",
-  "version": "1.5.51",
+  "version": "1.5.53",
   "description": "SingleFile Core",
   "author": "Gildas Lormeau",
   "license": "AGPL-3.0-or-later",