sinapse-ai 1.9.0 → 1.10.0

package/packages/installer/tests/unit/merger/strategies.test.js

@@ -1,154 +0,0 @@
-/**
- * @fileoverview Tests for Merge Strategy Factory
- * Story 9.1: Smart Merge Foundation
- */
-
-const {
-  getMergeStrategy,
-  hasMergeStrategy,
-  getSupportedTypes,
-  registerStrategy,
-  registerFileNameStrategy,
-} = require('../../../src/merger/strategies/index.js');
-const { EnvMerger } = require('../../../src/merger/strategies/env-merger.js');
-const { MarkdownMerger } = require('../../../src/merger/strategies/markdown-merger.js');
-const { ReplaceMerger } = require('../../../src/merger/strategies/replace-merger.js');
-
-describe('getMergeStrategy', () => {
-  it('should return EnvMerger for .env files', () => {
-    const merger = getMergeStrategy('.env');
-    expect(merger).toBeInstanceOf(EnvMerger);
-  });
-
-  it('should return EnvMerger for .env.local files', () => {
-    const merger = getMergeStrategy('.env.local');
-    expect(merger).toBeInstanceOf(EnvMerger);
-  });
-
-  it('should return EnvMerger for .env.example files', () => {
-    const merger = getMergeStrategy('.env.example');
-    expect(merger).toBeInstanceOf(EnvMerger);
-  });
-
-  it('should return MarkdownMerger for .md files', () => {
-    const merger = getMergeStrategy('CLAUDE.md');
-    expect(merger).toBeInstanceOf(MarkdownMerger);
-  });
-
-  it('should return MarkdownMerger for README.md', () => {
-    const merger = getMergeStrategy('README.md');
-    expect(merger).toBeInstanceOf(MarkdownMerger);
-  });
-
-  it('should return ReplaceMerger for unknown file types', () => {
-    const merger = getMergeStrategy('config.toml');
-    expect(merger).toBeInstanceOf(ReplaceMerger);
-  });
-
-  it('should return ReplaceMerger for .json files', () => {
-    const merger = getMergeStrategy('package.json');
-    expect(merger).toBeInstanceOf(ReplaceMerger);
-  });
-
-  it('should handle full paths', () => {
-    const merger = getMergeStrategy('/path/to/project/.env');
-    expect(merger).toBeInstanceOf(EnvMerger);
-  });
-
-  it('should handle paths with directories', () => {
-    const merger = getMergeStrategy('/path/to/.claude/CLAUDE.md');
-    expect(merger).toBeInstanceOf(MarkdownMerger);
-  });
-});
-
-describe('hasMergeStrategy', () => {
-  it('should return true for .env files', () => {
-    expect(hasMergeStrategy('.env')).toBe(true);
-  });
-
-  it('should return true for .md files', () => {
-    expect(hasMergeStrategy('CLAUDE.md')).toBe(true);
-  });
-
-  it('should return false for unsupported files', () => {
-    expect(hasMergeStrategy('config.toml')).toBe(false);
-  });
-
-  it('should return false for .json files', () => {
-    expect(hasMergeStrategy('package.json')).toBe(false);
-  });
-
-  it('should be case-insensitive for extensions', () => {
-    expect(hasMergeStrategy('README.MD')).toBe(true);
-  });
-});
-
-describe('getSupportedTypes', () => {
-  it('should return extensions and filenames', () => {
-    const types = getSupportedTypes();
-
-    expect(types).toHaveProperty('extensions');
-    expect(types).toHaveProperty('filenames');
-    expect(Array.isArray(types.extensions)).toBe(true);
-    expect(Array.isArray(types.filenames)).toBe(true);
-  });
-
-  it('should include .md in extensions', () => {
-    const types = getSupportedTypes();
-    expect(types.extensions).toContain('.md');
-  });
-
-  it('should include .env in filenames', () => {
-    const types = getSupportedTypes();
-    expect(types.filenames).toContain('.env');
-  });
-});
-
-describe('registerStrategy', () => {
-  it('should allow registering custom strategies for extensions', () => {
-    class CustomMerger extends ReplaceMerger {
-      name = 'custom';
-    }
-
-    registerStrategy('.custom', CustomMerger);
-
-    const merger = getMergeStrategy('file.custom');
-    expect(merger.name).toBe('custom');
-  });
-});
-
-describe('registerFileNameStrategy', () => {
-  it('should allow registering strategies for specific filenames', () => {
-    class SpecialMerger extends ReplaceMerger {
-      name = 'special';
-    }
-
-    registerFileNameStrategy('.special-config', SpecialMerger);
-
-    const merger = getMergeStrategy('.special-config');
-    expect(merger.name).toBe('special');
-  });
-});
-
-describe('ReplaceMerger', () => {
-  let merger;
-
-  beforeEach(() => {
-    merger = new ReplaceMerger();
-  });
-
-  it('should return new content as-is', async () => {
-    const existing = 'old content';
-    const newContent = 'new content';
-
-    const result = await merger.merge(existing, newContent);
-
-    expect(result.content).toBe('new content');
-    expect(result.stats.updated).toBe(1);
-  });
-
-  it('should report canMerge as false', () => {
-    expect(merger.canMerge('', '')).toBe(false);
-  });
-});
-

package/packages/installer/tests/unit/merger/yaml-merger.test.js

@@ -1,328 +0,0 @@
-'use strict';
-
-/**
- * YAML Merger Strategy Tests (Story INS-4.7)
- *
- * Validates Phase 1 merge rules:
- * - New keys added from source (framework)
- * - User values preserved on conflict (target wins)
- * - Deprecated keys kept with warning
- * - Output is valid YAML
- */
-
-const yaml = require('js-yaml');
-const path = require('path');
-const fs = require('fs');
-
-const { YamlMerger } = require(path.join(
-  __dirname, '..', '..', '..', 'src', 'merger', 'strategies', 'yaml-merger.js'
-));
-
-describe('YamlMerger (Story INS-4.7)', () => {
-  let merger;
-
-  beforeAll(() => {
-    merger = new YamlMerger();
-  });
-
-  describe('AC1: Strategy interface', () => {
-    test('extends BaseMerger with name "yaml"', () => {
-      expect(merger.name).toBe('yaml');
-    });
-
-    test('canMerge returns true for valid YAML', () => {
-      expect(merger.canMerge('key: value\n', 'other: data\n')).toBe(true);
-    });
-
-    test('canMerge returns false for invalid YAML', () => {
-      expect(merger.canMerge('key: value\n', '{{invalid')).toBe(false);
-    });
-
-    test('merge is async and returns MergeResult', async () => {
-      const result = await merger.merge('a: 1\n', 'a: 1\n');
-      expect(result).toHaveProperty('content');
-      expect(result).toHaveProperty('stats');
-      expect(result).toHaveProperty('changes');
-    });
-
-    test('getDescription returns meaningful text', () => {
-      expect(merger.getDescription()).toContain('YAML');
-      expect(merger.getDescription()).toContain('Phase 1');
-    });
-  });
-
-  describe('AC1: Strategy registration', () => {
-    test('.yaml extension registered in strategies/index.js', () => {
-      const { hasMergeStrategy, getMergeStrategy } = require(path.join(
-        __dirname, '..', '..', '..', 'src', 'merger', 'strategies', 'index.js'
-      ));
-
-      expect(hasMergeStrategy('config.yaml')).toBe(true);
-      const strategy = getMergeStrategy('config.yaml');
-      expect(strategy.name).toBe('yaml');
-    });
-
-    test('.yml extension also registered', () => {
-      const { hasMergeStrategy } = require(path.join(
-        __dirname, '..', '..', '..', 'src', 'merger', 'strategies', 'index.js'
-      ));
-
-      expect(hasMergeStrategy('config.yml')).toBe(true);
-    });
-
-    test('YamlMerger exported from merger/index.js', () => {
-      const mergerModule = require(path.join(
-        __dirname, '..', '..', '..', 'src', 'merger', 'index.js'
-      ));
-
-      expect(mergerModule.YamlMerger).toBeDefined();
-    });
-  });
-
-  describe('AC2: Phase 1 merge rules', () => {
-    test('new key in source → added to merged output', async () => {
-      const source = yaml.dump({ existingKey: 'a', newFeature: { enabled: true } });
-      const target = yaml.dump({ existingKey: 'a' });
-
-      const result = await merger.merge(source, target);
-      const merged = yaml.load(result.content);
-
-      expect(merged.newFeature).toEqual({ enabled: true });
-      expect(result.stats.added).toBeGreaterThanOrEqual(1);
-
-      const addedChange = result.changes.find(
-        c => c.type === 'added' && c.identifier === 'newFeature'
-      );
-      expect(addedChange).toBeDefined();
-    });
-
-    test('key in both with same value → target value preserved', async () => {
-      const source = yaml.dump({ key: 'same' });
-      const target = yaml.dump({ key: 'same' });
-
-      const result = await merger.merge(source, target);
-      const merged = yaml.load(result.content);
-
-      expect(merged.key).toBe('same');
-      expect(result.stats.preserved).toBeGreaterThanOrEqual(1);
-
-      const preservedChange = result.changes.find(
-        c => c.type === 'preserved' && c.identifier === 'key'
-      );
-      expect(preservedChange).toBeDefined();
-    });
-
-    test('conflict (different values) → target wins', async () => {
-      const source = yaml.dump({ setting: 'framework-default' });
-      const target = yaml.dump({ setting: 'user-custom' });
-
-      const result = await merger.merge(source, target);
-      const merged = yaml.load(result.content);
-
-      expect(merged.setting).toBe('user-custom');
-      expect(result.stats.conflicts).toBeGreaterThanOrEqual(1);
-
-      const conflictChange = result.changes.find(
-        c => c.type === 'conflict' && c.identifier === 'setting'
-      );
-      expect(conflictChange).toBeDefined();
-      expect(conflictChange.reason).toContain('Keeping user value');
-    });
-
-    test('deprecated key (in target, not in source) → kept with warning', async () => {
-      const source = yaml.dump({ current: true });
-      const target = yaml.dump({ current: true, legacyKey: 'old-value' });
-
-      const result = await merger.merge(source, target);
-      const merged = yaml.load(result.content);
-
-      expect(merged.legacyKey).toBe('old-value');
-
-      const deprecatedChange = result.changes.find(
-        c => c.type === 'conflict' && c.identifier === 'legacyKey'
-      );
-      expect(deprecatedChange).toBeDefined();
-      expect(deprecatedChange.reason).toContain('Deprecated');
-    });
-
-    test('output is valid YAML', async () => {
-      const source = yaml.dump({ a: 1, b: { c: 2 }, d: [1, 2, 3] });
-      const target = yaml.dump({ a: 99, e: 'user' });
-
-      const result = await merger.merge(source, target);
-
-      expect(() => yaml.load(result.content)).not.toThrow();
-    });
-
-    test('all changes in MergeResult.changes array (no separate warnings)', async () => {
-      const source = yaml.dump({ a: 1, b: 2 });
-      const target = yaml.dump({ a: 99, c: 3 });
-
-      const result = await merger.merge(source, target);
-
-      expect(result).not.toHaveProperty('warnings');
-      expect(Array.isArray(result.changes)).toBe(true);
-      expect(result.changes.length).toBeGreaterThan(0);
-    });
-  });
-
-  describe('AC2: Deep merge', () => {
-    test('nested new keys added at depth', async () => {
-      const source = yaml.dump({
-        boundary: { frameworkProtection: true, newSetting: 'added' },
-      });
-      const target = yaml.dump({
-        boundary: { frameworkProtection: false },
-      });
-
-      const result = await merger.merge(source, target);
-      const merged = yaml.load(result.content);
-
-      expect(merged.boundary.frameworkProtection).toBe(false); // user wins
-      expect(merged.boundary.newSetting).toBe('added'); // new key added
-    });
-
-    test('nested conflict preserves user value', async () => {
-      const source = yaml.dump({
-        pvMindContext: { location: 'default-path' },
-      });
-      const target = yaml.dump({
-        pvMindContext: { location: 'user-custom-path' },
-      });
-
-      const result = await merger.merge(source, target);
-      const merged = yaml.load(result.content);
-
-      expect(merged.pvMindContext.location).toBe('user-custom-path');
-    });
-  });
-
-  describe('AC4: User config preservation', () => {
-    test('custom pvMindContext.location preserved after upgrade', async () => {
-      const source = yaml.dump({
-        project: { type: 'EXISTING_SINAPSE', version: '2.2.0' },
-        pvMindContext: { location: 'default' },
-      });
-      const target = yaml.dump({
-        project: { type: 'EXISTING_SINAPSE', version: '2.1.0' },
-        pvMindContext: { location: '/my/custom/path' },
-      });
-
-      const result = await merger.merge(source, target);
-      const merged = yaml.load(result.content);
-
-      expect(merged.pvMindContext.location).toBe('/my/custom/path');
-    });
-
-    test('new framework key added alongside preserved user config', async () => {
-      const source = yaml.dump({
-        existing: 'value',
-        someNewFeature: { enabled: true },
-      });
-      const target = yaml.dump({
-        existing: 'value',
-      });
-
-      const result = await merger.merge(source, target);
-      const merged = yaml.load(result.content);
-
-      expect(merged.existing).toBe('value');
-      expect(merged.someNewFeature).toEqual({ enabled: true });
-    });
-  });
-
-  describe('AC5: Boundary section preservation', () => {
-    test('user-customized boundary paths NOT removed', async () => {
-      const source = yaml.dump({
-        boundary: {
-          frameworkProtection: true,
-          protected: ['.sinapse-ai/core/'],
-        },
-      });
-      const target = yaml.dump({
-        boundary: {
-          frameworkProtection: false,
-          protected: ['.sinapse-ai/core/', 'my-custom-path/'],
-          exceptions: ['my-exception/'],
-        },
-      });
-
-      const result = await merger.merge(source, target);
-      const merged = yaml.load(result.content);
-
-      // User boundary values preserved (target wins on arrays — no deep array merge)
-      expect(merged.boundary.frameworkProtection).toBe(false);
-      expect(merged.boundary.protected).toContain('my-custom-path/');
-      expect(merged.boundary.exceptions).toContain('my-exception/');
-    });
-  });
-
-  describe('AC6: Edge cases', () => {
-    test('empty source → target preserved as-is', async () => {
-      const source = '';
-      const target = yaml.dump({ user: 'config' });
-
-      const result = await merger.merge(source, target);
-      const merged = yaml.load(result.content);
-
-      expect(merged.user).toBe('config');
-    });
-
-    test('empty target → source keys added', async () => {
-      const source = yaml.dump({ framework: 'config' });
-      const target = '';
-
-      const result = await merger.merge(source, target);
-      const merged = yaml.load(result.content);
-
-      expect(merged.framework).toBe('config');
-    });
-
-    test('arrays treated as scalar (target wins, not merged)', async () => {
-      const source = yaml.dump({ list: [1, 2, 3] });
-      const target = yaml.dump({ list: [4, 5] });
-
-      const result = await merger.merge(source, target);
-      const merged = yaml.load(result.content);
-
-      expect(merged.list).toEqual([4, 5]); // target wins
-    });
-  });
-});
-
-describe('Brownfield Upgrader Integration (Story INS-4.7)', () => {
-  test('brownfield-upgrader imports YamlMerger', () => {
-    const upgraderSource = fs.readFileSync(
-      path.join(__dirname, '..', '..', '..', 'src', 'installer', 'brownfield-upgrader.js'),
-      'utf8'
-    );
-    expect(upgraderSource).toContain('YamlMerger');
-    expect(upgraderSource).toContain('yaml-merger.js');
-  });
-
-  test('upgrader has core-config.yaml merge exception in userModifiedFiles loop', () => {
-    const upgraderSource = fs.readFileSync(
-      path.join(__dirname, '..', '..', '..', 'src', 'installer', 'brownfield-upgrader.js'),
-      'utf8'
-    );
-    expect(upgraderSource).toContain("file.path.endsWith('core-config.yaml')");
-    expect(upgraderSource).toContain('merger.merge(sourceContent, targetContent)');
-    expect(upgraderSource).toContain('.backup-');
-  });
-
-  test('upgrader still skips non-yaml user-modified files', () => {
-    const upgraderSource = fs.readFileSync(
-      path.join(__dirname, '..', '..', '..', 'src', 'installer', 'brownfield-upgrader.js'),
-      'utf8'
-    );
-    expect(upgraderSource).toContain('User modified - preserving local changes');
-  });
-});
-
-describe('Existing strategies still work', () => {
-  test('strategies.test.js file exists (regression guard)', () => {
-    const testPath = path.join(__dirname, 'strategies.test.js');
-    expect(fs.existsSync(testPath)).toBe(true);
-  });
-});
-

package/packages/sinapse-install/tests/unit/chrome-brain.smoke.test.js

@@ -1,66 +0,0 @@
-/**
- * Chrome Brain — smoke tests
- *
- * @audit Audit 2 P0 (Q1.2) — flagship capability shipped at 0% coverage.
- * This suite locks in the public contract so future regressions surface
- * without exercising real Chrome / filesystem mutations (those require an
- * integration env). Coverage of `detectChrome()` and `getChromeBrainStatus()`
- * is best-effort because both are environment-aware.
- */
-
-'use strict';
-
-const path = require('path');
-
-const chromeBrain = require(
-  path.join(__dirname, '..', '..', 'src', 'capabilities', 'chrome-brain'),
-);
-
-describe('chrome-brain — public contract (Audit 2 Q1.2 smoke)', () => {
-  test('exports the documented surface', () => {
-    expect(typeof chromeBrain.installChromeBrain).toBe('function');
-    expect(typeof chromeBrain.uninstallChromeBrain).toBe('function');
-    expect(typeof chromeBrain.getChromeBrainStatus).toBe('function');
-    expect(typeof chromeBrain.detectChrome).toBe('function');
-  });
-
-  test('detectChrome returns the documented shape', () => {
-    const result = chromeBrain.detectChrome();
-    expect(result).toEqual(expect.objectContaining({
-      found: expect.any(Boolean),
-    }));
-    // path is string|null, variant is string|null
-    expect(['string', 'object']).toContain(typeof result.path);
-    expect(['string', 'object']).toContain(typeof result.variant);
-    if (result.path !== null) expect(typeof result.path).toBe('string');
-    if (result.variant !== null) expect(typeof result.variant).toBe('string');
-  });
-
-  test('detectChrome is deterministic across calls', () => {
-    const first = chromeBrain.detectChrome();
-    const second = chromeBrain.detectChrome();
-    expect(first).toEqual(second);
-  });
-
-  test('getChromeBrainStatus returns an object without throwing', () => {
-    expect(() => chromeBrain.getChromeBrainStatus()).not.toThrow();
-    const status = chromeBrain.getChromeBrainStatus();
-    expect(typeof status).toBe('object');
-    expect(status).not.toBeNull();
-  });
-
-  test('uninstallChromeBrain accepts options without throwing on dry path', () => {
-    // Dry-run / status-only call should not perform destructive ops when
-    // the install markers are absent. We do NOT pass `{ force: true }`.
-    expect(() => chromeBrain.uninstallChromeBrain({ dryRun: true })).not.toThrow();
-  });
-
-  test('installChromeBrain function arity is callable (not invoked here)', () => {
-    // Sanity-check arity without invoking (install is destructive). A
-    // real install requires a Chrome binary + writes to ~/.claude/, which
-    // is out of scope for unit-test smoke. Integration coverage is a
-    // separate follow-up story.
-    expect(chromeBrain.installChromeBrain.length).toBeGreaterThanOrEqual(0);
-    expect(chromeBrain.installChromeBrain.length).toBeLessThanOrEqual(2);
-  });
-});