sinapse-ai 1.17.0 → 1.19.1

package/.sinapse-ai/core/orchestration/workflow-executor.js

@@ -23,9 +23,8 @@ const fsSync = require('fs');
 const path = require('path');
 const yaml = require('js-yaml');
 
-// Import dependencies from Story 11.1, 11.2, and 11.5
+// Import dependencies from Story 11.1 and 11.5
 const ExecutorAssignment = require('./executor-assignment');
-const TerminalSpawner = require('./terminal-spawner');
 const { SessionState, ActionType } = require('./session-state');
 
 // IDS Gate Wiring: GateEvaluator wires the IDS verification gates into the
@@ -190,25 +189,6 @@ class WorkflowExecutor {
     }
   }
 
-  /**
-   * Emits terminal spawn to all registered callbacks (Story 12.6)
-   * @param {string} agent - Agent ID
-   * @param {number} pid - Process ID
-   * @param {string} task - Task being executed
-   * @private
-   */
-  _emitTerminalSpawn(agent, pid, task) {
-    for (const callback of this._terminalSpawnCallbacks) {
-      try {
-        callback(agent, pid, task);
-      } catch (error) {
-        if (this.options.debug) {
-          console.log(`[WorkflowExecutor] Terminal spawn callback error: ${error.message}`);
-        }
-      }
-    }
-  }
-
   /**
    * Loads the workflow definition
    * @returns {Promise<Object>} Workflow definition
@@ -450,6 +430,82 @@ class WorkflowExecutor {
     };
   }
 
+  /**
+   * Loads and validates an arbitrary workflow definition by path and returns it
+   * as a structured handoff for the agent-driven steps it describes.
+   *
+   * This is the GENERIC counterpart to {@link WorkflowExecutor#execute}, which is
+   * specialized for the development-cycle (it reads story metadata and runs the
+   * six hardcoded dev-cycle phases in-process). Handlers that drive multi-agent
+   * workflows — e.g. the brownfield/greenfield handlers running
+   * brownfield-discovery.yaml — use this entry point; the per-step work is then
+   * carried out by the spawned agents the workflow assigns (orchestrate-then-handoff).
+   *
+   * Validation is REAL: a missing path, a missing file, malformed YAML, or an
+   * empty definition each surface as an honest `{ success: false, error }`. The
+   * method never fabricates step output.
+   *
+   * @param {string} workflowPath - Absolute path to the workflow YAML
+   * @param {Object} [options] - Execution context
+   * @param {string} [options.projectRoot] - Project root (defaults to this.projectRoot)
+   * @param {Object} [options.techStack] - Detected tech stack threaded into the returned context
+   * @returns {Promise<Object>} `{ success, workflowPath, workflow, steps, context }`
+   *   on success, or `{ success: false, error }` on a validation failure.
+   */
+  async executeWorkflow(workflowPath, options = {}) {
+    if (!workflowPath || typeof workflowPath !== 'string') {
+      return { success: false, error: 'workflowPath is required and must be a string' };
+    }
+
+    if (!fsSync.existsSync(workflowPath)) {
+      return { success: false, error: `Workflow file not found: ${workflowPath}` };
+    }
+
+    let definition;
+    try {
+      const content = await fs.readFile(workflowPath, 'utf8');
+      definition = yaml.load(content);
+    } catch (error) {
+      return { success: false, error: `Failed to parse workflow ${workflowPath}: ${error.message}` };
+    }
+
+    const workflow = definition && definition.workflow ? definition.workflow : definition;
+    if (!workflow || typeof workflow !== 'object') {
+      return { success: false, error: `Workflow definition is empty: ${workflowPath}` };
+    }
+
+    return {
+      success: true,
+      workflowPath,
+      workflow,
+      steps: WorkflowExecutor._extractStepIds(workflow),
+      context: {
+        projectRoot: options.projectRoot || this.projectRoot,
+        techStack: options.techStack || {},
+      },
+    };
+  }
+
+  /**
+   * Extracts ordered step identifiers from a workflow definition that may model
+   * its steps as a `sequence` list (brownfield/greenfield workflows) or a
+   * `phases` object map (development-cycle).
+   * @param {Object} workflow - The `workflow` node of a parsed definition
+   * @returns {string[]} Ordered step identifiers (empty array when none declared)
+   * @private
+   */
+  static _extractStepIds(workflow) {
+    if (workflow && Array.isArray(workflow.sequence)) {
+      return workflow.sequence.map(
+        (step, index) => (step && (step.step || step.id || step.name)) || `step_${index + 1}`,
+      );
+    }
+    if (workflow && workflow.phases && typeof workflow.phases === 'object') {
+      return Object.keys(workflow.phases);
+    }
+    return [];
+  }
+
   /**
    * Executes a single workflow phase
    * @param {string} phaseId - Phase identifier
@@ -640,39 +696,8 @@ class WorkflowExecutor {
         }
       }
 
-      // Use terminal spawning (Story 11.2)
-      if (phase.spawn_in_terminal && TerminalSpawner.isSpawnerAvailable()) {
-        const context = {
-          story: storyPath,
-          files: [],
-          instructions: `Execute *develop for story: ${storyPath}`,
-          metadata: this.state.accumulatedContext,
-        };
-
-        const result = await TerminalSpawner.spawnAgent(agent.replace('@', ''), 'develop', {
-          context,
-          timeout: DEFAULT_TIMEOUT_MS,
-          debug: this.options.debug,
-        });
-
-        // Story 12.6: Emit terminal spawn for observability (AC1)
-        if (result.pid) {
-          this._emitTerminalSpawn(agent, result.pid, 'development');
-        }
-
-        return {
-          status: result.success ? PhaseStatus.COMPLETED : PhaseStatus.FAILED,
-          implementation: {
-            files_created: [],
-            files_modified: [],
-            tests_added: [],
-          },
-          output: result.output,
-          outputFile: result.outputFile,
-        };
-      }
-
-      // Fallback: Return pending for manual execution
+      // Honest fallback: the dev cycle does not invoke the agent in-process here;
+      // execution is handed off (manual) rather than fabricated by a stub.
       return {
         status: PhaseStatus.COMPLETED,
         implementation: {
@@ -680,7 +705,7 @@ class WorkflowExecutor {
           files_modified: [],
           tests_added: [],
         },
-        note: 'Terminal spawning not available, manual execution required',
+        note: 'Manual execution required',
       };
     } catch (error) {
       return {
@@ -957,42 +982,7 @@ class WorkflowExecutor {
       // Story 12.6: Emit agent spawn for observability (AC1)
       this._emitAgentSpawn(agent, 'quality_gate');
 
-      // Use terminal spawning
-      if (phase.spawn_in_terminal && TerminalSpawner.isSpawnerAvailable()) {
-        const context = {
-          story: storyPath,
-          files: [],
-          instructions: `Execute quality review for story: ${storyPath}`,
-          metadata: {
-            executor: this.state.executor,
-            implementation: this.state.phaseResults['2_development']?.implementation,
-          },
-        };
-
-        const result = await TerminalSpawner.spawnAgent(agent.replace('@', ''), 'quality-review', {
-          context,
-          timeout: DEFAULT_TIMEOUT_MS / 4, // 30 minutes
-          debug: this.options.debug,
-        });
-
-        // Story 12.6: Emit terminal spawn for observability (AC1)
-        if (result.pid) {
-          this._emitTerminalSpawn(agent, result.pid, 'quality_gate');
-        }
-
-        return {
-          status: result.success ? PhaseStatus.COMPLETED : PhaseStatus.FAILED,
-          review_result: {
-            verdict: result.success ? 'APPROVED' : 'NEEDS_WORK',
-            score: result.success ? 90 : 60,
-            findings: [],
-            recommendations: [],
-          },
-          output: result.output,
-        };
-      }
-
-      // Fallback
+      // Honest fallback: the review is handed off (manual) rather than fabricated by a stub.
       return {
         status: PhaseStatus.COMPLETED,
         review_result: {
@@ -1001,7 +991,7 @@ class WorkflowExecutor {
           findings: [],
           recommendations: [],
         },
-        note: 'Terminal spawning not available, manual review required',
+        note: 'Manual review required',
       };
     } catch (error) {
       return {
@@ -1027,40 +1017,7 @@ class WorkflowExecutor {
       // Story 12.6: Emit agent spawn for observability (AC1)
       this._emitAgentSpawn(agent, 'push');
 
-      // Use terminal spawning
-      if (phase.spawn_in_terminal && TerminalSpawner.isSpawnerAvailable()) {
-        const context = {
-          story: storyPath,
-          files: [],
-          instructions: `Execute *pre-push and *push for story: ${storyPath}`,
-          metadata: {
-            review_result: this.state.phaseResults['4_quality_gate']?.review_result,
-          },
-        };
-
-        const result = await TerminalSpawner.spawnAgent(agent.replace('@', ''), 'push-and-pr', {
-          context,
-          timeout: DEFAULT_TIMEOUT_MS / 12, // 10 minutes
-          debug: this.options.debug,
-        });
-
-        // Story 12.6: Emit terminal spawn for observability (AC1)
-        if (result.pid) {
-          this._emitTerminalSpawn(agent, result.pid, 'push');
-        }
-
-        return {
-          status: result.success ? PhaseStatus.COMPLETED : PhaseStatus.FAILED,
-          push_result: {
-            commit_hash: '',
-            branch: 'main',
-          },
-          pr_url: '',
-          output: result.output,
-        };
-      }
-
-      // Fallback
+      // Honest fallback: the push is handed off (manual) rather than fabricated by a stub.
       return {
         status: PhaseStatus.COMPLETED,
         push_result: {
@@ -1068,7 +1025,7 @@ class WorkflowExecutor {
           branch: 'main',
         },
         pr_url: '',
-        note: 'Terminal spawning not available, manual push required',
+        note: 'Manual push required',
       };
     } catch (error) {
       return {

package/.sinapse-ai/core/quality-gates/focus-area-recommender.js

@@ -124,13 +124,15 @@ class FocusAreaRecommender {
 
     for (const file of changedFiles.slice(0, 20)) {
       try {
-        // Count commits touching this file in last 30 days
-        const commitCount = execSync(
-          `git log --oneline --since="30 days ago" -- "${file}" 2>/dev/null | wc -l`,
-          { encoding: 'utf8', timeout: 5000 },
-        ).trim();
+        // Count commits touching this file in last 30 days. No shell pipe
+        // (wc -l / 2>/dev/null) — those fail on Windows cmd; count lines in JS
+        // and suppress stderr via stdio so it stays cross-platform.
+        const commitOut = execSync(
+          `git log --oneline --since="30 days ago" -- "${file}"`,
+          { encoding: 'utf8', timeout: 5000, stdio: ['ignore', 'pipe', 'ignore'] },
+        );
 
-        const count = parseInt(commitCount, 10) || 0;
+        const count = commitOut.split('\n').filter(Boolean).length;
 
         if (count >= 5) {
           insights.hotspots.push({
@@ -140,11 +142,13 @@ class FocusAreaRecommender {
           });
         }
 
-        // Get unique contributors for this file
-        const authors = execSync(
-          `git log --format="%aN" --since="30 days ago" -- "${file}" 2>/dev/null | sort -u`,
-          { encoding: 'utf8', timeout: 5000 },
-        ).trim().split('\n').filter(Boolean);
+        // Get unique contributors for this file. Dedup in JS via Set instead of
+        // a `| sort -u` shell pipe (unavailable on Windows cmd).
+        const authorsOut = execSync(
+          `git log --format="%aN" --since="30 days ago" -- "${file}"`,
+          { encoding: 'utf8', timeout: 5000, stdio: ['ignore', 'pipe', 'ignore'] },
+        );
+        const authors = [...new Set(authorsOut.split('\n').map((s) => s.trim()).filter(Boolean))];
 
         for (const author of authors) {
           insights.contributors.set(author, (insights.contributors.get(author) || 0) + 1);

package/.sinapse-ai/core/registry/build-registry.js

@@ -23,8 +23,9 @@ const SCAN_SOURCES = [
     category: 'task',
     taskFormat: 'TASK-FORMAT-V1',
     subcategoryExtractor: (filePath) => {
-      const parts = filePath.split('/');
-      const filename = parts[parts.length - 1];
+      // path.basename is OS-agnostic; a raw glob result on Windows uses '\\',
+      // so split('/') would return the whole path and corrupt the subcategory.
+      const filename = path.basename(filePath);
       // Extract agent prefix (e.g., dev-, qa-, po-)
       const prefixMatch = filename.match(/^([a-z]+)-/);
       if (prefixMatch) {

package/.sinapse-ai/core/synapse/scripts/generate-constitution.js

@@ -20,6 +20,7 @@ const path = require('path');
 const ROMAN_TO_ARABIC = {
   'I': 1, 'II': 2, 'III': 3, 'IV': 4, 'V': 5,
   'VI': 6, 'VII': 7, 'VIII': 8, 'IX': 9, 'X': 10,
+  'XI': 11,
 };
 
 /**

package/.sinapse-ai/core/synapse/utils/atomic-write.js

@@ -22,6 +22,28 @@ const path = require('path');
 
 const IS_WINDOWS = process.platform === 'win32';
 
+// On Windows the AV scanner, Windows Search indexer, or a concurrent reader can
+// hold a transient lock on the target, making unlink/rename throw EPERM/EBUSY
+// where POSIX would succeed. A short bounded retry clears virtually all of these.
+const TRANSIENT_LOCK_CODES = new Set(['EPERM', 'EBUSY', 'EACCES', 'ENOTEMPTY']);
+
+function sleepSync(ms) {
+  Atomics.wait(new Int32Array(new SharedArrayBuffer(4)), 0, 0, ms);
+}
+
+function retrySync(fn, retries = 3, delayMs = 120) {
+  for (let attempt = 0; ; attempt++) {
+    try {
+      return fn();
+    } catch (err) {
+      if (!TRANSIENT_LOCK_CODES.has(err.code) || attempt >= retries) {
+        throw err;
+      }
+      sleepSync(delayMs * (attempt + 1));
+    }
+  }
+}
+
 /**
  * Write data to a file atomically.
  *
@@ -49,18 +71,20 @@ function atomicWriteSync(filePath, data, encoding = 'utf8') {
 
     // Step 2: On Windows, unlink target first (rename won't overwrite)
     if (IS_WINDOWS) {
-      try {
-        fs.unlinkSync(filePath);
-      } catch (err) {
-        if (err.code !== 'ENOENT') {
-          throw err;
+      retrySync(() => {
+        try {
+          fs.unlinkSync(filePath);
+        } catch (err) {
+          if (err.code !== 'ENOENT') {
+            throw err;
+          }
+          // ENOENT = target doesn't exist yet, that's fine
         }
-        // ENOENT = target doesn't exist yet, that's fine
-      }
+      });
     }
 
-    // Step 3: Atomic rename
-    fs.renameSync(tmpPath, filePath);
+    // Step 3: Atomic rename (retried for transient Windows locks)
+    retrySync(() => fs.renameSync(tmpPath, filePath));
   } catch (error) {
     // Clean up tmp file on failure
     try {
@@ -76,5 +100,6 @@ function atomicWriteSync(filePath, data, encoding = 'utf8') {
 
 module.exports = {
   atomicWriteSync,
+  retrySync,
 };
 

package/.sinapse-ai/core-config.yaml

@@ -310,7 +310,11 @@ ideSync:
       enabled: false
       path: .codex/agents
       format: full-markdown-yaml
-  redirects: {}
+  redirects:
+    # Master alias: o id-fonte canônico é snps-orqx; sinapse-orqx aponta para ele
+    # no espelho de dogfood (.claude/). No install o command-generator gera ambos
+    # como entry points full do Imperator — isto cobre só a paridade do repo.
+    sinapse-orqx: snps-orqx
   validation:
     strictMode: true
     failOnDrift: true

package/.sinapse-ai/data/capability-detection.js

@@ -26,7 +26,7 @@ function detectToolSearch() {
   // Check Claude Code cached features for tool search availability
   const claudeJsonPath = path.join(os.homedir(), '.claude.json');
   try {
-    const config = JSON.parse(fs.readFileSync(claudeJsonPath, 'utf8'));
+    const config = JSON.parse(fs.readFileSync(claudeJsonPath, 'utf8').replace(/^\uFEFF/, ''));
     const features = config.cachedGrowthBookFeatures || {};
     return {
       available: features.tengu_mcp_tool_search === true,
@@ -54,7 +54,7 @@ function detectDeferLoading() {
 function detectProjectMcps() {
   const mcpJsonPath = path.join(PROJECT_ROOT, '.mcp.json');
   try {
-    const config = JSON.parse(fs.readFileSync(mcpJsonPath, 'utf8'));
+    const config = JSON.parse(fs.readFileSync(mcpJsonPath, 'utf8').replace(/^\uFEFF/, ''));
     const servers = config.mcpServers || {};
     return Object.entries(servers).map(([name, cfg]) => ({
       name,
@@ -96,7 +96,7 @@ function detectGlobalMcps() {
   // Detection: check ~/.claude/settings.json or known conventions
   const settingsPath = path.join(os.homedir(), '.claude', 'settings.json');
   try {
-    const settings = JSON.parse(fs.readFileSync(settingsPath, 'utf8'));
+    const settings = JSON.parse(fs.readFileSync(settingsPath, 'utf8').replace(/^\uFEFF/, ''));
     if (settings.mcpServers) {
       for (const [name, cfg] of Object.entries(settings.mcpServers)) {
         servers.push({