silphscope 1.2.10 → 1.2.12

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "silphscope",
-  "version": "1.2.10",
+  "version": "1.2.12",
   "description": "A firered/leafgreen ROM asset extractor for use in web applications",
   "main": "main.js",
   "exports": {

package/rom-configs/firered.js

@@ -6,6 +6,9 @@ export const firered = {
         monFrontSprites: 0x2350AC,
         monBackSprites: 0x23654C,
         monPalettes: 0x23730C,
-        monShinyPalettes: 0x2380CC
+        monShinyPalettes: 0x2380CC,
+        monIconTable: 0x3D37A0,
+        monIconPaletteIndices: 0x3D3E80,
+        monIconPaletteTable: 0x3D4038,
     } // if this works out... well hehe... :D
 }

package/src/graphics/mons/render-mon-icon.js

@@ -5,6 +5,8 @@ import { extract } from "../extract.js";
 import { PNG } from "pngjs";
 import fs from "fs";
 import { render4bppImage } from "../render-4bpp-image.js";
+import { resolveMonIcon } from "./resolvers/mon-icon-resolver.js";
+import { resolveMonIconPalette } from "./resolvers/mon-icon-palette-resolver.js";
 
 const streamToBuffer = (stream) => new Promise((resolve, reject) => {
     const chunks = [];
@@ -13,7 +15,7 @@ const streamToBuffer = (stream) => new Promise((resolve, reject) => {
     stream.on("error", reject);
 });
 
-export async function renderMonIcon(monName, mons, assets, iconPalettes, rom, options = {}) {
+export async function renderMonIcon(monName, mons, reader, rom, options = {}) {
     const { outputDir = null } = options;
 
     if (!rom || !(rom instanceof Uint8Array || Buffer.isBuffer(rom))) {
@@ -25,13 +27,12 @@ export async function renderMonIcon(monName, mons, assets, iconPalettes, rom, op
         throw new Error(`Missing mon entry for ${monName}`);
     }
 
-    const iconAsset = assets.find(a => a.name === mon.Icon);
-    if (!iconAsset) throw new Error(`Missing icon asset for ${monName}`);
+    const iconAsset = resolveMonIcon(mon, reader);
+    const iconPalette = resolveMonIconPalette(mon, reader);
+    if (!iconAsset || !iconPalette) throw new Error(`Missing icon asset for ${monName}`);
 
     const iconData = extract(iconAsset, rom);
-    const palIndex = Number(mon.iconPalIndex);
-    const palSize = 32;
-    const rawIconPalData = extract(iconPalettes, rom);
+    const rawIconPalData = extract(iconPalette, rom);
     const width = 32;
     const height = 64;
 
@@ -40,8 +41,6 @@ export async function renderMonIcon(monName, mons, assets, iconPalettes, rom, op
         paletteData: rawIconPalData.data, 
         width, 
         height, 
-        paletteOffset: palIndex * palSize, 
-        paletteSize: palSize
     });
 
     const frameHeight = 32;

package/src/graphics/mons/render-mons.js

@@ -31,9 +31,7 @@ export async function renderMon(monName, mons, assets, reader, rom, options = {}
     }
 
     if (icon === true) {
-        const comboPal = assets.find(a => a.name === "gMonIconPalettes");
-        if (!comboPal) throw new Error("Missing gMonIconPalettes asset");
-        await renderMonIcon(monName, mons, assets, comboPal, rom, { outputDir });
+        await renderMonIcon(monName, mons, reader, rom, { outputDir });
     }
     if (footprint === true) {
         await renderMonFoot(monName, mons, assets, rom, { outputDir });

package/src/graphics/mons/resolvers/mon-icon-palette-resolver.js

@@ -0,0 +1,9 @@
+export function resolveMonIconPalette(mon, reader) { // I kinda think this might be wrong... but erm who knows :o maybe I got it right first try lol
+    const indexTable = reader.getTable("monIconPaletteIndices");
+    const paletteIndex = reader.readU8(indexTable + mon.index);
+    const paletteTable = reader.getTable("monIconPaletteTable");
+    const palettePtr = reader.readPointer(paletteTable + paletteIndex * 4);
+    return {
+        offset: palettePtr
+    };
+}

package/src/graphics/mons/resolvers/mon-icon-resolver.js

@@ -0,0 +1,8 @@
+export function resolveMonIcon(mon, reader) {
+    const table = reader.getTable("monIconTable");
+    const entryOffset = table + mon.index * 4;
+    const ptr = reader.readPointer(entryOffset);
+    return {
+        offset: ptr
+    };
+}

package/src/rom-reader.js

@@ -10,7 +10,10 @@ export class RomReader {
             (rom[offset + 1] << 8) |
             (rom[offset + 2] << 16) |
             (rom[offset + 3] << 24)
-        );
+        ) >>> 0; // this should also prevent a bug for the numbers becoming negative due to unsigned and signed numbers canoodling :o
+    }
+    readU8(offset) { // how did I forget this T-T
+        return this.rom[offset];
     }
     readPointer(offset) {
         return this.readU32(offset) - 0x08000000;