silksong-coop-mod 0.4.4 → 0.4.6

package/README.md

@@ -1,4 +1,4 @@
-# silksong-coop-mod 0.4.4
+# silksong-coop-mod 0.4.6
 
 The files a player needs to install a two-player co-op build of **SSMP**, packaged so they can be fetched from
 a mirror that is reachable inside mainland China. This is not a Node library: nothing here is imported or run
@@ -14,4 +14,4 @@ The BepInEx loader is included, so the install needs no network access at all.
 
 The multiplayer mod is the work of [Extremelyd1](https://github.com/Extremelyd1/SSMP). This is a modified copy
 that adds a shared two-player save; please do not take questions about it to the original author. Distributed
-under the GNU LGPL 2.1 - see `LICENSE`. Built from https://github.com/Candy-649/SSMP at `0dec9bb`.
+under the GNU LGPL 2.1 - see `LICENSE`. Built from https://github.com/Candy-649/SSMP at `db8df94`.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "silksong-coop-mod",
-  "version": "0.4.4",
+  "version": "0.4.6",
   "description": "Offline installer payload for a two-player co-op build of the SSMP Silksong multiplayer mod. Not a Node library.",
   "license": "LGPL-2.1-or-later",
   "author": "Candy-649 (https://github.com/Candy-649)",

package/update.ps1

@@ -18,6 +18,11 @@ param(
     # Skip the search and use this game folder. Handy when the game lives somewhere unusual.
     [string] $GameDir,
 
+    # Ask only these registries, instead of the mirror first and npm itself second. A mirror that answers from a
+    # stale cache is the one failure this script cannot tell apart from being up to date, so there has to be a
+    # way straight past it.
+    [string[]] $Registry,
+
     # Report what would happen and change nothing.
     [switch] $WhatIfOnly
 )
@@ -34,6 +39,7 @@ $Registries = @(
     'https://registry.npmmirror.com',
     'https://registry.npmjs.org'
 )
+if ($Registry) { $Registries = $Registry }
 
 function Write-Step($text) { Write-Host ""; Write-Host "==> $text" -ForegroundColor Cyan }
 function Write-Ok($text) { Write-Host "    $text" -ForegroundColor Green }
@@ -114,15 +120,41 @@ try {
     Write-Step 'Asking what the newest build is'
     $meta = $null
     $usedRegistry = $null
+    $bestVersion = $null
     foreach ($registry in $Registries) {
-        $url = "$registry/$PackageName/latest"
+        # Both the query string and the headers are here on purpose. A CDN in front of a mirror can hold an old
+        # answer for this exact URL: one player's updater reported the version before last, and said it was
+        # already up to date, while the very same URL answered correctly from another network. Headers alone are
+        # not enough, because an edge is free to ignore them - but a URL it has never seen is always a miss.
+        $url = "$registry/$PackageName/latest?t=$([DateTimeOffset]::UtcNow.ToUnixTimeMilliseconds())"
         try {
-            $meta = Invoke-RestMethod -Uri $url -UseBasicParsing -TimeoutSec 30
-            $usedRegistry = $registry
-            break
+            $answer = Invoke-RestMethod -Uri $url -UseBasicParsing -TimeoutSec 30 -Headers @{
+                'Cache-Control' = 'no-cache'
+                'Pragma'        = 'no-cache'
+            }
         } catch {
             Write-Warn2 "$registry did not answer ($($_.Exception.Message))"
+            continue
+        }
+
+        # Every registry is asked and the newest answer wins, rather than the first one to reply. The order used
+        # to decide it, which quietly made each player depend on the route that suits the other: the mirror is
+        # the one that works from the mainland, but a player outside it was sent to the mirror first and was told
+        # by a stale cache that they were already up to date. Whichever side of the border you are on, the answer
+        # is now the newest one either registry has, and the tarball comes from that same answer.
+        $answerVersion = Get-ComparableVersion $answer.version
+        if (-not $answerVersion) {
+            Write-Warn2 "$registry gave a version this cannot read ('$($answer.version)')"
+            continue
         }
+
+        if ($bestVersion -and $answerVersion -le $bestVersion) {
+            continue
+        }
+
+        $meta = $answer
+        $bestVersion = $answerVersion
+        $usedRegistry = $registry
     }
     if (-not $meta) {
         throw ("No registry answered, so there is nothing to compare against. Your network may be blocking`n" +