signalk-mareas-ihm 1.2.0 → 1.2.1

package/README.md

@@ -74,6 +74,14 @@ El calado del barco se lee automáticamente de Signal K (`design.draft`) o se pu
 
 ### Changelog
 
+#### v1.2.1
+- **UI Fondeo renovada**: cajas resultado con títulos uniformes 14px, Cadena y Profundidad en naranja, Estado Marea muestra resumen, Status Profundidad con estado varada, Publicar SK en barra verde.
+- **Config overlay**: panel configuración se superpone sin scroll, con botón Calcular naranja.
+- **Botones 170px**: todos los botones de la barra principal ampliados.
+- **Fix alarma**: notificaciones OpenPlotter se limpian correctamente (state:normal).
+- **Fix hBow**: corregido borrado de altura de roldana.
+- **Fix Publicar SK**: estado persistente entre reinicios.
+
 #### v1.2.0
 - ⚓ **Calculadora de fondeo**: nueva pestaña FONDEO con modelo de scope náutico. Cadena recomendada, radio de borneo, publicación opcional en Signal K (`environment.anchor.mareasIhm.*`).
 - 🔇 **Fix notificaciones**: la alarma de varada suena una sola vez (antes se repetía cada 60s).
@@ -174,6 +182,14 @@ Vessel draft is read automatically from Signal K (`design.draft`) or can be conf
 
 ### Changelog
 
+#### v1.2.1
+- **UI Fondeo renovada**: cajas resultado con títulos uniformes 14px, Cadena y Profundidad en naranja, Estado Marea muestra resumen, Status Profundidad con estado varada, Publicar SK en barra verde.
+- **Config overlay**: panel configuración se superpone sin scroll, con botón Calcular naranja.
+- **Botones 170px**: todos los botones de la barra principal ampliados.
+- **Fix alarma**: notificaciones OpenPlotter se limpian correctamente (state:normal).
+- **Fix hBow**: corregido borrado de altura de roldana.
+- **Fix Publicar SK**: estado persistente entre reinicios.
+
 #### v1.2.0
 - ⚓ **Anchoring calculator**: new ANCHOR tab with nautical scope model. Recommended chain, swing radius, optional Signal K publication (`environment.anchor.mareasIhm.*`).
 - 🔇 **Notification fix**: grounding alarm sounds once (previously repeated every 60s).

package/dist/index.js

@@ -35,7 +35,7 @@ function isPositionValue(v) {
 }
 // Plugin version — must match package.json "version" field.
 // Shown in the WebApp instructions modal and published as environment.tide.pluginVersion.
-const PLUGIN_VERSION = "1.2.0";
+const PLUGIN_VERSION = "1.2.1";
 const DEFAULT_LANG = "es";
 const NEARBY_THRESHOLD_METERS = 30000;
 // v1.1.0: Default fallback station when no GPS and no lastStation (first boot).
@@ -1050,20 +1050,19 @@ export default function (app) {
                 // Previously, the clear only happened on the next evaluation cycle (~60s), causing phantom alarms.
                 function emitNotificationClear() {
                     try {
-                        // v1.2.0: Remove the notification path entirely (null) instead of emitting "normal".
-                        // This prevents apps like avnav from showing stale "normal" as an active alarm.
+                        // v1.2.1 FIX: Use state:"normal" instead of null. Null didn't clear OpenPlotter notifications.
                         const clearDelta = {
                             context: ("vessels." + app.selfId),
                             updates: [{
                                     timestamp: new Date().toISOString(),
                                     values: [{
                                             path: "notifications.signalk-mareas-ihm.grounding",
-                                            value: null
+                                            value: { state: "normal", method: [], message: "" }
                                         }]
                                 }]
                         };
                         app.handleMessage(plugin.id, clearDelta);
-                        lastGroundingNotifState = "cleared";
+                        lastGroundingNotifState = "normal"; // v1.2.1: "normal" not "cleared" — prevents re-emit on next cycle
                     }
                     catch { /* never break user action */ }
                 }
@@ -1105,6 +1104,8 @@ export default function (app) {
                 expressApp.get("/signalk-mareas-ihm/api/anchor/config", async (_req, res) => {
                     try {
                         const saved = (await ihmCache.get("anchorConfig"));
+                        if (saved && typeof saved.autoPublish === "boolean")
+                            anchorAutoPublish = saved.autoPublish;
                         res.json({ ...ANCHOR_DEFAULTS, ...saved, autoPublish: anchorAutoPublish });
                     }
                     catch (e) {
@@ -1123,8 +1124,10 @@ export default function (app) {
                             roundingStep: [1, 5].includes(Number(b.roundingStep)) ? Number(b.roundingStep) : ANCHOR_DEFAULTS.roundingStep,
                         };
                         await ihmCache.set("anchorConfig", cfg);
-                        if (typeof b.autoPublish === "boolean")
+                        if (typeof b.autoPublish === "boolean") {
                             anchorAutoPublish = b.autoPublish;
+                            await ihmCache.set("anchorConfig", { ...cfg, autoPublish: anchorAutoPublish });
+                        }
                         res.json({ ok: true, ...cfg, autoPublish: anchorAutoPublish });
                     }
                     catch (e) {
@@ -1141,28 +1144,57 @@ export default function (app) {
                             anchorAutoPublish = b.autoPublish;
                         const saved = (await ihmCache.get("anchorConfig"));
                         const cfg = { ...ANCHOR_DEFAULTS, ...saved };
-                        // Read SK values
-                        const skDepth = (() => { try {
-                            const v = app.getSelfPath("environment.depth.belowTransducer.value");
-                            return typeof v === "number" ? v : null;
-                        }
-                        catch {
-                            return null;
-                        } })();
-                        const skTideNow = (() => { try {
-                            const v = app.getSelfPath("environment.tide.heightNow.value");
-                            return typeof v === "number" ? v : null;
-                        }
-                        catch {
-                            return null;
-                        } })();
-                        const skNextHighH = (() => { try {
-                            const v = app.getSelfPath("environment.tide.heightNextHigh.value");
-                            return typeof v === "number" ? v : null;
+                        // Read SK values — unified depth reader with diagnostics
+                        const toNum = (v) => { if (v == null || v === "")
+                            return null; const n = Number(v); return (typeof n === "number" && isFinite(n) && n > 0) ? n : null; };
+                        const readSkNumber = (path) => {
+                            try {
+                                // Try path.value (SK v2 unwrapped)
+                                let d = toNum(app.getSelfPath(path + ".value"));
+                                if (d)
+                                    return d;
+                                // Try raw path (SK v1 may return {value: X} or plain number)
+                                const raw = app.getSelfPath(path);
+                                if (typeof raw === "number" && isFinite(raw) && raw > 0)
+                                    return raw;
+                                if (raw && typeof raw === "object") {
+                                    d = toNum(raw.value ?? raw.maximum);
+                                    if (d)
+                                        return d;
+                                }
+                                return null;
+                            }
+                            catch {
+                                return null;
+                            }
+                        };
+                        // Try ALL standard depth paths: belowTransducer > belowSurface > belowKeel
+                        let skDepth = null;
+                        let depthPathUsed = "none";
+                        const depthPaths = [
+                            "environment.depth.belowTransducer",
+                            "environment.depth.belowSurface",
+                            "environment.depth.belowKeel",
+                        ];
+                        const depthDiag = {};
+                        for (const dp of depthPaths) {
+                            try {
+                                const rawDot = app.getSelfPath(dp + ".value");
+                                const rawObj = app.getSelfPath(dp);
+                                depthDiag[dp] = { dotValue: rawDot ?? null, raw: (typeof rawObj === "object" ? JSON.stringify(rawObj)?.slice(0, 200) : rawObj) ?? null };
+                            }
+                            catch (e) {
+                                depthDiag[dp] = { error: e?.message };
+                            }
+                            const v = readSkNumber(dp);
+                            if (v) {
+                                skDepth = v;
+                                depthPathUsed = dp;
+                                break;
+                            }
                         }
-                        catch {
-                            return null;
-                        } })();
+                        const skTideNow = readSkNumber("environment.tide.heightNow");
+                        const skNextHighH = readSkNumber("environment.tide.heightNextHigh");
                         const skNextHighT = (() => { try {
                             const v = app.getSelfPath("environment.tide.timeNextHigh.value");
                             return typeof v === "string" ? Date.parse(v) : null;
@@ -1170,13 +1202,7 @@ export default function (app) {
                         catch {
                             return null;
                         } })();
-                        const skNextLowH = (() => { try {
-                            const v = app.getSelfPath("environment.tide.heightNextLow.value");
-                            return typeof v === "number" ? v : null;
-                        }
-                        catch {
-                            return null;
-                        } })();
+                        const skNextLowH = readSkNumber("environment.tide.heightNextLow");
                         const skNextLowT = (() => { try {
                             const v = app.getSelfPath("environment.tide.timeNextLow.value");
                             return typeof v === "string" ? Date.parse(v) : null;
@@ -1184,13 +1210,7 @@ export default function (app) {
                         catch {
                             return null;
                         } })();
-                        const skLoa = (() => { try {
-                            const v = app.getSelfPath("design.length.overall.value");
-                            return typeof v === "number" ? v : null;
-                        }
-                        catch {
-                            return null;
-                        } })();
+                        const skLoa = readSkNumber("design.length.overall");
                         const skTendency = (() => { try {
                             const v = app.getSelfPath("environment.tide.tendencypercentage.value");
                             return typeof v === "string" ? v : null;
@@ -1221,7 +1241,39 @@ export default function (app) {
                         if (anchorAutoPublish && Number.isFinite(result.chainL) && !result.partial) {
                             publishAnchoringDeltas(result);
                         }
-                        res.json({ ...result, depthMax, depthMin, draftEffective, tendencyPercentage: skTendency });
+                        res.json({ ...result, depthMax, depthMin, draftEffective, tendencyPercentage: skTendency, depthPathUsed, skDepthFound: skDepth, depthDiag });
+                    }
+                    catch (e) {
+                        res.status(500).json({ error: e?.message ?? String(e) });
+                    }
+                });
+                // v1.2.1: Diagnostic endpoint — shows exactly what Signal K returns for depth paths
+                // Access: http://localhost:3000/signalk-mareas-ihm/api/anchor/depth-debug
+                expressApp.get("/signalk-mareas-ihm/api/anchor/depth-debug", async (_req, res) => {
+                    try {
+                        const paths = [
+                            "environment.depth.belowTransducer",
+                            "environment.depth.belowSurface",
+                            "environment.depth.belowKeel",
+                            "environment.depth",
+                        ];
+                        const results = {};
+                        for (const p of paths) {
+                            try {
+                                const raw = app.getSelfPath(p);
+                                const dotValue = (() => { try {
+                                    return app.getSelfPath(p + ".value");
+                                }
+                                catch {
+                                    return "ERROR";
+                                } })();
+                                results[p] = { raw: raw ?? "UNDEFINED", dotValue: dotValue ?? "UNDEFINED", rawType: typeof raw, dotValueType: typeof dotValue };
+                            }
+                            catch (e) {
+                                results[p] = { error: e?.message ?? String(e) };
+                            }
+                        }
+                        res.json({ timestamp: new Date().toISOString(), depthPaths: results });
                     }
                     catch (e) {
                         res.status(500).json({ error: e?.message ?? String(e) });
@@ -1560,9 +1612,24 @@ export default function (app) {
                     return (n && n > 0) ? n : null;
                 };
                 const readDepthBelowTransducer = () => {
-                    const raw = app.getSelfPath("environment.depth.belowTransducer.value") || app.getSelfPath("environment.depth.belowTransducer");
-                    const n = toNum(raw);
-                    return (n && n > 0) ? n : null;
+                    // Try ALL standard depth paths: belowTransducer > belowSurface > belowKeel
+                    for (const p of ["environment.depth.belowTransducer", "environment.depth.belowSurface", "environment.depth.belowKeel"]) {
+                        try {
+                            let d = toNum(app.getSelfPath(p + ".value"));
+                            if (d && d > 0)
+                                return d;
+                            const raw = app.getSelfPath(p);
+                            if (typeof raw === "number" && isFinite(raw) && raw > 0)
+                                return raw;
+                            if (raw && typeof raw === "object") {
+                                d = toNum(raw.value ?? raw.maximum);
+                                if (d && d > 0)
+                                    return d;
+                            }
+                        }
+                        catch { /* try next */ }
+                    }
+                    return null;
                 };
                 // --- Draft resolution (manual vs Signal K) ---
                 const cachedDraft = toNum(caladoCfg?.draft);
@@ -1746,9 +1813,10 @@ export default function (app) {
                     };
                     app.handleMessage(plugin.id, draftDelta);
                 }
-                // v1.2.0: Only emit notifications on STATE TRANSITIONS to avoid spam.
-                // Apps like avnav interpret ANY notification on the path as active alarm.
-                // Alarm sounds ONCE; stays latched until user does snooze/off.
+                // v1.2.1: Notification state machine — emit on transitions, clear stale notifications
+                // BUG FIX: After plugin restart, lastGroundingNotifState="cleared" but old alarm notification
+                // may still be active in SK data model. By checking !== "normal" instead of === "alarm",
+                // we emit ONE clear on startup to kill stale zombie notifications.
                 const shouldNotify = notifyRisk;
                 const soundMuted = alarmaCfg?.soundMuted === true;
                 const notifMethod = soundMuted ? ["visual", "push"] : ["visual", "sound", "push"];
@@ -1767,22 +1835,20 @@ export default function (app) {
                     app.handleMessage(plugin.id, notifDelta);
                     lastGroundingNotifState = "alarm";
                 }
-                else if (!shouldNotify && lastGroundingNotifState === "alarm") {
-                    // TRANSITION alarm → clear: remove the notification path entirely.
-                    // Using null removes the path from the SK data model, so apps like avnav
-                    // won't see a stale "normal" notification as an active alarm.
+                else if (!shouldNotify && lastGroundingNotifState !== "normal") {
+                    // TRANSITION → clear: covers both "alarm"→"normal" AND "cleared"→"normal" (startup)
                     const clearDelta = {
                         context: ("vessels." + app.selfId),
                         updates: [{
                                 timestamp: now.toISOString(),
                                 values: [{
                                         path: "notifications.signalk-mareas-ihm.grounding",
-                                        value: null
+                                        value: { state: "normal", method: [], message: tr("Sin riesgo de varada", "No grounding risk") }
                                     }]
                             }]
                     };
                     app.handleMessage(plugin.id, clearDelta);
-                    lastGroundingNotifState = "cleared";
+                    lastGroundingNotifState = "normal";
                 }
                 // If already "cleared" or "normal" and no risk → do nothing (no spam).
             }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "signalk-mareas-ihm",
-  "version": "1.2.0",
+  "version": "1.2.1",
   "description": "Official tide predictions from the Spanish Hydrographic Institute (IHM).",
   "type": "module",
   "main": "./dist/index.js",