sign-off-axi 0.3.0 → 0.3.1

package/README.md

@@ -202,6 +202,8 @@ npm run build:skill           # regenerates skills/sign-off-axi/SKILL.md from sr
 npm pack                      # builds the publishable sign-off-axi tarball
 ```
 
+A release is a merged version-bump PR: CI publishes the new version to npm.
+
 ### Test runs never touch your board
 
 With no board named, a bare command uses the nearest `.sign-off/` that `init` set up, looking from the working folder up to its repo root (the folder holding `.git`) or up to HOME, but never HOME's own `.sign-off/`. The working folder's own `.sign-off/` is always used. A folder above it is searched only when that climb reaches a repo root or HOME, so a `.sign-off/` above a folder with neither (outside HOME, no `.git`) is never used, and the account's own home is never used. Otherwise the default board is `~/.sign-off/decisions.json`, under `SIGN_OFF_HOME` when it is set (it takes HOME's place for the default board and for where the climb stops), else under HOME.

package/dist/cli.js

@@ -565,7 +565,7 @@ function post(args, cmd = 'post') {
         const size = statSync(actual);
         if (!size.isFile() || size.size > MOCK_BYTES)
             throw fail(`--view ${values.view} must be a file of 5 MB or less`, 'VALIDATION_ERROR');
-        return storeIncoming(file, on, buildIncoming(values, { type, view: values.view }, filer), filer);
+        return storeIncoming(file, on, buildIncoming(values, { type, view: values.view }, filer, file), filer);
     }
     const mocks = values.mock?.map((m) => {
         const at = m.indexOf('=');
@@ -578,7 +578,7 @@ function post(args, cmd = 'post') {
             throw fail(`--mock ${path} escapes the board folder`, 'VALIDATION_ERROR', 'Keep mock files next to the board file');
         return { value: m.slice(0, at), path };
     });
-    return storeIncoming(file, on, buildIncoming(values, { type, tradeoff: values.tradeoff, mocks }, filer), filer);
+    return storeIncoming(file, on, buildIncoming(values, { type, tradeoff: values.tradeoff, mocks }, filer, file), filer);
 }
 /** For a program that feeds the board: the --from file, checked like any post, becomes the whole board, items and top-level fields. Answers stay.
  * With a filer it replaces only that filer's items (and items with no filer it names by key); every other item and top-level field stays. */
@@ -669,7 +669,7 @@ function postMedia(file, on, values, type, filer) {
     });
     mkdirSync(dirname(file), { recursive: true, mode: 0o700 });
     return locked(`${file}.lock`, () => {
-        const items = existsSync(file) ? readItems(file).items : [];
+        const { items, extra } = existsSync(file) ? readItems(file) : { items: [], extra: {} };
         // Boards in one folder share evidence/, so a number is taken only by creating its folder; one in use is never written into.
         const current = board(file), store = join(dirname(file), 'evidence'), taken = current.map((d) => Number(/^update-(\d+)$/.exec(d.key)?.[1] ?? 0));
         const own = explainer && (values.key ?? slug(values.title));
@@ -698,7 +698,7 @@ function postMedia(file, on, values, type, filer) {
             : { key, type, number, title, about, detail, close, link, media, filer, filed });
         // The whole board is checked before it is written, so a bad post leaves the board and evidence/ as they were.
         const check = `${file}.${process.pid}.check`;
-        writeFileSync(check, JSON.stringify({ schema: 2, items }), { mode: 0o600 });
+        writeFileSync(check, JSON.stringify({ ...extra, schema: 2, items }), { mode: 0o600 });
         try {
             loadDecisions(check);
         }
@@ -810,13 +810,14 @@ function recommended(items, flags) {
     if (d)
         throw fail(`items[${items.indexOf(d)}] (key ${d.key}) lists options but no recommend_value`, 'VALIDATION_ERROR', `Add "recommend_value": "<value>", the option you would pick: one of ${values}`);
 }
-/** Flags are validated by the same loader as a file: write them as a one-decision file first. */
-function buildIncoming(values, extra = {}, filer, file = '') {
+/** Flags are validated by the same loader as a file: write them as a one-decision file first. Items are checked against the board they go to, so its answers_only or readonly holds. */
+function buildIncoming(values, extra, filer, file) {
+    const board = existsSync(file) ? readItems(file).extra : {};
     if (values.from !== undefined) {
         // An item that names its own filer keeps it.
         const source = resolve(values.from), raw = readItems(source).items;
         contractItems(raw, values.from, file);
-        const incoming = loadDecisions(source);
+        const incoming = loadDecisions(source, board);
         recommended(raw, false);
         return { incoming: incoming.map((d) => ({ filer, ...d })), raw: raw.map((i) => ({ filer, ...i })) };
     }
@@ -825,7 +826,7 @@ function buildIncoming(values, extra = {}, filer, file = '') {
     try {
         const { title, key = slug(title), about, detail, recommend: recommend_value, default: default_if_silent, close } = values;
         writeFileSync(source, JSON.stringify({ schema: 2, items: [{ key, title, about, detail, options: optionsOf(values), recommend_value, default_if_silent, close, ...extra, filer }] }));
-        const incoming = loadDecisions(source), raw = readItems(source).items;
+        const incoming = loadDecisions(source, board), raw = readItems(source).items;
         recommended(raw, true);
         return { incoming, raw };
     }

package/dist/store.js

@@ -56,8 +56,9 @@ export function writeItems(path, items, extra) {
     writeFileSync(tmp, `${JSON.stringify({ ...(extra ?? old?.extra), schema: 2, items }, null, 2)}\n`, { mode: 0o600 });
     renameSync(tmp, path);
 }
-export function loadDecisions(path) {
-    const name = basename(path), { schema, items, extra } = readItems(path), list = schema === 1 ? 'decisions' : 'items';
+/** `board`: the top-level fields of the board the items are posted to, which decide in place of the file's own. */
+export function loadDecisions(path, board) {
+    const name = basename(path), { schema, items, extra: own } = readItems(path), list = schema === 1 ? 'decisions' : 'items', extra = board ?? own;
     const fed = extra.readonly === true || extra.answers_only === true;
     const seen = new Map();
     return items.map((d, i) => {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "sign-off-axi",
-  "version": "0.3.0",
+  "version": "0.3.1",
   "description": "One review board for evidence, quick yes/no decisions and retro changes.",
   "type": "module",
   "bin": { "sign-off-axi": "dist/cli.js" },