shufflecom-calculations 6.0.0 → 6.1.0

package/src/sports/calculate-sports-payout-odds.ts

@@ -4,9 +4,7 @@ import {
   OutcomeResult,
   SportsBetLegInterface,
   SportsBetLegType,
-  SportsBetSelectionInterface,
   SportsBetSelectionStatus,
-  SportsBetType,
   SportsMarketSelectionInterface,
 } from './sports.types';
 import { SportsSystemBetType, SportsSystemBetTypeCombinations, SportsSystemBetTypeSelectionCountsToBetCounts } from './system-bet.types';
@@ -46,72 +44,6 @@ export function generateSystemBetIndexCombinations(length: number, size: number)
   return combinations;
 }
 
-export function getSystemBetSubBetSelectionsAndIndex(
-  selections: SportsBetSelectionInterface[],
-  sportsSystemBetType: SportsSystemBetType,
-): { subBetSelection: SportsBetSelectionInterface[]; combinationIndex: string }[] {
-  const systemBetSizes = SportsSystemBetTypeCombinations[sportsSystemBetType];
-  if (!systemBetSizes) {
-    throw new Error('Invalid system bet type');
-  }
-  if (!SportsSystemBetTypeSelectionCountsToBetCounts[selections.length]?.[sportsSystemBetType]) {
-    throw new Error('Invalid selection count');
-  }
-  const combinations = systemBetSizes.flatMap(size => generateSystemBetIndexCombinations(selections.length, size));
-  const combinationSelections = combinations.map(combination => {
-    return {
-      subBetSelection: combination.map(index => selections[index]),
-      combinationIndex: combination.map(index => index + 1).join('/'),
-    };
-  });
-
-  return combinationSelections;
-}
-
-export function getSystemBetSubBetSelections(
-  selections: SportsBetSelectionInterface[],
-  sportsSystemBetType: SportsSystemBetType,
-): SportsBetSelectionInterface[][] {
-  const subBetSelectionsAndIndex = getSystemBetSubBetSelectionsAndIndex(selections, sportsSystemBetType);
-  return subBetSelectionsAndIndex.map(({ subBetSelection }) => subBetSelection);
-}
-
-// Selection-shaped façade over `calculateSportsPayoutOddsFromLegs`. Builds legs from the input
-// selections, maps subBetSelections to subBetLegs, and delegates. Callers that already have legs
-// deprecated function and is only used for cashout atm, as only regular bet / system bets are allowed for cashouts
-export function calculateSportsPayoutOdds(
-  selections: SportsBetSelectionInterface[],
-  marketSelections: SportsMarketSelectionInterface[],
-  opt: {
-    sportsCustomBetTotalOddsDecimal: BigNumber | null;
-    subBetSelections: SportsBetSelectionInterface[][] | null;
-    isEstimation: boolean; // treats PENDING leg as WON
-  },
-): BigNumber {
-  const sportsBetType = opt.sportsCustomBetTotalOddsDecimal !== null ? SportsBetType.CUSTOM_BET : SportsBetType.REGULAR;
-  const legs = deriveLegsFromSelections(sportsBetType, selections, opt.sportsCustomBetTotalOddsDecimal ?? new BigNumber(1));
-  const subBetLegs = opt.subBetSelections ? mapSubBetSelectionsToLegs(opt.subBetSelections, legs) : null;
-  return calculateSportsPayoutOddsFromLegs(legs, marketSelections, { subBetLegs, isEstimation: opt.isEstimation });
-}
-
-function mapSubBetSelectionsToLegs(subBetSelections: SportsBetSelectionInterface[][], legs: SportsBetLegInterface[]): SportsBetLegInterface[][] {
-  const legByMarketSelectionId = new Map<string, SportsBetLegInterface>();
-  for (const leg of legs) {
-    for (const selection of leg.selections) {
-      legByMarketSelectionId.set(selection.marketSelectionId, leg);
-    }
-  }
-  return subBetSelections.map(subBet =>
-    subBet.map(selection => {
-      const leg = legByMarketSelectionId.get(selection.marketSelectionId);
-      if (!leg) {
-        throw new Error('Sub bet leg not found');
-      }
-      return leg;
-    }),
-  );
-}
-
 function calculateSelectionCashoutOdds(
   totalOddsDecimal: BigNumber,
   selectionOddsDecimal: BigNumber,
@@ -188,35 +120,6 @@ function calculateSelectionCashoutOdds(
     .dividedBy(oddsFractionToDecimal(marketSelection.oddsNumerator, marketSelection.oddsDenominator));
 }
 
-/**
- * Structural mapping from (bet type, selections) → legs.
- *
- * @deprecated Reconstructing legs from a flat selection list only works for regular/system bets and
- * single-custom-leg bets — it cannot represent a multi-custom-leg (multi-SGM) bet and throws for
- * one. Confined to the cashout odds path; anywhere persisted legs are available, pass them to
- * `calculateSportsPayoutOddsFromLegs` instead of calling this.
- */
-export function deriveLegsFromSelections(
-  sportsBetType: SportsBetType,
-  selections: SportsBetSelectionInterface[],
-  customBetTotalOddsDecimal: BigNumber,
-): SportsBetLegInterface[] {
-  if (sportsBetType === SportsBetType.CUSTOM_BET) {
-    const distinctLegIds = new Set(selections.map(selection => selection.sportsBetLegId).filter(Boolean));
-    if (distinctLegIds.size > 1) {
-      throw new Error(
-        'deriveLegsFromSelections cannot reconstruct a multi-custom-leg bet from a flat selection list; use persisted legs with calculateSportsPayoutOddsFromLegs',
-      );
-    }
-    return [{ type: SportsBetLegType.CUSTOM, oddsDecimal: customBetTotalOddsDecimal, selections }];
-  }
-  return selections.map(selection => ({
-    type: SportsBetLegType.REGULAR,
-    oddsDecimal: oddsFractionToDecimal(selection.oddsNumerator, selection.oddsDenominator),
-    selections: [selection],
-  }));
-}
-
 export function getSystemBetSubBetLegs<TLeg>(legs: TLeg[], sportsSystemBetType: SportsSystemBetType): TLeg[][] {
   return getSystemBetSubBetLegsAndIndex(legs, sportsSystemBetType).map(({ subBetLegs }) => subBetLegs);
 }
@@ -292,7 +195,7 @@ function getLegPayoutOddsDecimal(
     return leg.oddsDecimal;
   }
 
-  // REGULAR leg: exactly one selection. Mirrors the per-selection reducer in calculateSportsPayoutOdds.
+  // REGULAR leg: exactly one selection, so the leg resolves to that selection's own outcome.
   const [selection] = leg.selections;
   const selectionOddsDecimal = oddsFractionToDecimal(selection.oddsNumerator, selection.oddsDenominator);
   const marketSelection = marketSelectionMap[selection.marketSelectionId];

package/src/sports/sports.types.ts

@@ -96,6 +96,7 @@ export enum SportsCashoutFailedReason {
   SPORTS_MARKET_CLOSED = 'SPORTS_MARKET_CLOSED',
   SPORTS_MARKET_CASHOUT_NOT_ENABLED = 'SPORTS_MARKET_CASHOUT_NOT_ENABLED',
   BOOSTED_BET_NOT_ALLOWED_CASHOUT = 'BOOSTED_BET_NOT_ALLOWED_CASHOUT',
+  CUSTOM_BET_NOT_ALLOWED_CASHOUT = 'CUSTOM_BET_NOT_ALLOWED_CASHOUT',
 }
 
 export enum SportsBetType {
@@ -169,9 +170,7 @@ export interface SportsBetSelectionInterface {
   status: SportsBetSelectionStatus;
   oddsNumerator: BigNumber;
   oddsDenominator: BigNumber;
-  // Present on persisted selections; used to detect multi-custom-leg bets that a flat selection
-  // list cannot faithfully represent (see deriveLegsFromSelections).
-  sportsBetLegId?: string | null;
+  sportsBetLegId: string;
   boostId?: string | null;
 }
 

package/src/fiat-document/fiat-document.spec.ts

@@ -1,137 +0,0 @@
-import { FIAT_DOCUMENT_SPECS, FiatDocumentType, compactFiatDocument, formatFiatDocument, isFiatDocumentValid } from '.';
-
-const { CPF, CURP, CUIL_CUIT } = FiatDocumentType;
-
-describe('fiat documents', () => {
-  describe('isFiatDocumentValid', () => {
-    it('accepts each document formatted or bare', () => {
-      expect(isFiatDocumentValid(CPF, '123.456.789-09')).toBe(true);
-      expect(isFiatDocumentValid(CPF, '12345678909')).toBe(true);
-      expect(isFiatDocumentValid(CUIL_CUIT, '20-32456789-6')).toBe(true);
-      expect(isFiatDocumentValid(CUIL_CUIT, '20324567896')).toBe(true);
-      expect(isFiatDocumentValid(CURP, 'BOXW310820HNERXN09')).toBe(true);
-    });
-
-    it('rejects wrong length, stray characters and bad prefixes', () => {
-      expect(isFiatDocumentValid(CPF, '1234567890')).toBe(false);
-      expect(isFiatDocumentValid(CPF, '1234567890a')).toBe(false);
-      expect(isFiatDocumentValid(CUIL_CUIT, '19-12345678-9')).toBe(false);
-      expect(isFiatDocumentValid(CUIL_CUIT, '2012345678')).toBe(false);
-      expect(isFiatDocumentValid(CURP, 'ABCD123456HDFXYZ')).toBe(false);
-    });
-
-    it("tolerates a document's own separators in any position", () => {
-      expect(isFiatDocumentValid(CPF, '123-456-789-09')).toBe(true);
-      expect(isFiatDocumentValid(CUIL_CUIT, '20-3245678-96')).toBe(true);
-    });
-
-    it('rejects a separator the document does not use — a dotted CUIT is not a CUIT', () => {
-      expect(isFiatDocumentValid(CUIL_CUIT, '20.32456789.6')).toBe(false);
-      expect(isFiatDocumentValid(CURP, 'BOXW-310820-HNERXN09')).toBe(false);
-    });
-  });
-
-  describe('compactFiatDocument', () => {
-    it('strips separators and upper-cases, per document column', () => {
-      expect(compactFiatDocument('cpf', '123.456.789-09')).toBe('12345678909');
-      expect(compactFiatDocument('cuilCuit', '20-32456789-6')).toBe('20324567896');
-      expect(compactFiatDocument('curp', 'boxw310820hnerxn09')).toBe('BOXW310820HNERXN09');
-    });
-
-    it('is idempotent on an already-canonical value', () => {
-      expect(compactFiatDocument('cpf', '12345678909')).toBe('12345678909');
-      expect(compactFiatDocument('curp', 'BOXW310820HNERXN09')).toBe('BOXW310820HNERXN09');
-    });
-
-    it('passes a non-document column through untouched', () => {
-      expect(compactFiatDocument('email', 'Fiat.User@Example.TEST')).toBe('Fiat.User@Example.TEST');
-      expect(compactFiatDocument('phoneNumber', '+14165550100')).toBe('+14165550100');
-    });
-  });
-
-  describe('formatFiatDocument', () => {
-    it('re-punctuates a stored document into the shape the product spec names', () => {
-      expect(formatFiatDocument('cpf', '12345678909')).toBe('123.456.789-09');
-      expect(formatFiatDocument('cuilCuit', '20324567896')).toBe('20-32456789-6');
-      expect(formatFiatDocument('curp', 'BOXW310820HNERXN09')).toBe('BOXW310820HNERXN09');
-    });
-
-    it('round-trips against compactFiatDocument and is idempotent', () => {
-      for (const [column, stored] of [
-        ['cpf', '12345678909'],
-        ['cuilCuit', '20324567896'],
-        ['curp', 'BOXW310820HNERXN09'],
-      ] as const) {
-        const formatted = formatFiatDocument(column, stored);
-        expect(compactFiatDocument(column, formatted)).toBe(stored);
-        expect(formatFiatDocument(column, formatted)).toBe(formatted);
-      }
-    });
-
-    it('passes a non-document column through untouched', () => {
-      expect(formatFiatDocument('email', 'a@b.test')).toBe('a@b.test');
-    });
-  });
-
-  describe('CUIT prefixes', () => {
-    // AFIP check digit over base '<prefix>32456789', so each case is a genuinely valid CUIT.
-    const W = [5, 4, 3, 2, 7, 6, 5, 4, 3, 2];
-    const validCuitFor = (prefix: string) => {
-      const base = `${prefix}32456789`;
-      const sum = [...base].reduce((acc, d, i) => acc + Number(d) * W[i], 0);
-      const remainder = 11 - (sum % 11);
-      return base + (remainder === 11 ? 0 : remainder === 10 ? 9 : remainder);
-    };
-
-    // AFIP: 20 men, 27 women, 23-26 either (when the usual prefix is already taken), 30/33
-    // legal persons. 34 is not in AFIP's summary but is in stdnum's list and long-standing
-    // practice, so we keep it — a superset can only fail at the PSP, never lock a user out.
-    // stdnum's own list omits 25 and 26, which is why we compute the check digit ourselves.
-    it.each(['20', '23', '24', '25', '26', '27', '30', '33', '34'])('accepts a valid CUIT with the %s prefix', prefix => {
-      expect(isFiatDocumentValid(CUIL_CUIT, validCuitFor(prefix))).toBe(true);
-    });
-
-    // An individual's 8 middle digits are their DNI, zero-padded when shorter.
-    it('accepts a zero-padded DNI', () => {
-      expect(isFiatDocumentValid(CUIL_CUIT, '20051234562')).toBe(true);
-      expect(isFiatDocumentValid(CUIL_CUIT, '27000512341')).toBe(true);
-    });
-
-    it('still rejects a prefix that is not issued at all', () => {
-      expect(isFiatDocumentValid(CUIL_CUIT, validCuitFor('19'))).toBe(false);
-      expect(isFiatDocumentValid(CUIL_CUIT, validCuitFor('28'))).toBe(false);
-    });
-  });
-
-  describe('issuer checksums', () => {
-    // Each value below is well-formed but carries wrong check digits — a mistyped document,
-    // which is exactly what the checksum exists to catch before it reaches the PSP.
-    it.each([
-      [CUIL_CUIT, '20-32456789-4'],
-      [CURP, 'BOXW310820HNERXN08'],
-      [CPF, '12345678900'],
-    ])('rejects a well-formed but checksum-invalid %s', (documentType, value) => {
-      expect(isFiatDocumentValid(documentType, value)).toBe(false);
-    });
-
-    it('rejects an all-zero DNI, which the CUIT check digit alone would let through', () => {
-      // 20-00000000-1 and 27-00000000-6 both carry correct check digits.
-      expect(isFiatDocumentValid(CUIL_CUIT, '20000000001')).toBe(false);
-      expect(isFiatDocumentValid(CUIL_CUIT, '27000000006')).toBe(false);
-      // A real DNI that merely starts with zeros still passes.
-      expect(isFiatDocumentValid(CUIL_CUIT, '27000512341')).toBe(true);
-    });
-
-    it('rejects every repeated-digit CPF, which mod-11 alone would let through', () => {
-      for (let digit = 0; digit <= 9; digit++) {
-        expect(isFiatDocumentValid(CPF, String(digit).repeat(11))).toBe(false);
-      }
-    });
-
-    it('keeps a checksum on every document, so a new one is a deliberate omission', () => {
-      for (const spec of Object.values(FIAT_DOCUMENT_SPECS)) {
-        expect(typeof spec.checksum).toBe('function');
-      }
-    });
-  });
-});