shoud-cli 1.0.2 → 1.0.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "shoud-cli",
-  "version": "1.0.2",
+  "version": "1.0.3",
   "description": "SHOUD Terminal Agent: Give your computer a job.",
   "main": "bin/shoud.js",
   "bin": {
@@ -18,7 +18,7 @@
     "ora": "^5.4.1"
   },
   "engines": {
-    "node": ">=18.0.0"
+    "node": "18.0.0"
   },
   "files": [
     "bin/",

package/src/tools/index.js

@@ -1,14 +1,7 @@
-const { execFileSync } = require('child_process');
+const { execSync } = require('child_process');
 const fs = require('fs');
 const path = require('path');
-
-// Allowed shell commands (whitelist)
-const ALLOWED_COMMANDS = new Set([
-  'ls', 'pwd', 'cat', 'grep', 'find', 'echo',
-  'mkdir', 'rmdir', 'touch', 'head', 'tail',
-  'wc', 'sort', 'uniq', 'diff', 'patch',
-  'git' // optional, but careful
-]);
+const os = require('os');
 
 // Maximum output size (1 MB)
 const MAX_OUTPUT_SIZE = 1024 * 1024;
@@ -16,13 +9,19 @@ const MAX_OUTPUT_SIZE = 1024 * 1024;
 // Get the project root (current working directory where CLI was started)
 const PROJECT_ROOT = process.cwd();
 
+// Determine the appropriate shell
+function getShell() {
+  if (os.platform() === 'win32') {
+    return 'powershell.exe'; // Use PowerShell on Windows
+  }
+  return '/bin/bash'; // Use bash on Unix (Linux/macOS)
+}
+
 /**
  * Sanitize a file path to ensure it stays within the project root.
  */
 function sanitizePath(inputPath) {
-  // Resolve relative paths
   const resolved = path.resolve(PROJECT_ROOT, inputPath);
-  // Ensure it starts with the project root
   if (!resolved.startsWith(PROJECT_ROOT)) {
     throw new Error('Path is outside the project directory.');
   }
@@ -31,27 +30,21 @@ function sanitizePath(inputPath) {
 
 /**
  * Execute a shell command securely.
- * Only commands from the whitelist are allowed.
+ * No command whitelist – safety is enforced by the permission engine.
  */
 function executeShell(commandString) {
-  // Split command into parts (first word is the command, rest are arguments)
-  const parts = commandString.trim().split(/\s+/);
-  if (parts.length === 0) throw new Error('Empty command.');
-
-  const cmd = parts[0];
-  if (!ALLOWED_COMMANDS.has(cmd)) {
-    throw new Error(`Command "${cmd}" is not allowed.`);
+  if (!commandString || commandString.trim().length === 0) {
+    throw new Error('Empty command.');
   }
 
-  const args = parts.slice(1);
-
   try {
-    const output = execFileSync(cmd, args, {
+    const output = execSync(commandString, {
       cwd: PROJECT_ROOT,
       encoding: 'utf-8',
+      shell: getShell(),
       timeout: 30000, // 30 seconds
       maxBuffer: MAX_OUTPUT_SIZE,
-      stdio: 'pipe'
+      stdio: 'pipe',
     });
     return output.trim() || 'Command executed successfully with no output.';
   } catch (err) {
@@ -86,13 +79,11 @@ function readFile(filePath) {
 }
 
 /**
- * Write content to a file securely (optional, but useful for agent).
- * Ensure file is within project root.
+ * Write content to a file securely, ensuring it's within the project root.
  */
 function writeFile(filePath, content) {
   const safePath = sanitizePath(filePath);
   try {
-    // Ensure directory exists
     const dir = path.dirname(safePath);
     if (!fs.existsSync(dir)) {
       fs.mkdirSync(dir, { recursive: true });