shmakk 1.1.0 → 1.2.0

package/skills/database-postgresql-optimization.md

@@ -0,0 +1,405 @@
+---
+name: postgresql-optimization
+description: 'PostgreSQL-specific development assistant focusing on unique PostgreSQL features, advanced data types, and PostgreSQL-exclusive capabilities. Covers JSONB operations, array types, custom types, range/geometric types, full-text search, window functions, and PostgreSQL extensions ecosystem.'
+category: database
+---
+
+# PostgreSQL Development Assistant
+
+Expert PostgreSQL guidance for ${selection} (or entire project if no selection). Focus on PostgreSQL-specific features, optimization patterns, and advanced capabilities.
+
+## � PostgreSQL-Specific Features
+
+### JSONB Operations
+```sql
+-- Advanced JSONB queries
+CREATE TABLE events (
+    id SERIAL PRIMARY KEY,
+    data JSONB NOT NULL,
+    created_at TIMESTAMPTZ DEFAULT NOW()
+);
+
+-- GIN index for JSONB performance
+CREATE INDEX idx_events_data_gin ON events USING gin(data);
+
+-- JSONB containment and path queries
+SELECT * FROM events 
+WHERE data @> '{"type": "login"}'
+  AND data #>> '{user,role}' = 'admin';
+
+-- JSONB aggregation
+SELECT jsonb_agg(data) FROM events WHERE data ? 'user_id';
+```
+
+### Array Operations
+```sql
+-- PostgreSQL arrays
+CREATE TABLE posts (
+    id SERIAL PRIMARY KEY,
+    tags TEXT[],
+    categories INTEGER[]
+);
+
+-- Array queries and operations
+SELECT * FROM posts WHERE 'postgresql' = ANY(tags);
+SELECT * FROM posts WHERE tags && ARRAY['database', 'sql'];
+SELECT * FROM posts WHERE array_length(tags, 1) > 3;
+
+-- Array aggregation
+SELECT array_agg(DISTINCT category) FROM posts, unnest(categories) as category;
+```
+
+### Window Functions & Analytics
+```sql
+-- Advanced window functions
+SELECT 
+    product_id,
+    sale_date,
+    amount,
+    -- Running totals
+    SUM(amount) OVER (PARTITION BY product_id ORDER BY sale_date) as running_total,
+    -- Moving averages
+    AVG(amount) OVER (PARTITION BY product_id ORDER BY sale_date ROWS BETWEEN 2 PRECEDING AND CURRENT ROW) as moving_avg,
+    -- Rankings
+    DENSE_RANK() OVER (PARTITION BY EXTRACT(month FROM sale_date) ORDER BY amount DESC) as monthly_rank,
+    -- Lag/Lead for comparisons
+    LAG(amount, 1) OVER (PARTITION BY product_id ORDER BY sale_date) as prev_amount
+FROM sales;
+```
+
+### Full-Text Search
+```sql
+-- PostgreSQL full-text search
+CREATE TABLE documents (
+    id SERIAL PRIMARY KEY,
+    title TEXT,
+    content TEXT,
+    search_vector tsvector
+);
+
+-- Update search vector
+UPDATE documents 
+SET search_vector = to_tsvector('english', title || ' ' || content);
+
+-- GIN index for search performance
+CREATE INDEX idx_documents_search ON documents USING gin(search_vector);
+
+-- Search queries
+SELECT * FROM documents 
+WHERE search_vector @@ plainto_tsquery('english', 'postgresql database');
+
+-- Ranking results
+SELECT *, ts_rank(search_vector, plainto_tsquery('postgresql')) as rank
+FROM documents 
+WHERE search_vector @@ plainto_tsquery('postgresql')
+ORDER BY rank DESC;
+```
+
+## � PostgreSQL Performance Tuning
+
+### Query Optimization
+```sql
+-- EXPLAIN ANALYZE for performance analysis
+EXPLAIN (ANALYZE, BUFFERS, FORMAT TEXT) 
+SELECT u.name, COUNT(o.id) as order_count
+FROM users u
+LEFT JOIN orders o ON u.id = o.user_id
+WHERE u.created_at > '2024-01-01'::date
+GROUP BY u.id, u.name;
+
+-- Identify slow queries from pg_stat_statements
+SELECT query, calls, total_time, mean_time, rows,
+       100.0 * shared_blks_hit / nullif(shared_blks_hit + shared_blks_read, 0) AS hit_percent
+FROM pg_stat_statements 
+ORDER BY total_time DESC 
+LIMIT 10;
+```
+
+### Index Strategies
+```sql
+-- Composite indexes for multi-column queries
+CREATE INDEX idx_orders_user_date ON orders(user_id, order_date);
+
+-- Partial indexes for filtered queries
+CREATE INDEX idx_active_users ON users(created_at) WHERE status = 'active';
+
+-- Expression indexes for computed values
+CREATE INDEX idx_users_lower_email ON users(lower(email));
+
+-- Covering indexes to avoid table lookups
+CREATE INDEX idx_orders_covering ON orders(user_id, status) INCLUDE (total, created_at);
+```
+
+### Connection & Memory Management
+```sql
+-- Check connection usage
+SELECT count(*) as connections, state 
+FROM pg_stat_activity 
+GROUP BY state;
+
+-- Monitor memory usage
+SELECT name, setting, unit 
+FROM pg_settings 
+WHERE name IN ('shared_buffers', 'work_mem', 'maintenance_work_mem');
+```
+
+## �️ PostgreSQL Advanced Data Types
+
+### Custom Types & Domains
+```sql
+-- Create custom types
+CREATE TYPE address_type AS (
+    street TEXT,
+    city TEXT,
+    postal_code TEXT,
+    country TEXT
+);
+
+CREATE TYPE order_status AS ENUM ('pending', 'processing', 'shipped', 'delivered', 'cancelled');
+
+-- Use domains for data validation
+CREATE DOMAIN email_address AS TEXT 
+CHECK (VALUE ~* '^[A-Za-z0-9._%+-]+@[A-Za-z0-9.-]+\.[A-Za-z]{2,}$');
+
+-- Table using custom types
+CREATE TABLE customers (
+    id SERIAL PRIMARY KEY,
+    email email_address NOT NULL,
+    address address_type,
+    status order_status DEFAULT 'pending'
+);
+```
+
+### Range Types
+```sql
+-- PostgreSQL range types
+CREATE TABLE reservations (
+    id SERIAL PRIMARY KEY,
+    room_id INTEGER,
+    reservation_period tstzrange,
+    price_range numrange
+);
+
+-- Range queries
+SELECT * FROM reservations 
+WHERE reservation_period && tstzrange('2024-07-20', '2024-07-25');
+
+-- Exclude overlapping ranges
+ALTER TABLE reservations 
+ADD CONSTRAINT no_overlap 
+EXCLUDE USING gist (room_id WITH =, reservation_period WITH &&);
+```
+
+### Geometric Types
+```sql
+-- PostgreSQL geometric types
+CREATE TABLE locations (
+    id SERIAL PRIMARY KEY,
+    name TEXT,
+    coordinates POINT,
+    coverage CIRCLE,
+    service_area POLYGON
+);
+
+-- Geometric queries
+SELECT name FROM locations 
+WHERE coordinates <-> point(40.7128, -74.0060) < 10; -- Within 10 units
+
+-- GiST index for geometric data
+CREATE INDEX idx_locations_coords ON locations USING gist(coordinates);
+```
+
+## 📊 PostgreSQL Extensions & Tools
+
+### Useful Extensions
+```sql
+-- Enable commonly used extensions
+CREATE EXTENSION IF NOT EXISTS "uuid-ossp";    -- UUID generation
+CREATE EXTENSION IF NOT EXISTS "pgcrypto";     -- Cryptographic functions
+CREATE EXTENSION IF NOT EXISTS "unaccent";     -- Remove accents from text
+CREATE EXTENSION IF NOT EXISTS "pg_trgm";      -- Trigram matching
+CREATE EXTENSION IF NOT EXISTS "btree_gin";    -- GIN indexes for btree types
+
+-- Using extensions
+SELECT uuid_generate_v4();                     -- Generate UUIDs
+SELECT crypt('password', gen_salt('bf'));      -- Hash passwords
+SELECT similarity('postgresql', 'postgersql'); -- Fuzzy matching
+```
+
+### Monitoring & Maintenance
+```sql
+-- Database size and growth
+SELECT pg_size_pretty(pg_database_size(current_database())) as db_size;
+
+-- Table and index sizes
+SELECT schemaname, tablename,
+       pg_size_pretty(pg_total_relation_size(schemaname||'.'||tablename)) as size
+FROM pg_tables 
+ORDER BY pg_total_relation_size(schemaname||'.'||tablename) DESC;
+
+-- Index usage statistics
+SELECT schemaname, tablename, indexname, idx_scan, idx_tup_read, idx_tup_fetch
+FROM pg_stat_user_indexes 
+WHERE idx_scan = 0;  -- Unused indexes
+```
+
+### PostgreSQL-Specific Optimization Tips
+- **Use EXPLAIN (ANALYZE, BUFFERS)** for detailed query analysis
+- **Configure postgresql.conf** for your workload (OLTP vs OLAP)
+- **Use connection pooling** (pgbouncer) for high-concurrency applications
+- **Regular VACUUM and ANALYZE** for optimal performance
+- **Partition large tables** using PostgreSQL 10+ declarative partitioning
+- **Use pg_stat_statements** for query performance monitoring
+
+## 📊 Monitoring and Maintenance
+
+### Query Performance Monitoring
+```sql
+-- Identify slow queries
+SELECT query, calls, total_time, mean_time, rows
+FROM pg_stat_statements 
+ORDER BY total_time DESC 
+LIMIT 10;
+
+-- Check index usage
+SELECT schemaname, tablename, indexname, idx_scan, idx_tup_read, idx_tup_fetch
+FROM pg_stat_user_indexes 
+WHERE idx_scan = 0;
+```
+
+### Database Maintenance
+- **VACUUM and ANALYZE**: Regular maintenance for performance
+- **Index Maintenance**: Monitor and rebuild fragmented indexes
+- **Statistics Updates**: Keep query planner statistics current
+- **Log Analysis**: Regular review of PostgreSQL logs
+
+## 🛠️ Common Query Patterns
+
+### Pagination
+```sql
+-- ❌ BAD: OFFSET for large datasets
+SELECT * FROM products ORDER BY id OFFSET 10000 LIMIT 20;
+
+-- ✅ GOOD: Cursor-based pagination
+SELECT * FROM products 
+WHERE id > $last_id 
+ORDER BY id 
+LIMIT 20;
+```
+
+### Aggregation
+```sql
+-- ❌ BAD: Inefficient grouping
+SELECT user_id, COUNT(*) 
+FROM orders 
+WHERE order_date >= '2024-01-01' 
+GROUP BY user_id;
+
+-- ✅ GOOD: Optimized with partial index
+CREATE INDEX idx_orders_recent ON orders(user_id) 
+WHERE order_date >= '2024-01-01';
+
+SELECT user_id, COUNT(*) 
+FROM orders 
+WHERE order_date >= '2024-01-01' 
+GROUP BY user_id;
+```
+
+### JSON Queries
+```sql
+-- ❌ BAD: Inefficient JSON querying
+SELECT * FROM users WHERE data::text LIKE '%admin%';
+
+-- ✅ GOOD: JSONB operators and GIN index
+CREATE INDEX idx_users_data_gin ON users USING gin(data);
+
+SELECT * FROM users WHERE data @> '{"role": "admin"}';
+```
+
+## 📋 Optimization Checklist
+
+### Query Analysis
+- [ ] Run EXPLAIN ANALYZE for expensive queries
+- [ ] Check for sequential scans on large tables
+- [ ] Verify appropriate join algorithms
+- [ ] Review WHERE clause selectivity
+- [ ] Analyze sort and aggregation operations
+
+### Index Strategy
+- [ ] Create indexes for frequently queried columns
+- [ ] Use composite indexes for multi-column searches
+- [ ] Consider partial indexes for filtered queries
+- [ ] Remove unused or duplicate indexes
+- [ ] Monitor index bloat and fragmentation
+
+### Security Review
+- [ ] Use parameterized queries exclusively
+- [ ] Implement proper access controls
+- [ ] Enable row-level security where needed
+- [ ] Audit sensitive data access
+- [ ] Use secure connection methods
+
+### Performance Monitoring
+- [ ] Set up query performance monitoring
+- [ ] Configure appropriate log settings
+- [ ] Monitor connection pool usage
+- [ ] Track database growth and maintenance needs
+- [ ] Set up alerting for performance degradation
+
+## 🎯 Optimization Output Format
+
+### Query Analysis Results
+```
+## Query Performance Analysis
+
+**Original Query**:
+[Original SQL with performance issues]
+
+**Issues Identified**:
+- Sequential scan on large table (Cost: 15000.00)
+- Missing index on frequently queried column
+- Inefficient join order
+
+**Optimized Query**:
+[Improved SQL with explanations]
+
+**Recommended Indexes**:
+```sql
+CREATE INDEX idx_table_column ON table(column);
+```
+
+**Performance Impact**: Expected 80% improvement in execution time
+```
+
+## 🚀 Advanced PostgreSQL Features
+
+### Window Functions
+```sql
+-- Running totals and rankings
+SELECT 
+    product_id,
+    order_date,
+    amount,
+    SUM(amount) OVER (PARTITION BY product_id ORDER BY order_date) as running_total,
+    ROW_NUMBER() OVER (PARTITION BY product_id ORDER BY amount DESC) as rank
+FROM sales;
+```
+
+### Common Table Expressions (CTEs)
+```sql
+-- Recursive queries for hierarchical data
+WITH RECURSIVE category_tree AS (
+    SELECT id, name, parent_id, 1 as level
+    FROM categories 
+    WHERE parent_id IS NULL
+    
+    UNION ALL
+    
+    SELECT c.id, c.name, c.parent_id, ct.level + 1
+    FROM categories c
+    JOIN category_tree ct ON c.parent_id = ct.id
+)
+SELECT * FROM category_tree ORDER BY level, name;
+```
+
+Focus on providing specific, actionable PostgreSQL optimizations that improve query performance, security, and maintainability while leveraging PostgreSQL's advanced features.

package/skills/database-sql-code-review.md

@@ -0,0 +1,302 @@
+---
+name: sql-code-review
+description: 'Universal SQL code review assistant that performs comprehensive security, maintainability, and code quality analysis across all SQL databases (MySQL, PostgreSQL, SQL Server, Oracle). Focuses on SQL injection prevention, access control, code standards, and anti-pattern detection. Complements SQL optimization prompt for complete development coverage.'
+category: database
+---
+
+# SQL Code Review
+
+Perform a thorough SQL code review of ${selection} (or entire project if no selection) focusing on security, performance, maintainability, and database best practices.
+
+## 🔒 Security Analysis
+
+### SQL Injection Prevention
+```sql
+-- ❌ CRITICAL: SQL Injection vulnerability
+query = "SELECT * FROM users WHERE id = " + userInput;
+query = f"DELETE FROM orders WHERE user_id = {user_id}";
+
+-- ✅ SECURE: Parameterized queries
+-- PostgreSQL/MySQL
+PREPARE stmt FROM 'SELECT * FROM users WHERE id = ?';
+EXECUTE stmt USING @user_id;
+
+-- SQL Server
+EXEC sp_executesql N'SELECT * FROM users WHERE id = @id', N'@id INT', @id = @user_id;
+```
+
+### Access Control & Permissions
+- **Principle of Least Privilege**: Grant minimum required permissions
+- **Role-Based Access**: Use database roles instead of direct user permissions
+- **Schema Security**: Proper schema ownership and access controls
+- **Function/Procedure Security**: Review DEFINER vs INVOKER rights
+
+### Data Protection
+- **Sensitive Data Exposure**: Avoid SELECT * on tables with sensitive columns
+- **Audit Logging**: Ensure sensitive operations are logged
+- **Data Masking**: Use views or functions to mask sensitive data
+- **Encryption**: Verify encrypted storage for sensitive data
+
+## ⚡ Performance Optimization
+
+### Query Structure Analysis
+```sql
+-- ❌ BAD: Inefficient query patterns
+SELECT DISTINCT u.* 
+FROM users u, orders o, products p
+WHERE u.id = o.user_id 
+AND o.product_id = p.id
+AND YEAR(o.order_date) = 2024;
+
+-- ✅ GOOD: Optimized structure
+SELECT u.id, u.name, u.email
+FROM users u
+INNER JOIN orders o ON u.id = o.user_id
+WHERE o.order_date >= '2024-01-01' 
+AND o.order_date < '2025-01-01';
+```
+
+### Index Strategy Review
+- **Missing Indexes**: Identify columns that need indexing
+- **Over-Indexing**: Find unused or redundant indexes
+- **Composite Indexes**: Multi-column indexes for complex queries
+- **Index Maintenance**: Check for fragmented or outdated indexes
+
+### Join Optimization
+- **Join Types**: Verify appropriate join types (INNER vs LEFT vs EXISTS)
+- **Join Order**: Optimize for smaller result sets first
+- **Cartesian Products**: Identify and fix missing join conditions
+- **Subquery vs JOIN**: Choose the most efficient approach
+
+### Aggregate and Window Functions
+```sql
+-- ❌ BAD: Inefficient aggregation
+SELECT user_id, 
+       (SELECT COUNT(*) FROM orders o2 WHERE o2.user_id = o1.user_id) as order_count
+FROM orders o1
+GROUP BY user_id;
+
+-- ✅ GOOD: Efficient aggregation
+SELECT user_id, COUNT(*) as order_count
+FROM orders
+GROUP BY user_id;
+```
+
+## 🛠️ Code Quality & Maintainability
+
+### SQL Style & Formatting
+```sql
+-- ❌ BAD: Poor formatting and style
+select u.id,u.name,o.total from users u left join orders o on u.id=o.user_id where u.status='active' and o.order_date>='2024-01-01';
+
+-- ✅ GOOD: Clean, readable formatting
+SELECT u.id,
+       u.name,
+       o.total
+FROM users u
+LEFT JOIN orders o ON u.id = o.user_id
+WHERE u.status = 'active'
+  AND o.order_date >= '2024-01-01';
+```
+
+### Naming Conventions
+- **Consistent Naming**: Tables, columns, constraints follow consistent patterns
+- **Descriptive Names**: Clear, meaningful names for database objects
+- **Reserved Words**: Avoid using database reserved words as identifiers
+- **Case Sensitivity**: Consistent case usage across schema
+
+### Schema Design Review
+- **Normalization**: Appropriate normalization level (avoid over/under-normalization)
+- **Data Types**: Optimal data type choices for storage and performance
+- **Constraints**: Proper use of PRIMARY KEY, FOREIGN KEY, CHECK, NOT NULL
+- **Default Values**: Appropriate default values for columns
+
+## 🗄️ Database-Specific Best Practices
+
+### PostgreSQL
+```sql
+-- Use JSONB for JSON data
+CREATE TABLE events (
+    id SERIAL PRIMARY KEY,
+    data JSONB NOT NULL,
+    created_at TIMESTAMPTZ DEFAULT NOW()
+);
+
+-- GIN index for JSONB queries
+CREATE INDEX idx_events_data ON events USING gin(data);
+
+-- Array types for multi-value columns
+CREATE TABLE tags (
+    post_id INT,
+    tag_names TEXT[]
+);
+```
+
+### MySQL
+```sql
+-- Use appropriate storage engines
+CREATE TABLE sessions (
+    id VARCHAR(128) PRIMARY KEY,
+    data TEXT,
+    expires TIMESTAMP
+) ENGINE=InnoDB;
+
+-- Optimize for InnoDB
+ALTER TABLE large_table 
+ADD INDEX idx_covering (status, created_at, id);
+```
+
+### SQL Server
+```sql
+-- Use appropriate data types
+CREATE TABLE products (
+    id BIGINT IDENTITY(1,1) PRIMARY KEY,
+    name NVARCHAR(255) NOT NULL,
+    price DECIMAL(10,2) NOT NULL,
+    created_at DATETIME2 DEFAULT GETUTCDATE()
+);
+
+-- Columnstore indexes for analytics
+CREATE COLUMNSTORE INDEX idx_sales_cs ON sales;
+```
+
+### Oracle
+```sql
+-- Use sequences for auto-increment
+CREATE SEQUENCE user_id_seq START WITH 1 INCREMENT BY 1;
+
+CREATE TABLE users (
+    id NUMBER DEFAULT user_id_seq.NEXTVAL PRIMARY KEY,
+    name VARCHAR2(255) NOT NULL
+);
+```
+
+## 🧪 Testing & Validation
+
+### Data Integrity Checks
+```sql
+-- Verify referential integrity
+SELECT o.user_id 
+FROM orders o 
+LEFT JOIN users u ON o.user_id = u.id 
+WHERE u.id IS NULL;
+
+-- Check for data consistency
+SELECT COUNT(*) as inconsistent_records
+FROM products 
+WHERE price < 0 OR stock_quantity < 0;
+```
+
+### Performance Testing
+- **Execution Plans**: Review query execution plans
+- **Load Testing**: Test queries with realistic data volumes
+- **Stress Testing**: Verify performance under concurrent load
+- **Regression Testing**: Ensure optimizations don't break functionality
+
+## 📊 Common Anti-Patterns
+
+### N+1 Query Problem
+```sql
+-- ❌ BAD: N+1 queries in application code
+for user in users:
+    orders = query("SELECT * FROM orders WHERE user_id = ?", user.id)
+
+-- ✅ GOOD: Single optimized query
+SELECT u.*, o.*
+FROM users u
+LEFT JOIN orders o ON u.id = o.user_id;
+```
+
+### Overuse of DISTINCT
+```sql
+-- ❌ BAD: DISTINCT masking join issues
+SELECT DISTINCT u.name 
+FROM users u, orders o 
+WHERE u.id = o.user_id;
+
+-- ✅ GOOD: Proper join without DISTINCT
+SELECT u.name
+FROM users u
+INNER JOIN orders o ON u.id = o.user_id
+GROUP BY u.name;
+```
+
+### Function Misuse in WHERE Clauses
+```sql
+-- ❌ BAD: Functions prevent index usage
+SELECT * FROM orders 
+WHERE YEAR(order_date) = 2024;
+
+-- ✅ GOOD: Range conditions use indexes
+SELECT * FROM orders 
+WHERE order_date >= '2024-01-01' 
+  AND order_date < '2025-01-01';
+```
+
+## 📋 SQL Review Checklist
+
+### Security
+- [ ] All user inputs are parameterized
+- [ ] No dynamic SQL construction with string concatenation
+- [ ] Appropriate access controls and permissions
+- [ ] Sensitive data is properly protected
+- [ ] SQL injection attack vectors are eliminated
+
+### Performance
+- [ ] Indexes exist for frequently queried columns
+- [ ] No unnecessary SELECT * statements
+- [ ] JOINs are optimized and use appropriate types
+- [ ] WHERE clauses are selective and use indexes
+- [ ] Subqueries are optimized or converted to JOINs
+
+### Code Quality
+- [ ] Consistent naming conventions
+- [ ] Proper formatting and indentation
+- [ ] Meaningful comments for complex logic
+- [ ] Appropriate data types are used
+- [ ] Error handling is implemented
+
+### Schema Design
+- [ ] Tables are properly normalized
+- [ ] Constraints enforce data integrity
+- [ ] Indexes support query patterns
+- [ ] Foreign key relationships are defined
+- [ ] Default values are appropriate
+
+## 🎯 Review Output Format
+
+### Issue Template
+```
+## [PRIORITY] [CATEGORY]: [Brief Description]
+
+**Location**: [Table/View/Procedure name and line number if applicable]
+**Issue**: [Detailed explanation of the problem]
+**Security Risk**: [If applicable - injection risk, data exposure, etc.]
+**Performance Impact**: [Query cost, execution time impact]
+**Recommendation**: [Specific fix with code example]
+
+**Before**:
+```sql
+-- Problematic SQL
+```
+
+**After**:
+```sql
+-- Improved SQL
+```
+
+**Expected Improvement**: [Performance gain, security benefit]
+```
+
+### Summary Assessment
+- **Security Score**: [1-10] - SQL injection protection, access controls
+- **Performance Score**: [1-10] - Query efficiency, index usage
+- **Maintainability Score**: [1-10] - Code quality, documentation
+- **Schema Quality Score**: [1-10] - Design patterns, normalization
+
+### Top 3 Priority Actions
+1. **[Critical Security Fix]**: Address SQL injection vulnerabilities
+2. **[Performance Optimization]**: Add missing indexes or optimize queries
+3. **[Code Quality]**: Improve naming conventions and documentation
+
+Focus on providing actionable, database-agnostic recommendations while highlighting platform-specific optimizations and best practices.