shll-skills 5.1.0 → 5.1.1

package/SKILL.md

@@ -270,6 +270,19 @@ Step 2: Call SHLL execute_calldata(token_id, target, data, value) → PolicyGuar
 
 For multi-step transactions (e.g. approve + swap), use `execute_calldata_batch` to execute atomically.
 
+⚠️ **CRITICAL SECURITY: Verify Recipient Address**
+
+Before executing calldata from an external source, you **MUST verify** that any `recipient`, `to`, or `receiver` address embedded in the calldata matches the agent's vault address. Use the `portfolio` tool to get the vault address first.
+
+**Why:** A compromised or malicious API could return valid-looking swap calldata but with the recipient set to an attacker's address. PolicyGuard validates the target contract and spending limits, but does NOT parse internal calldata fields like `recipient`.
+
+```
+Step 0: portfolio(token_id) → get vault address
+Step 1: Get calldata from OKX/Bitget/1inch
+Step 2: Verify that 'recipient' in calldata == vault address
+Step 3: execute_calldata(token_id, target, data, value)
+```
+
 ---
 
 ## LINKS

package/dist/mcp.js

@@ -1316,11 +1316,11 @@ server.tool(
 );
 server.tool(
   "execute_calldata",
-  "Execute raw calldata through PolicyGuard safety layer. Use this to execute transactions from other DeFi skills (OKX DEX API, Bitget, 1inch, etc.) with SHLL on-chain policy enforcement. All actions are validated against spending limits, cooldowns, and whitelists before execution.",
+  "Execute raw calldata through PolicyGuard safety layer. Use this to execute transactions from other DeFi skills (OKX DEX API, Bitget, 1inch, etc.) with SHLL on-chain policy enforcement. IMPORTANT: Before calling, verify that any 'recipient' or 'to' address embedded in the calldata matches the agent's vault address (use the 'portfolio' tool to check). This prevents funds from being routed to an unintended address.",
   {
     token_id: import_zod.z.string().describe("Agent NFA Token ID"),
-    target: import_zod.z.string().describe("Target contract address (0x...)"),
-    data: import_zod.z.string().describe("Transaction calldata hex string"),
+    target: import_zod.z.string().regex(/^0x[0-9a-fA-F]{40}$/, "Must be a valid Ethereum address").describe("Target contract address (0x...)"),
+    data: import_zod.z.string().regex(/^0x[0-9a-fA-F]*$/, "Must be a valid hex string starting with 0x").describe("Transaction calldata hex string"),
     value: import_zod.z.string().default("0").describe("Native BNB value in wei (default: 0)")
   },
   async ({ token_id, target, data, value }) => {
@@ -1363,8 +1363,8 @@ server.tool(
   {
     token_id: import_zod.z.string().describe("Agent NFA Token ID"),
     actions: import_zod.z.array(import_zod.z.object({
-      target: import_zod.z.string().describe("Target contract address"),
-      data: import_zod.z.string().describe("Calldata hex"),
+      target: import_zod.z.string().regex(/^0x[0-9a-fA-F]{40}$/, "Must be a valid Ethereum address").describe("Target contract address"),
+      data: import_zod.z.string().regex(/^0x[0-9a-fA-F]*$/, "Must be valid hex").describe("Calldata hex"),
       value: import_zod.z.string().default("0").describe("BNB value in wei")
     })).describe("Array of actions to execute atomically")
   },

package/dist/mcp.mjs

@@ -827,11 +827,11 @@ server.tool(
 );
 server.tool(
   "execute_calldata",
-  "Execute raw calldata through PolicyGuard safety layer. Use this to execute transactions from other DeFi skills (OKX DEX API, Bitget, 1inch, etc.) with SHLL on-chain policy enforcement. All actions are validated against spending limits, cooldowns, and whitelists before execution.",
+  "Execute raw calldata through PolicyGuard safety layer. Use this to execute transactions from other DeFi skills (OKX DEX API, Bitget, 1inch, etc.) with SHLL on-chain policy enforcement. IMPORTANT: Before calling, verify that any 'recipient' or 'to' address embedded in the calldata matches the agent's vault address (use the 'portfolio' tool to check). This prevents funds from being routed to an unintended address.",
   {
     token_id: z.string().describe("Agent NFA Token ID"),
-    target: z.string().describe("Target contract address (0x...)"),
-    data: z.string().describe("Transaction calldata hex string"),
+    target: z.string().regex(/^0x[0-9a-fA-F]{40}$/, "Must be a valid Ethereum address").describe("Target contract address (0x...)"),
+    data: z.string().regex(/^0x[0-9a-fA-F]*$/, "Must be a valid hex string starting with 0x").describe("Transaction calldata hex string"),
     value: z.string().default("0").describe("Native BNB value in wei (default: 0)")
   },
   async ({ token_id, target, data, value }) => {
@@ -874,8 +874,8 @@ server.tool(
   {
     token_id: z.string().describe("Agent NFA Token ID"),
     actions: z.array(z.object({
-      target: z.string().describe("Target contract address"),
-      data: z.string().describe("Calldata hex"),
+      target: z.string().regex(/^0x[0-9a-fA-F]{40}$/, "Must be a valid Ethereum address").describe("Target contract address"),
+      data: z.string().regex(/^0x[0-9a-fA-F]*$/, "Must be valid hex").describe("Calldata hex"),
       value: z.string().default("0").describe("BNB value in wei")
     })).describe("Array of actions to execute atomically")
   },

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "shll-skills",
-    "version": "5.1.0",
+    "version": "5.1.1",
     "description": "SHLL DeFi Agent — CLI + MCP Server for BSC",
     "main": "dist/index.js",
     "bin": {

package/src/mcp.ts

@@ -973,11 +973,11 @@ server.tool(
 // (OKX DEX API, Bitget, 1inch, etc.) and routes through PolicyGuard
 server.tool(
     "execute_calldata",
-    "Execute raw calldata through PolicyGuard safety layer. Use this to execute transactions from other DeFi skills (OKX DEX API, Bitget, 1inch, etc.) with SHLL on-chain policy enforcement. All actions are validated against spending limits, cooldowns, and whitelists before execution.",
+    "Execute raw calldata through PolicyGuard safety layer. Use this to execute transactions from other DeFi skills (OKX DEX API, Bitget, 1inch, etc.) with SHLL on-chain policy enforcement. IMPORTANT: Before calling, verify that any 'recipient' or 'to' address embedded in the calldata matches the agent's vault address (use the 'portfolio' tool to check). This prevents funds from being routed to an unintended address.",
     {
         token_id: z.string().describe("Agent NFA Token ID"),
-        target: z.string().describe("Target contract address (0x...)"),
-        data: z.string().describe("Transaction calldata hex string"),
+        target: z.string().regex(/^0x[0-9a-fA-F]{40}$/, "Must be a valid Ethereum address").describe("Target contract address (0x...)"),
+        data: z.string().regex(/^0x[0-9a-fA-F]*$/, "Must be a valid hex string starting with 0x").describe("Transaction calldata hex string"),
         value: z.string().default("0").describe("Native BNB value in wei (default: 0)"),
     },
     async ({ token_id, target, data, value }) => {
@@ -1023,8 +1023,8 @@ server.tool(
     {
         token_id: z.string().describe("Agent NFA Token ID"),
         actions: z.array(z.object({
-            target: z.string().describe("Target contract address"),
-            data: z.string().describe("Calldata hex"),
+            target: z.string().regex(/^0x[0-9a-fA-F]{40}$/, "Must be a valid Ethereum address").describe("Target contract address"),
+            data: z.string().regex(/^0x[0-9a-fA-F]*$/, "Must be valid hex").describe("Calldata hex"),
             value: z.string().default("0").describe("BNB value in wei"),
         })).describe("Array of actions to execute atomically"),
     },