shipwright-cli 2.4.0 → 3.1.0

package/scripts/sw-code-review.sh

@@ -6,7 +6,7 @@
 set -euo pipefail
 trap 'echo "ERROR: $BASH_SOURCE:$LINENO exited with status $?" >&2' ERR
 
-VERSION="2.4.0"
+VERSION="3.1.0"
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 REPO_DIR="$(cd "$SCRIPT_DIR/.." && pwd)"
 
@@ -21,24 +21,6 @@ REPO_DIR="$(cd "$SCRIPT_DIR/.." && pwd)"
 [[ "$(type -t success 2>/dev/null)" == "function" ]] || success() { echo -e "\033[38;2;74;222;128m\033[1m✓\033[0m $*"; }
 [[ "$(type -t warn 2>/dev/null)" == "function" ]]    || warn()    { echo -e "\033[38;2;250;204;21m\033[1m⚠\033[0m $*"; }
 [[ "$(type -t error 2>/dev/null)" == "function" ]]   || error()   { echo -e "\033[38;2;248;113;113m\033[1m✗\033[0m $*" >&2; }
-if [[ "$(type -t emit_event 2>/dev/null)" != "function" ]]; then
-  emit_event() {
-    local event_type="$1"; shift; mkdir -p "${HOME}/.shipwright"
-    local payload="{\"ts\":\"$(date -u +%Y-%m-%dT%H:%M:%SZ)\",\"type\":\"$event_type\""
-    while [[ $# -gt 0 ]]; do local key="${1%%=*}" val="${1#*=}"; payload="${payload},\"${key}\":\"${val}\""; shift; done
-    echo "${payload}}" >> "${HOME}/.shipwright/events.jsonl"
-  }
-fi
-CYAN="${CYAN:-\033[38;2;0;212;255m}"
-PURPLE="${PURPLE:-\033[38;2;124;58;237m}"
-BLUE="${BLUE:-\033[38;2;0;102;255m}"
-GREEN="${GREEN:-\033[38;2;74;222;128m}"
-YELLOW="${YELLOW:-\033[38;2;250;204;21m}"
-RED="${RED:-\033[38;2;248;113;113m}"
-DIM="${DIM:-\033[2m}"
-BOLD="${BOLD:-\033[1m}"
-RESET="${RESET:-\033[0m}"
-
 # ─── Configuration ───────────────────────────────────────────────────────
 REVIEW_CONFIG="${REPO_DIR}/.claude/code-review.json"
 QUALITY_METRICS_FILE="${REPO_DIR}/.claude/pipeline-artifacts/quality-metrics.json"
@@ -335,17 +317,16 @@ auto_fix() {
     local backup="${target_file}.review-backup"
     cp "$target_file" "$backup"
 
-    # Fix 1: Run shellcheck and capture warnings
-    if command -v shellcheck &>/dev/null; then
-        local shellcheck_fixes=0
+    # Report shellcheck issues (informational — auto-fix is limited to whitespace)
+    if command -v shellcheck >/dev/null 2>&1; then
         local warnings_file
         warnings_file=$(mktemp)
         shellcheck -f json "$target_file" > "$warnings_file" 2>/dev/null || true
 
         if [[ -s "$warnings_file" ]]; then
-            shellcheck_fixes=$(jq 'length' "$warnings_file" 2>/dev/null || echo "0")
-            info "shellcheck found $shellcheck_fixes issues in $target_file"
-            fixed=$((fixed + shellcheck_fixes))
+            local shellcheck_count
+            shellcheck_count=$(jq 'length' "$warnings_file" 2>/dev/null || echo "0")
+            [[ "$shellcheck_count" -gt 0 ]] && info "shellcheck found $shellcheck_count issues in $target_file (manual review recommended)"
         fi
         rm -f "$warnings_file"
     fi
@@ -381,7 +362,7 @@ run_claude_semantic_review() {
     local diff_content="$1"
     local requirements="${2:-}"
     [[ -z "$diff_content" ]] && return 0
-    if ! command -v claude &>/dev/null; then
+    if ! command -v claude >/dev/null 2>&1; then
         return 0
     fi
 
@@ -437,13 +418,12 @@ review_changes() {
     local review_output="{\"timestamp\":\"$(date -u +%Y-%m-%dT%H:%M:%SZ)\",\"scope\":\"$review_scope\",\"findings\":{}}"
     local total_issues=0
 
-    # Get changed files
+    # Get changed files (Bash 3.2 compatible — no mapfile)
     local changed_files=()
     if [[ "$review_scope" == "staged" ]]; then
-        mapfile -t changed_files < <(cd "$REPO_DIR" && git diff --cached --name-only 2>/dev/null || true)
+        while IFS= read -r _f; do [[ -n "$_f" ]] && changed_files+=("$_f"); done < <(cd "$REPO_DIR" && git diff --cached --name-only 2>/dev/null || true)
     else
-        # For PR: get diff against main
-        mapfile -t changed_files < <(cd "$REPO_DIR" && git diff main...HEAD --name-only 2>/dev/null || true)
+        while IFS= read -r _f; do [[ -n "$_f" ]] && changed_files+=("$_f"); done < <(cd "$REPO_DIR" && git diff main...HEAD --name-only 2>/dev/null || true)
     fi
 
     [[ ${#changed_files[@]} -eq 0 ]] && { success "No changes to review"; return 0; }
@@ -456,9 +436,9 @@ review_changes() {
         diff_content=$(cd "$REPO_DIR" && git diff main...HEAD 2>/dev/null || true)
     fi
     local semantic_issues=()
-    if [[ -n "$diff_content" ]] && command -v claude &>/dev/null; then
+    if [[ -n "$diff_content" ]] && command -v claude >/dev/null 2>&1; then
         info "Running Claude semantic review (logic, race conditions, API usage)..."
-        mapfile -t semantic_issues < <(run_claude_semantic_review "$diff_content" "${REVIEW_REQUIREMENTS:-}" || true)
+        while IFS= read -r _si; do [[ -n "$_si" ]] && semantic_issues+=("$_si"); done < <(run_claude_semantic_review "$diff_content" "${REVIEW_REQUIREMENTS:-}" || true)
         if [[ ${#semantic_issues[@]} -gt 0 ]]; then
             total_issues=$((total_issues + ${#semantic_issues[@]}))
             review_output=$(echo "$review_output" | jq --argjson arr "$(printf '%s\n' "${semantic_issues[@]}" | jq -R . | jq -s .)" '.semantic_findings = $arr' 2>/dev/null || echo "$review_output")
@@ -476,10 +456,10 @@ review_changes() {
         local arch_issues=()
         local style_issues=()
 
-        mapfile -t smells < <(detect_code_smells "$file_path")
-        mapfile -t solids < <(check_solid_principles "$file_path")
-        mapfile -t arch_issues < <(check_architecture_boundaries "$file_path")
-        mapfile -t style_issues < <(check_style_consistency "$file_path")
+        while IFS= read -r _s; do [[ -n "$_s" ]] && smells+=("$_s"); done < <(detect_code_smells "$file_path")
+        while IFS= read -r _s; do [[ -n "$_s" ]] && solids+=("$_s"); done < <(check_solid_principles "$file_path")
+        while IFS= read -r _s; do [[ -n "$_s" ]] && arch_issues+=("$_s"); done < <(check_architecture_boundaries "$file_path")
+        while IFS= read -r _s; do [[ -n "$_s" ]] && style_issues+=("$_s"); done < <(check_style_consistency "$file_path")
 
         local file_issues=$((${#smells[@]} + ${#solids[@]} + ${#arch_issues[@]} + ${#style_issues[@]}))
         total_issues=$((total_issues + file_issues))

package/scripts/sw-connect.sh

@@ -8,7 +8,7 @@
 set -euo pipefail
 trap 'echo "ERROR: $BASH_SOURCE:$LINENO exited with status $?" >&2' ERR
 
-VERSION="2.4.0"
+VERSION="3.1.0"
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 
 # ─── Cross-platform compatibility ──────────────────────────────────────────
@@ -18,8 +18,11 @@ SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 # Canonical helpers (colors, output, events)
 # shellcheck source=lib/helpers.sh
 [[ -f "$SCRIPT_DIR/lib/helpers.sh" ]] && source "$SCRIPT_DIR/lib/helpers.sh"
+[[ -f "$SCRIPT_DIR/lib/config.sh" ]] && source "$SCRIPT_DIR/lib/config.sh"
 # Fallbacks when helpers not loaded (e.g. test env with overridden SCRIPT_DIR)
 [[ "$(type -t info 2>/dev/null)" == "function" ]]    || info()    { echo -e "\033[38;2;0;212;255m\033[1m▸\033[0m $*"; }
+# Color fallbacks when helpers not loaded
+: "${CYAN:=}" "${BOLD:=}" "${RESET:=}" "${DIM:=}" "${GREEN:=}" "${RED:=}" "${YELLOW:=}" "${PURPLE:=}" "${WHITE:=}" "${BLUE:=}"
 [[ "$(type -t success 2>/dev/null)" == "function" ]] || success() { echo -e "\033[38;2;74;222;128m\033[1m✓\033[0m $*"; }
 [[ "$(type -t warn 2>/dev/null)" == "function" ]]    || warn()    { echo -e "\033[38;2;250;204;21m\033[1m⚠\033[0m $*"; }
 [[ "$(type -t error 2>/dev/null)" == "function" ]]   || error()   { echo -e "\033[38;2;248;113;113m\033[1m✗\033[0m $*" >&2; }
@@ -35,16 +38,6 @@ if [[ "$(type -t emit_event 2>/dev/null)" != "function" ]]; then
     echo "${payload}}" >> "${HOME}/.shipwright/events.jsonl"
   }
 fi
-CYAN="${CYAN:-\033[38;2;0;212;255m}"
-PURPLE="${PURPLE:-\033[38;2;124;58;237m}"
-BLUE="${BLUE:-\033[38;2;0;102;255m}"
-GREEN="${GREEN:-\033[38;2;74;222;128m}"
-YELLOW="${YELLOW:-\033[38;2;250;204;21m}"
-RED="${RED:-\033[38;2;248;113;113m}"
-DIM="${DIM:-\033[2m}"
-BOLD="${BOLD:-\033[1m}"
-RESET="${RESET:-\033[0m}"
-
 # ─── Constants ──────────────────────────────────────────────────────────────
 SHIPWRIGHT_DIR="$HOME/.shipwright"
 PID_FILE="$SHIPWRIGHT_DIR/connect.pid"
@@ -53,7 +46,7 @@ DAEMON_PID_FILE="$SHIPWRIGHT_DIR/daemon.pid"
 DAEMON_STATE_FILE="$SHIPWRIGHT_DIR/daemon-state.json"
 EVENTS_FILE="$SHIPWRIGHT_DIR/events.jsonl"
 CONNECT_LOG="$SHIPWRIGHT_DIR/connect.log"
-DEFAULT_URL="http://localhost:8767"
+DEFAULT_URL="http://localhost:$(_config_get_int "dashboard.port" 8767)"
 HEARTBEAT_INTERVAL=10
 
 ensure_dir() {

package/scripts/sw-context.sh

@@ -6,9 +6,9 @@
 set -euo pipefail
 trap 'echo "ERROR: $BASH_SOURCE:$LINENO exited with status $?" >&2' ERR
 
-VERSION="2.4.0"
+VERSION="3.1.0"
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
-REPO_DIR="$(cd "$SCRIPT_DIR/.." && pwd)"
+REPO_DIR="${SHIPWRIGHT_REPO_DIR:-$(cd "$SCRIPT_DIR/.." && pwd)}"
 
 # ─── Cross-platform compatibility ──────────────────────────────────────────
 # shellcheck source=lib/compat.sh
@@ -26,24 +26,6 @@ if [[ "$(type -t now_iso 2>/dev/null)" != "function" ]]; then
   now_iso()   { date -u +"%Y-%m-%dT%H:%M:%SZ"; }
   now_epoch() { date +%s; }
 fi
-if [[ "$(type -t emit_event 2>/dev/null)" != "function" ]]; then
-  emit_event() {
-    local event_type="$1"; shift; mkdir -p "${HOME}/.shipwright"
-    local payload="{\"ts\":\"$(date -u +%Y-%m-%dT%H:%M:%SZ)\",\"type\":\"$event_type\""
-    while [[ $# -gt 0 ]]; do local key="${1%%=*}" val="${1#*=}"; payload="${payload},\"${key}\":\"${val}\""; shift; done
-    echo "${payload}}" >> "${HOME}/.shipwright/events.jsonl"
-  }
-fi
-CYAN="${CYAN:-\033[38;2;0;212;255m}"
-PURPLE="${PURPLE:-\033[38;2;124;58;237m}"
-BLUE="${BLUE:-\033[38;2;0;102;255m}"
-GREEN="${GREEN:-\033[38;2;74;222;128m}"
-YELLOW="${YELLOW:-\033[38;2;250;204;21m}"
-RED="${RED:-\033[38;2;248;113;113m}"
-DIM="${DIM:-\033[2m}"
-BOLD="${BOLD:-\033[1m}"
-RESET="${RESET:-\033[0m}"
-
 # ─── Paths ────────────────────────────────────────────────────────────────
 ARTIFACTS_DIR="${REPO_DIR}/.claude/pipeline-artifacts"
 CONTEXT_BUNDLE="${ARTIFACTS_DIR}/context-bundle.md"
@@ -124,7 +106,7 @@ extract_recent_prs() {
         return
     fi
 
-    if ! command -v gh &>/dev/null; then
+    if ! command -v gh >/dev/null 2>&1; then
         echo "(gh CLI not available, using git log)"
         echo ""
         local recent_commits
@@ -405,6 +387,7 @@ gather_context() {
 
     local tmp_file
     tmp_file=$(mktemp "${TMPDIR:-/tmp}/sw-context-bundle.XXXXXX")
+    trap "rm -f '$tmp_file'" RETURN
 
     # Write bundle header
     {
@@ -484,9 +467,9 @@ gather_context() {
 # ─── Show current bundle ───────────────────────────────────────────────────
 show_context() {
     if [[ ! -f "$CONTEXT_BUNDLE" ]]; then
-        warn "No context bundle found at ${CONTEXT_BUNDLE}"
-        echo "Run '${CYAN}shipwright context gather --goal \"...\" --stage plan${RESET}' first"
-        return 1
+        echo "Pipeline Context — No bundle generated yet"
+        echo "Run '${CYAN}shipwright context gather --goal \"...\" --stage plan${RESET}' to create one"
+        return 0
     fi
 
     cat "$CONTEXT_BUNDLE"
@@ -498,7 +481,7 @@ clear_context() {
         rm -f "$CONTEXT_BUNDLE"
         success "Context bundle cleared"
     else
-        warn "No context bundle to clear"
+        info "No context bundle to clear — already cleared"
     fi
 }
 
@@ -584,7 +567,7 @@ main() {
 
             # If issue provided, fetch from GitHub
             if [[ -n "$issue" ]]; then
-                if [[ "${NO_GITHUB:-}" == "true" ]] || ! command -v gh &>/dev/null; then
+                if [[ "${NO_GITHUB:-}" == "true" ]] || ! command -v gh >/dev/null 2>&1; then
                     goal="GitHub issue #$issue (fetch unavailable)"
                 else
                     goal=$(gh issue view "$issue" --json title,body --template '{{.title}}: {{.body}}' 2>/dev/null || echo "GitHub issue #$issue")

package/scripts/sw-cost.sh

@@ -6,7 +6,7 @@
 set -euo pipefail
 trap 'echo "ERROR: $BASH_SOURCE:$LINENO exited with status $?" >&2' ERR
 
-VERSION="2.4.0"
+VERSION="3.1.0"
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 REPO_DIR="$(cd "$SCRIPT_DIR/.." && pwd)"
 
@@ -34,16 +34,6 @@ if [[ "$(type -t emit_event 2>/dev/null)" != "function" ]]; then
     echo "${payload}}" >> "${HOME}/.shipwright/events.jsonl"
   }
 fi
-CYAN="${CYAN:-\033[38;2;0;212;255m}"
-PURPLE="${PURPLE:-\033[38;2;124;58;237m}"
-BLUE="${BLUE:-\033[38;2;0;102;255m}"
-GREEN="${GREEN:-\033[38;2;74;222;128m}"
-YELLOW="${YELLOW:-\033[38;2;250;204;21m}"
-RED="${RED:-\033[38;2;248;113;113m}"
-DIM="${DIM:-\033[2m}"
-BOLD="${BOLD:-\033[1m}"
-RESET="${RESET:-\033[0m}"
-
 format_duration() {
     local secs="$1"
     if [[ "$secs" -ge 3600 ]]; then
@@ -152,14 +142,14 @@ cost_record() {
     local cost_usd
     cost_usd=$(cost_calculate "$input_tokens" "$output_tokens" "$model")
 
-    # Try SQLite first
-    if type db_record_cost &>/dev/null; then
-        db_record_cost "$input_tokens" "$output_tokens" "$model" "$stage" "$cost_usd" "$issue" 2>/dev/null || true
+    # Try SQLite first (arg order must match db_record_cost signature: tokens, tokens, model, cost, stage, issue)
+    if type db_record_cost >/dev/null 2>&1; then
+        db_record_cost "$input_tokens" "$output_tokens" "$model" "$cost_usd" "$stage" "$issue" 2>/dev/null || true
     fi
 
     # Always write to JSON (dual-write period)
     (
-        if command -v flock &>/dev/null; then
+        if command -v flock >/dev/null 2>&1; then
             flock -w 10 200 2>/dev/null || { warn "Cost lock timeout"; }
         fi
         local tmp_file
@@ -202,7 +192,7 @@ cost_check_budget() {
 
     # Try DB for budget info
     local budget_enabled budget_usd
-    if type db_get_budget &>/dev/null && type db_available &>/dev/null && db_available 2>/dev/null; then
+    if type db_get_budget >/dev/null 2>&1 && type db_available >/dev/null 2>&1 && db_available 2>/dev/null; then
         local db_budget
         db_budget=$(db_get_budget 2>/dev/null || true)
         if [[ -n "$db_budget" ]]; then
@@ -259,7 +249,7 @@ cost_remaining_budget() {
     ensure_cost_dir
 
     # Try DB for remaining budget (single query)
-    if type db_remaining_budget &>/dev/null && type db_available &>/dev/null && db_available 2>/dev/null; then
+    if type db_remaining_budget >/dev/null 2>&1 && type db_available >/dev/null 2>&1 && db_available 2>/dev/null; then
         local db_result
         db_result=$(db_remaining_budget 2>/dev/null || true)
         if [[ -n "$db_result" ]]; then
@@ -274,6 +264,11 @@ cost_remaining_budget() {
     budget_usd=$(jq -r '.daily_budget_usd' "$BUDGET_FILE" 2>/dev/null || echo "0")
 
     if [[ "$budget_enabled" != "true" || "$budget_usd" == "0" ]]; then
+        if [[ -z "${_BUDGET_UNCONFIGURED_WARNED:-}" ]]; then
+            info "Budget not configured — unlimited. Use 'shipwright cost budget set <amount>'"
+            emit_event "cost.budget_unconfigured" "status=unlimited"
+            _BUDGET_UNCONFIGURED_WARNED=1
+        fi
         echo "unlimited"
         return 0
     fi
@@ -818,7 +813,7 @@ budget_set() {
     ensure_cost_dir
 
     # Write to DB if available
-    if type db_set_budget &>/dev/null; then
+    if type db_set_budget >/dev/null 2>&1; then
         db_set_budget "$amount" 2>/dev/null || true
     fi
 
@@ -904,6 +899,8 @@ show_help() {
 }
 
 # ─── Command Router ─────────────────────────────────────────────────────────
+# Only run CLI when executed directly (not when sourced by sw-pipeline.sh)
+if [[ "${BASH_SOURCE[0]}" == "$0" ]]; then
 
 SUBCOMMAND="${1:-help}"
 shift 2>/dev/null || true
@@ -953,3 +950,5 @@ case "$SUBCOMMAND" in
         exit 1
         ;;
 esac
+
+fi  # end source guard