shipwright-cli 2.4.0 → 3.0.0

package/scripts/sw-recruit.sh

@@ -14,7 +14,7 @@ SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 RECRUIT_VERSION="3.0.0"
 
 # ─── Dependency check ─────────────────────────────────────────────────────────
-if ! command -v jq &>/dev/null; then
+if ! command -v jq >/dev/null 2>&1; then
     echo "ERROR: sw-recruit.sh requires 'jq' (JSON processor). Install with:" >&2
     echo "  macOS:  brew install jq" >&2
     echo "  Ubuntu: sudo apt install jq" >&2
@@ -45,16 +45,6 @@ if [[ "$(type -t emit_event 2>/dev/null)" != "function" ]]; then
     echo "${payload}}" >> "${HOME}/.shipwright/events.jsonl"
   }
 fi
-CYAN="${CYAN:-\033[38;2;0;212;255m}"
-PURPLE="${PURPLE:-\033[38;2;124;58;237m}"
-BLUE="${BLUE:-\033[38;2;0;102;255m}"
-GREEN="${GREEN:-\033[38;2;74;222;128m}"
-YELLOW="${YELLOW:-\033[38;2;250;204;21m}"
-RED="${RED:-\033[38;2;248;113;113m}"
-DIM="${DIM:-\033[2m}"
-BOLD="${BOLD:-\033[1m}"
-RESET="${RESET:-\033[0m}"
-
 # ─── File Locking for Concurrent Safety ────────────────────────────────────
 # Usage: _recruit_locked_write <target_file> <tmp_file>
 # Acquires flock, then moves tmp_file to target atomically.
@@ -65,7 +55,7 @@ _recruit_locked_write() {
     local lock_file="${target}.lock"
 
     (
-        if command -v flock &>/dev/null; then
+        if command -v flock >/dev/null 2>&1; then
             flock -w 5 200 2>/dev/null || true
         fi
         mv "$tmp_file" "$target"
@@ -90,7 +80,7 @@ POLICY_FILE="${SCRIPT_DIR}/../config/policy.json"
 _recruit_policy() {
     local key="$1"
     local default="$2"
-    if [[ -f "$POLICY_FILE" ]] && command -v jq &>/dev/null; then
+    if [[ -f "$POLICY_FILE" ]] && command -v jq >/dev/null 2>&1; then
         local val
         val=$(jq -r ".recruit.${key} // empty" "$POLICY_FILE" 2>/dev/null) || true
         [[ -n "$val" ]] && echo "$val" || echo "$default"
@@ -133,7 +123,7 @@ fi
 # Set SW_RECRUIT_NO_LLM=1 to disable LLM calls (e.g., in tests)
 _recruit_has_claude() {
     [[ "${SW_RECRUIT_NO_LLM:-}" == "1" ]] && return 1
-    command -v claude &>/dev/null
+    command -v claude >/dev/null 2>&1
 }
 
 # Call Claude with a prompt, return text. Falls back gracefully.
@@ -144,7 +134,7 @@ _recruit_call_claude() {
     # Honor the no-LLM flag everywhere (not just _recruit_has_claude)
     [[ "${SW_RECRUIT_NO_LLM:-}" == "1" ]] && { echo ""; return; }
 
-    if [[ "$INTELLIGENCE_AVAILABLE" == "true" ]] && command -v _intelligence_call_claude &>/dev/null; then
+    if [[ "$INTELLIGENCE_AVAILABLE" == "true" ]] && command -v _intelligence_call_claude >/dev/null 2>&1; then
         _intelligence_call_claude "$prompt" 2>/dev/null || echo ""
         return
     fi
@@ -164,7 +154,7 @@ _recruit_call_claude() {
 initialize_builtin_roles() {
     ensure_recruit_dir
 
-    if jq -e '.architect' "$ROLES_DB" &>/dev/null 2>&1; then
+    if jq -e '.architect' "$ROLES_DB" >/dev/null 2>&1; then
         return 0
     fi
 
@@ -385,7 +375,7 @@ Return JSON only, no markdown fences."
     local result
     result=$(_recruit_call_claude "$prompt")
 
-    if [[ -n "$result" ]] && echo "$result" | jq -e '.primary_role' &>/dev/null 2>&1; then
+    if [[ -n "$result" ]] && echo "$result" | jq -e '.primary_role' >/dev/null 2>&1; then
         echo "$result"
         return 0
     fi
@@ -483,7 +473,7 @@ Return JSON only."
         local result
         result=$(_recruit_call_claude "$prompt")
 
-        if [[ -n "$result" ]] && echo "$result" | jq -e '.key' &>/dev/null 2>&1; then
+        if [[ -n "$result" ]] && echo "$result" | jq -e '.key' >/dev/null 2>&1; then
             role_key=$(echo "$result" | jq -r '.key')
             role_title=$(echo "$result" | jq -r '.title')
             role_desc=$(echo "$result" | jq -r '.description')
@@ -1042,7 +1032,7 @@ cmd_team() {
 
         # Gather codebase context if in a git repo
         local codebase_context=""
-        if command -v git &>/dev/null && git rev-parse --git-dir &>/dev/null 2>&1; then
+        if command -v git >/dev/null 2>&1 && git rev-parse --git-dir >/dev/null 2>&1; then
             local file_count lang_summary
             file_count=$(git ls-files 2>/dev/null | wc -l | tr -d ' ')
             lang_summary=$(git ls-files 2>/dev/null | grep -oE '\.[^.]+$' | sort | uniq -c | sort -rn | head -5 | tr '\n' ';' || echo "unknown")
@@ -1069,7 +1059,7 @@ Return JSON only."
         local result
         result=$(_recruit_call_claude "$prompt")
 
-        if [[ -n "$result" ]] && echo "$result" | jq -e '.team' &>/dev/null 2>&1; then
+        if [[ -n "$result" ]] && echo "$result" | jq -e '.team' >/dev/null 2>&1; then
             while IFS= read -r role; do
                 [[ -z "$role" || "$role" == "null" ]] && continue
                 recommended_team+=("$role")
@@ -1439,7 +1429,7 @@ Return JSON only."
     local result
     result=$(_recruit_call_claude "$prompt")
 
-    if [[ -n "$result" ]] && echo "$result" | jq -e '.roles | length > 0' &>/dev/null 2>&1; then
+    if [[ -n "$result" ]] && echo "$result" | jq -e '.roles | length > 0' >/dev/null 2>&1; then
         local new_count
         new_count=$(echo "$result" | jq '.roles | length')
 
@@ -1596,7 +1586,7 @@ Return JSON only."
         local result
         result=$(_recruit_call_claude "$prompt")
 
-        if [[ -n "$result" ]] && echo "$result" | jq -e '.working_style' &>/dev/null 2>&1; then
+        if [[ -n "$result" ]] && echo "$result" | jq -e '.working_style' >/dev/null 2>&1; then
             # Save the LLM-generated mind profile
             local tmp_file
             tmp_file=$(mktemp)
@@ -1700,7 +1690,7 @@ Return JSON only."
         local result
         result=$(_recruit_call_claude "$prompt")
 
-        if [[ -n "$result" ]] && echo "$result" | jq -e '.sub_tasks' &>/dev/null 2>&1; then
+        if [[ -n "$result" ]] && echo "$result" | jq -e '.sub_tasks' >/dev/null 2>&1; then
             local restated_goal
             restated_goal=$(echo "$result" | jq -r '.goal // ""')
             [[ -n "$restated_goal" ]] && echo -e "  ${DIM}Interpreted as: ${restated_goal}${RESET}"
@@ -1926,7 +1916,7 @@ cmd_match() {
         local llm_result
         llm_result=$(_recruit_llm_match "$task_description" "$available_roles")
 
-        if [[ -n "$llm_result" ]] && echo "$llm_result" | jq -e '.primary_role' &>/dev/null 2>&1; then
+        if [[ -n "$llm_result" ]] && echo "$llm_result" | jq -e '.primary_role' >/dev/null 2>&1; then
             primary_role=$(echo "$llm_result" | jq -r '.primary_role')
             secondary_roles=$(echo "$llm_result" | jq -r '.secondary_roles // [] | join(", ")')
             confidence=$(echo "$llm_result" | jq -r '.confidence // 0.8')
@@ -1961,7 +1951,7 @@ cmd_match() {
     fi
 
     # Validate role exists
-    if ! jq -e ".\"${primary_role}\"" "$ROLES_DB" &>/dev/null 2>&1; then
+    if ! jq -e ".\"${primary_role}\"" "$ROLES_DB" >/dev/null 2>&1; then
         primary_role="builder"
     fi
 

package/scripts/sw-regression.sh

@@ -6,7 +6,7 @@
 set -euo pipefail
 trap 'echo "ERROR: $BASH_SOURCE:$LINENO exited with status $?" >&2' ERR
 
-VERSION="2.4.0"
+VERSION="3.0.0"
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 REPO_DIR="$(cd "$SCRIPT_DIR/.." && pwd)"
 
@@ -34,16 +34,6 @@ if [[ "$(type -t emit_event 2>/dev/null)" != "function" ]]; then
     echo "${payload}}" >> "${HOME}/.shipwright/events.jsonl"
   }
 fi
-CYAN="${CYAN:-\033[38;2;0;212;255m}"
-PURPLE="${PURPLE:-\033[38;2;124;58;237m}"
-BLUE="${BLUE:-\033[38;2;0;102;255m}"
-GREEN="${GREEN:-\033[38;2;74;222;128m}"
-YELLOW="${YELLOW:-\033[38;2;250;204;21m}"
-RED="${RED:-\033[38;2;248;113;113m}"
-DIM="${DIM:-\033[2m}"
-BOLD="${BOLD:-\033[1m}"
-RESET="${RESET:-\033[0m}"
-
 format_duration() {
     local secs="$1"
     if [[ "$secs" -ge 3600 ]]; then
@@ -134,7 +124,7 @@ collect_script_metrics() {
     # Check for syntax errors
     while IFS= read -r script; do
         if ! bash -n "$script" 2>/dev/null; then
-            ((syntax_errors++))
+            syntax_errors=$((syntax_errors + 1))
         fi
     done < <(find "$REPO_DIR/scripts" -maxdepth 1 -name "*.sh" -type f 2>/dev/null)
 
@@ -291,14 +281,14 @@ cmd_check() {
             # Metric should not decrease
             if (( $(echo "$current_val_num < $baseline_val_num" | bc -l 2>/dev/null || echo "0") )); then
                 echo -e "${RED}✗ $name: $baseline_val_num → $current_val_num (${pct_diff}%)${RESET}"
-                ((regressions++))
+                regressions=$((regressions + 1))
                 return 1
             fi
         elif [[ "$direction" == "increase" ]]; then
             # Metric should not increase beyond threshold
             if (( $(echo "$pct_diff > $threshold_val" | bc -l 2>/dev/null || echo "0") )); then
                 echo -e "${RED}✗ $name: $baseline_val_num → $current_val_num (+${pct_diff}%)${RESET}"
-                ((regressions++))
+                regressions=$((regressions + 1))
                 return 1
             fi
         fi
@@ -306,10 +296,10 @@ cmd_check() {
         # Improvement
         if [[ "$direction" == "decrease" ]] && (( $(echo "$current_val_num > $baseline_val_num" | bc -l 2>/dev/null || echo "0") )); then
             echo -e "${GREEN}✓ $name: $baseline_val_num → $current_val_num (improved)${RESET}"
-            ((improvements++))
+            improvements=$((improvements + 1))
         elif [[ "$direction" == "increase" ]] && (( $(echo "$current_val_num < $baseline_val_num" | bc -l 2>/dev/null || echo "0") )); then
             echo -e "${GREEN}✓ $name: $baseline_val_num → $current_val_num (improved)${RESET}"
-            ((improvements++))
+            improvements=$((improvements + 1))
         fi
     }
 
@@ -335,10 +325,10 @@ cmd_check() {
     pass_rate_diff=$(awk "BEGIN { printf \"%.1f\", ($base_pass_rate - $curr_pass_rate) }")
     if (( $(echo "$pass_rate_diff > $pass_rate_threshold" | bc -l 2>/dev/null || echo "0") )); then
         echo -e "${RED}✗ Pass Rate: $base_pass_rate% → $curr_pass_rate% (drop: ${pass_rate_diff}%)${RESET}"
-        ((regressions++))
+        regressions=$((regressions + 1))
     elif (( $(echo "$curr_pass_rate > $base_pass_rate" | bc -l 2>/dev/null || echo "0") )); then
         echo -e "${GREEN}✓ Pass Rate: $base_pass_rate% → $curr_pass_rate%${RESET}"
-        ((improvements++))
+        improvements=$((improvements + 1))
     else
         echo -e "${DIM}= Pass Rate: $base_pass_rate% → $curr_pass_rate%${RESET}"
     fi
@@ -373,10 +363,10 @@ cmd_check() {
     curr_syntax_errors=$(echo "$current" | jq -r '.syntax_errors // 0')
     if [[ "$curr_syntax_errors" -gt "$base_syntax_errors" ]]; then
         echo -e "${RED}✗ Syntax Errors: $base_syntax_errors → $curr_syntax_errors${RESET}"
-        ((regressions++))
+        regressions=$((regressions + 1))
     elif [[ "$curr_syntax_errors" -lt "$base_syntax_errors" ]]; then
         echo -e "${GREEN}✓ Syntax Errors: $base_syntax_errors → $curr_syntax_errors${RESET}"
-        ((improvements++))
+        improvements=$((improvements + 1))
     else
         echo -e "${DIM}= Syntax Errors: $base_syntax_errors → $curr_syntax_errors${RESET}"
     fi
@@ -510,7 +500,7 @@ cmd_history() {
 
     local count=0
     while IFS= read -r baseline_file; do
-        ((count++))
+        count=$((count + 1))
         if [[ "$count" -gt 10 ]]; then
             break
         fi

package/scripts/sw-release-manager.sh

@@ -6,7 +6,7 @@
 set -euo pipefail
 trap 'echo "ERROR: $BASH_SOURCE:$LINENO exited with status $?" >&2' ERR
 
-VERSION="2.4.0"
+VERSION="3.0.0"
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 REPO_DIR="$(cd "$SCRIPT_DIR/.." && pwd)"
 
@@ -26,24 +26,6 @@ if [[ "$(type -t now_iso 2>/dev/null)" != "function" ]]; then
   now_iso()   { date -u +"%Y-%m-%dT%H:%M:%SZ"; }
   now_epoch() { date +%s; }
 fi
-if [[ "$(type -t emit_event 2>/dev/null)" != "function" ]]; then
-  emit_event() {
-    local event_type="$1"; shift; mkdir -p "${HOME}/.shipwright"
-    local payload="{\"ts\":\"$(date -u +%Y-%m-%dT%H:%M:%SZ)\",\"type\":\"$event_type\""
-    while [[ $# -gt 0 ]]; do local key="${1%%=*}" val="${1#*=}"; payload="${payload},\"${key}\":\"${val}\""; shift; done
-    echo "${payload}}" >> "${HOME}/.shipwright/events.jsonl"
-  }
-fi
-CYAN="${CYAN:-\033[38;2;0;212;255m}"
-PURPLE="${PURPLE:-\033[38;2;124;58;237m}"
-BLUE="${BLUE:-\033[38;2;0;102;255m}"
-GREEN="${GREEN:-\033[38;2;74;222;128m}"
-YELLOW="${YELLOW:-\033[38;2;250;204;21m}"
-RED="${RED:-\033[38;2;248;113;113m}"
-DIM="${DIM:-\033[2m}"
-BOLD="${BOLD:-\033[1m}"
-RESET="${RESET:-\033[0m}"
-
 # ─── Structured Event Log ──────────────────────────────────────────────────
 EVENTS_FILE="${HOME}/.shipwright/events.jsonl"
 
@@ -133,7 +115,9 @@ check_tests_passing() {
         return 0
     fi
 
-    if ! npm test 2>&1 | tee /tmp/test-output.log | tail -20; then
+    local _test_log
+    _test_log=$(mktemp "${TMPDIR:-/tmp}/sw-test-output.XXXXXX")
+    if ! npm test 2>&1 | tee "$_test_log" | tail -20; then
         error "Tests are not passing"
         return 1
     fi
@@ -171,7 +155,7 @@ check_coverage_threshold() {
 check_no_open_blockers() {
     info "Checking for open blockers..."
 
-    if ! command -v gh &>/dev/null; then
+    if ! command -v gh >/dev/null 2>&1; then
         warn "GitHub CLI not available — skipping blocker check"
         return 0
     fi
@@ -191,13 +175,20 @@ check_no_open_blockers() {
 check_security_scan() {
     info "Checking security scan status..."
 
-    if ! command -v gh &>/dev/null; then
+    if ! command -v gh >/dev/null 2>&1; then
         warn "GitHub CLI not available — skipping security check"
         return 0
     fi
 
+    local repo_nwo
+    repo_nwo=$(gh repo view --json nameWithOwner --jq '.nameWithOwner' 2>/dev/null || echo "")
+    if [[ -z "$repo_nwo" ]]; then
+        warn "Could not determine repository — skipping security check"
+        return 0
+    fi
+
     local vulns
-    vulns=$(gh api repos/{owner}/{repo}/dependabot/alerts --jq 'length' 2>/dev/null || echo "0")
+    vulns=$(gh api "repos/${repo_nwo}/dependabot/alerts" --jq 'length' 2>/dev/null || echo "0")
 
     if [[ $vulns -gt 0 ]]; then
         error "Found $vulns security vulnerabilities"
@@ -319,7 +310,7 @@ publish_release() {
     fi
 
     # Create GitHub release
-    if command -v gh &>/dev/null; then
+    if command -v gh >/dev/null 2>&1; then
         if gh release create "$next_version" --title "$next_version" --generate-notes; then
             success "GitHub release created"
         else
@@ -371,7 +362,7 @@ create_rc() {
     fi
 
     # Create GitHub pre-release
-    if command -v gh &>/dev/null; then
+    if command -v gh >/dev/null 2>&1; then
         if gh release create "$rc_version" --title "RC: $rc_version" --prerelease --generate-notes; then
             success "GitHub pre-release created"
         else
@@ -424,7 +415,7 @@ promote_rc() {
     fi
 
     # Create GitHub release (not pre-release)
-    if command -v gh &>/dev/null; then
+    if command -v gh >/dev/null 2>&1; then
         if gh release create "$stable_version" --title "$stable_version" --generate-notes; then
             success "GitHub release created"
         else
@@ -472,7 +463,7 @@ rollback_release() {
     fi
 
     # Delete GitHub release
-    if command -v gh &>/dev/null; then
+    if command -v gh >/dev/null 2>&1; then
         if gh release delete "$version" --yes 2>/dev/null; then
             success "GitHub release deleted"
         else
@@ -534,7 +525,7 @@ show_history() {
     info "Release History"
     echo ""
 
-    if ! command -v gh &>/dev/null; then
+    if ! command -v gh >/dev/null 2>&1; then
         error "GitHub CLI required for history"
         return 1
     fi

package/scripts/sw-release.sh

@@ -5,9 +5,9 @@
 # ╚═══════════════════════════════════════════════════════════════════════════╝
 set -euo pipefail
 trap 'echo "ERROR: $BASH_SOURCE:$LINENO exited with status $?" >&2' ERR
-trap 'rm -f "${tmp_file:-}"' EXIT
+trap 'rm -f "${tmp_file:-}" "${tmp_changelog:-}"' EXIT
 
-VERSION="2.4.0"
+VERSION="3.0.0"
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 REPO_DIR="$(cd "$SCRIPT_DIR/.." && pwd)"
 
@@ -18,6 +18,7 @@ REPO_DIR="$(cd "$SCRIPT_DIR/.." && pwd)"
 # Canonical helpers (colors, output, events)
 # shellcheck source=lib/helpers.sh
 [[ -f "$SCRIPT_DIR/lib/helpers.sh" ]] && source "$SCRIPT_DIR/lib/helpers.sh"
+[[ -f "$SCRIPT_DIR/lib/config.sh" ]] && source "$SCRIPT_DIR/lib/config.sh"
 # Fallbacks when helpers not loaded (e.g. test env with overridden SCRIPT_DIR)
 [[ "$(type -t info 2>/dev/null)" == "function" ]]    || info()    { echo -e "\033[38;2;0;212;255m\033[1m▸\033[0m $*"; }
 [[ "$(type -t success 2>/dev/null)" == "function" ]] || success() { echo -e "\033[38;2;74;222;128m\033[1m✓\033[0m $*"; }
@@ -35,16 +36,6 @@ if [[ "$(type -t emit_event 2>/dev/null)" != "function" ]]; then
     echo "${payload}}" >> "${HOME}/.shipwright/events.jsonl"
   }
 fi
-CYAN="${CYAN:-\033[38;2;0;212;255m}"
-PURPLE="${PURPLE:-\033[38;2;124;58;237m}"
-BLUE="${BLUE:-\033[38;2;0;102;255m}"
-GREEN="${GREEN:-\033[38;2;74;222;128m}"
-YELLOW="${YELLOW:-\033[38;2;250;204;21m}"
-RED="${RED:-\033[38;2;248;113;113m}"
-DIM="${DIM:-\033[2m}"
-BOLD="${BOLD:-\033[1m}"
-RESET="${RESET:-\033[0m}"
-
 # ─── Parse flags ───────────────────────────────────────────────────────────
 DRY_RUN=false
 VERSION_TYPE=""
@@ -510,7 +501,8 @@ cmd_publish() {
     info "Step 2/5: Generating changelog..."
     local changelog
     changelog="$(generate_changelog_md "$next_version" "$current_version" "HEAD")"
-    echo "$changelog" > /tmp/release-changelog.md
+    tmp_changelog="$(mktemp)"
+    echo "$changelog" > "$tmp_changelog"
     success "Changelog generated"
     echo ""
 
@@ -531,15 +523,15 @@ cmd_publish() {
 
     # Step 5: Create GitHub release
     info "Step 5/5: Creating GitHub release..."
-    if command -v gh &>/dev/null; then
-        if gh release create "$next_version" --title "$next_version" --notes-file /tmp/release-changelog.md; then
+    if command -v gh >/dev/null 2>&1; then
+        if gh release create "$next_version" --title "$next_version" --notes-file "$tmp_changelog"; then
             success "GitHub release created"
         else
             warn "Failed to create GitHub release (may already exist)"
         fi
     else
         warn "gh CLI not installed — skipping GitHub release creation"
-        echo -e "  Manual create: ${DIM}gh release create $next_version --title '$next_version' --notes-file /tmp/release-changelog.md${RESET}"
+        echo -e "  Manual create: ${DIM}gh release create $next_version --title '$next_version' --notes-file <changelog_file>${RESET}"
     fi
     echo ""
 

package/scripts/sw-remote.sh

@@ -6,7 +6,7 @@
 set -euo pipefail
 trap 'echo "ERROR: $BASH_SOURCE:$LINENO exited with status $?" >&2' ERR
 
-VERSION="2.4.0"
+VERSION="3.0.0"
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 REPO_DIR="$(cd "$SCRIPT_DIR/.." && pwd)"
 
@@ -34,16 +34,6 @@ if [[ "$(type -t emit_event 2>/dev/null)" != "function" ]]; then
     echo "${payload}}" >> "${HOME}/.shipwright/events.jsonl"
   }
 fi
-CYAN="${CYAN:-\033[38;2;0;212;255m}"
-PURPLE="${PURPLE:-\033[38;2;124;58;237m}"
-BLUE="${BLUE:-\033[38;2;0;102;255m}"
-GREEN="${GREEN:-\033[38;2;74;222;128m}"
-YELLOW="${YELLOW:-\033[38;2;250;204;21m}"
-RED="${RED:-\033[38;2;248;113;113m}"
-DIM="${DIM:-\033[2m}"
-BOLD="${BOLD:-\033[1m}"
-RESET="${RESET:-\033[0m}"
-
 # ─── Defaults ───────────────────────────────────────────────────────────────
 MACHINES_FILE="$HOME/.shipwright/machines.json"
 SSH_OPTS="-o ConnectTimeout=5 -o BatchMode=yes -o StrictHostKeyChecking=accept-new"