shipwright-cli 1.7.1 → 1.9.0

package/scripts/sw-patrol-meta.sh

@@ -0,0 +1,417 @@
+#!/usr/bin/env bash
+# ╔═══════════════════════════════════════════════════════════════════════════╗
+# ║  sw-patrol-meta.sh — Shipwright Self-Improvement Patrol                ║
+# ║  Sourced by sw-daemon.sh during patrol — creates improvement issues    ║
+# ╚═══════════════════════════════════════════════════════════════════════════╝
+# NOTE: This file is sourced (not executed). Do NOT add set -euo pipefail.
+# All functions from the parent (sw-daemon.sh) are available.
+
+# ─── Helper: Create issue if not duplicate ─────────────────────────────────
+patrol_meta_create_issue() {
+    local title="$1"
+    local body="$2"
+    local extra_labels="${3:-}"
+
+    if [[ "${NO_GITHUB:-false}" == "true" ]]; then
+        info "  [dry-run] Would create: $title"
+        return 0
+    fi
+
+    # Dedup: check if an open issue with this exact title already exists
+    local existing
+    existing=$(gh issue list --state open --search "$title" --json number,title --jq ".[].title" 2>/dev/null || echo "")
+    if echo "$existing" | grep -qF "$title" 2>/dev/null; then
+        info "  Skipping duplicate: $title"
+        return 0
+    fi
+
+    local labels="auto-patrol,meta-improvement,ready-to-build"
+    if [[ -n "$extra_labels" ]]; then
+        labels="${labels},${extra_labels}"
+    fi
+
+    gh issue create \
+        --title "$title" \
+        --body "$body" \
+        --label "$labels" 2>/dev/null || {
+        warn "  Failed to create issue: $title"
+        return 1
+    }
+
+    issues_created=$((issues_created + 1))
+    total_findings=$((total_findings + 1))
+    emit_event "patrol.meta_issue_created" "title=$title"
+    success "  Created issue: $title"
+}
+
+# ─── Check 1: Untested Scripts ──────────────────────────────────────────────
+patrol_meta_untested_scripts() {
+    info "  Checking for untested Shipwright scripts..."
+    local count=0
+
+    for script in "$SCRIPT_DIR"/sw-*.sh; do
+        [[ ! -f "$script" ]] && continue
+        local base
+        base=$(basename "$script" .sh)
+
+        # Skip test scripts themselves
+        [[ "$base" == *-test ]] && continue
+        # Skip sourced provider scripts (no standalone execution)
+        [[ "$base" == sw-tracker-linear ]] && continue
+        [[ "$base" == sw-tracker-jira ]] && continue
+        [[ "$base" == sw-patrol-meta ]] && continue
+
+        local test_file="$SCRIPT_DIR/${base}-test.sh"
+        if [[ ! -f "$test_file" ]]; then
+            count=$((count + 1))
+            patrol_meta_create_issue \
+                "[Meta] Add tests for ${base}.sh" \
+                "## Missing Test Suite
+
+The script \`scripts/${base}.sh\` does not have a corresponding test file \`scripts/${base}-test.sh\`.
+
+### Requirements
+- Create \`scripts/${base}-test.sh\` following the existing test patterns
+- Use mock environment (TEMP_DIR with mock binaries on PATH)
+- Include PASS/FAIL counters, colored output, summary section
+- Add ERR trap: \`trap 'echo \"ERROR: \\\$BASH_SOURCE:\\\$LINENO exited with status \\\$?\" >&2' ERR\`
+- Register in \`package.json\` test script chain
+- Aim for at least 10 meaningful test cases
+
+### Context
+All other Shipwright scripts follow this test pattern. See \`scripts/sw-daemon-test.sh\` as a reference.
+
+_Auto-generated by Shipwright meta-patrol_"
+        fi
+    done
+
+    if [[ "$count" -eq 0 ]]; then
+        echo -e "    ${GREEN}●${RESET} All scripts have test suites"
+    else
+        echo -e "    ${CYAN}●${RESET} Found ${count} untested script(s)"
+    fi
+}
+
+# ─── Check 2: Bash 3.2 Compatibility ───────────────────────────────────────
+patrol_meta_bash_compat() {
+    info "  Checking Bash 3.2 compatibility..."
+    local count=0
+
+    for script in "$SCRIPT_DIR"/sw-*.sh; do
+        [[ ! -f "$script" ]] && continue
+        local base
+        base=$(basename "$script")
+
+        # Look for Bash 4+ patterns
+        local violations=""
+        local v
+
+        # declare -A (associative arrays)
+        v=$(grep -n 'declare -A' "$script" 2>/dev/null | head -3 || true)
+        [[ -n "$v" ]] && violations="${violations}\n- \`declare -A\` (associative arrays): ${v}"
+
+        # readarray / mapfile
+        v=$(grep -n 'readarray\|mapfile' "$script" 2>/dev/null | head -3 || true)
+        [[ -n "$v" ]] && violations="${violations}\n- \`readarray/mapfile\`: ${v}"
+
+        # ${var,,} lowercase
+        v=$(grep -n '${[a-zA-Z_]*,,}' "$script" 2>/dev/null | head -3 || true)
+        [[ -n "$v" ]] && violations="${violations}\n- \`\${var,,}\` lowercase: ${v}"
+
+        # ${var^^} uppercase
+        v=$(grep -n '${[a-zA-Z_]*\^\^}' "$script" 2>/dev/null | head -3 || true)
+        [[ -n "$v" ]] && violations="${violations}\n- \`\${var^^}\` uppercase: ${v}"
+
+        if [[ -n "$violations" ]]; then
+            count=$((count + 1))
+            patrol_meta_create_issue \
+                "[Meta] Fix Bash 3.2 incompatibility in ${base}" \
+                "## Bash 3.2 Compatibility Issue
+
+The script \`scripts/${base}\` uses Bash 4+ features that break on macOS default Bash (3.2).
+
+### Violations Found
+$(echo -e "$violations")
+
+### Required Changes
+- Replace \`declare -A\` with indexed arrays or separate variables
+- Replace \`readarray\` with \`while IFS= read -r\` loops
+- Replace \`\${var,,}\` with \`echo \"\$var\" | tr '[:upper:]' '[:lower:]'\`
+- Replace \`\${var^^}\` with \`echo \"\$var\" | tr '[:lower:]' '[:upper:]'\`
+
+_Auto-generated by Shipwright meta-patrol_"
+        fi
+    done
+
+    if [[ "$count" -eq 0 ]]; then
+        echo -e "    ${GREEN}●${RESET} All scripts are Bash 3.2 compatible"
+    else
+        echo -e "    ${CYAN}●${RESET} Found ${count} script(s) with Bash 4+ patterns"
+    fi
+}
+
+# ─── Check 3: VERSION Sync ─────────────────────────────────────────────────
+patrol_meta_version_sync() {
+    info "  Checking VERSION consistency..."
+    local versions=""
+    local mismatches=""
+    local reference_version=""
+
+    for script in "$SCRIPT_DIR"/sw-*.sh "$SCRIPT_DIR/sw"; do
+        [[ ! -f "$script" ]] && continue
+        local base
+        base=$(basename "$script")
+        local ver
+        ver=$(grep -m1 '^VERSION=' "$script" 2>/dev/null | sed 's/VERSION="//' | sed 's/"//' || true)
+        if [[ -n "$ver" ]]; then
+            if [[ -z "$reference_version" ]]; then
+                reference_version="$ver"
+            elif [[ "$ver" != "$reference_version" ]]; then
+                mismatches="${mismatches}\n- \`${base}\`: ${ver} (expected ${reference_version})"
+            fi
+        fi
+    done
+
+    if [[ -n "$mismatches" ]]; then
+        patrol_meta_create_issue \
+            "[Meta] Fix VERSION mismatch across scripts" \
+            "## VERSION Mismatch
+
+Some scripts have different VERSION values. All scripts should use the same version.
+
+### Reference Version: \`${reference_version}\`
+
+### Mismatches
+$(echo -e "$mismatches")
+
+### Fix
+Update all VERSION= lines to match the reference version.
+
+_Auto-generated by Shipwright meta-patrol_"
+        echo -e "    ${CYAN}●${RESET} VERSION mismatch detected"
+    else
+        echo -e "    ${GREEN}●${RESET} All script versions match: ${reference_version:-unknown}"
+    fi
+}
+
+# ─── Check 4: DORA Trends (30-day) ─────────────────────────────────────────
+patrol_meta_dora_trends() {
+    info "  Analyzing 30-day DORA trends..."
+
+    if [[ ! -f "$EVENTS_FILE" ]]; then
+        echo -e "    ${DIM}●${RESET} No events data available"
+        return
+    fi
+
+    local now_e
+    now_e=$(now_epoch)
+    local thirty_days_ago=$(( now_e - 2592000 ))
+    local fifteen_days_ago=$(( now_e - 1296000 ))
+
+    # Compare first half (days 16-30) vs second half (days 1-15)
+    local first_half_lt second_half_lt
+    first_half_lt=$(jq -s "[.[] | select(.type == \"pipeline.completed\" and .result == \"success\" and (.ts_epoch // 0) >= $thirty_days_ago and (.ts_epoch // 0) < $fifteen_days_ago) | .duration_s // 0] | if length > 0 then (add / length) else 0 end" "$EVENTS_FILE" 2>/dev/null || echo "0")
+    second_half_lt=$(jq -s "[.[] | select(.type == \"pipeline.completed\" and .result == \"success\" and (.ts_epoch // 0) >= $fifteen_days_ago) | .duration_s // 0] | if length > 0 then (add / length) else 0 end" "$EVENTS_FILE" 2>/dev/null || echo "0")
+
+    # Check if lead time regressed > 20%
+    if [[ "$first_half_lt" != "0" ]] && [[ "$second_half_lt" != "0" ]]; then
+        local increase_pct
+        increase_pct=$(echo "$first_half_lt $second_half_lt" | awk '{if ($1 > 0) printf "%.0f", (($2 - $1) / $1) * 100; else print "0"}')
+
+        if [[ "$increase_pct" -gt 20 ]]; then
+            patrol_meta_create_issue \
+                "[Meta] Investigate lead time regression (+${increase_pct}%)" \
+                "## DORA Lead Time Regression
+
+Average pipeline lead time has increased by **${increase_pct}%** over the last 30 days.
+
+| Period | Avg Lead Time |
+|--------|--------------|
+| Days 16-30 | ${first_half_lt}s |
+| Days 1-15 | ${second_half_lt}s |
+
+### Suggested Actions
+- Check if pipeline template complexity has increased
+- Review build stage iteration counts
+- Look for test suite slowdowns
+- Check if retry rates have increased
+
+_Auto-generated by Shipwright meta-patrol_"
+            echo -e "    ${CYAN}●${RESET} Lead time regression: +${increase_pct}%"
+        else
+            echo -e "    ${GREEN}●${RESET} Lead time stable (${increase_pct}% change)"
+        fi
+    else
+        echo -e "    ${DIM}●${RESET} Insufficient data for trend analysis"
+    fi
+}
+
+# ─── Check 5: Template Effectiveness ───────────────────────────────────────
+patrol_meta_template_effectiveness() {
+    info "  Analyzing pipeline template effectiveness..."
+
+    if [[ ! -f "$EVENTS_FILE" ]]; then
+        echo -e "    ${DIM}●${RESET} No events data available"
+        return
+    fi
+
+    # Get success rates by template from the last 30 days
+    local template_stats
+    template_stats=$(jq -s '
+        [.[] | select(.type == "pipeline.completed" and (.ts_epoch // 0) > (now - 2592000))]
+        | group_by(.template // "unknown")
+        | map({
+            template: .[0].template // "unknown",
+            total: length,
+            successes: [.[] | select(.result == "success")] | length
+        })
+        | map(. + { rate: (if .total > 0 then (.successes * 100 / .total) else 0 end) })
+        | sort_by(-.rate)
+    ' "$EVENTS_FILE" 2>/dev/null || echo "[]")
+
+    local template_count
+    template_count=$(echo "$template_stats" | jq 'length' 2>/dev/null || echo "0")
+
+    if [[ "$template_count" -gt 1 ]]; then
+        local best_template best_rate worst_template worst_rate
+        best_template=$(echo "$template_stats" | jq -r '.[0].template' 2>/dev/null || echo "unknown")
+        best_rate=$(echo "$template_stats" | jq -r '.[0].rate' 2>/dev/null || echo "0")
+        worst_template=$(echo "$template_stats" | jq -r '.[-1].template' 2>/dev/null || echo "unknown")
+        worst_rate=$(echo "$template_stats" | jq -r '.[-1].rate' 2>/dev/null || echo "0")
+
+        local rate_diff=$(( ${best_rate%.*} - ${worst_rate%.*} ))
+
+        if [[ "$rate_diff" -gt 30 ]]; then
+            patrol_meta_create_issue \
+                "[Meta] Consider defaulting to '${best_template}' pipeline template" \
+                "## Template Effectiveness Analysis
+
+The **${best_template}** template significantly outperforms other templates.
+
+### Success Rates (Last 30 Days)
+$(echo "$template_stats" | jq -r '.[] | "| \(.template) | \(.successes)/\(.total) | \(.rate)% |"' 2>/dev/null || echo "No data")
+
+### Recommendation
+Consider setting \`pipeline_template: \"${best_template}\"\` as the default in \`daemon-config.json\`.
+
+_Auto-generated by Shipwright meta-patrol_"
+            echo -e "    ${CYAN}●${RESET} '${best_template}' outperforms by ${rate_diff}%"
+        else
+            echo -e "    ${GREEN}●${RESET} Templates performing similarly (${rate_diff}% spread)"
+        fi
+    else
+        echo -e "    ${DIM}●${RESET} Not enough template variety for comparison"
+    fi
+}
+
+# ─── Check 6: Memory Pruning ───────────────────────────────────────────────
+patrol_meta_memory_pruning() {
+    info "  Checking memory file sizes..."
+
+    local memory_dir="$HOME/.shipwright/memory"
+    if [[ ! -d "$memory_dir" ]]; then
+        echo -e "    ${DIM}●${RESET} No memory directory"
+        return
+    fi
+
+    local total_size
+    total_size=$(du -sk "$memory_dir" 2>/dev/null | awk '{print $1}' || echo "0")
+    local total_mb=$(( total_size / 1024 ))
+
+    if [[ "$total_mb" -gt 10 ]]; then
+        patrol_meta_create_issue \
+            "[Meta] Prune memory files (${total_mb}MB)" \
+            "## Memory Storage Cleanup Needed
+
+The Shipwright memory directory has grown to **${total_mb}MB**.
+
+### Location
+\`~/.shipwright/memory/\`
+
+### Suggested Actions
+- Archive old memory files (older than 90 days)
+- Deduplicate similar failure patterns
+- Compress rarely-accessed memories
+- Consider implementing automatic memory rotation
+
+_Auto-generated by Shipwright meta-patrol_"
+        echo -e "    ${CYAN}●${RESET} Memory files: ${total_mb}MB (needs pruning)"
+    else
+        echo -e "    ${GREEN}●${RESET} Memory files: ${total_mb}MB (healthy)"
+    fi
+}
+
+# ─── Check 7: Event Analysis (Top Recurring Failures) ──────────────────────
+patrol_meta_event_analysis() {
+    info "  Analyzing recurring failure patterns..."
+
+    if [[ ! -f "$EVENTS_FILE" ]]; then
+        echo -e "    ${DIM}●${RESET} No events data available"
+        return
+    fi
+
+    # Find top 3 most common failure reasons in the last 7 days
+    local now_e
+    now_e=$(now_epoch)
+    local seven_days_ago=$(( now_e - 604800 ))
+
+    local top_failures
+    top_failures=$(jq -s "
+        [.[] | select(.type == \"pipeline.completed\" and .result != \"success\" and (.ts_epoch // 0) >= $seven_days_ago)]
+        | group_by(.failed_stage // \"unknown\")
+        | map({ stage: .[0].failed_stage // \"unknown\", count: length })
+        | sort_by(-.count)
+        | .[0:3]
+    " "$EVENTS_FILE" 2>/dev/null || echo "[]")
+
+    local failure_count
+    failure_count=$(echo "$top_failures" | jq 'length' 2>/dev/null || echo "0")
+
+    if [[ "$failure_count" -gt 0 ]]; then
+        local created=0
+        while IFS= read -r failure; do
+            local stage count
+            stage=$(echo "$failure" | jq -r '.stage' 2>/dev/null || echo "unknown")
+            count=$(echo "$failure" | jq -r '.count' 2>/dev/null || echo "0")
+
+            if [[ "$count" -ge 3 ]]; then
+                patrol_meta_create_issue \
+                    "[Meta] Investigate recurring '${stage}' stage failures (${count}x in 7d)" \
+                    "## Recurring Pipeline Failure
+
+The **${stage}** stage has failed **${count} times** in the last 7 days.
+
+### Suggested Investigation
+- Check events.jsonl for error details: \`jq 'select(.type == \"pipeline.completed\" and .failed_stage == \"${stage}\")' ~/.shipwright/events.jsonl\`
+- Review memory patterns: \`shipwright memory search \"${stage}\"\`
+- Check if a specific issue type triggers this failure
+
+_Auto-generated by Shipwright meta-patrol_"
+                created=$((created + 1))
+            fi
+        done < <(echo "$top_failures" | jq -c '.[]' 2>/dev/null)
+
+        if [[ "$created" -gt 0 ]]; then
+            echo -e "    ${CYAN}●${RESET} Created ${created} issue(s) for recurring failures"
+        else
+            echo -e "    ${GREEN}●${RESET} No recurring failures above threshold"
+        fi
+    else
+        echo -e "    ${GREEN}●${RESET} No failures in last 7 days"
+    fi
+}
+
+# ─── Main Entry Point ──────────────────────────────────────────────────────
+patrol_meta_run() {
+    echo -e "\n  ${BOLD}Meta Self-Improvement Checks${RESET}"
+
+    patrol_meta_untested_scripts
+    patrol_meta_bash_compat
+    patrol_meta_version_sync
+    patrol_meta_dora_trends
+    patrol_meta_template_effectiveness
+    patrol_meta_memory_pruning
+    patrol_meta_event_analysis
+
+    echo ""
+}