shipready 1.5.2 → 1.6.0

package/dist/checks/env.js

@@ -61,7 +61,7 @@ export function findRealLookingExampleValues(content) {
         if (eq <= 0)
             continue;
         const key = line.slice(0, eq).trim();
-        let value = line.slice(eq + 1).trim().replace(/^["']|["']$/g, "");
+        const value = line.slice(eq + 1).trim().replace(/^["']|["']$/g, "");
         if (!value)
             continue;
         const lower = value.toLowerCase();
@@ -83,7 +83,7 @@ export function findRealLookingExampleValues(content) {
     return suspicious;
 }
 /** Checks .env / .env.example / gitignore safety around env vars. */
-export function checkEnv(root, envUsages) {
+export function checkEnv(root, envUsages, workspaceDirs = []) {
     const findings = [];
     const hasEnv = fileExists(root, ".env");
     const exampleContent = readTextFile(root, ".env.example") ?? readTextFile(root, ".env.sample");
@@ -111,8 +111,17 @@ export function checkEnv(root, envUsages) {
             });
         }
     }
+    // Monorepos keep .env.example per workspace package, not at the root.
+    const workspaceExamples = workspaceDirs.filter((d) => fileExists(root, `${d}/.env.example`) || fileExists(root, `${d}/.env.sample`));
     // .env.example presence
-    if (usedVars.length > 0 && !hasExample) {
+    if (usedVars.length > 0 && !hasExample && workspaceExamples.length > 0) {
+        findings.push({
+            severity: "success",
+            rule: "env.example-found-workspaces",
+            message: `.env.example found in ${workspaceExamples.length} workspace package${workspaceExamples.length > 1 ? "s" : ""}`,
+        });
+    }
+    else if (usedVars.length > 0 && !hasExample) {
         findings.push({
             severity: "error",
             rule: "env.example-missing",

package/dist/checks/gitignore.js

@@ -1,4 +1,6 @@
+import { isNodeEcosystem } from "../utils/framework.js";
 import { readTextFile } from "../utils/files.js";
+/** Node-ecosystem entries (also the default when the framework is unknown). */
 export const IMPORTANT_IGNORES = [
     ".env",
     ".env.local",
@@ -7,8 +9,30 @@ export const IMPORTANT_IGNORES = [
     "build",
     ".next",
 ];
+/**
+ * Expected entries per ecosystem. Suggesting node_modules to a Go project
+ * (or target/ to a Python one) is noise that erodes trust in the tool, so
+ * each ecosystem only gets entries that actually apply to it.
+ */
+const ECOSYSTEM_IGNORES = {
+    Python: [".env", "__pycache__", ".venv"],
+    Go: [".env"],
+    Rust: [".env", "target"],
+    PHP: [".env", "vendor"],
+    Ruby: [".env", ".bundle"],
+    Java: [".env", "target", "build"],
+    Deno: [".env"],
+    "Static HTML": [".env"],
+    unknown: [".env"],
+};
+/** Returns the entries a project of the given framework should ignore. */
+export function importantIgnoresFor(framework) {
+    if (!framework || isNodeEcosystem(framework))
+        return IMPORTANT_IGNORES;
+    return ECOSYSTEM_IGNORES[framework] ?? [".env"];
+}
 /** Returns which important entries are missing from gitignore content. */
-export function missingIgnoreEntries(content) {
+export function missingIgnoreEntries(content, framework) {
     const lines = content
         .split("\n")
         .map((l) => l.trim())
@@ -23,10 +47,10 @@ export function missingIgnoreEntries(content) {
         // "node_modules/" style already normalized above
         return false;
     });
-    return IMPORTANT_IGNORES.filter((e) => !covers(e));
+    return importantIgnoresFor(framework).filter((e) => !covers(e));
 }
 /** Checks .gitignore existence and important entries. */
-export function checkGitignore(root) {
+export function checkGitignore(root, framework) {
     const findings = [];
     const content = readTextFile(root, ".gitignore");
     if (content === null) {
@@ -37,7 +61,7 @@ export function checkGitignore(root) {
         });
         return { name: "gitignore", findings };
     }
-    const missing = missingIgnoreEntries(content);
+    const missing = missingIgnoreEntries(content, framework);
     if (missing.length > 0) {
         findings.push({
             severity: "warning",

package/dist/checks/packageJson.js

@@ -1,5 +1,21 @@
+import { fileExists } from "../utils/files.js";
 import { isNodeEcosystem } from "../utils/framework.js";
 const IMPORTANT_SCRIPTS = ["dev", "build", "test", "lint"];
+/** Linter configs that count as lint coverage even without a lint script. */
+const LINTER_CONFIGS = [
+    "biome.json",
+    "biome.jsonc",
+    "eslint.config.js",
+    "eslint.config.mjs",
+    "eslint.config.cjs",
+    "eslint.config.ts",
+    ".eslintrc",
+    ".eslintrc.js",
+    ".eslintrc.cjs",
+    ".eslintrc.json",
+    ".eslintrc.yml",
+    ".eslintrc.yaml",
+];
 /** Checks package.json existence and important scripts. */
 export function checkPackageJson(project) {
     const findings = [];
@@ -26,7 +42,16 @@ export function checkPackageJson(project) {
         rule: "package-json.found",
         message: "package.json found",
     });
-    const missing = IMPORTANT_SCRIPTS.filter((s) => !project.scripts[s]);
+    const hasLinterConfig = LINTER_CONFIGS.some((f) => fileExists(project.root, f));
+    const missing = IMPORTANT_SCRIPTS.filter((s) => {
+        if (project.scripts[s])
+            return false;
+        // A biome/eslint config means linting is set up; the script name is
+        // a convention, not a requirement (e.g. Biome repos run "biome check").
+        if (s === "lint" && hasLinterConfig)
+            return false;
+        return true;
+    });
     if (missing.length > 0) {
         findings.push({
             severity: "warning",

package/dist/fixers/gitignore.js

@@ -1,18 +1,13 @@
-import { missingIgnoreEntries } from "../checks/gitignore.js";
+import { importantIgnoresFor, missingIgnoreEntries } from "../checks/gitignore.js";
 import { readTextFile, writeTextFile } from "../utils/files.js";
 /** Adds missing important entries to .gitignore (creates it if absent). */
-export function fixGitignore(root, dryRun = false) {
+export function fixGitignore(root, dryRun = false, framework) {
     const file = ".gitignore";
     const existing = readTextFile(root, file);
     if (existing === null) {
         const content = [
             "# Added by shipready",
-            ".env",
-            ".env.local",
-            "node_modules",
-            "dist",
-            "build",
-            ".next",
+            ...importantIgnoresFor(framework),
             "",
         ].join("\n");
         if (!dryRun) {
@@ -20,7 +15,7 @@ export function fixGitignore(root, dryRun = false) {
         }
         return { file, action: "created", dryRun, preview: content };
     }
-    const missing = missingIgnoreEntries(existing);
+    const missing = missingIgnoreEntries(existing, framework);
     if (missing.length === 0) {
         return { file, action: "skipped", reason: "already complete" };
     }

package/dist/scanner.js

@@ -8,7 +8,7 @@ import { checkHistory, isGitRepo, scanGitHistory } from "./checks/history.js";
 import { verifySecrets } from "./checks/verify.js";
 import { checkTodos, scanContentForTodos } from "./checks/todos.js";
 import { fileExists, findSourceFiles, isProbablyBinary, readJsonFile, readTextFile, } from "./utils/files.js";
-import { detectFramework, detectPackageManager } from "./utils/framework.js";
+import { detectFramework, detectPackageManager, findWorkspaceDirs } from "./utils/framework.js";
 import { isRuleDisabled, loadConfig } from "./config.js";
 /** File extensions considered code for content scanning (not config/data). */
 const CODE_ONLY = new Set([
@@ -21,14 +21,16 @@ const CODE_ONLY = new Set([
 export async function detectProject(root, config) {
     const pkg = readJsonFile(root, "package.json");
     const sourceFiles = await findSourceFiles(root, config?.ignore ?? []);
+    const workspaceDirs = findWorkspaceDirs(root, pkg);
     return {
         root,
         hasPackageJson: fileExists(root, "package.json"),
         packageJson: pkg,
         packageManager: detectPackageManager(root),
-        framework: detectFramework(pkg, root, sourceFiles),
+        framework: detectFramework(pkg, root, sourceFiles, workspaceDirs),
         scripts: pkg?.scripts ?? {},
         sourceFiles,
+        workspaceDirs,
     };
 }
 /** Extracts env usages, secrets, and todos from all source files. */
@@ -133,11 +135,11 @@ export async function runScan(root, options = {}) {
     const rawResults = [
         checkPackageJson(project),
         checkReadme(root),
-        checkEnv(root, envUsages),
+        checkEnv(root, envUsages, project.workspaceDirs),
         checkSecrets(secrets),
         ...(options.history ? [checkHistory(historySecrets, historyScanned)] : []),
         checkTodos(todos),
-        checkGitignore(root),
+        checkGitignore(root, project.framework),
     ];
     // Disabled rules are removed before scoring so they don't affect the score.
     const results = applyDisabledRules(rawResults, config.disableRules);

package/dist/utils/framework.js

@@ -1,4 +1,66 @@
+import fs from "node:fs";
+import path from "node:path";
 import { fileExists } from "./files.js";
+/**
+ * Finds workspace package directories for monorepos. Reads patterns from
+ * package.json "workspaces" and pnpm-workspace.yaml, expanding one level of
+ * trailing-star globs ("apps/*"). Only dirs that contain a package.json
+ * count - that's what makes them workspace packages.
+ */
+export function findWorkspaceDirs(root, pkg) {
+    const patterns = [];
+    const ws = pkg?.["workspaces"];
+    if (Array.isArray(ws))
+        patterns.push(...ws);
+    else if (ws && typeof ws === "object" && Array.isArray(ws.packages)) {
+        patterns.push(...(ws.packages));
+    }
+    const pnpmWs = path.join(root, "pnpm-workspace.yaml");
+    if (fs.existsSync(pnpmWs)) {
+        try {
+            // Minimal YAML: only the common "packages:" list form is supported.
+            const lines = fs.readFileSync(pnpmWs, "utf8").split("\n");
+            let inPackages = false;
+            for (const raw of lines) {
+                const line = raw.trim();
+                if (line.startsWith("packages:")) {
+                    inPackages = true;
+                    continue;
+                }
+                if (inPackages) {
+                    if (line.startsWith("- "))
+                        patterns.push(line.slice(2).trim().replace(/^["']|["']$/g, ""));
+                    else if (line && !line.startsWith("#"))
+                        inPackages = false;
+                }
+            }
+        }
+        catch { /* unreadable yaml: treat as no workspaces */ }
+    }
+    const dirs = new Set();
+    for (const pattern of patterns) {
+        if (pattern.startsWith("!"))
+            continue;
+        if (pattern.endsWith("/*")) {
+            const base = pattern.slice(0, -2);
+            const abs = path.join(root, base);
+            if (!fs.existsSync(abs))
+                continue;
+            try {
+                for (const entry of fs.readdirSync(abs, { withFileTypes: true })) {
+                    if (entry.isDirectory() && fs.existsSync(path.join(abs, entry.name, "package.json"))) {
+                        dirs.add(path.join(base, entry.name));
+                    }
+                }
+            }
+            catch { /* unreadable dir */ }
+        }
+        else if (fs.existsSync(path.join(root, pattern, "package.json"))) {
+            dirs.add(pattern);
+        }
+    }
+    return [...dirs].sort();
+}
 /** Detects the package manager based on lockfiles and manifests. */
 export function detectPackageManager(root) {
     // Node ecosystems (lockfile wins over manifest)
@@ -45,12 +107,26 @@ function countByExt(files, exts) {
  * that static sites, Python, Go, Rust, PHP, and Ruby projects are
  * identified instead of reported as "unknown".
  */
-export function detectFramework(pkg, root, sourceFiles = []) {
+export function detectFramework(pkg, root, sourceFiles = [], workspaceDirs = []) {
     if (pkg) {
         const deps = {
             ...pkg.dependencies,
             ...pkg.devDependencies,
         };
+        // Monorepo roots rarely depend on the framework directly - check the
+        // workspace packages so a Turborepo of Next.js apps reads "Next.js",
+        // not "Node.js".
+        if (root && workspaceDirs.length > 0 && !deps["next"] && !deps["react"] && !deps["vue"] && !deps["svelte"]) {
+            for (const dir of workspaceDirs) {
+                try {
+                    const wsPkg = JSON.parse(fs.readFileSync(path.join(root, dir, "package.json"), "utf8"));
+                    const wsResult = detectFramework(wsPkg, undefined, []);
+                    if (wsResult !== "Node.js")
+                        return wsResult;
+                }
+                catch { /* skip unreadable workspace */ }
+            }
+        }
         // Order matters: meta-frameworks before their underlying libraries.
         if (deps["next"])
             return "Next.js";

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "shipready",
-  "version": "1.5.2",
+  "version": "1.6.0",
   "description": "Pre-flight check for your repo before shipping. Scans AI-coded projects for secrets, env issues, debug leftovers, and generates AI-agent instruction files.",
   "type": "module",
   "license": "MIT",
@@ -59,9 +59,12 @@
     "picocolors": "^1.1.1"
   },
   "devDependencies": {
+    "@eslint/js": "^10.0.1",
     "@types/node": "^22.10.2",
+    "eslint": "^10.7.0",
     "tsx": "^4.19.2",
     "typescript": "^5.7.2",
+    "typescript-eslint": "^8.63.0",
     "vitest": "^2.1.8"
   }
 }