ship18ion 1.1.0 → 1.1.3

package/dist/cli/index.js

@@ -27,11 +27,16 @@ program
     const config = await (0, config_1.loadConfig)(cwd);
     const spinner = (0, ora_1.default)('Initializing...').start();
     try {
+        let framework = 'unknown';
         if (!options.ci) {
-            const framework = await (0, detector_1.detectFramework)(cwd);
+            framework = await (0, detector_1.detectFramework)(cwd);
             spinner.text = `Detected Framework: ${chalk_1.default.cyan(framework.toUpperCase())}`;
             await new Promise(r => setTimeout(r, 800)); // Brief pause to show framework
         }
+        else {
+            // Even in CI, simple detection is useful for reporting if needed, or we just skip
+            framework = await (0, detector_1.detectFramework)(cwd);
+        }
         const results = await (0, runner_1.runChecks)(config, cwd, (stage) => {
             if (!options.ci)
                 spinner.text = stage;
@@ -39,7 +44,7 @@ program
         spinner.succeed(chalk_1.default.green('Checks completed!'));
         console.log('');
         // Uses console reporter for both normal and CI for now (it handles exit codes)
-        (0, console_1.reportConsole)(results, cwd);
+        (0, console_1.reportConsole)(results, cwd, framework);
     }
     catch (e) {
         spinner.fail(chalk_1.default.red('Error running checks'));

package/dist/engine/runner.js

@@ -13,7 +13,9 @@ async function runChecks(config, cwd, onProgress) {
     if (onProgress)
         onProgress('Scanning files...');
     const files = await (0, scanner_1.scanFiles)(cwd, config.ignore);
-    const ctx = { config, files, cwd };
+    // Framework detection
+    const framework = await (0, detector_1.detectFramework)(cwd);
+    const ctx = { config, files, cwd, framework };
     const results = [];
     // Run all checks
     if (onProgress)
@@ -31,8 +33,7 @@ async function runChecks(config, cwd, onProgress) {
     if (onProgress)
         onProgress('Inspecting build artifacts...');
     results.push(...await (0, build_1.checkBuild)(ctx));
-    // Framework detection
-    const framework = await (0, detector_1.detectFramework)(cwd);
+    // Framework specific checks
     if (framework === 'nextjs') {
         if (onProgress)
             onProgress('Running Next.js specific checks...');

package/dist/reporters/console.js

@@ -17,7 +17,10 @@ function getCategory(ruleId) {
     const prefix = ruleId.split('-')[0];
     return CATEGORIES[prefix] || { icon: '❓', label: 'Other' };
 }
-function reportConsole(results, cwd) {
+function reportConsole(results, cwd, framework) {
+    if (framework) {
+        console.log(chalk_1.default.blue(`ℹ️  Framework: ${framework.toUpperCase()}`));
+    }
     if (results.length === 0) {
         console.log(chalk_1.default.green('\n✅  Production Readiness Check Passed!\n'));
         return;

package/dist/rules/build.js

@@ -46,12 +46,12 @@ async function checkBuild(ctx) {
     // We search inside the found build directories
     for (const dir of foundBuildDirs) {
         const mapFiles = await (0, glob_1.glob)(`${dir}/**/*.map`, { cwd: ctx.cwd, absolute: true });
-        for (const file of mapFiles) {
+        if (mapFiles.length > 0) {
             results.push({
                 status: 'warn',
-                message: `Source map found in build output (${dir}) (information leak)`,
+                message: `Found ${mapFiles.length} source map files in '${dir}' (e.g. ${path_1.default.basename(mapFiles[0])}). Ensure these are not exposed publicly.`,
                 ruleId: 'build-source-map',
-                file
+                file: dir // Point to the directory itself
             });
         }
         // 2. Check for .env files in build output

package/dist/rules/git.js

@@ -1,10 +1,16 @@
 "use strict";
+var __importDefault = (this && this.__importDefault) || function (mod) {
+    return (mod && mod.__esModule) ? mod : { "default": mod };
+};
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.checkGit = checkGit;
 const child_process_1 = require("child_process");
+const fs_1 = __importDefault(require("fs"));
+const path_1 = __importDefault(require("path"));
 async function checkGit(ctx) {
     const results = [];
     try {
+        // ... (Existing git checks) ...
         // Check for uncommitted changes
         const status = (0, child_process_1.execSync)('git status --porcelain', { cwd: ctx.cwd, encoding: 'utf-8' });
         if (status.trim().length > 0) {
@@ -18,17 +24,67 @@ async function checkGit(ctx) {
         const branch = (0, child_process_1.execSync)('git rev-parse --abbrev-ref HEAD', { cwd: ctx.cwd, encoding: 'utf-8' }).trim();
         const allowedBranches = ['main', 'master', 'staging', 'production', 'prod'];
         if (!allowedBranches.includes(branch)) {
+            // Warn, but maybe less aggressively? Keeping as warn.
             results.push({
                 status: 'warn',
                 message: `You are on branch '${branch}'. Production builds typically come from main/master.`,
                 ruleId: 'git-branch',
             });
         }
+        // --- New: .gitignore Check ---
+        const gitignorePath = path_1.default.join(ctx.cwd, '.gitignore');
+        if (fs_1.default.existsSync(gitignorePath)) {
+            const content = fs_1.default.readFileSync(gitignorePath, 'utf-8');
+            const lines = content.split('\n').map(l => l.trim()).filter(l => l && !l.startsWith('#'));
+            // Helper to check if item is ignored (naive grep)
+            const isIgnored = (item) => lines.some(l => l.includes(item));
+            const requiredIgnores = ['node_modules', '.env'];
+            if (ctx.framework === 'nextjs') {
+                requiredIgnores.push('.next');
+            }
+            else if (ctx.framework !== 'unknown') {
+                // For other frameworks, maybe 'dist' or 'build'
+                if (!isIgnored('dist') && !isIgnored('build')) {
+                    // We can't strictly require one, but warn if NEITHER is found? 
+                    // Let's stick to safe defaults.
+                }
+            }
+            for (const item of requiredIgnores) {
+                if (!isIgnored(item)) {
+                    results.push({
+                        status: 'warn',
+                        message: `.gitignore is missing '${item}'. This is critical for security and repo size.`,
+                        ruleId: 'git-ignore-missing',
+                        file: gitignorePath
+                    });
+                }
+            }
+            // Check for specific dangerous files not being ignored
+            const dangerousPatterns = ['firebase.json', 'serviceAccountKey.json', '*.pem', '*.key'];
+            // This is tricky because firebase.json CAN be committed. serviceAccountKey.json should NOT.
+            if (!isIgnored('serviceAccountKey.json')) {
+                // Only warn if the FILE actually exists? Or just warn generic?
+                // Best to warn if the file exists AND isn't ignored.
+                if (fs_1.default.existsSync(path_1.default.join(ctx.cwd, 'serviceAccountKey.json'))) {
+                    results.push({
+                        status: 'fail',
+                        message: 'serviceAccountKey.json exists but is NOT in .gitignore!',
+                        ruleId: 'git-ignore-auth',
+                        file: gitignorePath
+                    });
+                }
+            }
+        }
+        else {
+            results.push({
+                status: 'warn',
+                message: 'No .gitignore file found! node_modules and secrets might be committed.',
+                ruleId: 'git-no-ignore',
+            });
+        }
     }
     catch (e) {
         // Not a git repo or git not found
-        // Silently fail or warn?
-        // results.push({ status: 'warn', message: 'Not a git repository or git command failed.', ruleId: 'git-error' });
     }
     return results;
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ship18ion",
-  "version": "1.1.0",
+  "version": "1.1.3",
   "description": "",
   "main": "dist/cli/index.js",
   "bin": {

package/src/cli/index.ts

@@ -27,10 +27,14 @@ program
         const spinner = ora('Initializing...').start();
 
         try {
+            let framework: string = 'unknown';
             if (!options.ci) {
-                const framework = await detectFramework(cwd);
+                framework = await detectFramework(cwd);
                 spinner.text = `Detected Framework: ${chalk.cyan(framework.toUpperCase())}`;
                 await new Promise(r => setTimeout(r, 800)); // Brief pause to show framework
+            } else {
+                // Even in CI, simple detection is useful for reporting if needed, or we just skip
+                framework = await detectFramework(cwd);
             }
 
             const results = await runChecks(config, cwd, (stage) => {
@@ -41,7 +45,7 @@ program
             console.log('');
 
             // Uses console reporter for both normal and CI for now (it handles exit codes)
-            reportConsole(results, cwd);
+            reportConsole(results, cwd, framework);
         } catch (e) {
             spinner.fail(chalk.red('Error running checks'));
             console.error(e);

package/src/engine/runner.ts

@@ -17,7 +17,10 @@ export async function runChecks(
 ): Promise<RuleResult[]> {
     if (onProgress) onProgress('Scanning files...');
     const files = await scanFiles(cwd, config.ignore);
-    const ctx: RuleContext = { config, files, cwd };
+    // Framework detection
+    const framework = await detectFramework(cwd);
+
+    const ctx: RuleContext = { config, files, cwd, framework };
 
     const results: RuleResult[] = [];
 
@@ -37,8 +40,7 @@ export async function runChecks(
     if (onProgress) onProgress('Inspecting build artifacts...');
     results.push(...await checkBuild(ctx));
 
-    // Framework detection
-    const framework = await detectFramework(cwd);
+    // Framework specific checks
     if (framework === 'nextjs') {
         if (onProgress) onProgress('Running Next.js specific checks...');
         results.push(...await checkNextJs(ctx));

package/src/engine/types.ts

@@ -1,4 +1,5 @@
 import { Ship18ionConfig } from './config';
+import { FrameworkType } from './detector';
 
 export interface RuleResult {
     status: 'pass' | 'fail' | 'warn';
@@ -12,4 +13,5 @@ export interface RuleContext {
     config: Ship18ionConfig;
     files: string[];
     cwd: string;
+    framework: FrameworkType;
 }

package/src/reporters/console.ts

@@ -15,7 +15,11 @@ function getCategory(ruleId: string) {
     return CATEGORIES[prefix] || { icon: '❓', label: 'Other' };
 }
 
-export function reportConsole(results: RuleResult[], cwd: string) {
+export function reportConsole(results: RuleResult[], cwd: string, framework?: string) {
+    if (framework) {
+        console.log(chalk.blue(`ℹ️  Framework: ${framework.toUpperCase()}`));
+    }
+
     if (results.length === 0) {
         console.log(chalk.green('\n✅  Production Readiness Check Passed!\n'));
         return;

package/src/rules/build.ts

@@ -51,12 +51,12 @@ export async function checkBuild(ctx: RuleContext): Promise<RuleResult[]> {
     for (const dir of foundBuildDirs) {
         const mapFiles = await glob(`${dir}/**/*.map`, { cwd: ctx.cwd, absolute: true });
 
-        for (const file of mapFiles) {
+        if (mapFiles.length > 0) {
             results.push({
                 status: 'warn',
-                message: `Source map found in build output (${dir}) (information leak)`,
+                message: `Found ${mapFiles.length} source map files in '${dir}' (e.g. ${path.basename(mapFiles[0])}). Ensure these are not exposed publicly.`,
                 ruleId: 'build-source-map',
-                file
+                file: dir // Point to the directory itself
             });
         }
 

package/src/rules/git.ts

@@ -1,10 +1,14 @@
 import { execSync } from 'child_process';
 import { RuleContext, RuleResult } from '../engine/types';
 
+import fs from 'fs';
+import path from 'path';
+
 export async function checkGit(ctx: RuleContext): Promise<RuleResult[]> {
     const results: RuleResult[] = [];
 
     try {
+        // ... (Existing git checks) ...
         // Check for uncommitted changes
         const status = execSync('git status --porcelain', { cwd: ctx.cwd, encoding: 'utf-8' });
         if (status.trim().length > 0) {
@@ -19,6 +23,7 @@ export async function checkGit(ctx: RuleContext): Promise<RuleResult[]> {
         const branch = execSync('git rev-parse --abbrev-ref HEAD', { cwd: ctx.cwd, encoding: 'utf-8' }).trim();
         const allowedBranches = ['main', 'master', 'staging', 'production', 'prod'];
         if (!allowedBranches.includes(branch)) {
+            // Warn, but maybe less aggressively? Keeping as warn.
             results.push({
                 status: 'warn',
                 message: `You are on branch '${branch}'. Production builds typically come from main/master.`,
@@ -26,10 +31,64 @@ export async function checkGit(ctx: RuleContext): Promise<RuleResult[]> {
             });
         }
 
+        // --- New: .gitignore Check ---
+        const gitignorePath = path.join(ctx.cwd, '.gitignore');
+        if (fs.existsSync(gitignorePath)) {
+            const content = fs.readFileSync(gitignorePath, 'utf-8');
+            const lines = content.split('\n').map(l => l.trim()).filter(l => l && !l.startsWith('#'));
+
+            // Helper to check if item is ignored (naive grep)
+            const isIgnored = (item: string) => lines.some(l => l.includes(item));
+
+            const requiredIgnores = ['node_modules', '.env'];
+            if (ctx.framework === 'nextjs') {
+                requiredIgnores.push('.next');
+            } else if (ctx.framework !== 'unknown') {
+                // For other frameworks, maybe 'dist' or 'build'
+                if (!isIgnored('dist') && !isIgnored('build')) {
+                    // We can't strictly require one, but warn if NEITHER is found? 
+                    // Let's stick to safe defaults.
+                }
+            }
+
+            for (const item of requiredIgnores) {
+                if (!isIgnored(item)) {
+                    results.push({
+                        status: 'warn',
+                        message: `.gitignore is missing '${item}'. This is critical for security and repo size.`,
+                        ruleId: 'git-ignore-missing',
+                        file: gitignorePath
+                    });
+                }
+            }
+
+            // Check for specific dangerous files not being ignored
+            const dangerousPatterns = ['firebase.json', 'serviceAccountKey.json', '*.pem', '*.key'];
+            // This is tricky because firebase.json CAN be committed. serviceAccountKey.json should NOT.
+
+            if (!isIgnored('serviceAccountKey.json')) {
+                // Only warn if the FILE actually exists? Or just warn generic?
+                // Best to warn if the file exists AND isn't ignored.
+                if (fs.existsSync(path.join(ctx.cwd, 'serviceAccountKey.json'))) {
+                    results.push({
+                        status: 'fail',
+                        message: 'serviceAccountKey.json exists but is NOT in .gitignore!',
+                        ruleId: 'git-ignore-auth',
+                        file: gitignorePath
+                    });
+                }
+            }
+
+        } else {
+            results.push({
+                status: 'warn',
+                message: 'No .gitignore file found! node_modules and secrets might be committed.',
+                ruleId: 'git-no-ignore',
+            });
+        }
+
     } catch (e) {
         // Not a git repo or git not found
-        // Silently fail or warn?
-        // results.push({ status: 'warn', message: 'Not a git repository or git command failed.', ruleId: 'git-error' });
     }
 
     return results;