shelving 1.276.0 → 1.276.1

package/firebase/FirestoreProvider.d.ts

@@ -108,7 +108,7 @@ export declare class FirestoreProvider<I extends string = string, T extends Data
     deleteQuery<II extends I, TT extends T>(collection: Collection<string, II, TT>, query: Query<Item<II, TT>>): Promise<void>;
     /**
      * Runs the callback in a Firestore transaction: begin → reads with the transaction id → buffered writes committed atomically.
-     * - Retries the whole callback (up to 5 attempts) when the commit is aborted by contention, so the callback must have no side effects other than through its provider.
+     * - Retries the whole callback (up to 5 attempts, with jittered exponential backoff) when the commit is aborted by contention, so the callback must have no side effects other than through its provider.
      * - Rolls back and rethrows if the callback throws.
      * - Reads see a consistent snapshot and never the transaction's own buffered writes.
      */

package/firebase/FirestoreProvider.js

@@ -1,12 +1,13 @@
 import { DBProvider } from "../db/provider/DBProvider.js";
 import { ResponseError } from "../error/ResponseError.js";
 import { UnsupportedError } from "../error/UnsupportedError.js";
+import { getDelay } from "../util/async.js";
 import { joinDataPath } from "../util/data.js";
 import { BLACKHOLE } from "../util/function.js";
 import { getItem } from "../util/item.js";
 import { isPlainObject } from "../util/object.js";
 import { getQueryFilters, getQueryLimit, getQueryOrders } from "../util/query.js";
-import { getRandomKey } from "../util/random.js";
+import { getRandom, getRandomKey } from "../util/random.js";
 import { getUpdates } from "../util/update.js";
 import { toData, toFirestoreFields, toFirestoreValue } from "./value.js";
 // Constants.
@@ -260,7 +261,7 @@ export class FirestoreProvider extends DBProvider {
     }
     /**
      * Runs the callback in a Firestore transaction: begin → reads with the transaction id → buffered writes committed atomically.
-     * - Retries the whole callback (up to 5 attempts) when the commit is aborted by contention, so the callback must have no side effects other than through its provider.
+     * - Retries the whole callback (up to 5 attempts, with jittered exponential backoff) when the commit is aborted by contention, so the callback must have no side effects other than through its provider.
      * - Rolls back and rethrows if the callback throws.
      * - Reads see a consistent snapshot and never the transaction's own buffered writes.
      */
@@ -268,6 +269,9 @@ export class FirestoreProvider extends DBProvider {
         let retryTransaction;
         let aborted;
         for (let attempt = 0; attempt < TRANSACTION_ATTEMPTS; attempt++) {
+            // Back off with jitter before each retry so contending transactions de-synchronise instead of re-aborting each other in lockstep.
+            if (attempt)
+                await getDelay(getRandom(0, 100 * 2 ** attempt));
             const { transaction } = (await this._request("beginTransaction", {
                 options: { readWrite: retryTransaction ? { retryTransaction } : {} },
             }));

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "shelving",
-	"version": "1.276.0",
+	"version": "1.276.1",
 	"author": "Dave Houlbrooke <dave@shax.com>",
 	"repository": {
 		"type": "git",