shariq-pi-extensions 0.2.27 → 0.2.28

package/docs/EXTENSIONS.md

@@ -44,7 +44,7 @@ State is stored in Pi session entries and reconstructed on resume, reload, and t
 
 The subagent extension runs flat Pi child agents with profiles, capability policies, continuation, result delivery, optional worktrees, pre-warmed task dispatch, instant cascading cancellation, cross-session persistence, and a dashboard. Configuration lives in `<agent-dir>/subagents.json`; trusted projects may override it through their Pi config directory. The configured concurrency ceiling is 50.
 
-The extension supplies tools including `spawn_agent`, `task`, `check_agent`, `list_agents`, `wait_agent`, `send_message`, `close_agent`, `reply_question`, and `apply_agent_changes`. These lifecycle operations render as compact expandable main-chat cards; running children share the bounded Active work dock and completed counts no longer occupy footer space after settlement. All completed subagent snapshots and transcripts persist across Pi restarts (`<agent-dir>/subagents/runs/`), allowing `resume_from` to resume completed workers at any point. Interruption immediately cascades across all child fibers in `<10ms`. Child settlement stays in a private extension queue while the parent is active, then starts one custom-result turn at Pi's safe idle edge with the summary guaranteed in model context and never rendered as user-authored or follow-up input; status tools are for explicit inspection, not waiting.
+The extension supplies tools including `spawn_agent`, `task`, `check_agent`, `list_agents`, `wait_agent`, `send_message`, `close_agent`, `reply_question`, and `apply_agent_changes`. These lifecycle operations render as compact expandable main-chat cards; only active manager entries contribute to the footer and bounded Active work dock, so persisted history never inflates live failure counts. Cancellation and reload interruption use a distinct `cancelled` state rather than `error`. All completed and cancelled production subagent snapshots and transcripts persist across Pi restarts (`<agent-dir>/subagents/runs/`), allowing `resume_from` to resume completed workers at any point. Interruption immediately cascades across all child fibers in `<10ms`. Child settlement stays in a private extension queue while the parent is active, then starts one custom-result turn at Pi's safe idle edge with the summary guaranteed in model context and never rendered as user-authored or follow-up input; status tools are for explicit inspection, not waiting.
 
 ### [Orchestration](../extensions/orchestration/README.md)
 

package/extensions/subagents/README.md

@@ -10,7 +10,7 @@ The system is deliberately flat. Only the main Pi thread can spawn subagents. Ch
 
 - **Pre-Warmed Pool Dispatch:** Pre-warms unique agent IDs and allocation buffers ahead of time, eliminating string-formatting and crypto overhead on the critical path for sub-millisecond task dispatch.
 - **Instant Cascading Cancellation:** Structured Effect-TS fiber supervision cascades immediate abort signals to all running subagents and child processes in `<10ms`, guaranteeing zero orphan processes upon interruption or parent turn cancellation.
-- **Cross-Session Snapshot Persistence:** Full subagent snapshots and transcripts are automatically persisted under `~/.pi/agent/subagents/runs/<id>/snapshot.json`, enabling discovery and resumption (`resume_from`) across Pi restarts.
+- **Cross-Session Snapshot Persistence:** Full production subagent snapshots and transcripts are automatically persisted under `~/.pi/agent/subagents/runs/<id>/snapshot.json`, enabling discovery and resumption (`resume_from`) across Pi restarts. Test-only manager backends do not write into user state.
 
 ## Parent tools
 
@@ -70,7 +70,7 @@ Project configuration is ignored when the project is not trusted. Concurrency is
 
 New children start with independent context by default. `fork_turns` may be `all` or a positive number of recent user turns. Forking keeps user messages and final assistant text while removing thinking, tool calls, and tool results so the child never inherits an unresolved tool protocol.
 
-Every child uses a persistent Pi session file. `resume_from` continues a completed child with its full transcript, tool state, and logical agent id, including after a parent `/reload` or resume. Non-secret metadata is stored both in the parent session and in `~/.pi/agent/subagents/catalog.json`, so children created by an ephemeral or different parent process remain discoverable. Existing legacy ids remain valid catalog keys.
+Every child uses a persistent Pi session file. `resume_from` continues a completed or cancelled child with its full transcript, tool state, and logical agent id, including after a parent `/reload` or resume. Cancellation and reload interruption are recorded as `cancelled`, not as failures; historical snapshots remain discoverable but only active manager entries contribute to the live footer and Active work dock. Non-secret metadata is stored both in the parent session and in `~/.pi/agent/subagents/catalog.json`, so children created by an ephemeral or different parent process remain discoverable. Existing legacy ids remain valid catalog keys.
 
 ## Worktree isolation
 
@@ -80,7 +80,7 @@ Children share the requested workspace by default. Use `isolation: "worktree"` o
 
 ## UI
 
-Subagent lifecycle tools render as compact main-chat cards with expandable detail. Running children appear in the shared bounded **Active work** dock with elapsed time and their current tool, then disappear when settled because the result card becomes the durable timeline record. `/subagents` or `/subagents agents` opens the live operations dashboard and takeover UI. `/btw <question>` starts a read-only, context-aware side investigation owned by the user; it opens directly in takeover view and records its answer without waking the parent model. Wide terminals use a split-pane agent list and selected-agent inspector with running/completed/failed counts, model/profile/access metadata, a context meter, current tool activity, queue state, elapsed time, turns, cwd, and latest output. Aborting a running child from the dashboard requires pressing `x` twice; Escape or navigation cancels an armed abort. The takeover view adds a live transcript, context meter, active-tool state, scrolling, child interruption, and follow-up input. `/subagents peers` shows the persistent peer-message audit trail. `/subagents profiles` browses profiles and personas, and `/subagents config` edits validated configuration.
+Subagent lifecycle tools render as compact main-chat cards with expandable detail. Running children appear in the shared bounded **Active work** dock with elapsed time and their current tool, then disappear when settled because the result card becomes the durable timeline record. `/subagents` or `/subagents agents` opens the live operations dashboard and takeover UI. `/btw <question>` starts a read-only, context-aware side investigation owned by the user; it opens directly in takeover view and records its answer without waking the parent model. Wide terminals use a split-pane agent list and selected-agent inspector with running/completed/cancelled/failed counts, model/profile/access metadata, a context meter, current tool activity, queue state, elapsed time, turns, cwd, and latest output. Aborting a running child from the dashboard requires pressing `x` twice; Escape or navigation cancels an armed abort. The takeover view adds a live transcript, context meter, active-tool state, scrolling, child interruption, and follow-up input. `/subagents peers` shows the persistent peer-message audit trail. `/subagents profiles` browses profiles and personas, and `/subagents config` edits validated configuration.
 
 ## Architecture
 

package/extensions/subagents/index.ts

@@ -512,7 +512,7 @@ export default function (pi: ExtensionAPI) {
 
   const updateStatus = (manager: SubagentManagerShape) => {
     if (!ui) return;
-    const subs = manager.view.list();
+    const subs = manager.view.active();
     const runningSnapshots = subs.filter((snap) => snap.status === "running");
     const failed = subs.filter((snap) => snap.status === "error").length;
     if (activityContext) {
@@ -843,7 +843,7 @@ export default function (pi: ExtensionAPI) {
       const sections: string[] = [];
       let remainingBytes = WAIT_OUTPUT_MAX_BYTES;
       for (const snap of settled) {
-        const verb = snap.status === "error" ? "failed" : "finished";
+        const verb = snap.status === "error" ? "failed" : snap.status === "cancelled" ? "was cancelled" : "finished";
         let section = `## ${snap.id} "${snap.title}" ${verb}`;
         if (snap.errorText) section += `\nError: ${snap.errorText}`;
         const headerBytes = Buffer.byteLength(section, "utf8") + 2;
@@ -996,7 +996,7 @@ export default function (pi: ExtensionAPI) {
     },
     renderResult(result, { expanded }, theme) {
       const details = result.details as { id?: string; status?: string; turns?: number } | undefined;
-      const state = details?.status === "error" ? "error" : details?.status === "running" ? "active" : "success";
+      const state = details?.status === "error" ? "error" : details?.status === "running" ? "active" : details?.status === "cancelled" ? "muted" : "success";
       return new Text(toolResultCard(result, expanded, theme, state, details?.id ?? "subagent", `${details?.status ?? "unknown"} · ${details?.turns ?? 0} turns`), 0, 0);
     },
   });
@@ -1294,13 +1294,14 @@ export default function (pi: ExtensionAPI) {
         status?: string;
       };
       const failed = details.status === "error";
-      const icon = failed ? theme.fg("error", "x") : theme.fg("success", "■");
+      const cancelled = details.status === "cancelled";
+      const icon = failed ? theme.fg("error", "x") : cancelled ? theme.fg("muted", "■") : theme.fg("success", "■");
       const header =
         `${icon} ` +
         theme.fg("accent", theme.bold(`subagent ${details.id ?? "?"}`)) +
         theme.fg(
           "muted",
-          ` · ${details.title ?? ""} · ${failed ? "failed" : "finished"}`,
+          ` · ${details.title ?? ""} · ${failed ? "failed" : cancelled ? "cancelled" : "finished"}`,
         );
 
       const content =
@@ -1340,10 +1341,11 @@ export default function (pi: ExtensionAPI) {
       const data = entry.data;
       if (!data) return new Text(theme.fg("warning", "By-the-way result unavailable"), 0, 0);
       const failed = data.status === "error";
+      const cancelled = data.status === "cancelled";
       const header =
-        `${theme.fg(failed ? "error" : "success", "■")} ` +
+        `${theme.fg(failed ? "error" : cancelled ? "muted" : "success", "■")} ` +
         theme.fg("accent", theme.bold(`by the way · ${data.title}`)) +
-        theme.fg("muted", ` · ${failed ? "failed" : "answered"} · ${data.id}`);
+        theme.fg("muted", ` · ${failed ? "failed" : cancelled ? "cancelled" : "answered"} · ${data.id}`);
       const body = [data.errorText ? `Error: ${data.errorText}` : "", data.answer]
         .filter(Boolean)
         .join("\n\n");

package/extensions/subagents/src/catalog.ts

@@ -48,7 +48,7 @@ function validRecord(value: unknown): value is ArchivedSubagent {
     typeof record.cwd === "string" &&
     typeof record.sessionFile === "string" &&
     typeof record.updatedAt === "number" &&
-    (record.status === "running" || record.status === "done" || record.status === "error")
+    (record.status === "running" || record.status === "done" || record.status === "error" || record.status === "cancelled")
   );
 }
 

package/extensions/subagents/src/domain.ts

@@ -27,7 +27,7 @@ export const REASONING_EFFORTS = [
 ] as const;
 export type ReasoningEffort = (typeof REASONING_EFFORTS)[number];
 
-export type SubagentStatus = "running" | "done" | "error";
+export type SubagentStatus = "running" | "done" | "error" | "cancelled";
 
 /** Parent-session context resolved by the tool layer and passed opaquely. */
 export interface PeerAgent {

package/extensions/subagents/src/manager.ts

@@ -24,7 +24,7 @@ import {
 } from "effect";
 import type { SubagentBackend, SubagentSession } from "./backend.ts";
 import { BackendRegistry } from "./backend.ts";
-import { loadPersistedSnapshots, saveSnapshot } from "./storage.ts";
+import { loadPersistedSnapshots } from "./storage.ts";
 import type {
   BackendName,
   LiveToolState,
@@ -95,6 +95,7 @@ interface Entry {
 /** Synchronous bridge for the TUI. Snapshots are live objects; do not mutate. */
 export interface SubagentReadModel {
   list(): ReadonlyArray<SubagentSnapshot>;
+  active(): ReadonlyArray<SubagentSnapshot>;
   get(id: string): SubagentSnapshot | undefined;
   size(): number;
   /** Any-change notification (footer status, dashboard). */
@@ -329,7 +330,7 @@ const makeManager = Effect.gen(function* () {
         s.finalText = outcome.partialText ?? "";
         break;
       case "Interrupted":
-        s.status = "error";
+        s.status = "cancelled";
         s.errorText = "Run was aborted";
         s.finalText = outcome.partialText ?? "";
         break;
@@ -339,7 +340,6 @@ const makeManager = Effect.gen(function* () {
     s.liveTools = [];
     s.queued = [];
     const consumed = (waitInterest.get(s.id) ?? 0) > 0;
-    saveSnapshot(s as SubagentSnapshot);
     notify(s.id);
     try {
       // During teardown, don't queue results into a shutting-down session.
@@ -776,6 +776,7 @@ const makeManager = Effect.gen(function* () {
       );
       return [...active, ...historical];
     },
+    active: () => [...entries.values()].map((entry) => entry.snapshot),
     get: (id) => entries.get(id)?.snapshot ?? persistedSnapshots.get(id),
     size: () => entries.size,
     subscribe: (listener) => {

package/extensions/subagents/src/prompt.ts

@@ -83,11 +83,11 @@ export const SUBAGENT_LIST_TOOL_DESCRIPTION =
 export function buildSubagentResultMessage(options: {
   id: string;
   title: string;
-  status: "running" | "done" | "error";
+  status: "running" | "done" | "error" | "cancelled";
   errorText?: string;
   output: string;
 }) {
-  const verb = options.status === "error" ? "failed" : "finished";
+  const verb = options.status === "error" ? "failed" : options.status === "cancelled" ? "was cancelled" : "finished";
   let text = `Pi subagent ${options.id} "${options.title}" ${verb}.`;
   if (options.errorText) text += `\nError: ${options.errorText}`;
   text += `\n\n${options.output}`;

package/extensions/subagents/src/storage.ts

@@ -26,6 +26,20 @@ export function saveSnapshot(snapshot: SubagentSnapshot) {
   }
 }
 
+export function normalizePersistedSnapshot(snap: SubagentSnapshot): SubagentSnapshot {
+  if (snap.status === "running") {
+    return {
+      ...snap,
+      status: "cancelled",
+      errorText: "Pi exited or reloaded while this subagent was active.",
+    };
+  }
+  if (snap.status === "error" && /abort|cancel|interrupt|exited or reloaded/i.test(snap.errorText ?? "")) {
+    return { ...snap, status: "cancelled" };
+  }
+  return snap;
+}
+
 export function loadPersistedSnapshots(): SubagentSnapshot[] {
   let names: string[] = [];
   try {
@@ -38,16 +52,9 @@ export function loadPersistedSnapshots(): SubagentSnapshot[] {
     try {
       const file = path.join(rootDir(), name, "snapshot.json");
       if (!fs.existsSync(file)) continue;
-      let snap = JSON.parse(fs.readFileSync(file, "utf8")) as SubagentSnapshot;
-      if (!snap.id || !snap.title) continue;
-      if (snap.status === "running") {
-        snap = {
-          ...snap,
-          status: "error",
-          errorText: "Pi exited or reloaded while this subagent was active.",
-        };
-      }
-      snapshots.push(snap);
+      const parsed = JSON.parse(fs.readFileSync(file, "utf8")) as SubagentSnapshot;
+      if (!parsed.id || !parsed.title) continue;
+      snapshots.push(normalizePersistedSnapshot(parsed));
     } catch {
       // Best effort recovery
     }

package/extensions/subagents/src/ui/takeover.ts

@@ -41,6 +41,8 @@ function statusGlyph(snap: SubagentSnapshot, theme: Theme): string {
       return theme.fg("success", "■");
     case "error":
       return theme.fg("error", "■");
+    case "cancelled":
+      return theme.fg("muted", "■");
   }
 }
 
@@ -52,6 +54,8 @@ function statusWord(snap: SubagentSnapshot, theme: Theme): string {
       return theme.fg("success", "done");
     case "error":
       return theme.fg("error", "failed");
+    case "cancelled":
+      return theme.fg("muted", "cancelled");
   }
 }
 
@@ -314,6 +318,7 @@ export class SubagentDashboard implements Component {
     const running = subs.filter((snap) => snap.status === "running").length;
     const done = subs.filter((snap) => snap.status === "done").length;
     const failed = subs.filter((snap) => snap.status === "error").length;
+    const cancelled = subs.filter((snap) => snap.status === "cancelled").length;
     const selected = subs[this.selection.index];
 
     const headerLeft = theme.fg("accent", theme.bold("Subagent operations"));
@@ -321,6 +326,7 @@ export class SubagentDashboard implements Component {
       running > 0 ? stateLabel(theme, "warning", `${running} running`) : "",
       done > 0 ? stateLabel(theme, "success", `${done} done`) : "",
       failed > 0 ? stateLabel(theme, "error", `${failed} failed`) : "",
+      cancelled > 0 ? stateLabel(theme, "muted", `${cancelled} cancelled`) : "",
     ].filter(Boolean).join(theme.fg("dim", " · "));
     const lines = [joinSides(`  ${headerLeft}`, `${counts || theme.fg("muted", "idle")}  `, width)];
 
@@ -416,7 +422,7 @@ export class SubagentDashboard implements Component {
     height: number,
   ): string[] {
     const theme = this.theme;
-    const state = snap.status === "running" ? "warning" : snap.status === "done" ? "success" : "error";
+    const state = snap.status === "running" ? "warning" : snap.status === "done" ? "success" : snap.status === "cancelled" ? "muted" : "error";
     const percent = contextPercent(snap.usage);
     const activeTools = snap.liveTools.filter((tool) => !tool.done);
     const lines: string[] = [

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "shariq-pi-extensions",
-  "version": "0.2.27",
+  "version": "0.2.28",
   "description": "Cross-platform extension suite for the Pi coding agent.",
   "license": "MIT",
   "author": "Shariq Riaz",