shapeup-sdlc 1.7.0 → 3.0.1

package/{skills/tech-lead/scripts/hill-derive.mjs → kernel/reduce/hill.mjs}

@@ -5,10 +5,9 @@
 
 import { readFileSync, writeFileSync, existsSync, readdirSync, mkdirSync } from "node:fs";
 import { resolve, join } from "node:path";
-import { isMain } from "./lib/is-main.mjs";
-import { runArgs } from "./lib/argv.mjs";
-import { scopesDir, hillDir, verdictsDir, evaluationDir, discoveryLedger } from "./lib/paths.mjs";
-import { readAllContracts, SCOPE_CONTRACT } from "./lib/contract-md.mjs";
+import { runArgs } from "../lib/argv.mjs";
+import { scopesDir, hillDir, verdictsDir, evaluationDir, discoveryLedger } from "../lib/paths.mjs";
+import { readAllContracts, SCOPE_CONTRACT } from "../lib/contract.mjs";
 
 /**
  * Derive and write the hill phase for all scopes mechanically based on T0, T1, and ledger facts.
@@ -64,8 +63,21 @@ export function deriveHill(cwd, slug) {
         if (!t0Facts[b.scope_id]) t0Facts[b.scope_id] = { hasGreen: false, seesawGreen: false };
         if (b.overall === "green") {
           t0Facts[b.scope_id].hasGreen = true;
-          // If regression is false on a green T0, it means seesaw was also green
-          if (b.regression === false) {
+          // Read the REAL seesaw result off the verdict artifact (`t0.mjs`'s `writeArtifact()`
+          // already persists the full `{ran, pass, scopes_checked, failing}` object), rather than
+          // inferring it from a false `regression` flag. That inference was vacuously true on every
+          // green T0 whether or not a seesaw check ever ran: nothing in this codebase currently
+          // passes `--seesaw-registry` to `verify t0`, so `seesaw.ran` is always `false` today and
+          // `regression` is always `false` too — "not asked" was being read as "clean," letting a
+          // scope reach FINISHED on a regression check that had never executed.
+          //
+          // Betting Table decision (Phase 3.5 / S4): wiring the seesaw registry for real is a
+          // genuine feature with a real running cost (re-running every finished scope's fixtures
+          // on every later attempt) and is out of proportion to a certification-gap fix. Deferred,
+          // not silently dropped — a scope with no registry wired simply cannot reach FINISHED via
+          // this path today, which is the honest state of the system: this check was never really
+          // gating FINISHED before either.
+          if (b.seesaw?.ran && b.seesaw?.pass) {
             t0Facts[b.scope_id].seesawGreen = true;
           }
         }
@@ -119,14 +131,21 @@ export function deriveHill(cwd, slug) {
 }
 
 export const ARGV_SPEC = {
-  usage: "hill-derive.mjs --slug <slug> [--cwd <dir>]",
+  usage: "harness.mjs reduce hill --slug <slug> [--cwd <dir>]",
   _: { arity: 0, max: 0, name: "(no positional operands)" },
   slug: { type: "str", required: true },
   cwd: { type: "path" },
 };
 
-if (isMain(import.meta.url)) {
-  const args = runArgs(ARGV_SPEC);
+/**
+ * Derive each scope's hill phase from its T0 and evaluation artifacts.
+ *
+ * @param {string[]} rawArgv - The subcommand's own arguments (harness.mjs strips the verb words).
+ * @returns {(Promise<void>|void)} Settles when the subcommand has written its output; most paths
+ *   call `process.exit()` with the subcommand's documented code rather than returning.
+ */
+export async function cli(rawArgv) {
+  const args = runArgs(ARGV_SPEC, rawArgv);
   const cwd = resolve(args.cwd || process.cwd());
   const report = deriveHill(cwd, args.slug);
   console.log(JSON.stringify(report, null, 2));