shaka-player 4.7.9 → 4.7.11

package/lib/ads/ad_manager.js

@@ -656,7 +656,7 @@ shaka.ads.AdManager = class extends shaka.util.FakeEventTarget {
    */
   getServerSideCuePoints() {
     shaka.Deprecate.deprecateFeature(5,
-        'AdManager',
+        'AdManager.getServerSideCuePoints',
         'Please use getCuePoints function.');
     return this.getCuePoints();
   }

package/lib/dash/segment_template.js

@@ -755,16 +755,10 @@ shaka.dash.TimelineSegmentIndex = class extends shaka.media.SegmentIndex {
 
     this.evict(this.periodStart_);
 
-    if (timeline.length === 0) {
-      return;
-    }
-
-    if (this.periodEnd_ !== Infinity) {
-      // Adjust the last timeline entry to match the period end
-      const lastTimePeriod = timeline[timeline.length - 1];
-      // NOTE: end should be relative to period start
-      lastTimePeriod.end = this.periodEnd_ - this.periodStart_;
-    }
+    // Do NOT adjust last range to match period end! With high precision
+    // timestamps several recalculations may give wrong results on less precise
+    // platforms. To mitigate that, we're using cached |periodEnd_| value in
+    // find/get() methods whenever possible.
   }
 
   /**
@@ -784,7 +778,7 @@ shaka.dash.TimelineSegmentIndex = class extends shaka.media.SegmentIndex {
     const timeline = this.templateInfo_.timeline;
 
     // Early exit if the time isn't within this period
-    if (time < this.periodStart_ || time > this.periodEnd_) {
+    if (time < this.periodStart_ || time >= this.periodEnd_) {
       return null;
     }
 
@@ -797,10 +791,14 @@ shaka.dash.TimelineSegmentIndex = class extends shaka.media.SegmentIndex {
       // the references by a fraction of a second. To account for this, we use
       // the start of the next segment as /end/, unless this is the last
       // reference, in which case we use the period end as the /end/
-      let end = range.end + this.periodStart_;
+      let end;
 
       if (i < lastIndex) {
         end = timeline[i + 1].start + this.periodStart_;
+      } else if (this.periodEnd_ === Infinity) {
+        end = range.end + this.periodStart_;
+      } else {
+        end = this.periodEnd_;
       }
 
       if ((time >= start) && (time < end)) {
@@ -831,6 +829,12 @@ shaka.dash.TimelineSegmentIndex = class extends shaka.media.SegmentIndex {
           .unscaledPresentationTimeOffset + range.unscaledStart;
       const timestampOffset = this.periodStart_ -
         this.templateInfo_.scaledPresentationTimeOffset;
+      const trueSegmentEnd = this.periodStart_ + range.end;
+      let segmentEnd = trueSegmentEnd;
+      if (correctedPosition === this.getNumReferences() - 1 &&
+          this.periodEnd_ !== Infinity) {
+        segmentEnd = this.periodEnd_;
+      }
 
       const partialSegmentRefs = [];
 
@@ -901,7 +905,7 @@ shaka.dash.TimelineSegmentIndex = class extends shaka.media.SegmentIndex {
 
       ref = new shaka.media.SegmentReference(
           this.periodStart_ + range.start,
-          this.periodStart_ + range.end,
+          segmentEnd,
           createUrisCb,
           /* startByte= */ 0,
           /* endByte= */ null,
@@ -916,6 +920,7 @@ shaka.dash.TimelineSegmentIndex = class extends shaka.media.SegmentIndex {
           shaka.media.SegmentReference.Status.AVAILABLE,
           this.aes128Key_,
           /* allPartialSegments= */ range.partialSegments > 0);
+      ref.trueEndTime = trueSegmentEnd;
       this.references[correctedPosition] = ref;
     }
 

package/lib/deprecate/deprecate.js

@@ -107,7 +107,7 @@ shaka.Deprecate = class {
       libraryVersion,
       '. Additional information:',
       description,
-    ].join('');
+    ].join(' ');
 
     shaka.log.alwaysError(errorMessage);
     goog.asserts.assert(false, errorMessage);

package/lib/hls/hls_parser.js

@@ -32,6 +32,7 @@ goog.require('shaka.util.FakeEvent');
 goog.require('shaka.util.LanguageUtils');
 goog.require('shaka.util.ManifestParserUtils');
 goog.require('shaka.util.MimeUtils');
+goog.require('shaka.util.Networking');
 goog.require('shaka.util.OperationManager');
 goog.require('shaka.util.Pssh');
 goog.require('shaka.media.SegmentUtils');
@@ -909,8 +910,11 @@ shaka.hls.HlsParser = class {
         playlist, middleSegment.tags, getUris);
     this.mapTagToInitSegmentRefMap_.clear();
     if (initSegmentRef) {
-      const initSegmentRequest = shaka.net.NetworkingEngine.makeRequest(
-          initSegmentRef.getUris(), this.config_.retryParameters);
+      const initSegmentRequest = shaka.util.Networking.createSegmentRequest(
+          initSegmentRef.getUris(),
+          initSegmentRef.getStartByte(),
+          initSegmentRef.getEndByte(),
+          this.config_.retryParameters);
       const initType =
           shaka.net.NetworkingEngine.AdvancedRequestType.INIT_SEGMENT;
       const initResponse = await this.makeNetworkRequest_(
@@ -2839,12 +2843,12 @@ shaka.hls.HlsParser = class {
     // Don't download the key object until the segment is parsed, to avoid a
     // startup delay for long manifests with lots of keys.
     keyInfo.fetchKey = async () => {
-      const keyUri = shaka.hls.Utils.constructSegmentUris(
+      const keyUris = shaka.hls.Utils.constructSegmentUris(
           getUris(), drmTag.getRequiredAttrValue('URI'), variables);
 
       const requestType = shaka.net.NetworkingEngine.RequestType.KEY;
       const request = shaka.net.NetworkingEngine.makeRequest(
-          [keyUri], this.config_.retryParameters);
+          keyUris, this.config_.retryParameters);
       const keyResponse = await this.makeNetworkRequest_(request, requestType);
 
       // keyResponse.status is undefined when URI is "data:text/plain;base64,"
@@ -4130,7 +4134,22 @@ shaka.hls.HlsParser = class {
    * @return {?shaka.extern.DrmInfo}
    * @private
    */
-  static identityDrmParser_(drmTag) {
+  static identityDrmParser_(drmTag, mimeType) {
+    if (mimeType == 'video/mp2t') {
+      throw new shaka.util.Error(
+          shaka.util.Error.Severity.CRITICAL,
+          shaka.util.Error.Category.MANIFEST,
+          shaka.util.Error.Code.HLS_MSE_ENCRYPTED_MP2T_NOT_SUPPORTED);
+    }
+
+    if (shaka.util.Platform.isMediaKeysPolyfilled()) {
+      throw new shaka.util.Error(
+          shaka.util.Error.Severity.CRITICAL,
+          shaka.util.Error.Category.MANIFEST,
+          shaka.util.Error.Code
+              .HLS_MSE_ENCRYPTED_LEGACY_APPLE_MEDIA_KEYS_NOT_SUPPORTED);
+    }
+
     const method = drmTag.getRequiredAttrValue('METHOD');
     const VALID_METHODS = ['SAMPLE-AES', 'SAMPLE-AES-CTR'];
     if (!VALID_METHODS.includes(method)) {

package/lib/media/manifest_parser.js

@@ -28,7 +28,7 @@ shaka.media.ManifestParser = class {
    */
   static registerParserByExtension(extension, parserFactory) {
     shaka.Deprecate.deprecateFeature(5,
-        'ManifestParser',
+        'ManifestParser.registerParserByExtension',
         'Please use an ManifestParser with registerParserByMime function.');
   }
 
@@ -125,7 +125,8 @@ shaka.media.ManifestParser = class {
         shaka.util.Error.Severity.CRITICAL,
         shaka.util.Error.Category.MANIFEST,
         shaka.util.Error.Code.UNABLE_TO_GUESS_MANIFEST_TYPE,
-        uri);
+        uri,
+        mimeType);
   }
 
 

package/lib/media/segment_reference.js

@@ -129,7 +129,10 @@ shaka.media.InitSegmentReference = class {
   static equal(reference1, reference2) {
     const ArrayUtils = shaka.util.ArrayUtils;
     const BufferUtils = shaka.util.BufferUtils;
-    if (!reference1 || !reference2) {
+
+    if (reference1 === reference2) {
+      return true;
+    } else if (!reference1 || !reference2) {
       return reference1 == reference2;
     } else {
       return reference1.getStartByte() == reference2.getStartByte() &&

package/lib/media/streaming_engine.js

@@ -2163,8 +2163,8 @@ shaka.media.StreamingEngine = class {
     const bufferedBehind = presentationTime - startTime;
 
     const overflow = bufferedBehind - bufferBehind;
-    // See: https://github.com/shaka-project/shaka-player/issues/2982
-    if (overflow <= 0.01) {
+    // See: https://github.com/shaka-project/shaka-player/issues/6240
+    if (overflow <= 1) {
       shaka.log.v2(logPrefix,
           'buffer behind okay:',
           'presentationTime=' + presentationTime,

package/lib/player.js

@@ -742,7 +742,7 @@ shaka.Player = class extends shaka.util.FakeEventTarget {
     // player having been initialized.
     if (mediaElement) {
       shaka.Deprecate.deprecateFeature(5,
-          'Player',
+          'Player w/ mediaElement',
           'Please migrate from initializing Player with a mediaElement; ' +
           'use the attach method instead.');
       this.attach(mediaElement, /* initializeMediaSource= */ true);
@@ -1858,19 +1858,19 @@ shaka.Player = class extends shaka.util.FakeEventTarget {
       this.abrManager_ = abrFactory();
       if (typeof this.abrManager_.setMediaElement != 'function') {
         shaka.Deprecate.deprecateFeature(5,
-            'AbrManager',
+            'AbrManager w/o setMediaElement',
             'Please use an AbrManager with setMediaElement function.');
         this.abrManager_.setMediaElement = () => {};
       }
       if (typeof this.abrManager_.setCmsdManager != 'function') {
         shaka.Deprecate.deprecateFeature(5,
-            'AbrManager',
+            'AbrManager w/o setCmsdManager',
             'Please use an AbrManager with setCmsdManager function.');
         this.abrManager_.setCmsdManager = () => {};
       }
       if (typeof this.abrManager_.trySuggestStreams != 'function') {
         shaka.Deprecate.deprecateFeature(5,
-            'AbrManager',
+            'AbrManager w/o trySuggestStreams',
             'Please use an AbrManager with trySuggestStreams function.');
         this.abrManager_.trySuggestStreams = () => {};
       }
@@ -6934,7 +6934,7 @@ shaka.Player.TYPICAL_BUFFERING_THRESHOLD_ = 0.5;
  * @export
  */
 // eslint-disable-next-line no-useless-concat
-shaka.Player.version = 'v4.7.9' + '-uncompiled';  // x-release-please-version
+shaka.Player.version = 'v4.7.11' + '-uncompiled';  // x-release-please-version
 
 // Initialize the deprecation system using the version string we just set
 // on the player.

package/lib/polyfill/mediasource.js

@@ -32,11 +32,12 @@ shaka.polyfill.MediaSource = class {
 
     if (!window.MediaSource) {
       shaka.log.info('No MSE implementation available.');
-    } else if (window.cast && cast.__platform__ &&
-               cast.__platform__.canDisplayType) {
+    } else if (shaka.util.Platform.isChromecast()) {
       shaka.log.info('Patching Chromecast MSE bugs.');
-      // Chromecast cannot make accurate determinations via isTypeSupported.
-      shaka.polyfill.MediaSource.patchCastIsTypeSupported_();
+      // Chromecast fails on some TS content, even though it is supposed to
+      // support it.  Better to transmux.
+      // See https://github.com/shaka-project/shaka-player/issues/5278
+      shaka.polyfill.MediaSource.rejectContainer_('mp2t');
     } else if (safariVersion) {
       // NOTE:  shaka.Player.isBrowserSupported() has its own restrictions on
       // Safari version.
@@ -182,38 +183,6 @@ shaka.polyfill.MediaSource = class {
     };
   }
 
-  /**
-   * Patch isTypeSupported() to chain to a private API on the Chromecast which
-   * can query for support of detailed content parameters.
-   *
-   * @private
-   */
-  static patchCastIsTypeSupported_() {
-    const originalIsTypeSupported = MediaSource.isTypeSupported;
-
-    MediaSource.isTypeSupported = (mimeType) => {
-      // Parse the basic MIME type from its parameters.
-      const pieces = mimeType.split(/ *; */);
-      pieces.shift();  // Remove basic MIME type from pieces.
-
-      const hasCodecs = pieces.some((piece) => piece.startsWith('codecs='));
-      if (!hasCodecs) {
-        // Though the original reason for this special case was not documented,
-        // it is presumed to be because the platform won't accept a MIME type
-        // without codecs in canDisplayType.  It is valid, however, in
-        // isTypeSupported.
-        return originalIsTypeSupported(mimeType);
-      }
-
-      // Only canDisplayType can check extended MIME type parameters on this
-      // platform (such as frame rate, resolution, etc).
-      // In previous versions of this polyfill, the MIME type parameters were
-      // manipulated, filtered, or extended.  This is no longer true, so we pass
-      // the full MIME type to the platform as we received it.
-      return cast.__platform__.canDisplayType(mimeType);
-    };
-  }
-
   /**
    * Patch isTypeSupported() to translate vp09 codec strings into vp9, to allow
    * such content to play on older smart TVs.

package/lib/text/vtt_text_parser.js

@@ -687,6 +687,8 @@ shaka.text.VttTextParser = class {
         refCue.fontFamily, cue.fontFamily);
     cue.fontSize = VttTextParser.getOrDefault_(
         refCue.fontSize, cue.fontSize);
+    cue.textShadow = VttTextParser.getOrDefault_(
+        refCue.textShadow, cue.textShadow);
 
     // Overwrite with new values as unable to determine
     // if new value is set or not
@@ -695,7 +697,6 @@ shaka.text.VttTextParser = class {
     cue.opacity = refCue.opacity;
     cue.rubyTag = refCue.rubyTag;
     cue.textCombineUpright = refCue.textCombineUpright;
-    cue.textShadow = refCue.textShadow;
     cue.wrapLine = refCue.wrapLine;
   }
 

package/lib/util/error.js

@@ -527,6 +527,7 @@ shaka.util.Error.Code = {
    *   <li>Configure the server to accept a HEAD request for the manifest.
    * </ul>
    * <br> error.data[0] is the manifest URI.
+   * <br> error.data[1] is the detected or specified MIME type.
    */
   'UNABLE_TO_GUESS_MANIFEST_TYPE': 4000,
 

package/lib/util/periods.js

@@ -1215,7 +1215,18 @@ shaka.util.PeriodCombiner = class {
       return false;
     }
 
-    // If language-based differences haven't decided this, look at roles.  If
+    // If language-based differences haven't decided this, look at labels.
+    // If available options differ, look does any matches with output stream.
+    if (best.label !== candidate.label) {
+      if (outputStream.label === best.label) {
+        return false;
+      }
+      if (outputStream.label === candidate.label) {
+        return true;
+      }
+    }
+
+    // If label-based differences haven't decided this, look at roles.  If
     // the candidate has more roles in common with the output, upgrade to the
     // candidate.
     if (outputStream.roles.length) {
@@ -1410,6 +1421,17 @@ shaka.util.PeriodCombiner = class {
       return false;
     }
 
+    // If language-based differences haven't decided this, look at labels.
+    // If available options differ, look does any matches with output stream.
+    if (best.label !== candidate.label) {
+      if (outputStream.label === best.label) {
+        return false;
+      }
+      if (outputStream.label === candidate.label) {
+        return true;
+      }
+    }
+
     // If the candidate has more roles in common with the output, upgrade to the
     // candidate.
     if (outputStream.roles.length) {

package/lib/util/stream_utils.js

@@ -908,7 +908,7 @@ shaka.util.StreamUtils = class {
     // currently don't support 'fLaC', while 'flac' is supported by most
     // major browsers.
     // See https://bugs.chromium.org/p/chromium/issues/detail?id=1422728
-    if (codecs === 'fLaC') {
+    if (codecs === 'fLaC' && !shaka.util.Platform.isSafari()) {
       return 'flac';
     }
 

package/lib/util/ts_parser.js

@@ -433,7 +433,7 @@ shaka.util.TsParser = class {
    */
   parseAvcNalus(pes, nextPes) {
     shaka.Deprecate.deprecateFeature(5,
-        'TsParser',
+        'TsParser.parseAvcNalus',
         'Please use parseNalus function instead.');
     return this.parseNalus(pes);
   }
@@ -769,7 +769,7 @@ shaka.util.TsParser = class {
    */
   getVideoResolution() {
     shaka.Deprecate.deprecateFeature(5,
-        'TsParser',
+        'TsParser.getVideoResolution',
         'Please use getVideoInfo function instead.');
     const videoInfo = this.getVideoInfo();
     return {

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "shaka-player",
   "description": "DASH/EME video player library",
-  "version": "4.7.9",
+  "version": "4.7.11",
   "homepage": "https://github.com/shaka-project/shaka-player",
   "author": "Google",
   "maintainers": [
@@ -43,13 +43,13 @@
     "karma-coverage": "^2.2.0",
     "karma-jasmine": "^4.0.1",
     "karma-jasmine-ajax": "^0.1.13",
-    "karma-local-wd-launcher": "^1.6.6",
+    "karma-local-wd-launcher": "^1.6.7",
     "karma-opera-launcher": "^1.0.0",
     "karma-sourcemap-loader": "^0.3.8",
     "karma-spec-reporter": "^0.0.34",
     "karma-webdriver-launcher": "^1.0.8",
     "lcevc_dec.js": "^1.0.1",
-    "less": "https://gitpkg.now.sh/joeyparrish/less.js/packages/less?28c63a43",
+    "less": "^4.2.0",
     "less-plugin-clean-css": "github:austingardner/less-plugin-clean-css#4e9e77bf",
     "material-design-lite": "^1.3.0",
     "open-sans-fonts": "^1.6.2",

package/ui/less/containers.less

@@ -24,6 +24,7 @@
   /* Set the fonts for all other content. */
   * {
     font-family: Roboto-Regular, Roboto, sans-serif, TengwarTelcontar;
+    -webkit-font-smoothing: antialiased;
   }
 }