shaka-player 4.6.2 → 4.6.3

package/externs/lcevc.js

@@ -1,3 +1,9 @@
+/*! @license
+ * Shaka Player
+ * Copyright 2023 Google LLC
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
 /**
 * @fileoverview Externs for LcevcDec
 * compiler.

package/externs/shaka/codecs.js

@@ -1,3 +1,9 @@
+/*! @license
+ * Shaka Player
+ * Copyright 2023 Google LLC
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
 /**
  * @typedef {{
  *   data: !Uint8Array,

package/externs/shaka/transmuxer.js

@@ -1,3 +1,9 @@
+/*! @license
+ * Shaka Player
+ * Copyright 2023 Google LLC
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
 /**
  * @fileoverview Externs for Transmuxer.
  *

package/lib/dash/dash_parser.js

@@ -1433,11 +1433,11 @@ shaka.dash.DashParser = class {
             'Must have Segment* with non-text streams.');
 
         const duration = context.periodInfo.duration || 0;
+        const getBaseUris = context.representation.getBaseUris;
         streamInfo = {
           generateSegmentIndex: () => {
-            const baseUris = context.representation.getBaseUris();
             return Promise.resolve(shaka.media.SegmentIndex.forSingleSegment(
-                periodStart, duration, baseUris));
+                periodStart, duration, getBaseUris()));
           },
         };
       }

package/lib/hls/hls_parser.js

@@ -934,7 +934,8 @@ shaka.hls.HlsParser = class {
         return basicInfo;
       }
     } else if (extension == 'mp4' || extension == 'cmfv' ||
-        contentMimeType == 'video/mp4' || contentMimeType == 'audio/mp4' ||
+        extension == 'm4s' || contentMimeType == 'video/mp4' ||
+        contentMimeType == 'audio/mp4' ||
         contentMimeType == 'video/iso.segment') {
       const basicInfo = shaka.media.SegmentUtils.getBasicInfoFromMp4(
           initData, response.data);

package/lib/media/media_source_engine.js

@@ -1661,6 +1661,7 @@ shaka.media.MediaSourceEngine = class {
     if (shaka.media.Capabilities.isChangeTypeSupported()) {
       if (this.transmuxers_[contentType]) {
         this.transmuxers_[contentType].destroy();
+        delete this.transmuxers_[contentType];
       }
       if (transmuxer) {
         this.transmuxers_[contentType] = transmuxer;
@@ -1859,8 +1860,8 @@ shaka.media.MediaSourceEngine = class {
       }
     }
 
-    const newCodec = MimeUtils.getCodecBase(
-        MimeUtils.getCodecs(newMimeType));
+    const newAllCodecs = MimeUtils.getCodecs(newMimeType);
+    const newCodec = MimeUtils.getCodecBase(newAllCodecs);
     const newBasicType = MimeUtils.getBasicType(newMimeType);
 
     // Current/new codecs base and basic type match then no need to switch
@@ -1868,10 +1869,15 @@ shaka.media.MediaSourceEngine = class {
       return false;
     }
 
-    if (this.config_.codecSwitchingStrategy ===
+    let allowChangeType = true;
+    if (this.needSplitMuxedContent_ || (newAllCodecs.split(',').length &&
+        transmuxer && !this.transmuxers_[contentType])) {
+      allowChangeType = false;
+    }
+
+    if (allowChangeType && this.config_.codecSwitchingStrategy ===
         shaka.config.CodecSwitchingStrategy.SMOOTH &&
-          shaka.media.Capabilities.isChangeTypeSupported() &&
-            !this.needSplitMuxedContent_) {
+          shaka.media.Capabilities.isChangeTypeSupported()) {
       await this.changeType(contentType, newMimeType, transmuxer);
     } else {
       if (transmuxer) {

package/lib/player.js

@@ -6781,7 +6781,7 @@ shaka.Player.TYPICAL_BUFFERING_THRESHOLD_ = 0.5;
  * @export
  */
 // eslint-disable-next-line no-useless-concat
-shaka.Player.version = 'v4.6.2' + '-uncompiled';  // x-release-please-version
+shaka.Player.version = 'v4.6.3' + '-uncompiled';  // x-release-please-version
 
 // Initialize the deprecation system using the version string we just set
 // on the player.

package/lib/text/ui_text_displayer.js

@@ -44,6 +44,9 @@ shaka.text.UITextDisplayer = class {
     /** @private {HTMLElement} */
     this.videoContainer_ = videoContainer;
 
+    /** @private {?number} */
+    this.aspectRatio_ = null;
+
     /** @type {HTMLElement} */
     this.textContainer_ = shaka.util.Dom.createHTMLElement('div');
     this.textContainer_.classList.add('shaka-text-container');
@@ -90,6 +93,23 @@ shaka.text.UITextDisplayer = class {
       this.updateCaptions_(/* forceUpdate= */ true);
     });
 
+    // From: https://html.spec.whatwg.org/multipage/media.html#dom-video-videowidth
+    // Whenever the natural width or natural height of the video changes
+    // (including, for example, because the selected video track was changed),
+    // if the element's readyState attribute is not HAVE_NOTHING, the user
+    // agent must queue a media element task given the media element to fire an
+    // event named resize at the media element.
+    this.eventManager_.listen(this.video_, 'resize', () => {
+      const element = /** @type {!HTMLVideoElement} */ (this.video_);
+      const width = element.videoWidth;
+      const height = element.videoHeight;
+      if (width && height) {
+        this.aspectRatio_ = width / height;
+      } else {
+        this.aspectRatio_ = null;
+      }
+    });
+
     /** @private {ResizeObserver} */
     this.resizeObserver_ = null;
     if ('ResizeObserver' in window) {
@@ -400,6 +420,10 @@ shaka.text.UITextDisplayer = class {
    */
   getRegionElement_(cue) {
     const region = cue.region;
+    // from https://dvcs.w3.org/hg/text-tracks/raw-file/default/608toVTT/608toVTT.html#caption-window-size
+    // if aspect ratio is 4/3, use that value, otherwise, use the 16:9 value
+    const lineWidthMultiple = this.aspectRatio_ === 4/3 ? 2.5 : 1.9;
+    const lineHeightMultiple = 5.33;
 
     const regionId = this.generateRegionId_(region);
     if (this.regionElements_.has(regionId)) {
@@ -417,11 +441,33 @@ shaka.text.UITextDisplayer = class {
     regionElement.id = 'shaka-text-region---' + regionId;
     regionElement.classList.add('shaka-text-region');
 
-    regionElement.style.height = region.height + heightUnit;
-    regionElement.style.width = region.width + widthUnit;
     regionElement.style.position = 'absolute';
-    regionElement.style.top = region.viewportAnchorY + viewportAnchorUnit;
-    regionElement.style.left = region.viewportAnchorX + viewportAnchorUnit;
+
+    const linesUnit = shaka.text.CueRegion.units.LINES;
+    if (region.heightUnits === linesUnit && region.widthUnits === linesUnit) {
+      regionElement.style.height = region.height * lineHeightMultiple + '%';
+      regionElement.style.width = region.width * lineWidthMultiple + '%';
+    } else {
+      regionElement.style.height = region.height + heightUnit;
+      regionElement.style.width = region.width + widthUnit;
+    }
+
+    if (region.viewportAnchorUnits === linesUnit) {
+      // from https://dvcs.w3.org/hg/text-tracks/raw-file/default/608toVTT/608toVTT.html#positioning-in-cea-708
+      let top = region.viewportAnchorY / 75 * 100;
+      const windowWidth = this.aspectRatio_ === 4/3 ? 160 : 210;
+      let left = region.viewportAnchorX / windowWidth * 100;
+      // adjust top and left values based on the region anchor and window size
+      top -= region.regionAnchorY * region.height * lineHeightMultiple / 100;
+      left -= region.regionAnchorX * region.width * lineWidthMultiple / 100;
+      regionElement.style.top = top + '%';
+      regionElement.style.left = left + '%';
+    } else {
+      regionElement.style.top = region.viewportAnchorY -
+        region.regionAnchorY * region.height / 100 + viewportAnchorUnit;
+      regionElement.style.left = region.viewportAnchorX -
+        region.regionAnchorX * region.width / 100 + viewportAnchorUnit;
+    }
 
     regionElement.style.display = 'flex';
     regionElement.style.flexDirection = 'column';

package/lib/util/mp4_box_parsers.js

@@ -301,11 +301,45 @@ shaka.util.Mp4BoxParsers = class {
    */
   static parseESDS(reader) {
     let codec = 'mp4a';
-    reader.skip(11);
-    codec += '.' + this.toHex_(reader.readUint8());
-    // this value is only a single digit
-    codec += '.' +
-        this.toHex_((reader.readUint8() >>> 2) & 0x3f).replace(/^0/, '');
+    let tag;
+    let oti;
+    while (reader.hasMoreData()) {
+      tag = reader.readUint8();
+      let byteRead = reader.readUint8();
+      while (byteRead & 0x80) {
+        byteRead = reader.readUint8();
+      }
+      if (tag == 0x03) {
+        reader.readUint16();
+        const flags = reader.readUint8();
+        if (flags & 0x80) {
+          reader.readUint16();
+        }
+        if (flags & 0x40) {
+          reader.skip(reader.readUint8());
+        }
+        if (flags & 0x20) {
+          reader.readUint16();
+        }
+      } else if (tag == 0x04) {
+        oti = reader.readUint8();
+        reader.skip(12);
+      } else if (tag == 0x05) {
+        break;
+      }
+    }
+    if (oti) {
+      codec += '.' + this.toHex_(oti);
+      if (tag == 0x05 && reader.hasMoreData()) {
+        const firstData = reader.readUint8();
+        let audioObjectType = (firstData & 0xF8) >> 3;
+        if (audioObjectType === 31 && reader.hasMoreData()) {
+          audioObjectType = 32 + ((firstData & 0x7) << 3) +
+              ((reader.readUint8() & 0xE0) >> 5);
+        }
+        codec += '.' + audioObjectType;
+      }
+    }
     return {codec};
   }
 

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "shaka-player",
   "description": "DASH/EME video player library",
-  "version": "4.6.2",
+  "version": "4.6.3",
   "homepage": "https://github.com/shaka-project/shaka-player",
   "author": "Google",
   "maintainers": [

package/test/util/mp4_box_parsers_unit.js

@@ -8,18 +8,24 @@ describe('Mp4BoxParsers', () => {
   const videoInitSegmentUri = '/base/test/test/assets/sintel-video-init.mp4';
   const videoSegmentUri = '/base/test/test/assets/sintel-video-segment.mp4';
 
+  const audioInitSegmentXheAacUri = '/base/test/test/assets/audio-xhe-aac.mp4';
+
   /** @type {!ArrayBuffer} */
   let videoInitSegment;
   /** @type {!ArrayBuffer} */
   let videoSegment;
+  /** @type {!ArrayBuffer} */
+  let audioInitSegmentXheAac;
 
   beforeAll(async () => {
     const responses = await Promise.all([
       shaka.test.Util.fetch(videoInitSegmentUri),
       shaka.test.Util.fetch(videoSegmentUri),
+      shaka.test.Util.fetch(audioInitSegmentXheAacUri),
     ]);
     videoInitSegment = responses[0];
     videoSegment = responses[1];
+    audioInitSegmentXheAac = responses[2];
   });
 
   it('parses init segment', () => {
@@ -157,6 +163,36 @@ describe('Mp4BoxParsers', () => {
     expect(baseMediaDecodeTime).toBe(expectedBaseMediaDecodeTime);
   });
 
+  it('parses ESDS box for xHE-AAC segment', () => {
+    let channelCount;
+    let sampleRate;
+    let codec;
+
+    const Mp4Parser = shaka.util.Mp4Parser;
+    new Mp4Parser()
+        .box('moov', Mp4Parser.children)
+        .box('trak', Mp4Parser.children)
+        .box('mdia', Mp4Parser.children)
+        .box('minf', Mp4Parser.children)
+        .box('stbl', Mp4Parser.children)
+        .fullBox('stsd', Mp4Parser.sampleDescription)
+        .box('mp4a', (box) => {
+          const parsedMP4ABox = shaka.util.Mp4BoxParsers.parseMP4A(box.reader);
+          channelCount = parsedMP4ABox.channelCount;
+          sampleRate = parsedMP4ABox.sampleRate;
+          if (box.reader.hasMoreData()) {
+            Mp4Parser.children(box);
+          }
+        })
+        .box('esds', (box) => {
+          const parsedESDSBox = shaka.util.Mp4BoxParsers.parseESDS(box.reader);
+          codec = parsedESDSBox.codec;
+        }).parse(audioInitSegmentXheAac, /* partialOkay= */ false);
+    expect(channelCount).toBe(2);
+    expect(sampleRate).toBe(48000);
+    expect(codec).toBe('mp4a.40.42');
+  });
+
   /**
    *
    * Explanation on the Uint8Array: